September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: mediatek_i2c_spi: document programmer
by Peter Marheine (Code Review) 26 Sep '22

26 Sep '22

Peter Marheine has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67825 ) Change subject: mediatek_i2c_spi: document programmer ...................................................................... mediatek_i2c_spi: document programmer This adds a manpage section describing the mediatek_i2c_spi programmer, including some discussion of devices that are supported as well as which systems use them. Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Change-Id: Ia63df470170fbadcabadcdad8e5acc0cde3a274b --- M flashrom.8.tmpl 1 file changed, 38 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/67825/1 diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 2cf3a38..45fb0e2 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -429,6 +429,8 @@ .sp .BR "* parade_lspcon" " (for SPI flash ROMs attached to Parade Technologies LSPCONs (PS175))" .sp +.BR "* mediatek_i2c_spi" " (for SPI flash ROMs attached to some Mediatek display devices accessible over I2C)" +.sp Some programmers have optional or mandatory parameters which are described in detail in the .B PROGRAMMER-SPECIFIC INFORMATION @@ -1521,7 +1523,7 @@ If the passed frequency is not supported by the adapter the nearest lower supported frequency will be used. .SS -.BR "realtek_mst_i2c_spi " and " parade_lspcon " programmers +.BR "realtek_mst_i2c_spi ", " parade_lspcon ", and " mediatek_i2c_spi " programmers .IP These programmers tunnel SPI commands through I2C-connected devices. The I2C bus over which communication occurs must be specified either by device path @@ -1575,6 +1577,27 @@ e.g. the PS175. Communication to the SPI flash is tunneled through the LSPCON over I2C. +.SS +.BR "mediatek_i2c_spi " programmer +.IP +This programmer supports SPI flash programming for chips attached to some +Mediatek display controllers, themselves accessed through I2C (tunneling +SPI flash commands through a I2C connection with the host). +.sp +The programmer is designed to support the TSUMOP82JUQ integrated display driver +and scaler as is used in the Google Meet Series One Desk 27 (which runs a +version of ChromeOS and uses Flashrom in its \fBtsum-scaler-updater\fP scripts +that ship with the OS). Other chips may use compatible protocols but have not +been tested with this programmer, and external chip IOs may need to be +controlled through other non-Flashrom means to configure the chip in order for +it to operate as expected. +.sp +\fBdevpath\fP and \fBbus\fP options select the I2C bus to use, as described +previously. \fBallow_brick\fP defaults to no, and must explicitly be set to +"yes" in order for the programmer to operate. This is required because there is +no mechanism in the driver to positively identify that a given I2C bus is +actually connected to a supported device. + .SH EXAMPLES To back up and update your BIOS, run .sp -- To view, visit https://review.coreboot.org/c/flashrom/+/67825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia63df470170fbadcabadcdad8e5acc0cde3a274b Gerrit-Change-Number: 67825 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: serial.c: support BAUD rates > 230400 on macOS
by Name of user not set (Code Review) 25 Sep '22

25 Sep '22

Attention is currently required from: Felix Singer, Name of user not set #1004601. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67822 to look at the new patch set (#3). Change subject: serial.c: support BAUD rates > 230400 on macOS ...................................................................... serial.c: support BAUD rates > 230400 on macOS use the apple way like demonstrated in the IOSerialTestLib.c example code to set BAUD rates > 230400 on macOS. Signed-off-by: Denis Ahrens <denis(a)h3q.com> Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 --- M serial.c 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/67822/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 Gerrit-Change-Number: 67822 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1004601 Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Name of user not set #1004601 Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: serial.c: support BAUD rates > 230400 on macOS
by Angel Pons (Code Review) 25 Sep '22

25 Sep '22

Attention is currently required from: Felix Singer, Name of user not set #1004601. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67822 ) Change subject: serial.c: support BAUD rates > 230400 on macOS ...................................................................... Patch Set 2: (1 comment) File serial.c: https://review.coreboot.org/c/flashrom/+/67822/comment/5dff6c57_5c428a98 PS2, Line 266: } > Replace spaces with tab and also indent one more level. Note: in flashrom, 1 tab is 8 spaces -- To view, visit https://review.coreboot.org/c/flashrom/+/67822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 Gerrit-Change-Number: 67822 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004601 Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Name of user not set #1004601 Gerrit-Comment-Date: Sun, 25 Sep 2022 20:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: serial.c: support BAUD rates > 230400 on macOS
by Angel Pons (Code Review) 25 Sep '22

25 Sep '22

Attention is currently required from: Name of user not set #1004601. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67822 ) Change subject: serial.c: support BAUD rates > 230400 on macOS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/67822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 Gerrit-Change-Number: 67822 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004601 Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Name of user not set #1004601 Gerrit-Comment-Date: Sun, 25 Sep 2022 20:26:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: serial.c: support BAUD rates > 230400 on macOS
by Felix Singer (Code Review) 25 Sep '22

25 Sep '22

Attention is currently required from: Name of user not set #1004601. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67822 ) Change subject: serial.c: support BAUD rates > 230400 on macOS ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/67822/comment/b3991bc0_22418c43 PS2, Line 9: use the apple way to set BAUD rates > 230400 on macOS. Please give a detailed explanation on the "apple way". File serial.c: https://review.coreboot.org/c/flashrom/+/67822/comment/b7e06b2c_9fdd11a2 PS2, Line 266: } Replace spaces with tab and also indent one more level. -- To view, visit https://review.coreboot.org/c/flashrom/+/67822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 Gerrit-Change-Number: 67822 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004601 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Name of user not set #1004601 Gerrit-Comment-Date: Sun, 25 Sep 2022 20:02:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: serial.c: support BAUD rates > 230400 on macOS
by Name of user not set (Code Review) 25 Sep '22

25 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67822 to look at the new patch set (#2). Change subject: serial.c: support BAUD rates > 230400 on macOS ...................................................................... serial.c: support BAUD rates > 230400 on macOS use the apple way to set BAUD rates > 230400 on macOS. Signed-off-by: Denis Ahrens <denis(a)h3q.com> Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 --- M serial.c 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/67822/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 Gerrit-Change-Number: 67822 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004601 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: serial.c: support BAUD rates > 230400 on macOS
by Name of user not set (Code Review) 25 Sep '22

25 Sep '22

Name of user not set #1004601 has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67822 ) Change subject: serial.c: support BAUD rates > 230400 on macOS ...................................................................... serial.c: support BAUD rates > 230400 on macOS use the apple way to set BAUD rates > 2000000 on macOS. Signed-off-by: Denis Ahrens <denis(a)h3q.com> Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 --- M serial.c 1 file changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/67822/1 diff --git a/serial.c b/serial.c index 72f9ef6..1a22228 100644 --- a/serial.c +++ b/serial.c @@ -36,6 +36,10 @@ #include "programmer.h" #include "custom_baud.h" +#ifdef __APPLE__ +#include <IOKit/serial/ioss.h> +#endif + fdtype sp_fd = SER_INV_FD; /* There is no way defined by POSIX to use arbitrary baud rates. It only defines some macros that can be used to @@ -185,6 +189,14 @@ return 1; } wanted = observed; +#ifdef __APPLE__ + int fakebaud = 0; + if (baud > 230400) + { + fakebaud = baud; + baud = 19200; + } +#endif if (baud >= 0) { if (use_custom_baud(baud, sp_baudtable)) { if (set_custom_baudrate(fd, baud)) { @@ -244,6 +256,18 @@ } // FIXME: display actual baud rate - at least if none was specified by the user. #endif + +#ifdef __APPLE__ + if (fakebaud) + { + cfmakeraw(&wanted); + if (ioctl(fd, IOSSIOSPEED, &fakebaud) == -1) { + msg_perr("[WARN] ioctl(..., IOSSIOSPEED, %d).\n", fakebaud); + msg_perr_strerror("problem with IOSSIOSPEED"); + return 1; + } + } +#endif return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/67822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c67048b9c7bc704d9b0c4ef4771f708fdb3e0f3 Gerrit-Change-Number: 67822 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004601 Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Aarya (Code Review) 25 Sep '22

25 Sep '22

Attention is currently required from: Simon Buhrow, Nico Huber, Paul Menzel, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66104 to look at the new patch set (#58). Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... flashrom.c: Add wrapper function to use the erase algorithm Add a function to call the erase algorithm. Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M flashrom.c 1 file changed, 136 insertions(+), 290 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/58 -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 58 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: ichspi: Factor out common hwseq_xfer logic into helpers
by Edward O'Callaghan (Code Review) 25 Sep '22

25 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Subrata Banik, Thomas Heijligen, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62869 ) Change subject: ichspi: Factor out common hwseq_xfer logic into helpers ...................................................................... Patch Set 28: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 Gerrit-Change-Number: 62869 Gerrit-PatchSet: 28 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 25 Sep 2022 12:52:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
by Edward O'Callaghan (Code Review) 25 Sep '22

25 Sep '22

Attention is currently required from: Nico Huber, Subrata Banik, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64968 ) Change subject: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently ...................................................................... Patch Set 6: -Code-Review -- To view, visit https://review.coreboot.org/c/flashrom/+/64968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c90ea1ff617a451a671827d7bc49679d349c79d Gerrit-Change-Number: 64968 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 25 Sep 2022 12:52:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022