September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: flashchips: Add WP settings for Flash Chip `W25Q512NW`
by Subrata Banik (Code Review) 26 Sep '22

26 Sep '22

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67827 ) Change subject: flashchips: Add WP settings for Flash Chip `W25Q512NW` ...................................................................... flashchips: Add WP settings for Flash Chip `W25Q512NW` This patch adds WP register bits and decode range for Flash Chip `W25Q512NW`. TEST=Able to flash AP FW, wp-enable/disable on Google/rex device which has flash chip `W25Q512NW`. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic5148f71404466dcf7772e3eb6e1800eb8666696 --- M flashchips.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/67827/1 diff --git a/flashchips.c b/flashchips.c index 47a37ee..2d09867 100644 --- a/flashchips.c +++ b/flashchips.c @@ -18189,6 +18189,15 @@ .write = spi_chip_write_256, .read = spi_chip_read, .voltage = {1650, 1950}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .srl = {STATUS2, 0, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {STATUS1, 6, RW}, + .cmp = {STATUS2, 6, RW}, + }, + .decode_range = decode_range_spi25, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/67827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5148f71404466dcf7772e3eb6e1800eb8666696 Gerrit-Change-Number: 67827 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: ichspi: Factor out common hwseq_xfer logic into helpers
by Anastasia Klimchuk (Code Review) 26 Sep '22

26 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62869 ) ( 28 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ichspi: Factor out common hwseq_xfer logic into helpers ...................................................................... ichspi: Factor out common hwseq_xfer logic into helpers List of changes: 1. Add a unified `execute SPI flash transfer` function that does: - Check the SCIP bit prior initiate new operation. - Start the transfer by setting address and length for transfer, finally set FGO bit. - Wait for the transaction to get completed/failed/timed out. 2. All HW Sequencing SPI operation uses `execute SPI flash transfer` function Note: The refactoring xfer logic here assumes setting `HSFC_FDBC to 0` while performing erase operation using `ich_hwseq_block_erase()`. But it does not impact the erase operations. BUG=b:223630977 TEST=Able to perform read-status/write-status/read/write/erase operation on PCH 600 series chipset (board name: google/kano). Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 Reviewed-on: https://review.coreboot.org/c/flashrom/+/62869 Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M ichspi.c 1 file changed, 86 insertions(+), 90 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved diff --git a/ichspi.c b/ichspi.c index f5876b7..fa15a95 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1268,7 +1268,7 @@ return flash->mst->opaque.data; } -/* Sets FLA in FADDR to (addr & hwseq_data.addr_mask) without touching other bits. */ +/* Sets FLA in FADDR to (addr & hwseq_data->addr_mask) without touching other bits. */ static void ich_hwseq_set_addr(uint32_t addr, uint32_t mask) { uint32_t addr_old = REGREAD32(ICH9_REG_FADDR) & ~mask; @@ -1344,9 +1344,52 @@ return 0; } -static int ich_hwseq_read_status(const struct flashctx *flash, enum flash_reg reg, uint8_t *value) +/* Fire up a transfer using the hardware sequencer. */ +static void ich_start_hwseq_xfer(uint32_t hsfc_cycle, uint32_t flash_addr, size_t len, + uint32_t addr_mask) { uint16_t hsfc; + + /* Sets flash_addr in FADDR */ + ich_hwseq_set_addr(flash_addr, addr_mask); + + /* make sure FDONE, FCERR, AEL are cleared by writing 1 to them */ + REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); + + /* Set up transaction parameters. */ + hsfc = REGREAD16(ICH9_REG_HSFC); + hsfc &= ~g_hwseq_data.hsfc_fcycle; /* clear operation */ + hsfc |= hsfc_cycle; + hsfc |= HSFC_FDBC_VAL(len - 1); + hsfc |= HSFC_FGO; /* start */ + prettyprint_ich9_reg_hsfc(hsfc, ich_generation); + REGWRITE16(ICH9_REG_HSFC, hsfc); +} + +static int ich_wait_for_hwseq_spi_cycle_complete(void) +{ + if (REGREAD8(ICH9_REG_HSFS) & HSFS_SCIP) { + msg_perr("Error: SCIP bit is unexpectedly set.\n"); + return 1; + } + return 0; +} + +/* Execute SPI flash transfer */ +static int ich_exec_sync_hwseq_xfer(uint32_t hsfc_cycle, uint32_t flash_addr, + size_t len, enum ich_chipset ich_gen, uint32_t addr_mask) +{ + if (ich_wait_for_hwseq_spi_cycle_complete()) { + msg_perr("SPI Transaction Timeout due to previous operation in process!\n"); + return 1; + } + + ich_start_hwseq_xfer(hsfc_cycle, flash_addr, len, addr_mask); + return ich_hwseq_wait_for_cycle_complete(len, ich_gen, addr_mask); +} + +static int ich_hwseq_read_status(const struct flashctx *flash, enum flash_reg reg, uint8_t *value) +{ const int len = 1; const struct hwseq_data *hwseq_data = get_hwseq_data_from_context(flash); @@ -1355,24 +1398,9 @@ return -1; } msg_pdbg("Reading Status register\n"); - ich_hwseq_set_addr(0, hwseq_data->addr_mask); - /* clear FDONE, FCERR, AEL by writing 1 to them (if they are set) */ - REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); - - hsfc = REGREAD16(ICH9_REG_HSFC); - hsfc &= ~hwseq_data->hsfc_fcycle; /* set read operation */ - - /* read status register */ - hsfc |= HSFC_CYCLE_RD_STATUS; - hsfc &= ~HSFC_FDBC; /* clear byte count */ - - /* set byte count */ - hsfc |= HSFC_FDBC_VAL(len - 1); - hsfc |= HSFC_FGO; /* start */ - REGWRITE16(ICH9_REG_HSFC, hsfc); - - if (ich_hwseq_wait_for_cycle_complete(len, ich_generation, hwseq_data->addr_mask)) { + if (ich_exec_sync_hwseq_xfer(HSFC_CYCLE_RD_STATUS, 0, len, ich_generation, + hwseq_data->addr_mask)) { msg_perr("Reading Status register failed\n!!"); return -1; } @@ -1383,7 +1411,6 @@ static int ich_hwseq_write_status(const struct flashctx *flash, enum flash_reg reg, uint8_t value) { - uint16_t hsfc; const int len = 1; const struct hwseq_data *hwseq_data = get_hwseq_data_from_context(flash); @@ -1392,25 +1419,11 @@ return -1; } msg_pdbg("Writing status register\n"); - ich_hwseq_set_addr(0, hwseq_data->addr_mask); - - /* clear FDONE, FCERR, AEL by writing 1 to them (if they are set) */ - REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); ich_fill_data(&value, len, ICH9_REG_FDATA0); - hsfc = REGREAD16(ICH9_REG_HSFC); - hsfc &= ~hwseq_data->hsfc_fcycle; /* clear operation */ - /* write status register */ - hsfc |= HSFC_CYCLE_WR_STATUS; - hsfc &= ~HSFC_FDBC; /* clear byte count */ - - /* set byte count */ - hsfc |= HSFC_FDBC_VAL(len - 1); - hsfc |= HSFC_FGO; /* start */ - REGWRITE16(ICH9_REG_HSFC, hsfc); - - if (ich_hwseq_wait_for_cycle_complete(len, ich_generation, hwseq_data->addr_mask)) { + if (ich_exec_sync_hwseq_xfer(HSFC_CYCLE_WR_STATUS, 0, len, ich_generation, + hwseq_data->addr_mask)) { msg_perr("Writing Status register failed\n!!"); return -1; } @@ -1478,7 +1491,6 @@ unsigned int len) { uint32_t erase_block; - uint16_t hsfc; const struct hwseq_data *hwseq_data = get_hwseq_data_from_context(flash); erase_block = ich_hwseq_get_erase_block_size(addr, hwseq_data->addr_mask, hwseq_data->only_4k); @@ -1505,25 +1517,9 @@ } msg_pdbg("Erasing %d bytes starting at 0x%06x.\n", len, addr); - ich_hwseq_set_addr(addr, hwseq_data->addr_mask); - /* make sure FDONE, FCERR, AEL are cleared by writing 1 to them */ - REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); - - if (REGREAD8(ICH9_REG_HSFS) & HSFS_SCIP) { - msg_perr("Error: SCIP bit is unexpectedly set.\n"); - return -1; - } - - hsfc = REGREAD16(ICH9_REG_HSFC); - hsfc &= ~hwseq_data->hsfc_fcycle; /* clear operation */ - hsfc |= HSFC_CYCLE_BLOCK_ERASE; /* set erase operation */ - hsfc |= HSFC_FGO; /* start */ - msg_pdbg("HSFC used for block erasing: "); - prettyprint_ich9_reg_hsfc(hsfc, ich_generation); - REGWRITE16(ICH9_REG_HSFC, hsfc); - - if (ich_hwseq_wait_for_cycle_complete(len, ich_generation, hwseq_data->addr_mask)) + if (ich_exec_sync_hwseq_xfer(HSFC_CYCLE_BLOCK_ERASE, addr, 0, ich_generation, + hwseq_data->addr_mask)) return -1; return 0; } @@ -1531,7 +1527,6 @@ static int ich_hwseq_read(struct flashctx *flash, uint8_t *buf, unsigned int addr, unsigned int len) { - uint16_t hsfc; uint8_t block_len; const struct hwseq_data *hwseq_data = get_hwseq_data_from_context(flash); @@ -1551,23 +1546,8 @@ /* as well as flash chip page borders as demanded in the Intel datasheets. */ block_len = min(block_len, 256 - (addr & 0xFF)); - ich_hwseq_set_addr(addr, hwseq_data->addr_mask); - - if (REGREAD8(ICH9_REG_HSFS) & HSFS_SCIP) { - msg_perr("Error: SCIP bit is unexpectedly set.\n"); - return -1; - } - - hsfc = REGREAD16(ICH9_REG_HSFC); - hsfc &= ~hwseq_data->hsfc_fcycle; /* set read operation */ - hsfc &= ~HSFC_FDBC; /* clear byte count */ - hsfc |= HSFC_CYCLE_READ; /* set read operation */ - /* set byte count */ - hsfc |= HSFC_FDBC_VAL(block_len - 1); - hsfc |= HSFC_FGO; /* start */ - REGWRITE16(ICH9_REG_HSFC, hsfc); - - if (ich_hwseq_wait_for_cycle_complete(block_len, ich_generation, hwseq_data->addr_mask)) + if (ich_exec_sync_hwseq_xfer(HSFC_CYCLE_READ, addr, block_len, ich_generation, + hwseq_data->addr_mask)) return 1; ich_read_data(buf, block_len, ICH9_REG_FDATA0); addr += block_len; @@ -1579,7 +1559,6 @@ static int ich_hwseq_write(struct flashctx *flash, const uint8_t *buf, unsigned int addr, unsigned int len) { - uint16_t hsfc; uint8_t block_len; const struct hwseq_data *hwseq_data = get_hwseq_data_from_context(flash); @@ -1594,28 +1573,14 @@ REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); while (len > 0) { - ich_hwseq_set_addr(addr, hwseq_data->addr_mask); /* Obey programmer limit... */ block_len = min(len, flash->mst->opaque.max_data_write); /* as well as flash chip page borders as demanded in the Intel datasheets. */ block_len = min(block_len, 256 - (addr & 0xFF)); ich_fill_data(buf, block_len, ICH9_REG_FDATA0); - if (REGREAD8(ICH9_REG_HSFS) & HSFS_SCIP) { - msg_perr("Error: SCIP bit is unexpectedly set.\n"); - return -1; - } - - hsfc = REGREAD16(ICH9_REG_HSFC); - hsfc &= ~hwseq_data->hsfc_fcycle; /* clear operation */ - hsfc |= HSFC_CYCLE_WRITE; /* set write operation */ - hsfc &= ~HSFC_FDBC; /* clear byte count */ - /* set byte count */ - hsfc |= HSFC_FDBC_VAL(block_len - 1); - hsfc |= HSFC_FGO; /* start */ - REGWRITE16(ICH9_REG_HSFC, hsfc); - - if (ich_hwseq_wait_for_cycle_complete(block_len, ich_generation, hwseq_data->addr_mask)) + if (ich_exec_sync_hwseq_xfer(HSFC_CYCLE_WRITE, addr, block_len, ich_generation, + hwseq_data->addr_mask)) return -1; addr += block_len; buf += block_len; -- To view, visit https://review.coreboot.org/c/flashrom/+/62869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 Gerrit-Change-Number: 62869 Gerrit-PatchSet: 30 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: spi: Make 'default_spi_write_aai' the default unless defined
by Anastasia Klimchuk (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67479 ) Change subject: spi: Make 'default_spi_write_aai' the default unless defined ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f14aaea0edcf0c08cea0e9cd27d58152707fb2a Gerrit-Change-Number: 67479 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 26 Sep 2022 05:10:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip probe func ptr to enumerate
by Edward O'Callaghan (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nikolai Artemiev. Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66781 to look at the new patch set (#10). Change subject: tree/: Convert flashchip probe func ptr to enumerate ...................................................................... tree/: Convert flashchip probe func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. squash in, flashchip.c: probe_jedec_29gl flashchip.c: probe_82802ab flashchip.c: probe_opaque flashchip.c: probe_jedec flashchip.c: probe_spi_res2 flashchip.c: probe_spi_res1 flashchip.c: probe_spi_rems flashchip.c: probe_spi_at25f flashchip.c: probe_spi_at45db flashchip.c: probe_spi_st95 flashchip.c: probe_spi_sfdp flashchip.c: probe_spi_rdid{4} flashchip.c: probe_w29ee011 flashchip.c: probe_en29lv640b flashchip.c: edi_probe_kb9012 flashchip.c: probe_spi_big_spansion Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashchips.c M flashrom.c M include/flash.h M tests/spi25.c 4 files changed, 684 insertions(+), 596 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/66781/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/66781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396 Gerrit-Change-Number: 66781 Gerrit-PatchSet: 10 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip write func ptr to enumerate
by Edward O'Callaghan (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66782 ) Change subject: tree/: Convert flashchip write func ptr to enumerate ...................................................................... Patch Set 9: (1 comment) File include/flash.h: https://review.coreboot.org/c/flashrom/+/66782/comment/e9188252_69f76bd8 PS8, Line 229: chip_write_func > There is an inconsistency in enum names at the moment: […] The functions are all inconsistent identifiers, I did best efforts not to be too confusing as a patch and not be overlapping with a rename patch. My take would be to follow up with a make everything consistent rename patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/66782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd Gerrit-Change-Number: 66782 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 26 Sep 2022 04:35:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip probe func ptr to enumerate
by Edward O'Callaghan (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66781 ) Change subject: tree/: Convert flashchip probe func ptr to enumerate ...................................................................... Patch Set 8: (3 comments) File flashrom.c: https://review.coreboot.org/c/flashrom/+/66781/comment/7f6670b0_dffa6841 PS8, Line 735: */ > Comment indentation seems off. Done. Originally intentional to make it clear. https://review.coreboot.org/c/flashrom/+/66781/comment/f0c04088_30630b68 PS8, Line 781: probe_func_t *probe_func = lookup_probe_func_ptr(flash->chip); > Why do you look up the function pointer twice? Resolved, thanks. File include/flash.h: https://review.coreboot.org/c/flashrom/+/66781/comment/72ba2eb8_b8b9a97b PS8, Line 226: SPI_ST95, > I'd prefer to have a `PROBE_` prefix, primarily because of the `JEDEC` enum value. Uff, so many lines. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396 Gerrit-Change-Number: 66781 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 26 Sep 2022 04:33:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Plumb 'all_skipped' global state into func param
by Edward O'Callaghan (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Angel Pons, Aarya, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67093 to look at the new patch set (#6). Change subject: flashrom.c: Plumb 'all_skipped' global state into func param ...................................................................... flashrom.c: Plumb 'all_skipped' global state into func param The 'all_skipped' global state can be made into a function parameter if one just follows though the CFG. Change-Id: I2346c869c47b48604360b0facf9313aae086c8dd Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c 1 file changed, 30 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/67093/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/67093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2346c869c47b48604360b0facf9313aae086c8dd Gerrit-Change-Number: 67093 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
by Edward O'Callaghan (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan. Hello Felix Singer, build bot (Jenkins), Nikolai Artemiev, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67091 to look at the new patch set (#6). Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash() ...................................................................... flashrom.c: Make 'chip_to_probe' a param to probe_flash() Apart from the very bespoke case of 'probe_w29ee011()' the override 'chip_to_probe' name is a nature parameter to 'probe_flash()'. However we can deal with w29ee011 by providing a probe specific validation funtion to check if the chip can indeed be overriden. Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M cli_classic.c M flashrom.c M include/chipdrivers.h M include/flash.h M libflashrom.c M w29ee011.c 6 files changed, 42 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/67091/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/67091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d Gerrit-Change-Number: 67091 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip write func ptr to enumerate
by Edward O'Callaghan (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66782 to look at the new patch set (#9). Change subject: tree/: Convert flashchip write func ptr to enumerate ...................................................................... tree/: Convert flashchip write func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. Squash in, flashchips.c: convert spi_chip_write_256() flashchips.c: convert write_jedec_1() flashchips.c: convert write_jedec() flashchips.c: convert write_opaque() flashchips.c: convert spi_chip_write_1() flashchips.c: convert spi_aai_write() flashchips.c: convert edi_chip_write() flashchips.c: convert write_en29lv640b() flashchips.c: convert write_82802ab() flashchips.c: convert spi_write_at45db() flashchips.c: convert write_28sf040() flashchips.c: convert NULL write Change-Id: I80149de169464b204fb09f1424a86fc645b740fd Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashchips.c M flashrom.c M include/flash.h M sfdp.c M tests/chip.c M tests/chip_wp.c M tests/spi25.c 7 files changed, 684 insertions(+), 599 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/66782/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/66782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd Gerrit-Change-Number: 66782 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip probe func ptr to enumerate
by Edward O'Callaghan (Code Review) 26 Sep '22

26 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Arthur Heymans, Nikolai Artemiev. Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66781 to look at the new patch set (#9). Change subject: tree/: Convert flashchip probe func ptr to enumerate ...................................................................... tree/: Convert flashchip probe func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. squash in, flashchip.c: probe_jedec_29gl flashchip.c: probe_82802ab flashchip.c: probe_opaque flashchip.c: probe_jedec flashchip.c: probe_spi_res2 flashchip.c: probe_spi_res1 flashchip.c: probe_spi_rems flashchip.c: probe_spi_at25f flashchip.c: probe_spi_at45db flashchip.c: probe_spi_st95 flashchip.c: probe_spi_sfdp flashchip.c: probe_spi_rdid{4} flashchip.c: probe_w29ee011 flashchip.c: probe_en29lv640b flashchip.c: edi_probe_kb9012 flashchip.c: probe_spi_big_spansion Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashchips.c M flashrom.c M include/flash.h M tests/spi25.c 4 files changed, 684 insertions(+), 596 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/66781/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/66781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396 Gerrit-Change-Number: 66781 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022