Aarya has uploaded a new patch set (#2) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/67717 )
Change subject: spi.c: Add AT45 & SF25F erasefn opcode mapping
......................................................................
spi.c: Add AT45 & SF25F erasefn opcode mapping
Change-Id: I798a91f1e20b63662715c68e6d43d03fc6005d51
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com>
---
M include/chipdrivers.h
M spi.c
2 files changed, 57 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/17/67717/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/67717
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I798a91f1e20b63662715c68e6d43d03fc6005d51
Gerrit-Change-Number: 67717
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Buhrow, Nico Huber, Paul Menzel, Aarya.
Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66104
to look at the new patch set (#56).
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
flashrom.c: Add wrapper function to use the erase algorithm
Add a function to call the erase algorithm.
Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M flashrom.c
1 file changed, 131 insertions(+), 289 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/56
--
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 56
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Buhrow, Nico Huber, Paul Menzel, Aarya.
Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66104
to look at the new patch set (#55).
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
flashrom.c: Add wrapper function to use the erase algorithm
Add a function to call the erase algorithm.
Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M flashrom.c
1 file changed, 128 insertions(+), 287 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/55
--
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 55
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67391 )
Change subject: drivers/: Make 'internal_delay' the default unless defined
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67391/comment/187de95d_e9d02910
PS5, Line 10: callback function pointer. This is a reasonable default for
please mention the struct you are dropping this function pointer from
--
To view, visit https://review.coreboot.org/c/flashrom/+/67391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I17460bc2c0aebcbb48c8dfa052b260991525cc49
Gerrit-Change-Number: 67391
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 16:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nikolai Artemiev.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67725 )
Change subject: cli_classic.c: Add error messages for invalid --wp-region use
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/67725/comment/7079d432_279e27fd
PS5, Line 1113:
> Please remove that empty line.
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/67725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d
Gerrit-Change-Number: 67725
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 14:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Nikolai Artemiev.
Hello Felix Singer, build bot (Jenkins), Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67725
to look at the new patch set (#6).
Change subject: cli_classic.c: Add error messages for invalid --wp-region use
......................................................................
cli_classic.c: Add error messages for invalid --wp-region use
Print warning if --wp-region is used without a layout file or the layout
file doesn't contain the region.
BUG=b:247055486
TEST=builds
Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d
Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com>
---
M cli_classic.c
1 file changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/67725/6
--
To view, visit https://review.coreboot.org/c/flashrom/+/67725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d
Gerrit-Change-Number: 67725
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-MessageType: newpatchset
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 )
Change subject: test_build.sh: Build all programmers individually using Meson
......................................................................
Patch Set 16:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66475/comment/da884bd3_c3ed1397
PS16, Line 12: the programmer groups individually.
> I don't quite understand. What could lead to break the groups if […]
They are separate options. I would like to build-test all of them.
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/66475/comment/07145705_bdc4faff
PS15, Line 57: # In case of clang analyzer we don't want to run it on
> > I wanted to avoid that and I didn't find another way than doing this. […]
Of course a function would work here, but it also seemed too much for me and so I decided against it. However, I can create a patch if you would like to have it this way.
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/66475/comment/2bb8fc37_3a98967b
PS16, Line 15: auto
> Why have `auto` here?
See my other comment.
--
To view, visit https://review.coreboot.org/c/flashrom/+/66475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4
Gerrit-Change-Number: 66475
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 23 Sep 2022 22:45:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 )
Change subject: test_build.sh: Build all programmers individually using Meson
......................................................................
Patch Set 16:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66475/comment/ec55f524_96ebbdf0
PS16, Line 12: the programmer groups individually.
I don't quite understand. What could lead to break the groups if
all at once and every programmer individually work?
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/66475/comment/72ce28b4_c58e51e5
PS15, Line 57: # In case of clang analyzer we don't want to run it on
> I wanted to avoid that and I didn't find another way than doing this.
The standard way to avoid duplication are functions. Not sure if I missed
anything why that wouldn't work here. Calling site could look like this:
```
single_meson_build all
if [ ${is_scan_build} -ne 1 ]; then
return
fi
for programmer in ${meson_programmer_opts}; do
single_meson_build ${programmer}
done
```
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/66475/comment/111b4e14_509651f2
PS16, Line 15: auto
Why have `auto` here?
--
To view, visit https://review.coreboot.org/c/flashrom/+/66475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4
Gerrit-Change-Number: 66475
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 23 Sep 2022 22:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67244 )
(
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: test_build.sh: Use multiple cores if Make is used
......................................................................
test_build.sh: Use multiple cores if Make is used
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67244
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
---
M test_build.sh
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, but someone else must approve
Thomas Heijligen: Looks good to me, approved
Angel Pons: Looks good to me, but someone else must approve
diff --git a/test_build.sh b/test_build.sh
index 2ca8de5..717df00 100755
--- a/test_build.sh
+++ b/test_build.sh
@@ -28,7 +28,7 @@
build_make () {
make clean
- make CONFIG_EVERYTHING=yes
+ make -j $(nproc) CONFIG_EVERYTHING=yes
# In case of clang analyzer we don't want to run it on
# each programmer individually. Thus, just return here.
@@ -39,7 +39,7 @@
for option in ${make_programmer_opts}; do
echo "Building ${option}"
make clean
- make CONFIG_NOTHING=yes CONFIG_${option}=yes
+ make -j $(nproc) CONFIG_NOTHING=yes CONFIG_${option}=yes
done
}
--
To view, visit https://review.coreboot.org/c/flashrom/+/67244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Gerrit-Change-Number: 67244
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged