September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: stlinkv3_spi.c: Fix 'stlinkv3_handle' may be used uninitialized
by Khoa Hoang (Code Review) 21 Sep '22

21 Sep '22

Khoa Hoang has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67714 ) Change subject: stlinkv3_spi.c: Fix 'stlinkv3_handle' may be used uninitialized ...................................................................... Abandoned dup -- To view, visit https://review.coreboot.org/c/flashrom/+/67714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id80eaa2e27902351b40bea3fb66eb368680f4ff4 Gerrit-Change-Number: 67714 Gerrit-PatchSet: 2 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Khoa Hoang (Code Review) 21 Sep '22

21 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67713 to look at the new patch set (#4). Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... flashchips.c: Add write protect support for W25Q16.V Enable WRSR2 feature flag and define reg_bits and decode_range for W25Q16.V to enable write protect support. TEST=flashrom --wp-{enable,disable,range,list,status} Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Signed-off-by: Khoa Hoang <admin(a)khoahoang.com> --- M flashchips.c 1 file changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/67713/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/67713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 4 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: internal: Pass programmer_cfg() through to MTD init
by Jonathon Hall (Code Review) 21 Sep '22

21 Sep '22

Jonathon Hall has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67744 ) Change subject: internal: Pass programmer_cfg() through to MTD init ...................................................................... Abandoned Dup of 496331a6727d146145f843141e6bc0a1e73b60ff -- To view, visit https://review.coreboot.org/c/flashrom/+/67744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I194ee0318c3bf829868e7b3c368ab45b3d2b3721 Gerrit-Change-Number: 67744 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
by Jonathon Hall (Code Review) 21 Sep '22

21 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par_master ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: > I found more issues. […] I'll bring back the mappers for the SPI masters. IMO, if I have to bring back the infrastructure, I would rather preserve behavior for all of the other masters I'm unable to test, so I'll probably restore ICH7 and ICH9 swseq as well if it works out cleanly. I definitely don't want to go refactoring lots of programmers in this patch ;-) So I can shoehorn a way for SPI masters to set the mapper in par_master, or move the mappers back up to registered_master, or possibly add a mapper to spi_master. I'm leaning toward spi_master I think if I can get it handled cleanly. I don't think we need mappers for any of the opaque masters. (linux_mtd and nicintel_eeprom already used fallback, I tested ichspi.) Have a good vacation, I'll probably leave more updates and comments here as I go but no rush! File serprog.c: https://review.coreboot.org/c/flashrom/+/67695/comment/1a4d1525_61d19f6a PS5, Line 919: 1024 > we have a `KiB` macro Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 5 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Sep 2022 16:54:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
by Thomas Heijligen (Code Review) 21 Sep '22

21 Sep '22

Attention is currently required from: Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par_master ...................................................................... Patch Set 5: (5 comments) Patchset: PS5: I found more issues. The internal wbsio spi_master, uses an hybrid of memory mapping and spi commands. The sb600 promontory faces similar problems. Unfortunately I'm on vacation the next weeks, so I've limited resources to look into all the issues coming with this change. But at this point already a huge thank you for all this work. File atapromise.c: https://review.coreboot.org/c/flashrom/+/67695/comment/2d146c62_d81ea3b1 PS2, Line 133: atapromise_map > Removed this, also updated the comment in fallback_map() since returning NULL is the desired behavio […] Done File atavia.c: https://review.coreboot.org/c/flashrom/+/67695/comment/729a6eaa_8d905911 PS2, Line 147: atavia_map > I kept this around for now since I can't test it and it doesn't hurt the overall structure. […] Done File serprog.c: https://review.coreboot.org/c/flashrom/+/67695/comment/a816598f_0a913cbd PS2, Line 582: .map_flash_region = serprog_map, > Ah I see it now, I replaced the mapper with max_rom_decode for all bus types. Done File serprog.c: https://review.coreboot.org/c/flashrom/+/67695/comment/9178b9ea_64821af5 PS5, Line 919: 1024 we have a `KiB` macro -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 5 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Sep 2022 16:04:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: writeprotect_ranges.c: add more range functions
by Maciej Pijanowski (Code Review) 21 Sep '22

21 Sep '22

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, Sergii Dmytruk. Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66212 ) Change subject: writeprotect_ranges.c: add more range functions ...................................................................... Patch Set 6: (1 comment) Patchset: PS3: > Sergii, I realised your chain is waiting for attention for a while. […] I'm afraid we will not be able to test all of them. I've tested some I could access with the results published here: https://github.com/flashrom/flashrom/issues/185#issuecomment-1253434497 The list of the chips comes mostly from the linked issue. We wanted to add support for all of them and hoped for some support in testing, but as you can see in the issue, there are no volounteers currently. Sergii suggested we might flag somehow the ones we tested and the ones which are purely based on the datasheet. Any thoughts on moving forward are appreciated. -- To view, visit https://review.coreboot.org/c/flashrom/+/66212 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied7b27be2ee2426af8f473432e2b01a290de2365 Gerrit-Change-Number: 66212 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 21 Sep 2022 15:28:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Improve robustness when dealing with empty $CC
by Patrick Georgi (Code Review) 21 Sep '22

21 Sep '22

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67740 ) Change subject: test_build.sh: Improve robustness when dealing with empty $CC ...................................................................... test_build.sh: Improve robustness when dealing with empty $CC Add quotes so that = knows what to compare, otherwise the shell complains: ./test_build.sh: 16: [: =: unexpected operator Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M test_build.sh 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/test_build.sh b/test_build.sh index 4d6570b..0a4506a 100755 --- a/test_build.sh +++ b/test_build.sh @@ -13,7 +13,7 @@ CH341A_SPI DIGILENT_SPI JLINK_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then +if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/67740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Gerrit-Change-Number: 67740 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: test_build.sh: Identify runs for Coverity Scan
by Patrick Georgi (Code Review) 21 Sep '22

21 Sep '22

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67739 ) Change subject: test_build.sh: Identify runs for Coverity Scan ...................................................................... test_build.sh: Identify runs for Coverity Scan For Coverity Scan[0] the same build rules apply as for scan-build. [0] https://scan.coverity.com/projects/flashrom Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67739 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M test_build.sh 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/test_build.sh b/test_build.sh index b2320b8..4d6570b 100755 --- a/test_build.sh +++ b/test_build.sh @@ -13,7 +13,7 @@ CH341A_SPI DIGILENT_SPI JLINK_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ]; then +if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/67739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Gerrit-Change-Number: 67739 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: internal.c: Pass `programmer_cfg` to `try_mtd()`
by Felix Singer (Code Review) 21 Sep '22

21 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67752 ) Change subject: internal.c: Pass `programmer_cfg` to `try_mtd()` ...................................................................... internal.c: Pass `programmer_cfg` to `try_mtd()` Programmer params are now passed via the `programmer_cfg` struct, but the internal programmer did not pass them to the `try_mtd()` function which was still using `NULL`. This problem resulted in a segmentation fault when trying to use the internal programmer. TEST=Make sure internal programmer does not segfault on Haswell ULT. Change-Id: I9e74bd68a1f9509a201dc518dbff96c27d68a3c3 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67752 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M include/programmer.h M internal.c 2 files changed, 29 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Thomas Heijligen: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/include/programmer.h b/include/programmer.h index a7cea5e..17abfd2 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -375,12 +375,15 @@ void probe_superio_ite(void); int init_superio_ite(const struct programmer_cfg *cfg); -#if CONFIG_LINUX_MTD == 1 /* trivial wrapper to avoid cluttering internal_init() with #if */ -static inline int try_mtd(void) { return programmer_linux_mtd.init(NULL); }; +static inline int try_mtd(const struct programmer_cfg *cfg) +{ +#if CONFIG_LINUX_MTD == 1 + return programmer_linux_mtd.init(cfg); #else -static inline int try_mtd(void) { return 1; }; + return 1; #endif +} /* mcp6x_spi.c */ int mcp6x_spi_init(int want_spi); diff --git a/internal.c b/internal.c index 43aa51b..6a8db5e 100644 --- a/internal.c +++ b/internal.c @@ -215,7 +215,7 @@ */ internal_buses_supported = BUS_NONSPI; - if (try_mtd() == 0) { + if (try_mtd(cfg) == 0) { ret = 0; goto internal_init_exit; } -- To view, visit https://review.coreboot.org/c/flashrom/+/67752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9e74bd68a1f9509a201dc518dbff96c27d68a3c3 Gerrit-Change-Number: 67752 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
by Felix Singer (Code Review) 21 Sep '22

21 Sep '22

Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64968 ) Change subject: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/64968/comment/406aa05a_711a3b48 PS6, Line 7: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently I rather would like to use the functions instead of the macros. https://review.coreboot.org/c/flashrom/+/64968/comment/95abb93c_b21e8c6b PS6, Line 14: TEST=builds As far as I can see, the binary shouldn't change. Please make sure this is the case. -- To view, visit https://review.coreboot.org/c/flashrom/+/64968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c90ea1ff617a451a671827d7bc49679d349c79d Gerrit-Change-Number: 64968 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:40:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022