May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64246 ) Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 11 May 2022 14:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add Intel Alder Lake-S support
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Michał Żygowski, Michał Kopeć. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64253 ) Change subject: ichspi: Add Intel Alder Lake-S support ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/64253/comment/6c2dfb50_b1f4d27f PS1, Line 2177: 0x7a8a, B_S, NT, "Intel", "W685 > The device IDs were taken from Intel doc #619362 (Intel 600, 700 Series PCH EDS Vol1), which is not […] Ack, thanks for providing me the reference https://review.coreboot.org/c/flashrom/+/64253/comment/75b37f27_a6ea0b6d PS1, Line 2180: {0x8086, 0x7a0d, B_S, NT, "Intel", "WM790", enable_flash_pch600}, : {0x8086, 0x7a0c, B_S, NT, "Intel", "HM770", enable_flash_pch600}, > Removed these 2 chipsets, since they don't exist yet. […] Good plan -- To view, visit https://review.coreboot.org/c/flashrom/+/64253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Gerrit-Change-Number: 64253 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Wed, 11 May 2022 14:00:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add Intel Alder Lake-S support
by Michał Kopeć (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64253 ) Change subject: ichspi: Add Intel Alder Lake-S support ...................................................................... Patch Set 2: (1 comment) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/64253/comment/7c42c036_f9b28525 PS1, Line 2180: {0x8086, 0x7a0d, B_S, NT, "Intel", "WM790", enable_flash_pch600}, : {0x8086, 0x7a0c, B_S, NT, "Intel", "HM770", enable_flash_pch600}, > Not yet released, but listed in the same doc as 600 series chipsets Removed these 2 chipsets, since they don't exist yet. They can be added later -- To view, visit https://review.coreboot.org/c/flashrom/+/64253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Gerrit-Change-Number: 64253 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 11 May 2022 13:41:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add Intel Alder Lake-S support
by Michał Kopeć (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64253 to look at the new patch set (#2). Change subject: ichspi: Add Intel Alder Lake-S support ...................................................................... ichspi: Add Intel Alder Lake-S support Add ADL PCH-S device IDs to enable flashrom on Alder Lake-S platforms. TEST=Dump BIOS on MSI Z690 PRO DDR4 WIFI Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M chipset_enable.c M ich_descriptors.c 2 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/64253/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Gerrit-Change-Number: 64253 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Add Intel Alder Lake-S support
by Michał Kopeć (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64253 ) Change subject: ichspi: Add Intel Alder Lake-S support ...................................................................... Patch Set 1: (2 comments) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/64253/comment/bffa1e5c_3e518ed7 PS1, Line 2177: 0x7a8a, B_S, NT, "Intel", "W685 > I haven't found it in public documentation. Are there public docs for it? […] The device IDs were taken from Intel doc #619362 (Intel 600, 700 Series PCH EDS Vol1), which is not public unfortunately https://review.coreboot.org/c/flashrom/+/64253/comment/35d7be6a_8bfa1297 PS1, Line 2180: {0x8086, 0x7a0d, B_S, NT, "Intel", "WM790", enable_flash_pch600}, : {0x8086, 0x7a0c, B_S, NT, "Intel", "HM770", enable_flash_pch600}, > Aren't these 13th gen / 700 chipsets which are not yet released? I haven't found public information […] Not yet released, but listed in the same doc as 600 series chipsets -- To view, visit https://review.coreboot.org/c/flashrom/+/64253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Gerrit-Change-Number: 64253 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 11 May 2022 13:26:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64248 ) Change subject: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: CB:64224 -- To view, visit https://review.coreboot.org/c/flashrom/+/64248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifba011c22988e9d2ae958cdafb1b11a3a8a7cc0a Gerrit-Change-Number: 64248 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 11 May 2022 13:13:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add Intel Alder Lake-S support
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Michał Kopeć. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64253 ) Change subject: ichspi: Add Intel Alder Lake-S support ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/64253/comment/3b641eb2_419b02ad PS1, Line 2177: 0x7a8a, B_S, NT, "Intel", "W685 I haven't found it in public documentation. Are there public docs for it? Intel 600 Series Chipset Family Platform Controller Hub (PCH) https://www.intel.com/content/www/us/en/products/docs/processors/core/core-… https://review.coreboot.org/c/flashrom/+/64253/comment/3ae739eb_cb1f1f36 PS1, Line 2180: {0x8086, 0x7a0d, B_S, NT, "Intel", "WM790", enable_flash_pch600}, : {0x8086, 0x7a0c, B_S, NT, "Intel", "HM770", enable_flash_pch600}, Aren't these 13th gen / 700 chipsets which are not yet released? I haven't found public information about them. -- To view, visit https://review.coreboot.org/c/flashrom/+/64253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Gerrit-Change-Number: 64253 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Wed, 11 May 2022 13:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it87spi.c: Enable probing of IT8686E
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Pete Smith. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64254 ) Change subject: it87spi.c: Enable probing of IT8686E ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/64254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a1780275a92089c2d91c5da1c472f6d8bc39a56 Gerrit-Change-Number: 64254 Gerrit-PatchSet: 1 Gerrit-Owner: Pete Smith <zailawee(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Pete Smith <zailawee(a)protonmail.com> Gerrit-Comment-Date: Wed, 11 May 2022 12:21:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: link flashrom binary against static libflashrom
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64030 ) Change subject: meson: link flashrom binary against static libflashrom ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/64030/comment/541a041c_87792b21 PS2, Line 8: > It would be great to have info about how the patch was tested. […] Is this enough? -- To view, visit https://review.coreboot.org/c/flashrom/+/64030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic522610f59e00299ebfa1bd29482ff92120ec52b Gerrit-Change-Number: 64030 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 11 May 2022 12:15:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63724 to look at the new patch set (#17). Change subject: [WIP] meson: rework the programmer selection ...................................................................... [WIP] meson: rework the programmer selection This is a WIP implementation for a new programmer selection. It should work by now but has some known and unknown bugs. (see Gerrit Comments) - Each dependency is optional and gets mandatory when the programmer is selected as active. - Each programmer is defined through an entry in the programmer dictionary - The entry lists systems & cpu_families where the programmer is supported; Dependencies, sources and flags. The group parameter is for selecting a set of programmer, the default parameter is to include the programmer to the `all` and `auto` set. - If the programmer gets selected the `active` entry is set to true. The `active` entry can be used afterwards to determine if the programmer should be included in sources, config, documentation - Needed system headers are represended through a pseudo dependency. - The programmer's `srcs` attribute contains all files which are needed to build the programmer. Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M meson_options.txt M tests/meson.build 3 files changed, 412 insertions(+), 341 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/63724/17 -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 17 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022