May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: libflashrom: Return progress state to the library user
by Anastasia Klimchuk (Code Review) 12 May '22

12 May '22

Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Patrick Rudolph. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 ) Change subject: libflashrom: Return progress state to the library user ...................................................................... Patch Set 15: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49643/comment/8c8cd7a9_ee190305 PS11, Line 15: > Done. […] Dummyflasher is useful for sure, thanks! I would still want to test on a real device. If you don't have capacity, let me know, me or Peter can test the patch. linux_mtd should not be a problem. I am leaving this unresolved for testing, and meanwhile other people can have a look. Otherwise I have no other comments on the code. -- To view, visit https://review.coreboot.org/c/flashrom/+/49643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c Gerrit-Change-Number: 49643 Gerrit-PatchSet: 15 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <hughsient(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 12 May 2022 00:29:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: serprog.c: Avoid calling memcpy with NULL pointer arguments
by Anastasia Klimchuk (Code Review) 12 May '22

12 May '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62726 ) Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ...................................................................... serprog.c: Avoid calling memcpy with NULL pointer arguments In function sp_stream_buffer_op, the variable parms might be NULL when passed to memcpy. Although, since parmlen is also 0 at that time I don't think it would make much difference. Still, add a NULL check before calling memcpy to be safe. Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62726 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M serprog.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Thomas Heijligen: Looks good to me, approved Edward O'Callaghan: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved diff --git a/serprog.c b/serprog.c index 2bbf44b..ea2bbf0 100644 --- a/serprog.c +++ b/serprog.c @@ -291,7 +291,8 @@ return 1; } sp[0] = cmd; - memcpy(&(sp[1]), parms, parmlen); + if (parms) + memcpy(&(sp[1]), parms, parmlen); if (sp_streamed_transmit_bytes >= (1 + parmlen + sp_device_serbuf_size)) { if (sp_flush_stream() != 0) { -- To view, visit https://review.coreboot.org/c/flashrom/+/62726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b Gerrit-Change-Number: 62726 Gerrit-PatchSet: 17 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: tests: Rearange CPP guards
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Attention is currently required from: Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64224 ) Change subject: tests: Rearange CPP guards ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File tests/lifecycle.c: https://review.coreboot.org/c/flashrom/+/64224/comment/3c3bb443_4d6685bc PS2, Line 87: #if CONFIG_DUMMY == 1 We could get rid of the pre-processor conditionals by splitting up the file into per-driver compilation units and using a weak symbol entry point then letting the linker do the rest for us. -- To view, visit https://review.coreboot.org/c/flashrom/+/64224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02880e73996b30df618738e86b8a52126fbe5b3b Gerrit-Change-Number: 64224 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 11 May 2022 23:48:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/64248 ) Change subject: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/64248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifba011c22988e9d2ae958cdafb1b11a3a8a7cc0a Gerrit-Change-Number: 64248 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64248 ) Change subject: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > CB:64224 Thanks Thomas! -- To view, visit https://review.coreboot.org/c/flashrom/+/64248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifba011c22988e9d2ae958cdafb1b11a3a8a7cc0a Gerrit-Change-Number: 64248 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 11 May 2022 23:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: test write protection
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: tests: test write protection ...................................................................... Patch Set 40: Code-Review+2 (1 comment) Patchset: PS39: > Thanks, these comments help a lot! That's a good idea indeed! -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 40 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 11 May 2022 22:50:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: add option to disable tests
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/63832/comment/cbd36495_ada37ecd PS1, Line 522: if cmocka_dep.found() > They behave like before this commit. Only the behavior with `--tests=enabled/disbaled` changes. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 11 May 2022 22:44:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add voltage data for chips
by Felix Singer (Code Review) 11 May '22

11 May '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Chinmay Lonkar. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64259 ) Change subject: Add voltage data for chips ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/64259/comment/ed87af12_0b4d9169 PS1, Line 7: Add voltage data for chips Suggestion: flashchips: Add voltage data for several chips https://review.coreboot.org/c/flashrom/+/64259/comment/8f3db194_1de8c732 PS1, Line 9: This patch adds voltage data for following chips: Suggestion: The following flashchips are missing voltage data. Thus, add them. -- To view, visit https://review.coreboot.org/c/flashrom/+/64259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13 Gerrit-Change-Number: 64259 Gerrit-PatchSet: 1 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Comment-Date: Wed, 11 May 2022 20:36:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add voltage data for chips
by Chinmay Lonkar (Code Review) 11 May '22

11 May '22

Chinmay Lonkar has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64259 ) Change subject: Add voltage data for chips ...................................................................... Add voltage data for chips This patch adds voltage data for following chips: * Intel 28F002BC/BL/BV/BX-T * Intel 28F004B5/BE/BV/BX-B * Intel 28F004B5/BE/BV/BX-T * Intel 28F008S3/S5/SC * Intel 28F400BV/BX/CE/CV-B * Intel 28F400BV/BX/CE/CV-T * Micron/Numonyx/ST M25P40-old * SyncMOS/MoselVitelic {F,S,V}29C51002T * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old Signed-off-by: ChinmayLonkar <chinmay20220(a)gmail.com> Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13 --- M flashchips.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/64259/1 diff --git a/flashchips.c b/flashchips.c index d155b24..f9cb0cd 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8112,6 +8112,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8139,6 +8140,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8166,6 +8168,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8189,6 +8192,7 @@ .unlock = unlock_28f004s5, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3300}, }, { @@ -8217,6 +8221,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3600}, }, { @@ -8245,6 +8250,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3600}, }, { @@ -10521,6 +10527,7 @@ .unlock = spi_disable_blockprotect_bp3_srwd, .write = spi_chip_write_256, .read = spi_chip_read, + .voltage = {2300, 3600}, }, { @@ -16884,6 +16891,7 @@ }, .write = write_jedec_1, .read = read_memmapped, + .voltage = {4500, 5500} }, { @@ -16910,6 +16918,7 @@ }, .write = write_jedec_1, .read = read_memmapped, + .voltage = {4500, 5500} }, { @@ -18607,6 +18616,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -18630,6 +18640,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/64259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13 Gerrit-Change-Number: 64259 Gerrit-PatchSet: 1 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: test write protection
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: tests: test write protection ...................................................................... Patch Set 40: Code-Review+2 (1 comment) Patchset: PS39: > Done Thanks, these comments help a lot! -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 40 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 11 May 2022 17:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022