May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64246 ) Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... Patch Set 3: (1 comment) File it85spi.c: https://review.coreboot.org/c/flashrom/+/64246/comment/f69e6aaa_cc45bd69 PS3, Line 244: > If you add new line here, that would be perfect ! Done -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 11 May 2022 03:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Hello build bot (Jenkins), Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64246 to look at the new patch set (#4). Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... it85spi.c: Fix some space/tab trivial style issues Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 27 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/64246/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64246 ) Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File it85spi.c: https://review.coreboot.org/c/flashrom/+/64246/comment/cc88919a_8c995366 PS3, Line 244: If you add new line here, that would be perfect ! -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 11 May 2022 03:00:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Rearange CPP guards
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64224 ) Change subject: tests: Rearange CPP guards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02880e73996b30df618738e86b8a52126fbe5b3b Gerrit-Change-Number: 64224 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 11 May 2022 02:42:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Hello build bot (Jenkins), Nikolai Artemiev, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64246 to look at the new patch set (#3). Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... it85spi.c: Fix some space/tab trivial style issues Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 26 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/64246/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: relocate config_print_wiki & config_default_programmer_*
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64029 ) Change subject: meson: relocate config_print_wiki & config_default_programmer_* ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/64029/comment/5f18177e_22f1958a PS2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"' I think we cannot drop it for our chromium use cases... I can double-check though. Let's not do anything in this patch :) > CONFIG_DEFAULT_PROGRAMMER_ARGS must be defined, at least as an empty string. classic_cli.c:838 Yes but line 838 is under the condition on line 835 `if (default_programmer)`. So if name is empty then args not needed either? meson has this condition on line 411. -- To view, visit https://review.coreboot.org/c/flashrom/+/64029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9538b0aee31b294844d4f4ca0396334a81dfb498 Gerrit-Change-Number: 64029 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 11 May 2022 02:34:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Edward O'Callaghan has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/64246 ) Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... it85spi.c: Fix some space/tab trivial style issues Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 15 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/64246/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64246 ) Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... it85spi.c: Fix some space/tab trivial style issues Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/64246/1 diff --git a/it85spi.c b/it85spi.c index 51328a8..4fe2b68 100644 --- a/it85spi.c +++ b/it85spi.c @@ -241,9 +241,9 @@ struct it85spi_data *data = flash->mst->spi.data; it85xx_enter_scratch_rom(data); - /* Exit scratch ROM ONLY when programmer shuts down. Otherwise, the - * temporary flash state may halt the EC. - */ + /* Exit scratch ROM ONLY when programmer shuts down. Otherwise, the + * temporary flash state may halt the EC. + */ #ifdef LPC_IO INDIRECT_A1(data->shm_io_base, (((unsigned long int)data->ce_high) >> 8) & 0xff); @@ -253,22 +253,22 @@ #ifdef LPC_MEMORY mmio_writeb(0, data->ce_high); #endif - for (i = 0; i < writecnt; ++i) { + for (i = 0; i < writecnt; ++i) { #ifdef LPC_IO INDIRECT_WRITE(data->shm_io_base, writearr[i]); #endif #ifdef LPC_MEMORY mmio_writeb(writearr[i], data->ce_low); #endif - } - for (i = 0; i < readcnt; ++i) { + } + for (i = 0; i < readcnt; ++i) { #ifdef LPC_IO readarr[i] = INDIRECT_READ(data->shm_io_base); #endif #ifdef LPC_MEMORY readarr[i] = mmio_readb(data->ce_low); #endif - } + } #ifdef LPC_IO INDIRECT_A1(data->shm_io_base, (((unsigned long int)data->ce_high) >> 8) & 0xff); INDIRECT_WRITE(data->shm_io_base, 0xFF); /* Write anything to this address.*/ @@ -277,7 +277,7 @@ mmio_writeb(0, data->ce_high); #endif - return 0; + return 0; } static const struct spi_master spi_master_it85xx = { -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson: add option to disable tests
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/63832/comment/b2e364eb_7e526aa7 PS1, Line 522: if cmocka_dep.found() > If `tests=enabled` the block will be executed, cmocka is a required dependency and the build fails i […] Oh I see thank you for explanation! I see that `cmocka_dep.found()` is back now :) Would it be possible for you to run two test scenarios that I copied in my previous message? Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 11 May 2022 02:19:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: Return progress state to the library user
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Patrick Rudolph. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 ) Change subject: libflashrom: Return progress state to the library user ...................................................................... Patch Set 13: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/49643/comment/9aa5963e_d91fde24 PS11, Line 15: > Would you mind having this as a follow up CL? Oh sorry for confusion, I didn't mean to write another unit test! I mean test in a literal meaning, build flashrom and run it on a device. CLI is now calling libflashrom functions, so calling read-erase-write from command line will execute the code which is added in this patch. And then if you can add the info into commit message what test scenarios were run, that would be perfect. Thanks! Patchset: PS13: Special thanks for avoiding global state for progress_state! Just few comments left. File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/49643/comment/6b476d91_baa5240d PS13, Line 113: flashrom_update_progress_callback Should this also be added in libflashrom.map ? File libflashrom.c: https://review.coreboot.org/c/flashrom/+/49643/comment/17539fe1_22dc1818 PS13, Line 106: @param userdata Userdata pointer to include with the progress callback. This param is now called `progress_state` https://review.coreboot.org/c/flashrom/+/49643/comment/435209d2_ff0cbb03 PS13, Line 98: /** : * @brief Set the progress callback function. : * : * Set a callback function which will be invoked whenever libflashrom wants : * to indicate the progress has changed. This allows frontends to do whatever : * they see fit with such values, e.g. update a progress bar in a GUI tool. : * : * @param progress_callback Pointer to the new progress callback function. : * @param userdata Userdata pointer to include with the progress callback. : */ Documentation has been moved to header file in CB:63903 , so you will need to rebase and then move this doc to header file together with the others. -- To view, visit https://review.coreboot.org/c/flashrom/+/49643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c Gerrit-Change-Number: 49643 Gerrit-PatchSet: 13 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <hughsient(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 11 May 2022 02:06:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022