May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ichspi: Add Intel Alder Lake-S support
by Michał Kopeć (Code Review) 11 May '22

11 May '22

Michał Kopeć has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64253 ) Change subject: ichspi: Add Intel Alder Lake-S support ...................................................................... ichspi: Add Intel Alder Lake-S support Add ADL PCH-S device IDs to enable flashrom on Alder Lake-S platforms. TEST=Dump BIOS on MSI Z690 PRO DDR4 WIFI Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M chipset_enable.c M ich_descriptors.c 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/64253/1 diff --git a/chipset_enable.c b/chipset_enable.c index a0bffa0..26c46a1 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2168,6 +2168,17 @@ {0x8086, 0x438b, B_S, DEP, "Intel", "HM570", enable_flash_pch500}, {0x8086, 0x54a4, B_S, DEP, "Intel", "Alder Lake-N", enable_flash_pch600}, {0x8086, 0x51a4, B_S, DEP, "Intel", "Alder Lake-P", enable_flash_pch600}, + {0x8086, 0x7a87, B_S, NT, "Intel", "H610", enable_flash_pch600}, + {0x8086, 0x7a86, B_S, NT, "Intel", "B660", enable_flash_pch600}, + {0x8086, 0x7a85, B_S, NT, "Intel", "H670", enable_flash_pch600}, + {0x8086, 0x7a83, B_S, NT, "Intel", "Q670", enable_flash_pch600}, + {0x8086, 0x7a84, B_S, DEP, "Intel", "Z690", enable_flash_pch600}, + {0x8086, 0x7a88, B_S, NT, "Intel", "W680", enable_flash_pch600}, + {0x8086, 0x7a8a, B_S, NT, "Intel", "W685", enable_flash_pch600}, + {0x8086, 0x7a8d, B_S, NT, "Intel", "WM690", enable_flash_pch600}, + {0x8086, 0x7a8c, B_S, NT, "Intel", "HM670", enable_flash_pch600}, + {0x8086, 0x7a0d, B_S, NT, "Intel", "WM790", enable_flash_pch600}, + {0x8086, 0x7a0c, B_S, NT, "Intel", "HM770", enable_flash_pch600}, {0x8086, 0x7e23, B_S, DEP, "Intel", "Meteor Lake-P/M", enable_flash_mtl}, #endif {0}, diff --git a/ich_descriptors.c b/ich_descriptors.c index 797642e..8709603 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -1048,8 +1048,12 @@ } else { if (content->ICCRIBA == 0x34) return CHIPSET_300_SERIES_CANNON_POINT; - if (content->CSSL == 0x11) - return CHIPSET_500_SERIES_TIGER_POINT; + if (content->CSSL == 0x11) { + if (content->CSSO == 0x68) + return CHIPSET_500_SERIES_TIGER_POINT; + else if (content->CSSO == 0x5c) + return CHIPSET_600_SERIES_ALDER_POINT; + } if (content->CSSL == 0x14) return CHIPSET_600_SERIES_ALDER_POINT; if (content->CSSL == 0x03) { -- To view, visit https://review.coreboot.org/c/flashrom/+/64253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a8c057994874a41ed400b176f156048dae43c0 Gerrit-Change-Number: 64253 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: dummyflasher: enforce write protection for W25Q128FV
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59074 ) Change subject: dummyflasher: enforce write protection for W25Q128FV ...................................................................... Patch Set 37: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/59074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fd1417f941186391bd213bd355530143c8f04a0 Gerrit-Change-Number: 59074 Gerrit-PatchSet: 37 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 11 May 2022 09:20:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher: emulate SR2 and SR3 for W25Q128FV
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Angel Pons, Sergii Dmytruk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59073 ) Change subject: dummyflasher: emulate SR2 and SR3 for W25Q128FV ...................................................................... Patch Set 37: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/59073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I79f9b4a0b604663d3288ad70dcbe3ea4075dede5 Gerrit-Change-Number: 59073 Gerrit-PatchSet: 37 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 11 May 2022 09:20:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher: add SR2 and SR3 emulation harness
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59072 ) Change subject: dummyflasher: add SR2 and SR3 emulation harness ...................................................................... Patch Set 37: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/59072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I177ae3f068f03380f5b3941d9996a07205672e59 Gerrit-Change-Number: 59072 Gerrit-PatchSet: 37 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 11 May 2022 09:19:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: relocate config_print_wiki & config_default_programmer_*
by Thomas Heijligen (Code Review) 11 May '22

11 May '22

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64029 ) Change subject: meson: relocate config_print_wiki & config_default_programmer_* ...................................................................... Patch Set 3: (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/64029/comment/9c543afb_4df28c9c PS2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"' > I think we cannot drop it for our chromium use cases... I can double-check though. […] The C compiler doesn't know the value of default_programmer. For a human it's easy to spot that its NULL in the case CONFIG_DEFAULT_PROGRAMMER_NAME is NULL and the following code is not needed, but the compiler doesn't get it. So you get an `CONFIG_DEFAULT_PROGRAMMER_ARGS undeclared` error in any case if ifs not defined. -- To view, visit https://review.coreboot.org/c/flashrom/+/64029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9538b0aee31b294844d4f4ca0396334a81dfb498 Gerrit-Change-Number: 64029 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 May 2022 06:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64248 ) Change subject: tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused ...................................................................... tests/lifecycle.c: Fix warn about dediprog_libusb_*() being unused Fix the immediate issue of dediprog_libusb_*() callbacks being unused however the more long term solution is to remove these pre-processing directives in favour of compilation units. Change-Id: Ifba011c22988e9d2ae958cdafb1b11a3a8a7cc0a Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/lifecycle.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/64248/1 diff --git a/tests/lifecycle.c b/tests/lifecycle.c index 63fcc3c..edb8188 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -229,6 +229,7 @@ #endif } +#if CONFIG_DEDIPROG == 1 static int dediprog_libusb_init(void *state, libusb_context **ctx) { *ctx = not_null(); @@ -251,6 +252,7 @@ } return wLength; } +#endif /* CONFIG_DEDIPROG == 1 */ void dediprog_basic_lifecycle_test_success(void **state) { -- To view, visit https://review.coreboot.org/c/flashrom/+/64248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifba011c22988e9d2ae958cdafb1b11a3a8a7cc0a Gerrit-Change-Number: 64248 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: pcidev: Construct a API to handle phantom pci controllers
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62951 ) Change subject: pcidev: Construct a API to handle phantom pci controllers ...................................................................... Patch Set 3: (1 comment) File include/programmer.h: https://review.coreboot.org/c/flashrom/+/62951/comment/ee10e055_97bcdaf1 PS3, Line 133: pcidev_phantom_spidev It would be great to have a name of the function with a verb, to explain what it is doing (get_pcidev_phantom_spidev maybe?). At the moment there are 3 nouns in a row. Maybe it's just me, but I was looking at the call in chipset_enable and could not understand what this function is doing. -- To view, visit https://review.coreboot.org/c/flashrom/+/62951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic75573a14c9997a2d0347cd683ffc0c78d1b3a4f Gerrit-Change-Number: 62951 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 11 May 2022 05:11:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Felix Singer, Martin L Roth, Patrick Georgi, Stefan Reinauer, Angel Pons, Stefan T. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/64101/comment/a2a8846c_19608c9d PS3, Line 7: Review access change This is somewhat a vague description and because of that may look a bit scary :) Also if this patch is doing two things (which was mentioned in other comments) and if it is technically possible to break it into two patches, each of them doing one thing, then we can have more specific description for each of the patches. Patchset: PS3: It seems like the patch is doing two things, so I am wondering if it is technically possible to split into two patches, each of them doing one thing? first one: adding flashrom reviewers group second one: something else For the first patch, it may be good to link some information where it comes from. Probably the most compact way is to link this thread: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/VGTQ… Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Wed, 11 May 2022 03:35:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Anastasia Klimchuk (Code Review) 11 May '22

11 May '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64246 ) Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 11 May 2022 03:10:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it85spi.c: Fix some space/tab trivial style issues
by Edward O'Callaghan (Code Review) 11 May '22

11 May '22

Attention is currently required from: Nikolai Artemiev. Hello build bot (Jenkins), Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64246 to look at the new patch set (#5). Change subject: it85spi.c: Fix some space/tab trivial style issues ...................................................................... it85spi.c: Fix some space/tab trivial style issues Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 27 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/64246/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/64246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9192461281f9e760644a241148f4c5100f76da98 Gerrit-Change-Number: 64246 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022