May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: cli_classic: fix memory leak
by Anastasia Klimchuk (Code Review) 16 May '22

16 May '22

Attention is currently required from: Angel Pons, Nikolai Artemiev, Joursoir. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 2 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Joursoir <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 16 May 2022 22:11:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][OTP] spi: add functions for OTP regions
by Anastasia Klimchuk (Code Review) 16 May '22

16 May '22

Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59402 ) Change subject: [RFC][OTP] spi: add functions for OTP regions ...................................................................... Patch Set 25: (1 comment) Patchset: PS25: > There are conflicts with master, so some rebasing is needed. […] That's awesome to hear that WP works for you! @Nikolai read this :) About OTP feature, I think the best would be to write on the mailing list and ask if anyone has an interest in these changes. Abandoning is easy to do, it can be done later at any time if needed. Are you alright to start a topic on the mailing list, would you do it? -- To view, visit https://review.coreboot.org/c/flashrom/+/59402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic33e2c1de8b0ca02df9118218a663ce63826f339 Gerrit-Change-Number: 59402 Gerrit-PatchSet: 25 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 16 May 2022 22:08:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, Joursoir. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 2 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Joursoir <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 16 May 2022 18:01:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Joursoir (Code Review) 16 May '22

16 May '22

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Joursoir has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... Patch Set 2: (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/64351/comment/ad55b1dc_59caca17 PS1, Line 1103: if (set_wp_region && wp_region) > Given that `wp_region` is explicitly first-time initialised to NULL (in the same line as the declara […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 2 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 16 May 2022 17:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Joursoir <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add W25Q512NW-IM ID to flashrom
by Nikolai Artemiev (Code Review) 16 May '22

16 May '22

Attention is currently required from: Vadim Bendebury. Hello Vadim Bendebury, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/64405 to review the following change. Change subject: Add W25Q512NW-IM ID to flashrom ...................................................................... Add W25Q512NW-IM ID to flashrom Add Winbond W25Q512NW-IM chip ID and specs to flashrom. BUG=b:200173901 BRANCH=none TEST=flash W25Q512NW-IM using CCD. Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Signed-off-by: Atul Dhudase <adhudase(a)codeaurora.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… Reviewed-by: Shelley Chen <shchen(a)chromium.org> Reviewed-by: Vadim Bendebury <vbendeb(a)chromium.org> Tested-by: Shelley Chen <shchen(a)chromium.org> Commit-Queue: Shelley Chen <shchen(a)chromium.org> (cherry picked from commit facb282e8939b8e4ad15d2478ed9ef86d98aed61) Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M flashchips.c M include/flashchips.h 2 files changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/64405/1 diff --git a/flashchips.c b/flashchips.c index d155b24..7e37980 100644 --- a/flashchips.c +++ b/flashchips.c @@ -17962,6 +17962,49 @@ .voltage = {2700, 3600}, }, + { + .vendor = "Winbond", + .name = "W25Q512NW-IM", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q512NW_IM, + .total_size = 64 * 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = spi_block_erase_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = spi_block_erase_dc, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + { .vendor = "Winbond", .name = "W25Q64BV/W25Q64CV/W25Q64FV", diff --git a/include/flashchips.h b/include/flashchips.h index ba97719..999139e 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -983,6 +983,7 @@ #define WINBOND_NEX_W25Q64JW_M 0x8017 /* W25Q64JW...M */ #define WINBOND_NEX_W25Q128_DTR 0x8018 /* W25Q128JW_DTR */ #define WINBOND_NEX_W25Q256_DTR 0x8019 /* W25Q256JW_DTR aka W25Q256256JW-IM */ +#define WINBOND_NEX_W25Q512NW_IM 0x8020 /* W25Q512NW-IM */ #define WINBOND_ID 0xDA /* Winbond */ #define WINBOND_W19B160BB 0x49 -- To view, visit https://review.coreboot.org/c/flashrom/+/64405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Gerrit-Change-Number: 64405 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Joursoir (Code Review) 16 May '22

16 May '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Nikolai Artemiev, Joursoir. Hello build bot (Jenkins), Thomas Heijligen, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64351 to look at the new patch set (#2). Change subject: cli_classic: fix memory leak ...................................................................... cli_classic: fix memory leak If parameter --wp-region is used and wp_region is allocated, free the last one at the exit of the application. Found-by: scan-build, clang v13.0.1 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe --- M cli_classic.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/64351/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 2 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Joursoir <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: use objects form libflashrom
by Arthur Heymans (Code Review) 16 May '22

16 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use objects form libflashrom ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 16:07:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: add "stdlib.h" to the default includes
by Arthur Heymans (Code Review) 16 May '22

16 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64385 ) Change subject: tests: add "stdlib.h" to the default includes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43fb02b2cff29d964e92556ad656cdda74a45ef2 Gerrit-Change-Number: 64385 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 16:06:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use files() for srcs list
by Arthur Heymans (Code Review) 16 May '22

16 May '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64384 ) Change subject: meson: use files() for srcs list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c Gerrit-Change-Number: 64384 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 16:05:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][OTP] spi: add functions for OTP regions
by Sergii Dmytruk (Code Review) 16 May '22

16 May '22

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59402 ) Change subject: [RFC][OTP] spi: add functions for OTP regions ...................................................................... Patch Set 25: (1 comment) Patchset: PS25: > Sergii, sorry for long waiting, but seems like we finally get to your OTP feature patches! […] There are conflicts with master, so some rebasing is needed. However, WP turned out to be enough for our project and we do not need OTP anymore. As a result, this code wasn't tested on hardware (but there are unit tests using dummyflasher). If that's OK and there is interest in these changes (someone will actually use them, maybe test), we can continue. Otherwise, this should probably be abandoned for now. -- To view, visit https://review.coreboot.org/c/flashrom/+/59402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic33e2c1de8b0ca02df9118218a663ce63826f339 Gerrit-Change-Number: 59402 Gerrit-PatchSet: 25 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 16 May 2022 15:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022