May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ft2232_spi.c: Add support for kt-link jtag interface
by Jacek Naglak (Code Review) 18 May '22

18 May '22

Attention is currently required from: Jacek Naglak. Hello Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64440 to look at the new patch set (#2). Change subject: ft2232_spi.c: Add support for kt-link jtag interface ...................................................................... ft2232_spi.c: Add support for kt-link jtag interface Change tested writing, reading and erasing spi flashes pinout: jtag - spi 1 vcc - vcc, wp#, hold# 4 gnd - gnd 5 tdi - si 7 tms - cs# 9 tck - sck 13 tdo - so Connect pins 9 and 12 in EXT connector for 3.3V power. Signed-off-by: Jacek Naglak <jnaglak(a)tlen.pl> Change-Id: Id58c675bc410ec3ef6d58603d13efc9ca53bb87c --- M ft2232_spi.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/64440/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id58c675bc410ec3ef6d58603d13efc9ca53bb87c Gerrit-Change-Number: 64440 Gerrit-PatchSet: 2 Gerrit-Owner: Jacek Naglak <jnaglak(a)tlen.pl> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jacek Naglak <jnaglak(a)tlen.pl> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests/chip_wp.c: Allow for logging during tests
by Edward O'Callaghan (Code Review) 18 May '22

18 May '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64442 ) Change subject: tests/chip_wp.c: Allow for logging during tests ...................................................................... tests/chip_wp.c: Allow for logging during tests Change-Id: I21160f3c0e9ca0c45bf23af9809dd8cf7af5beac Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/chip_wp.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/64442/1 diff --git a/tests/chip_wp.c b/tests/chip_wp.c index 8b209bd..b0ff872 100644 --- a/tests/chip_wp.c +++ b/tests/chip_wp.c @@ -31,6 +31,17 @@ #define LAYOUT_TAIL_REGION_START 0x1000 +static int flashrom_print_cb_tests(enum flashrom_log_level level, const char *fmt, va_list ap) +{ + int ret = 0; + FILE *output_type = stderr; + + ret = vfprintf(output_type, fmt, ap); + fflush(output_type); + + return ret; +} + static void setup_chip(struct flashrom_flashctx *flash, struct flashrom_layout **layout, struct flashchip *chip, const char *programmer_param) { @@ -48,6 +59,7 @@ } assert_int_equal(0, programmer_init(&programmer_dummy, programmer_param)); + flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb_tests); /* Assignment below normally happens while probing, but this test is not probing. */ flash->mst = &registered_masters[0]; } -- To view, visit https://review.coreboot.org/c/flashrom/+/64442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I21160f3c0e9ca0c45bf23af9809dd8cf7af5beac Gerrit-Change-Number: 64442 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: libflashrom: Return progress state to the library user
by Anastasia Klimchuk (Code Review) 18 May '22

18 May '22

Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Patrick Rudolph. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 ) Change subject: libflashrom: Return progress state to the library user ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c Gerrit-Change-Number: 49643 Gerrit-PatchSet: 19 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <hughsient(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 18 May 2022 02:39:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi.c: Add support for kt-link jtag interface
by Felix Singer (Code Review) 18 May '22

18 May '22

Attention is currently required from: Jacek Naglak. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64440 ) Change subject: ft2232_spi.c: Add support for kt-link jtag interface ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/64440/comment/475f1b1e_131eb09a PS1, Line 80: {FTDI_VID, KT_LINK_PID, OK, "Kristech", "KT-LINK"}, Move this line to the other FTDIs https://review.coreboot.org/c/flashrom/+/64440/comment/6cf84cc1_5a1715e1 PS1, Line 671: remove space https://review.coreboot.org/c/flashrom/+/64440/comment/525e0443_a0a89a1e PS1, Line 684: remove space -- To view, visit https://review.coreboot.org/c/flashrom/+/64440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id58c675bc410ec3ef6d58603d13efc9ca53bb87c Gerrit-Change-Number: 64440 Gerrit-PatchSet: 1 Gerrit-Owner: Jacek Naglak <jnaglak(a)tlen.pl> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jacek Naglak <jnaglak(a)tlen.pl> Gerrit-Comment-Date: Wed, 18 May 2022 01:38:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi.c: Add support for kt-link jtag interface
by Jacek Naglak (Code Review) 18 May '22

18 May '22

Jacek Naglak has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64440 ) Change subject: ft2232_spi.c: Add support for kt-link jtag interface ...................................................................... ft2232_spi.c: Add support for kt-link jtag interface Change tested writing, reading and erasing spi flashes pinout: jtag - spi 1 vcc - vcc, wp#, hold# 4 gnd - gnd 5 tdi - si 7 tms - cs# 9 tck - sck 13 tdo - so Connect pins 9 and 12 in EXT connector for 3.3V power. Signed-off-by: Jacek Naglak <jnaglak(a)tlen.pl> Change-Id: Id58c675bc410ec3ef6d58603d13efc9ca53bb87c --- M ft2232_spi.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/64440/1 diff --git a/ft2232_spi.c b/ft2232_spi.c index bafed40..072eb38 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -58,6 +58,8 @@ #define GOOGLE_SERVO_V2_PID0 0x5002 #define GOOGLE_SERVO_V2_PID1 0x5003 +#define KT_LINK_PID 0xbbe2 + static const struct dev_entry devs_ft2232spi[] = { {FTDI_VID, FTDI_FT2232H_PID, OK, "FTDI", "FT2232H"}, {FTDI_VID, FTDI_FT4232H_PID, OK, "FTDI", "FT4232H"}, @@ -75,6 +77,7 @@ {OLIMEX_VID, OLIMEX_ARM_TINY_PID, OK, "Olimex", "ARM-USB-TINY"}, {OLIMEX_VID, OLIMEX_ARM_OCD_H_PID, OK, "Olimex", "ARM-USB-OCD-H"}, {OLIMEX_VID, OLIMEX_ARM_TINY_H_PID, OK, "Olimex", "ARM-USB-TINY-H"}, + {FTDI_VID, KT_LINK_PID, OK, "Kristech", "KT-LINK"}, {0}, }; @@ -420,6 +423,13 @@ /* Flyswatter and Flyswatter-2 require GPIO bits 0x80 * and 0x40 to be driven low to enable output buffers */ pindir = 0xcb; + } else if (!strcasecmp(arg, "kt-link")) { + ft2232_type = KT_LINK_PID; + /* port B is used as uart */ + channel_count = 1; + /* Set GPIOL1 output high - enable TMS */ + aux_bits = 0x20; + pindir = 0x2b; } else { msg_perr("Error: Invalid device type specified.\n"); free(arg); @@ -658,6 +668,21 @@ goto ftdi_err; } + if ( ft2232_type == KT_LINK_PID) { + /* Enable kt-link jtag interface + * Set GPIOH4 output low - enable TMS + * Set GPIOH5 output low - enable TDI + * Set GPIOH6 output low - enable TCK */ + msg_pdbg("Set data bits HighByte\n"); + buf[0] = SET_BITS_HIGH; + buf[1] = 0x00; + buf[2] = 0x70; + if (send_buf(&ftdic, buf, 3)) { + ret = -8; + goto ftdi_err; + } + } + spi_data = calloc(1, sizeof(*spi_data)); if (!spi_data) { msg_perr("Unable to allocate space for SPI master data\n"); -- To view, visit https://review.coreboot.org/c/flashrom/+/64440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id58c675bc410ec3ef6d58603d13efc9ca53bb87c Gerrit-Change-Number: 64440 Gerrit-PatchSet: 1 Gerrit-Owner: Jacek Naglak <jnaglak(a)tlen.pl> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Anastasia Klimchuk (Code Review) 17 May '22

17 May '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... cli_classic: fix memory leak If parameter --wp-region is used and wp_region is allocated, free the last one at the exit of the application. Found-by: scan-build, clang v13.0.1 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Reviewed-on: https://review.coreboot.org/c/flashrom/+/64351 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Nikolai Artemiev <nartemiev(a)google.com> --- M cli_classic.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Nikolai Artemiev: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved diff --git a/cli_classic.c b/cli_classic.c index 9543009..83ac538 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -1100,6 +1100,7 @@ free(referencefile); free(layoutfile); free(pparam); + free(wp_region); /* clean up global variables */ free((char *)chip_to_probe); /* Silence! Freeing is not modifying contents. */ chip_to_probe = NULL; -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 3 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashchips.c: Fix 4BA for S25FL512S
by Thomas Heijligen (Code Review) 17 May '22

17 May '22

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64425 ) Change subject: flashchips.c: Fix 4BA for S25FL512S ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/64425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08c5a70351d945130183fe01c328dc4d30cfe0ef Gerrit-Change-Number: 64425 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 17 May 2022 17:36:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Drop incorrect `FEATURE_4BA_ENTER_EAR7` uses
by Thomas Heijligen (Code Review) 17 May '22

17 May '22

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64424 ) Change subject: flashchips.c: Drop incorrect `FEATURE_4BA_ENTER_EAR7` uses ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/64424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5510bab25dbb04c12ef8d6bd3fcb6faa51d6a1e8 Gerrit-Change-Number: 64424 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 17 May 2022 17:35:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][OTP] spi: add functions for OTP regions
by Sergii Dmytruk (Code Review) 17 May '22

17 May '22

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59402 ) Change subject: [RFC][OTP] spi: add functions for OTP regions ...................................................................... Patch Set 25: (1 comment) Patchset: PS25: > That's awesome to hear that WP works for you! @Nikolai read this :) […] Mailing list thread for convenience: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic33e2c1de8b0ca02df9118218a663ce63826f339 Gerrit-Change-Number: 59402 Gerrit-PatchSet: 25 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 17 May 2022 14:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Fix 4BA for S25FL512S
by Angel Pons (Code Review) 17 May '22

17 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello Nico Huber, Thomas Heijligen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/64425 to review the following change. Change subject: flashchips.c: Fix 4BA for S25FL512S ...................................................................... flashchips.c: Fix 4BA for S25FL512S Supporting 4BA read/write instructions without supporting any features to actually use 4BA mode makes no sense. As per the S25FL512 datasheet, `FEATURE_4BA_ENTER_EAR7` and `FEATURE_4BA_EXT_ADDR` are also supported, so select them through `FEATURE_4BA_EAR7`. As it is not known how this chip definition could actually work, it has been marked as untested. Change-Id: I08c5a70351d945130183fe01c328dc4d30cfe0ef Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/64425/1 diff --git a/flashchips.c b/flashchips.c index dfa717b..3e00a87 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16720,8 +16720,8 @@ .total_size = 65536, /* 512 Mb (=> 64 MB)) */ .page_size = 256, /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_NATIVE, - .tested = TEST_OK_PREW, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_EAR7, + .tested = TEST_UNTESTED, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/64425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08c5a70351d945130183fe01c328dc4d30cfe0ef Gerrit-Change-Number: 64425 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022