May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips.c: Drop incorrect `FEATURE_4BA_ENTER_EAR7` uses
by Angel Pons (Code Review) 17 May '22

17 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello Nico Huber, Thomas Heijligen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/64424 to review the following change. Change subject: flashchips.c: Drop incorrect `FEATURE_4BA_ENTER_EAR7` uses ...................................................................... flashchips.c: Drop incorrect `FEATURE_4BA_ENTER_EAR7` uses Using `FEATURE_4BA_ENTER_EAR7` along with `FEATURE_4BA` does not make sense, as `FEATURE_4BA` implies `FEATURE_4BA_ENTER` and the `spi25.c` function `spi_enter_exit_4ba()` only handles `FEATURE_4BA_ENTER_EAR7` if `FEATURE_4BA_ENTER` is not set. Besides, the datasheet for the two affected chips says the following: Note: The EN4B instruction will set the Bit 7 (EXTADD) of the volatile Bank Address Register to "1", but will not change the non-volatile Bank Address Register. This means the chip itself will set the bit that flashrom would set to enable 4BA mode when `FEATURE_4BA_ENTER_EAR7` is effective. This seems to be some sort of backwards compatibility behavior with software that uses the EXTADD bit to know whether the flash chip is in 4BA mode. Change-Id: I5510bab25dbb04c12ef8d6bd3fcb6faa51d6a1e8 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/64424/1 diff --git a/flashchips.c b/flashchips.c index d155b24..dfa717b 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7470,7 +7470,7 @@ /* supports SFDP */ /* OTP: 1024B total; read 0x68; write 0x62, erase 0x64, read ID 0x4B */ /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_EAR7, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, @@ -7646,7 +7646,7 @@ /* supports SFDP */ /* OTP: 1024B total; read 0x68; write 0x62, erase 0x64, read ID 0x4B */ /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_EAR7, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, -- To view, visit https://review.coreboot.org/c/flashrom/+/64424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5510bab25dbb04c12ef8d6bd3fcb6faa51d6a1e8 Gerrit-Change-Number: 64424 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson: use files() for srcs list
by Angel Pons (Code Review) 17 May '22

17 May '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64384 ) Change subject: meson: use files() for srcs list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c Gerrit-Change-Number: 64384 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 17 May 2022 10:20:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add W25Q512NW-IM ID to flashrom
by Angel Pons (Code Review) 17 May '22

17 May '22

Attention is currently required from: Vadim Bendebury, Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64405 ) Change subject: Add W25Q512NW-IM ID to flashrom ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/64405/comment/65f15679_2e806b68 PS1, Line 15: C > Original- Hmmm, so this and CL:3171890 have the same Change-Id, although they're on different Gerrit instances. This means we need to keep this Change-Id line as-is, and add the one for Original-Change-Id: Original-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Original-Signed-off-by: Atul Dhudase <adhudase(a)codeaurora.org> Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… Original-Reviewed-by: Shelley Chen <shchen(a)chromium.org> Original-Reviewed-by: Vadim Bendebury <vbendeb(a)chromium.org> Original-Tested-by: Shelley Chen <shchen(a)chromium.org> Original-Commit-Queue: Shelley Chen <shchen(a)chromium.org> (cherry picked from commit facb282e8939b8e4ad15d2478ed9ef86d98aed61) Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> File flashchips.c: https://review.coreboot.org/c/flashrom/+/64405/comment/ada4e639_51c00f63 PS1, Line 17973: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, The 4BA stuff looks suspicious... `FEATURE_4BA` implies `FEATURE_4BA_ENTER` which is mutually exclusive with `FEATUER_4BA_ENTER_WREN` (c.f. spi25.c function `spi_enter_exit_4ba()`). If I am looking at the right datasheet, it doesn't mention anything about WREN being needed before entering 4BA mode: https://imgur.com/6RVc3w4.png Also, `FEATURE_4BA` implies `FEATURE_4BA_READ` and `FEATURE_4BA_FAST_READ`, so there's no need to explicitly mention them again. TL;DR: Please simplify feature_bits to: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, https://review.coreboot.org/c/flashrom/+/64405/comment/a0d6afa5_a415b6f8 PS1, Line 17965: { : .vendor = "Winbond", : .name = "W25Q512NW-IM", : .bustype = BUS_SPI, : .manufacture_id = WINBOND_NEX_ID, : .model_id = WINBOND_NEX_W25Q512NW_IM, : .total_size = 64 * 1024, : .page_size = 256, : .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, : .tested = TEST_OK_PREW, : .probe = probe_spi_rdid, : .probe_timing = TIMING_ZERO, : .block_erasers = : { : { : .eraseblocks = { {4 * 1024, 16384} }, : .block_erase = spi_block_erase_21, : }, { : .eraseblocks = { {4 * 1024, 16384} }, : .block_erase = spi_block_erase_20, : }, { : .eraseblocks = { {32 * 1024, 2048} }, : .block_erase = spi_block_erase_52, : }, { : .eraseblocks = { {64 * 1024, 1024} }, : .block_erase = spi_block_erase_dc, : }, { : .eraseblocks = { {64 * 1024, 1024} }, : .block_erase = spi_block_erase_d8, : }, { : .eraseblocks = { {64 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_60, : }, { : .eraseblocks = { {64 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_c7, : } : }, : .unlock = spi_disable_blockprotect, : .write = spi_chip_write_256, : .read = spi_chip_read, : .voltage = {1650, 1950}, : }, Please indent with tabs -- To view, visit https://review.coreboot.org/c/flashrom/+/64405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Gerrit-Change-Number: 64405 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 17 May 2022 09:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add W25Q512NW-IM ID to flashrom
by Thomas Heijligen (Code Review) 17 May '22

17 May '22

Attention is currently required from: Vadim Bendebury, Angel Pons, Nikolai Artemiev. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64405 ) Change subject: Add W25Q512NW-IM ID to flashrom ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/64405/comment/77b26b18_5a50d549 PS1, Line 7: Add W25Q512NW-IM ID to flashrom nit: `flashchips: Add W25Q512NW-IM` -- To view, visit https://review.coreboot.org/c/flashrom/+/64405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Gerrit-Change-Number: 64405 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 17 May 2022 08:24:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add W25Q512NW-IM ID to flashrom
by Edward O'Callaghan (Code Review) 17 May '22

17 May '22

Attention is currently required from: Vadim Bendebury, Angel Pons, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64405 ) Change subject: Add W25Q512NW-IM ID to flashrom ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/64405/comment/a2ebecd2_b078c987 PS1, Line 15: C Original- -- To view, visit https://review.coreboot.org/c/flashrom/+/64405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Gerrit-Change-Number: 64405 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 17 May 2022 04:54:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: wrap chip->write() with a helper
by Edward O'Callaghan (Code Review) 17 May '22

17 May '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64374 ) Change subject: flashrom.c: wrap chip->write() with a helper ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I agree 100% I forgot to add WIP/Private label to this with the other ones on top. Sorry for the noise. -- To view, visit https://review.coreboot.org/c/flashrom/+/64374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I46490eba664f96df37310972141ee5db13e48877 Gerrit-Change-Number: 64374 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 17 May 2022 02:22:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: include/flash.h: Drop dead struct members
by Edward O'Callaghan (Code Review) 17 May '22

17 May '22

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/64373 ) Change subject: include/flash.h: Drop dead struct members ...................................................................... include/flash.h: Drop dead struct members These were part of the original wp implementation, now dead code left over. Change-Id: I43b25175c6ff833b822a93c4e752a28cf97d64b8 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/64373 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M include/flash.h 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/include/flash.h b/include/flash.h index 89d5737..27ade09 100644 --- a/include/flash.h +++ b/include/flash.h @@ -266,8 +266,6 @@ int (*unlock) (struct flashctx *flash); int (*write) (struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int (*read) (struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); - uint8_t (*read_status) (const struct flashctx *flash); - int (*write_status) (const struct flashctx *flash, int status); struct voltage { uint16_t min; uint16_t max; -- To view, visit https://review.coreboot.org/c/flashrom/+/64373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43b25175c6ff833b822a93c4e752a28cf97d64b8 Gerrit-Change-Number: 64373 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashrom.c: Make need_erase() helper static local
by Edward O'Callaghan (Code Review) 17 May '22

17 May '22

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/64369 ) Change subject: flashrom.c: Make need_erase() helper static local ...................................................................... flashrom.c: Make need_erase() helper static local The need_erase() helper is only used within flashrom.c Change-Id: Ic0946bb109fca2fc18e15eefa11cccea284ded0b Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/64369 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashrom.c M include/flash.h 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/flashrom.c b/flashrom.c index e8ed87e..7f54488 100644 --- a/flashrom.c +++ b/flashrom.c @@ -480,7 +480,7 @@ * @gran write granularity (enum, not count) * @return 0 if no erase is needed, 1 otherwise */ -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, +static int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value) { int result = 0; diff --git a/include/flash.h b/include/flash.h index 5170ba7..89d5737 100644 --- a/include/flash.h +++ b/include/flash.h @@ -411,7 +411,6 @@ int erase_flash(struct flashctx *flash); int probe_flash(struct registered_master *mst, int startchip, struct flashctx *fill_flash, int force); int verify_range(struct flashctx *flash, const uint8_t *cmpbuf, unsigned int start, unsigned int len); -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value); void emergency_help_message(void); void print_version(void); void print_buildinfo(void); -- To view, visit https://review.coreboot.org/c/flashrom/+/64369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic0946bb109fca2fc18e15eefa11cccea284ded0b Gerrit-Change-Number: 64369 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: libflashrom: Return progress state to the library user
by Edward O'Callaghan (Code Review) 17 May '22

17 May '22

Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Anastasia Klimchuk, Patrick Rudolph. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 ) Change subject: libflashrom: Return progress state to the library user ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c Gerrit-Change-Number: 49643 Gerrit-PatchSet: 19 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <hughsient(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 17 May 2022 00:29:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Nikolai Artemiev (Code Review) 16 May '22

16 May '22

Attention is currently required from: Angel Pons, Joursoir. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Thanks for catching this! -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 2 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Joursoir <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 16 May 2022 22:58:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022