May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson: use objects form libflashrom
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use objects form libflashrom ...................................................................... Patch Set 6: (1 comment) Patchset: PS2: > Using the srcs + https://mesonbuild.com/Reference-manual_returned_extracted_obj.html […] I've switched to this method to not depend on the static library for the tests. This is more future prove for tests -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 09:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use objects form libflashrom
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use objects form libflashrom ...................................................................... Patch Set 6: (1 comment) File tests/tests.c: https://review.coreboot.org/c/flashrom/+/64031/comment/04af3a7f_ec326c1e PS4, Line 23: #include <stdlib.h> > Can you split out the more trivial fix of this in tests so the patch is focused on the build system […] Done in CB:64385 -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 09:23:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: add "stdlib.h" to the default includes
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64385 ) Change subject: tests: add "stdlib.h" to the default includes ...................................................................... tests: add "stdlib.h" to the default includes Change-Id: I43fb02b2cff29d964e92556ad656cdda74a45ef2 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M tests/include/test.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/64385/1 diff --git a/tests/include/test.h b/tests/include/test.h index 88ac16d..28ac9f5 100644 --- a/tests/include/test.h +++ b/tests/include/test.h @@ -24,6 +24,7 @@ #include <stdarg.h> #include <stddef.h> +#include <stdlib.h> #include <setjmp.h> #include <cmocka.h> -- To view, visit https://review.coreboot.org/c/flashrom/+/64385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43fb02b2cff29d964e92556ad656cdda74a45ef2 Gerrit-Change-Number: 64385 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson: use files() for srcs list
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64384 ) Change subject: meson: use files() for srcs list ...................................................................... meson: use files() for srcs list Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 64 insertions(+), 61 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/64384/1 diff --git a/meson.build b/meson.build index cbce8c1..a8e5a7b 100644 --- a/meson.build +++ b/meson.build @@ -178,8 +178,7 @@ # some programmers require libusb if get_option('usb') - srcs += 'usbdev.c' - srcs += 'usb_device.c' + srcs += files('usbdev.c', 'usb_device.c') deps += dependency('libusb-1.0') elif need_libusb1 error('usb is disabled but one or more enabled programmer requires USB access') @@ -187,7 +186,7 @@ # some programmers require libpci if get_option('pciutils') - srcs += 'pcidev.c' + srcs += files('pcidev.c') deps += dependency('libpci') elif need_libpci error('pciutils is disabled but one or more enabled programmer requires PCI access') @@ -203,77 +202,81 @@ # set defines for configured programmers if config_atahpt - srcs += 'atahpt.c' + srcs += files('atahpt.c') cargs += '-DCONFIG_ATAHPT=1' endif if config_atapromise - srcs += 'atapromise.c' + srcs += files('atapromise.c') cargs += '-DCONFIG_ATAPROMISE=1' endif if config_atavia - srcs += 'atavia.c' + srcs += files('atavia.c') cargs += '-DCONFIG_ATAVIA=1' endif if config_buspirate_spi - srcs += 'buspirate_spi.c' + srcs += files('buspirate_spi.c') cargs += '-DCONFIG_BUSPIRATE_SPI=1' endif if config_ch341a_spi - srcs += 'ch341a_spi.c' + srcs += files('ch341a_spi.c') cargs += '-DCONFIG_CH341A_SPI=1' endif if config_dediprog - srcs += 'dediprog.c' + srcs += files('dediprog.c') cargs += '-DCONFIG_DEDIPROG=1' endif if config_developerbox_spi - srcs += 'developerbox_spi.c' + srcs += files('developerbox_spi.c') cargs += '-DCONFIG_DEVELOPERBOX_SPI=1' endif if config_digilent_spi - srcs += 'digilent_spi.c' + srcs += files('digilent_spi.c') cargs += '-DCONFIG_DIGILENT_SPI=1' endif if config_jlink_spi - srcs += 'jlink_spi.c' + srcs += files('jlink_spi.c') cargs += '-DCONFIG_JLINK_SPI=1' endif if config_drkaiser - srcs += 'drkaiser.c' + srcs += files('drkaiser.c') cargs += '-DCONFIG_DRKAISER=1' endif if config_dummy - srcs += 'dummyflasher.c' + srcs += files('dummyflasher.c') cargs += '-DCONFIG_DUMMY=1' endif if config_ft2232_spi - srcs += 'ft2232_spi.c' + srcs += files('ft2232_spi.c') cargs += '-DCONFIG_FT2232_SPI=1' cargs += '-DHAVE_FT232H=1' endif if config_gfxnvidia - srcs += 'gfxnvidia.c' + srcs += files('gfxnvidia.c') cargs += '-DCONFIG_GFXNVIDIA=1' endif if config_raiden_debug_spi - srcs += 'raiden_debug_spi.c' + srcs += files('raiden_debug_spi.c') cargs += '-DCONFIG_RAIDEN_DEBUG_SPI=1' endif if config_internal - srcs += 'board_enable.c' - srcs += 'cbtable.c' - srcs += 'chipset_enable.c' - srcs += 'internal.c' - srcs += 'processor_enable.c' + srcs += files( + 'board_enable.c', + 'cbtable.c', + 'chipset_enable.c', + 'internal.c', + 'processor_enable.c', + ) if host_is_x86 - srcs += 'amd_imc.c' - srcs += 'dmi.c' - srcs += 'ichspi.c' - srcs += 'it85spi.c' - srcs += 'it87spi.c' - srcs += 'mcp6x_spi.c' - srcs += 'sb600spi.c' - srcs += 'wbsio_spi.c' + srcs += files( + 'amd_imc.c', + 'dmi.c', + 'ichspi.c', + 'it85spi.c', + 'it87spi.c', + 'mcp6x_spi.c', + 'sb600spi.c', + 'wbsio_spi.c', + ) endif cargs += '-DCONFIG_INTERNAL=1' if get_option('config_internal_dmi') @@ -282,129 +285,129 @@ endif endif if config_it8212 - srcs += 'it8212.c' + srcs += files('it8212.c') cargs += '-DCONFIG_IT8212=1' endif if config_linux_mtd - srcs += 'linux_mtd.c' + srcs += files('linux_mtd.c') cargs += '-DCONFIG_LINUX_MTD=1' endif if config_linux_spi - srcs += 'linux_spi.c' + srcs += files('linux_spi.c') cargs += '-DCONFIG_LINUX_SPI=1' endif if config_mstarddc_spi - srcs += 'mstarddc_spi.c' + srcs += files('mstarddc_spi.c') cargs += '-DCONFIG_MSTARDDC_SPI=1' endif if config_nic3com - srcs += 'nic3com.c' + srcs += files('nic3com.c') cargs += '-DCONFIG_NIC3COM=1' endif if config_nicintel - srcs += 'nicintel.c' + srcs += files('nicintel.c') cargs += '-DCONFIG_NICINTEL=1' endif if config_nicintel_eeprom - srcs += 'nicintel_eeprom.c' + srcs += files('nicintel_eeprom.c') cargs += '-DCONFIG_NICINTEL_EEPROM=1' endif if config_nicintel_spi - srcs += 'nicintel_spi.c' + srcs += files('nicintel_spi.c') cargs += '-DCONFIG_NICINTEL_SPI=1' endif if config_nicnatsemi - srcs += 'nicnatsemi.c' + srcs += files('nicnatsemi.c') cargs += '-DCONFIG_NICNATSEMI=1' endif if config_nicrealtek - srcs += 'nicrealtek.c' + srcs += files('nicrealtek.c') cargs += '-DCONFIG_NICREALTEK=1' endif if config_ogp_spi - srcs += 'ogp_spi.c' + srcs += files('ogp_spi.c') cargs += '-DCONFIG_OGP_SPI=1' endif if config_pickit2_spi - srcs += 'pickit2_spi.c' + srcs += files('pickit2_spi.c') cargs += '-DCONFIG_PICKIT2_SPI=1' endif if config_pony_spi - srcs += 'pony_spi.c' + srcs += files('pony_spi.c') cargs += '-DCONFIG_PONY_SPI=1' endif if config_rayer_spi - srcs += 'rayer_spi.c' + srcs += files('rayer_spi.c') cargs += '-DCONFIG_RAYER_SPI=1' endif if config_satamv - srcs += 'satamv.c' + srcs += files('satamv.c') cargs += '-DCONFIG_SATAMV=1' endif if config_satasii - srcs += 'satasii.c' + srcs += files('satasii.c') cargs += '-DCONFIG_SATASII=1' endif if config_serprog - srcs += 'serprog.c' + srcs += files('serprog.c') cargs += '-DCONFIG_SERPROG=1' endif if config_usbblaster_spi - srcs += 'usbblaster_spi.c' + srcs += files('usbblaster_spi.c') cargs += '-DCONFIG_USBBLASTER_SPI=1' endif if config_stlinkv3_spi - srcs += 'stlinkv3_spi.c' + srcs += files('stlinkv3_spi.c') cargs += '-DCONFIG_STLINKV3_SPI=1' endif if config_lspcon_i2c_spi - srcs += 'lspcon_i2c_spi.c' + srcs += files('lspcon_i2c_spi.c') cargs += '-DCONFIG_LSPCON_I2C_SPI=1' endif if config_mediatek_i2c_spi - srcs += 'mediatek_i2c_spi.c' + srcs += files('mediatek_i2c_spi.c') cargs += '-DCONFIG_MEDIATEK_I2C_SPI=1' endif if config_realtek_mst_i2c_spi - srcs += 'realtek_mst_i2c_spi.c' + srcs += files('realtek_mst_i2c_spi.c') cargs += '-DCONFIG_REALTEK_MST_I2C_SPI=1' endif # bitbanging SPI infrastructure if need_bitbang_spi - srcs += 'bitbang_spi.c' + srcs += files('bitbang_spi.c') cargs += '-DCONFIG_BITBANG_SPI=1' endif if host_machine.system() == 'linux' - srcs += 'i2c_helper_linux.c' + srcs += files('i2c_helper_linux.c') endif if need_raw_mem_access - srcs += 'hwaccess_physmap.c' + srcs += files('hwaccess_physmap.c') endif if need_x86_port_io - srcs += 'hwaccess_x86_io.c' + srcs += files('hwaccess_x86_io.c') cargs += '-D__FLASHROM_HAVE_OUTB__=1' endif if need_x86_msr - srcs += 'hwaccess_x86_msr.c' + srcs += files('hwaccess_x86_msr.c') endif # raw serial IO if need_serial - srcs += 'serial.c' + srcs += files('serial.c') if host_machine.system() == 'linux' - srcs += 'custom_baud_linux.c' + srcs += files('custom_baud_linux.c') else - srcs += 'custom_baud.c' + srcs += files('custom_baud.c') endif endif if config_print_wiki - srcs += 'print_wiki.c' + srcs += files('print_wiki.c') cargs += '-DCONFIG_PRINT_WIKI=1' endif -- To view, visit https://review.coreboot.org/c/flashrom/+/64384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c Gerrit-Change-Number: 64384 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63724 to look at the new patch set (#19). Change subject: [WIP] meson: rework the programmer selection ...................................................................... [WIP] meson: rework the programmer selection This is a WIP implementation for a new programmer selection. It should work by now but has some known and unknown bugs. (see Gerrit Comments) - Each dependency is optional and gets mandatory when the programmer is selected as active. - Each programmer is defined through an entry in the programmer dictionary - The entry lists systems & cpu_families where the programmer is supported; Dependencies, sources and flags. The group parameter is for selecting a set of programmer, the default parameter is to include the programmer to the `all` and `auto` set. - If the programmer gets selected the `active` entry is set to true. The `active` entry can be used afterwards to determine if the programmer should be included in sources, config, documentation - Needed system headers are represended through a pseudo dependency. - The programmer's `srcs` attribute contains all files which are needed to build the programmer. Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M meson_options.txt M tests/meson.build 3 files changed, 413 insertions(+), 345 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/63724/19 -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 19 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Nico Huber, Namyoon Woo, Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Namyoon Woo, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63831 to look at the new patch set (#10). Change subject: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c ...................................................................... [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c This makes flashrom buildable without the dummy programmer. It does NOT fix the underlaying bug. * BUG: https://ticket.coreboot.org/issues/365 * COMMIT: https://review.coreboot.org/c/flashrom/+/44879 * COMMIT: https://review.coreboot.org/c/flashrom/+/46536 Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M dummyflasher.c M include/chipdrivers.h A include/you_need_to_fix_me.h M meson.build A you_need_to_fix_me.c 6 files changed, 124 insertions(+), 91 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/63831/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/63831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e Gerrit-Change-Number: 63831 Gerrit-PatchSet: 10 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: use objects form libflashrom
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64031 to look at the new patch set (#6). Change subject: meson: use objects form libflashrom ...................................................................... meson: use objects form libflashrom We can reuse the compiled objects form libflashrom for the tests. Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M tests/meson.build 2 files changed, 32 insertions(+), 44 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/64031/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Joursoir. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Should I add this to the commit message, or is it just the message to anyone? It's just a message to help everyone finding the cause for this patch. File cli_classic.c: https://review.coreboot.org/c/flashrom/+/64351/comment/b5eb2628_1e574829 PS1, Line 1103: if (set_wp_region && wp_region) > Theoretically, yes. If pointer is a null-pointer, no action would occur. […] The standard says: `If ptr is a null pointer, no action occurs.` - C99 standard (ISO/IEC 9899:1999); 7.20.3.2 The free function But I'm not sure how we handle it here. -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 1 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Joursoir <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 16 May 2022 08:43:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Joursoir <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Joursoir (Code Review) 16 May '22

16 May '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Nikolai Artemiev. Joursoir has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: > Joursoir, so glad to see you here, thanks for the patch! I'm happy to help! PS1: > This memory leak was introduced with CB:58738 cli_classic. […] Should I add this to the commit message, or is it just the message to anyone? File cli_classic.c: https://review.coreboot.org/c/flashrom/+/64351/comment/7322ecb7_e6623264 PS1, Line 1103: if (set_wp_region && wp_region) > I am wondering whether this condition needed. Maybe we can just have one line […] Theoretically, yes. If pointer is a null-pointer, no action would occur. But I'm not sure if this behavior is part of C standard. It makes no sense to check if set_wp_region is set, so at least I'll change it to ``` if (wp_region) free(wp_region); ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 1 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 16 May 2022 08:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: wrap chip->write() with a helper
by Thomas Heijligen (Code Review) 16 May '22

16 May '22

Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64374 ) Change subject: flashrom.c: wrap chip->write() with a helper ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: With the current state of the patch I does not see any benefit. This may change with a follow up patch File flashrom.c: https://review.coreboot.org/c/flashrom/+/64374/comment/45178087_5a9e8236 PS1, Line 1050: * @flash flash chip We have different documentation styles in the code. @flash @param flash We should unify this. I think `@param ...` is the one Doxygen and other tools recognize. https://review.coreboot.org/c/flashrom/+/64374/comment/5e6ea690_1f953be4 PS1, Line 1054: * Document the return code https://review.coreboot.org/c/flashrom/+/64374/comment/420379cf_b4a47dbb PS1, Line 1055: * TODO: Look up regions that are write-protected and avoid attempt to write Resolve the TODO? Maybe publish a follow up for it. -- To view, visit https://review.coreboot.org/c/flashrom/+/64374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I46490eba664f96df37310972141ee5db13e48877 Gerrit-Change-Number: 64374 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 08:04:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022