May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ichspi: Refactor Flashrom HW Sequencing Operation
by Edward O'Callaghan (Code Review) 16 May '22

16 May '22

Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62869 ) Change subject: ichspi: Refactor Flashrom HW Sequencing Operation ...................................................................... Patch Set 15: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62869/comment/641d8595_baa0a5c1 PS15, Line 7: Refactor Flashrom HW Sequencing Operation How about 'ichspi: Factor out common hwseq_xfer logic into helpers' -- To view, visit https://review.coreboot.org/c/flashrom/+/62869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 Gerrit-Change-Number: 62869 Gerrit-PatchSet: 15 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 05:23:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Martin L Roth (Code Review) 16 May '22

16 May '22

Attention is currently required from: Felix Singer, Patrick Georgi, Stefan Reinauer, Angel Pons, Anastasia Klimchuk, Stefan T. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/64101/comment/5257103a_59bcea60 PS3, Line 7: Review access change > This is somewhat a vague description and because of that may look a bit scary :) […] That's just the default name given by gerrit when it creates this patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Mon, 16 May 2022 04:59:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Refactor Flashrom HW Sequencing Operation
by Edward O'Callaghan (Code Review) 16 May '22

16 May '22

Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62869 ) Change subject: ichspi: Refactor Flashrom HW Sequencing Operation ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 Gerrit-Change-Number: 62869 Gerrit-PatchSet: 14 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 May 2022 04:44:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Validate BUS before trying 4BA commands
by Edward O'Callaghan (Code Review) 16 May '22

16 May '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64371 ) Change subject: flashrom.c: Validate BUS before trying 4BA commands ...................................................................... flashrom.c: Validate BUS before trying 4BA commands 4BA is sort of broken for opaque masters. Instead of just leaning on the chip feature flag to determine when to enter_exit out of 4ba modes, validate '(flash->chip->bustype == BUS_SPI)'. The following chips; - GD25Q256D - MX25L25635F/MX25L25645G - W25Q256.V - W25Q256JV_M Have issue with opaque masters that tries incorrectly to issue 4BA commands which results in failure. Change-Id: Ie26732b03a67bfafc8eae1f642dc85c6d37f7772 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/64371/1 diff --git a/flashrom.c b/flashrom.c index 7f54488..356de79 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1845,7 +1845,8 @@ } /* Enable/disable 4-byte addressing mode if flash chip supports it */ - if (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_ENTER_EAR7)) { + if ((flash->chip->bustype == BUS_SPI) && + (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_ENTER_EAR7))) { int ret; if (spi_master_4ba(flash)) ret = spi_enter_4ba(flash); -- To view, visit https://review.coreboot.org/c/flashrom/+/64371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie26732b03a67bfafc8eae1f642dc85c6d37f7772 Gerrit-Change-Number: 64371 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashrom.c: Make need_erase() helper static local
by Edward O'Callaghan (Code Review) 16 May '22

16 May '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64369 ) Change subject: flashrom.c: Make need_erase() helper static local ...................................................................... flashrom.c: Make need_erase() helper static local The need_erase() helper is only used within flashrom.c Change-Id: Ic0946bb109fca2fc18e15eefa11cccea284ded0b Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/flash.h 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/64369/1 diff --git a/flashrom.c b/flashrom.c index e8ed87e..7f54488 100644 --- a/flashrom.c +++ b/flashrom.c @@ -480,7 +480,7 @@ * @gran write granularity (enum, not count) * @return 0 if no erase is needed, 1 otherwise */ -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, +static int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value) { int result = 0; diff --git a/include/flash.h b/include/flash.h index 5170ba7..89d5737 100644 --- a/include/flash.h +++ b/include/flash.h @@ -411,7 +411,6 @@ int erase_flash(struct flashctx *flash); int probe_flash(struct registered_master *mst, int startchip, struct flashctx *fill_flash, int force); int verify_range(struct flashctx *flash, const uint8_t *cmpbuf, unsigned int start, unsigned int len); -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value); void emergency_help_message(void); void print_version(void); void print_buildinfo(void); -- To view, visit https://review.coreboot.org/c/flashrom/+/64369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic0946bb109fca2fc18e15eefa11cccea284ded0b Gerrit-Change-Number: 64369 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [RFC][OTP] spi: add functions for OTP regions
by Anastasia Klimchuk (Code Review) 16 May '22

16 May '22

Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59402 ) Change subject: [RFC][OTP] spi: add functions for OTP regions ...................................................................... Patch Set 25: (1 comment) Patchset: PS25: Sergii, sorry for long waiting, but seems like we finally get to your OTP feature patches! Just checking, is this ready for review, or do you plan any changes/rebasing? -- To view, visit https://review.coreboot.org/c/flashrom/+/59402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic33e2c1de8b0ca02df9118218a663ce63826f339 Gerrit-Change-Number: 59402 Gerrit-PatchSet: 25 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 16 May 2022 00:29:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: fix memory leak
by Anastasia Klimchuk (Code Review) 15 May '22

15 May '22

Attention is currently required from: Nikolai Artemiev, Joursoir. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 ) Change subject: cli_classic: fix memory leak ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Joursoir, so glad to see you here, thanks for the patch! File cli_classic.c: https://review.coreboot.org/c/flashrom/+/64351/comment/8ebd0720_eee00a91 PS1, Line 1103: if (set_wp_region && wp_region) I am wondering whether this condition needed. Maybe we can just have one line free(wp_region); I remember some time ago Angel explained to me that it is legit to call `free(pointer)` even if the pointer is null. Angel, Nikolai, what do you think? -- To view, visit https://review.coreboot.org/c/flashrom/+/64351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe Gerrit-Change-Number: 64351 Gerrit-PatchSet: 1 Gerrit-Owner: Joursoir <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Joursoir <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 15 May 2022 23:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util/shell.nix: Add libjaylink
by Felix Singer (Code Review) 15 May '22

15 May '22

Attention is currently required from: Paul Menzel, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64352 ) Change subject: util/shell.nix: Add libjaylink ...................................................................... Patch Set 4: (2 comments) Commit Message: PS2: > Please mention older NixOS versions are eol. What have older NixOS versions to do with this here? Seems unrelated to me. https://review.coreboot.org/c/flashrom/+/64352/comment/17063b1f_c81cab9f PS2, Line 9: remove the comment and : include the package libjaylink > The hash in the beginning is easily overlooked, so maybe say “activate the line” or something simila […] I think using "include" is fine. -- To view, visit https://review.coreboot.org/c/flashrom/+/64352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I56e750831143a4e34be95ec111a37bb476abfe85 Gerrit-Change-Number: 64352 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 15 May 2022 14:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util/shell.nix: Add libjaylink
by Felix Singer (Code Review) 15 May '22

15 May '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Thomas Heijligen, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64352 to look at the new patch set (#4). Change subject: util/shell.nix: Add libjaylink ...................................................................... util/shell.nix: Add libjaylink libjaylink is packaged since NixOS 21.11 and it is out for many months now. Thus, include the package libjaylink and remove comments. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I56e750831143a4e34be95ec111a37bb476abfe85 --- M util/shell.nix 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/64352/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/64352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I56e750831143a4e34be95ec111a37bb476abfe85 Gerrit-Change-Number: 64352 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: util/shell.nix: Add libjaylink
by Felix Singer (Code Review) 15 May '22

15 May '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Thomas Heijligen, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64352 to look at the new patch set (#3). Change subject: util/shell.nix: Add libjaylink ...................................................................... util/shell.nix: Add libjaylink libjaylink is packaged since NixOS 21.11 and it is out for many months now. Thus, remove the comment and include the package libjaylink. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I56e750831143a4e34be95ec111a37bb476abfe85 --- M util/shell.nix 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/64352/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/64352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I56e750831143a4e34be95ec111a37bb476abfe85 Gerrit-Change-Number: 64352 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022