April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add f25l16pa
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63912 ) Change subject: flashchips: Add f25l16pa ...................................................................... flashchips: Add f25l16pa Change-Id: If80e2bdacc14e94cd70bb0f9dff5f38c9af62ef3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/63912/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..5f9ef4e 100644 --- a/flashchips.c +++ b/flashchips.c @@ -4433,6 +4433,40 @@ .read = spi_chip_read, .voltage = {2700, 3600}, }, + { + .vendor = "ESMT", + .name = "F25L16PA", + .bustype = BUS_SPI, + .manufacture_id = ESMT_ID, + .model_id = ESMT_F25L16PA, // 0x14 + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_EITHER, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_bpl, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, { .vendor = "Eon", diff --git a/flashchips.h b/flashchips.h index ba97719..14ff1b8 100644 --- a/flashchips.h +++ b/flashchips.h @@ -232,6 +232,7 @@ #define ESMT_F25L64QA 0x4117 #define ESMT_F25L128QA 0x4118 #define ESMT_F49B002UA 0x00 +#define ESMT_F25L16PA 0x2015 /* * EN25 chips are SPI, first byte of device ID is memory type, -- To view, visit https://review.coreboot.org/c/flashrom/+/63912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If80e2bdacc14e94cd70bb0f9dff5f38c9af62ef3 Gerrit-Change-Number: 63912 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: Add IS25WQ040
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: roman.stingler(a)gmail.com. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63910 ) Change subject: flashchips: Add IS25WQ040 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/204 -- To view, visit https://review.coreboot.org/c/flashrom/+/63910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6f188e006bda415221c571c6aa9cfece649e572f Gerrit-Change-Number: 63910 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-Comment-Date: Thu, 28 Apr 2022 05:35:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add IS25WQ040
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: roman.stingler(a)gmail.com. Hello roman.stingler(a)gmail.com, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/63910 to review the following change. Change subject: flashchips: Add IS25WQ040 ...................................................................... flashchips: Add IS25WQ040 Change-Id: I6f188e006bda415221c571c6aa9cfece649e572f Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/63910/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..ac1e986 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7687,6 +7687,48 @@ { .vendor = "ISSI", + .name = "IS25WQ040", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WQ040, + .total_size = 4096, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + /* QPI enable 0x35, disable 0xF5 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS29GL064B", .bustype = BUS_PARALLEL, .manufacture_id = ISSI_ID, diff --git a/flashchips.h b/flashchips.h index ba97719..cd1ae43 100644 --- a/flashchips.h +++ b/flashchips.h @@ -479,6 +479,7 @@ #define ISSI_IS25WP064 0x7017 #define ISSI_IS25WP128 0x7018 #define ISSI_IS25WP256 0x7019 +#define ISSI_IS25WQ040 0x1253 #define ISSI_PMC_IS29GL032B 0xF9 #define ISSI_PMC_IS29GL032T 0xF6 #define ISSI_PMC_IS29GL064B 0x7E1000 -- To view, visit https://review.coreboot.org/c/flashrom/+/63910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6f188e006bda415221c571c6aa9cfece649e572f Gerrit-Change-Number: 63910 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: util/ich_descriptors_tool: Remove unneeded meson dependencies
by Anastasia Klimchuk (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63757 ) Change subject: util/ich_descriptors_tool: Remove unneeded meson dependencies ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ice1437cb294729b6af0e24f0a02692459b7a1412 Gerrit-Change-Number: 63757 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 28 Apr 2022 05:20:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: Add support for Synopsis ARC64 architecture
by Thomas Heijligen (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63896 ) Change subject: platform.h: Add support for Synopsis ARC64 architecture ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63896/comment/a888a4e5_6ba53bbe PS1, Line 7: platform.h: Add support for Synopsis ARC64 architecture s/platformh/Makefile/ Patchset: PS1: I assume this macro is correct because an employee of synopsys hat add this. But I haven't found this macro in the GCC source code. Can you point me to a location where to find it? Or is it just in not yet in mainline gcc? We are switching to meson as primary build system. Is there support for ARC64? (crossposting github) -- To view, visit https://review.coreboot.org/c/flashrom/+/63896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8707394871994f600b345d76614c5689fd081db4 Gerrit-Change-Number: 63896 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 05:11:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for BrightMoon T25S40
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63909 ) Change subject: flashchips: Add support for BrightMoon T25S40 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/200 -- To view, visit https://review.coreboot.org/c/flashrom/+/63909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia47e015aca092c2886703fdce1ff793246e1fc24 Gerrit-Change-Number: 63909 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 05:10:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for BrightMoon T25S40
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63909 ) Change subject: flashchips: Add support for BrightMoon T25S40 ...................................................................... flashchips: Add support for BrightMoon T25S40 Change-Id: Ia47e015aca092c2886703fdce1ff793246e1fc24 Signed-off-by: René Treffer <treffer(a)measite.de> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/63909/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..8162db1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3594,6 +3594,44 @@ }, { + .vendor = "BrightMoon", + .name = "T25S40", + .bustype = BUS_SPI, + .manufacture_id = 0x5e, + .model_id = 0x2013, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 16} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp3_srwd, + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B), dual I/O read (0x3B) supported */ + .voltage = {2700, 3600}, + }, + + { .vendor = "Catalyst", .name = "CAT28F512", .bustype = BUS_PARALLEL, -- To view, visit https://review.coreboot.org/c/flashrom/+/63909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia47e015aca092c2886703fdce1ff793246e1fc24 Gerrit-Change-Number: 63909 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: enable write-protection for W25Q{64,128}.V
by Anastasia Klimchuk (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59071 ) Change subject: flashchips: enable write-protection for W25Q{64,128}.V ...................................................................... Patch Set 27: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/59071/comment/f05470c1_6f128340 PS27, Line 16: W25Q64JV There are two of them in the latest version, commit message needs to be updated to mention "W25Q64JV-.Q" and "W25Q64JV-.M" -- To view, visit https://review.coreboot.org/c/flashrom/+/59071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iccb69a8d3a0dd2192e2c938caddaf07b1889ed35 Gerrit-Change-Number: 59071 Gerrit-PatchSet: 27 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 28 Apr 2022 05:09:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add XMC XM25QH128A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63908 to look at the new patch set (#3). Change subject: flashchips: Add XMC XM25QH128A ...................................................................... flashchips: Add XMC XM25QH128A Change-Id: I42f991bdb5959d5e035b765ee8fa7635a875f25d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/63908/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/63908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I42f991bdb5959d5e035b765ee8fa7635a875f25d Gerrit-Change-Number: 63908 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add XMC XM25QH128A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63908 to look at the new patch set (#2). Change subject: flashchips: Add XMC XM25QH128A ...................................................................... flashchips: Add XMC XM25QH128A Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I42f991bdb5959d5e035b765ee8fa7635a875f25d --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/63908/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I42f991bdb5959d5e035b765ee8fa7635a875f25d Gerrit-Change-Number: 63908 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022