April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: dummyflasher: enforce write protection for W25Q128FV
by Sergii Dmytruk (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59074 to look at the new patch set (#32). Change subject: dummyflasher: enforce write protection for W25Q128FV ...................................................................... dummyflasher: enforce write protection for W25Q128FV Start taking bits related to write protection into account. Also add "hwwp" parameter for dummy programmer that sets state of WP pin (not inverted value). dummyflasher doesn't store state of the chip between runs and flashrom allows running only one command, so testing WP in this way is limited. However, WP options can be combined with other operations and are executed prior to them, so certain scenarios can be checked. List possible ranges: flashrom -p dummy:emulate=W25Q128FV,hwwp=yes --wp-list Set a particular range and check status is correct: flashrom -p dummy:emulate=W25Q128FV,hwwp=yes \ --wp-enable \ --wp-range=0x00100000,0x00f00000 \ --wp-status Enable write protection and try erasing/writing (erasing here): # this fails flashrom -p dummy:emulate=W25Q128FV,hwwp=yes \ --wp-range=0,0x00c00000 \ --wp-enable \ --erase Write protecting empty range has no effect: # this succeeds flashrom -p dummy:emulate=W25Q128FV,hwwp=yes \ --wp-range=0,0 \ --wp-enable \ --erase Change-Id: I9fd1417f941186391bd213bd355530143c8f04a0 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M dummyflasher.c M flashrom.8.tmpl 2 files changed, 157 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/59074/32 -- To view, visit https://review.coreboot.org/c/flashrom/+/59074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fd1417f941186391bd213bd355530143c8f04a0 Gerrit-Change-Number: 59074 Gerrit-PatchSet: 32 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: test write protection
by Sergii Dmytruk (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59075 to look at the new patch set (#34). Change subject: tests: test write protection ...................................................................... tests: test write protection Tests both WP implementation and its emulation in dummy programmer. Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- A tests/chip_wp.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 337 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/59075/34 -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 34 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: Add optimisation level s and disable debug in meson build
by Thomas Heijligen (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63606 ) Change subject: meson: Add optimisation level s and disable debug in meson build ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ca96a866529cac320e66516ef280d5100ceefab Gerrit-Change-Number: 63606 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 10:49:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: mark PM25LQ020 as TESTED_OK_PREW
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: roman.stingler(a)gmail.com. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63921 ) Change subject: flashchips.c: mark PM25LQ020 as TESTED_OK_PREW ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/205 -- To view, visit https://review.coreboot.org/c/flashrom/+/63921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f0c04f505ef505e717e7bbbc0eaa8c9d8064012 Gerrit-Change-Number: 63921 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-Comment-Date: Thu, 28 Apr 2022 06:49:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: mark PM25LQ020 as TESTED_OK_PREW
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: roman.stingler(a)gmail.com. Hello roman.stingler(a)gmail.com, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/63921 to review the following change. Change subject: flashchips.c: mark PM25LQ020 as TESTED_OK_PREW ...................................................................... flashchips.c: mark PM25LQ020 as TESTED_OK_PREW Change-Id: I8f0c04f505ef505e717e7bbbc0eaa8c9d8064012 Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/63921/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..e3ebbc0 100644 --- a/flashchips.c +++ b/flashchips.c @@ -12578,7 +12578,7 @@ .page_size = 256, /* OTP: 256B total; read 0x4B, write 0xB1 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/63921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f0c04f505ef505e717e7bbbc0eaa8c9d8064012 Gerrit-Change-Number: 63921 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: nic3com: mark PCI id 9006 as supported
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63920 ) Change subject: nic3com: mark PCI id 9006 as supported ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/219 -- To view, visit https://review.coreboot.org/c/flashrom/+/63920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I88712d81b291c7ef4212bf19e284d270219fa908 Gerrit-Change-Number: 63920 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 06:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nic3com: mark PCI id 9006 as supported
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63920 ) Change subject: nic3com: mark PCI id 9006 as supported ...................................................................... nic3com: mark PCI id 9006 as supported I have tested this with my 3com ethernet card and it works. Change-Id: I88712d81b291c7ef4212bf19e284d270219fa908 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M nic3com.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/63920/1 diff --git a/nic3com.c b/nic3com.c index 3ef607d..1a6ebc3 100644 --- a/nic3com.c +++ b/nic3com.c @@ -40,7 +40,7 @@ {0x10b7, 0x9001, NT, "3COM", "3C90xB: PCI 10/100 Mbps; shared 10BASE-T/100BASE-T4" }, {0x10b7, 0x9004, OK, "3COM", "3C90xB: PCI 10BASE-T (TPO)" }, {0x10b7, 0x9005, NT, "3COM", "3C90xB: PCI 10BASE-T/10BASE2/AUI (COMBO)" }, - {0x10b7, 0x9006, NT, "3COM", "3C90xB: PCI 10BASE-T/10BASE2 (TPC)" }, + {0x10b7, 0x9006, OK, "3COM", "3C90xB: PCI 10BASE-T/10BASE2 (TPC)" }, {0x10b7, 0x900a, NT, "3COM", "3C90xB: PCI 10BASE-FL" }, {0x10b7, 0x905a, NT, "3COM", "3C90xB: PCI 10BASE-FX" }, {0x10b7, 0x9058, OK, "3COM", "3C905B: Cyclone 10/100/BNC" }, -- To view, visit https://review.coreboot.org/c/flashrom/+/63920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I88712d81b291c7ef4212bf19e284d270219fa908 Gerrit-Change-Number: 63920 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Add support for motherboard Jetway P4MDPT
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63919 ) Change subject: Add support for motherboard Jetway P4MDPT ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: From https://github.com/flashrom/flashrom/pull/241 -- To view, visit https://review.coreboot.org/c/flashrom/+/63919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I494863389d2afdb745d5c83a99cd955e6a5c334d Gerrit-Change-Number: 63919 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 06:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for motherboard Jetway P4MDPT
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/63919 ) Change subject: Add support for motherboard Jetway P4MDPT ...................................................................... Add support for motherboard Jetway P4MDPT Add support for motherboard Jetway P4MDPT Read: OK Flash: OK Change-Id: I494863389d2afdb745d5c83a99cd955e6a5c334d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M board_enable.c M print.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/63919/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I494863389d2afdb745d5c83a99cd955e6a5c334d Gerrit-Change-Number: 63919 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Add support for motherboard Jetway P4MDPT
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63919 ) Change subject: Add support for motherboard Jetway P4MDPT ...................................................................... Add support for motherboard Jetway P4MDPT Add support for motherboard Jetway P4MDPT Read: OK Flash: OK Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I494863389d2afdb745d5c83a99cd955e6a5c334d --- M board_enable.c M print.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/63919/1 diff --git a/board_enable.c b/board_enable.c index d740806..ae50df0 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2474,6 +2474,7 @@ {0x8086, 0x27b8, 0x8086, 0xd606, 0x8086, 0x2770, 0x8086, 0xd606, "^D945GCNL$", NULL, NULL, P2, "Intel", "D945GCNL", 0, OK, p2_not_a_laptop}, {0x8086, 0x7190, 0, 0, 0x8086, 0x7110, 0, 0, "^SE440BX-2$", NULL, NULL, P3, "Intel", "SE440BX-2", 0, NT, intel_piix4_gpo27_lower}, {0x1022, 0x7468, 0, 0, 0x1022, 0x7460, 0, 0, NULL, "iwill", "dk8_htx", P3, "IWILL", "DK8-HTX", 0, OK, w83627hf_gpio24_raise_2e}, + {0x5333, 0x8d04, 0x1106, 0x3065, 0x1106, 0x3059, 0x1106, 0x0571, "P4M266-8235", NULL, NULL, P3, "Jetway", "P4MDPT", 0, OK,w836xx_memw_enable_2e}, {0x8086, 0x27A0, 0x8086, 0x27a0, 0x8086, 0x27b8, 0x8086, 0x27b8, NULL, "kontron", "986lcd-m", P3, "Kontron", "986LCD-M", 0, OK, board_kontron_986lcd_m}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad R400", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad R400", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad T400", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T400", 0, OK, p2_whitelist_laptop}, diff --git a/print.c b/print.c index cbf12d6..0e2dffd 100644 --- a/print.c +++ b/print.c @@ -932,6 +932,7 @@ B("IWILL", "DK8-HTX", OK, "http://web.archive.org/web/20060507170150/http://www.iwill.net/product_2.as…", NULL), B("Jetway", "J-7BXAN", OK, "http://www.jetway.com.tw/evisn/download/d7BXAS.htm", NULL), B("Jetway", "J7F4K1G5D-PB", OK, "http://www.jetway.com.tw/jw/ipcboard_view.asp?productid=282&proname=J7F4K1G…", NULL), + B("Jetway", "P4MDPT", OK, "https://www.jetwaycomputer.com/spec/p4mdpt.html", NULL), B("Kontron", "986LCD-M", OK, "http://de.kontron.com/products/boards+and+mezzanines/embedded+motherboards/…", NULL), B("Lanner", "EM-8510C", OK, NULL, NULL), B("Lenovo", "Tilapia CRB", OK, NULL, "Used in ThinkCentre M75e."), -- To view, visit https://review.coreboot.org/c/flashrom/+/63919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I494863389d2afdb745d5c83a99cd955e6a5c334d Gerrit-Change-Number: 63919 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022