Attention is currently required from: Felix Singer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63898 )
Change subject: flashchips.h: Add Spansion S25FL064L
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63898/comment/b714945c_b6edd38c
PS2, Line 7: .h
Remove?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63898
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5
Gerrit-Change-Number: 63898
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Thu, 28 Apr 2022 06:24:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63900 )
Change subject: flashchips.c: Add XM25QH64A
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63900/comment/816e37b7_56ee305a
PS1, Line 7: .c
Please remove.
https://review.coreboot.org/c/flashrom/+/63900/comment/39bcbf37_d9c14937
PS1, Line 10: aiyion.prime
That is different from the author name.
--
To view, visit https://review.coreboot.org/c/flashrom/+/63900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I496a55c788d2ff376f32c56ec734f58340692876
Gerrit-Change-Number: 63900
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Thu, 28 Apr 2022 06:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63912 )
Change subject: flashchips: Add f25l16pa
......................................................................
Patch Set 1:
(1 comment)
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/63912/comment/77811ce9_2e769fb8
PS1, Line 235: #define ESMT_F25L16PA 0x2015
> Should that be sorted?
Yes. Currently, I am just going through the GitHub PRs, look what's useful and push it to Gerrit.
--
To view, visit https://review.coreboot.org/c/flashrom/+/63912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If80e2bdacc14e94cd70bb0f9dff5f38c9af62ef3
Gerrit-Change-Number: 63912
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 28 Apr 2022 06:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63912 )
Change subject: flashchips: Add f25l16pa
......................................................................
Patch Set 1:
(1 comment)
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/63912/comment/90ce710e_73c2d42d
PS1, Line 235: #define ESMT_F25L16PA 0x2015
Should that be sorted?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If80e2bdacc14e94cd70bb0f9dff5f38c9af62ef3
Gerrit-Change-Number: 63912
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Thu, 28 Apr 2022 06:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63914 )
Change subject: flashchips: Add Shanghai Fudan Microelectronics Group Company Lmt. FM25F04
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
From https://github.com/flashrom/flashrom/pull/51
--
To view, visit https://review.coreboot.org/c/flashrom/+/63914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I83575ea3a3a8136cf127557add4a08ec17b69445
Gerrit-Change-Number: 63914
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Thu, 28 Apr 2022 06:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63912 )
Change subject: flashchips: Add f25l16pa
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
From https://github.com/flashrom/flashrom/pull/64
--
To view, visit https://review.coreboot.org/c/flashrom/+/63912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If80e2bdacc14e94cd70bb0f9dff5f38c9af62ef3
Gerrit-Change-Number: 63912
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Thu, 28 Apr 2022 06:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment