April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add XMC XM25QH128A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63908 ) Change subject: flashchips: Add XMC XM25QH128A ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/193 -- To view, visit https://review.coreboot.org/c/flashrom/+/63908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I42f991bdb5959d5e035b765ee8fa7635a875f25d Gerrit-Change-Number: 63908 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 05:03:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add XMC XM25QH128A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63908 ) Change subject: flashchips: Add XMC XM25QH128A ...................................................................... flashchips: Add XMC XM25QH128A Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I42f991bdb5959d5e035b765ee8fa7635a875f25d --- M flashchips.c 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/63908/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..ea6bf1d 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19587,6 +19587,44 @@ }, { + .vendor = "XMC", + .name = "XM25QH128A", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QH128A, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { .vendor = "Zetta Device", .name = "ZD25D20", .bustype = BUS_SPI, -- To view, visit https://review.coreboot.org/c/flashrom/+/63908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I42f991bdb5959d5e035b765ee8fa7635a875f25d Gerrit-Change-Number: 63908 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: Add Shenzhen First-Rank T25S32
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63907 ) Change subject: flashchips: Add Shenzhen First-Rank T25S32 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/209 -- To view, visit https://review.coreboot.org/c/flashrom/+/63907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20b959275dd9b1151dad400a2c7b88c74310a10c Gerrit-Change-Number: 63907 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 04:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Shenzhen First-Rank T25S32
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63907 ) Change subject: flashchips: Add Shenzhen First-Rank T25S32 ...................................................................... flashchips: Add Shenzhen First-Rank T25S32 Change-Id: I20b959275dd9b1151dad400a2c7b88c74310a10c Signed-off-by: Charlie Bruce <charliebruce(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/63907/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..fe72a6c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15923,6 +15923,44 @@ }, { + .vendor = "Shenzhen FirstRank", + .name = "T25S32", + .bustype = BUS_SPI, + .manufacture_id = SHENZHEN_FIRSTRANK_ID, + .model_id = SHENZHEN_FIRSTRANK_T25S32_SPI, + .total_size = 4096, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, /* Sector Erase */ + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 128} }, /* 32 KB Block Erase */ + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, /* 64 KB Block Erase */ + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, /* Chip erase - option 1 */ + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, /* Chip erase - option 2 */ + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { .vendor = "Spansion", .name = "S25FL004A", .bustype = BUS_SPI, diff --git a/flashchips.h b/flashchips.h index ba97719..2d8660f 100644 --- a/flashchips.h +++ b/flashchips.h @@ -650,6 +650,11 @@ #define SHARP_LHF00L02 0xC9 /* Same as LHF00L06/LHF00L07 */ #define SHARP_LHF00L04 0xCF /* Same as LHF00L03/LHF00L05 */ +/* Shenzhen First-Rank Technology Co Ltd. */ +#define SHENZHEN_FIRSTRANK_ID 0x5E +#define SHENZHEN_FIRSTRANK_T25S32_SPI 0x4016 /* When in SPI mode */ +#define SHENZHEN_FIRSTRANK_T25S32_QPI 0x6016 /* When in QPI mode */ + /* Spansion was previously a joint venture of AMD and Fujitsu. */ #define SPANSION_ID 0x01 /* Spansion, same ID as AMD */ /* S25 chips are SPI. The first device ID byte is memory type and -- To view, visit https://review.coreboot.org/c/flashrom/+/63907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20b959275dd9b1151dad400a2c7b88c74310a10c Gerrit-Change-Number: 63907 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: spi25_statusreg.c: add SR3 read/write support
by Anastasia Klimchuk (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60230 ) Change subject: spi25_statusreg.c: add SR3 read/write support ...................................................................... Patch Set 11: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/60230/comment/6954bc4e_09e9461b PS11, Line 11: : Extended WRSR doesn't cover SR3, so only one feature flag is added. Sorry I only now noticed: the latest version does not add any flag. So this statement needs to be changed. I would say "Feature flag is not needed because .... <insert why>". -- To view, visit https://review.coreboot.org/c/flashrom/+/60230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id987c544c02da2b956e6ad2c525265cac8f15be1 Gerrit-Change-Number: 60230 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 28 Apr 2022 04:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Macronix MX25V8035F
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), roman.stingler(a)gmail.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63906 to look at the new patch set (#2). Change subject: flashchips: Add Macronix MX25V8035F ...................................................................... flashchips: Add Macronix MX25V8035F Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526 Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/63906/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526 Gerrit-Change-Number: 63906 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: roman.stingler(a)gmail.com Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add Macronix MX25V8035F
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Felix Singer, roman.stingler(a)gmail.com. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63906 ) Change subject: flashchips: Add Macronix MX25V8035F ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/206 -- To view, visit https://review.coreboot.org/c/flashrom/+/63906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526 Gerrit-Change-Number: 63906 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-Comment-Date: Thu, 28 Apr 2022 04:51:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Macronix MX25V8035F
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: roman.stingler(a)gmail.com. Hello roman.stingler(a)gmail.com, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/63906 to review the following change. Change subject: flashchips: Add Macronix MX25V8035F ...................................................................... flashchips: Add Macronix MX25V8035F Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526 Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/63906/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..5a599e6 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9652,6 +9652,48 @@ .voltage = {1650, 2000}, }, + + { + .vendor = "Macronix", + .name = "MX25V8035F", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25V8035F, + .total_size = 1024, + .page_size = 256, + /* OTP: 512B total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 32} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + /* TODO: security register */ + .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */ + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2300, 3600}, + }, + + { .vendor = "Macronix", .name = "MX29F001B", -- To view, visit https://review.coreboot.org/c/flashrom/+/63906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526 Gerrit-Change-Number: 63906 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP032
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Nicolò Boatto. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63905 ) Change subject: flashchips: Add ISSI IS25LP032 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/215 -- To view, visit https://review.coreboot.org/c/flashrom/+/63905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3757bc0624eb3a736438dc932d965fa6da213f69 Gerrit-Change-Number: 63905 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nicolò Boatto <nicoloboatto(a)gmail.com> Gerrit-Attention: Nicolò Boatto <nicoloboatto(a)gmail.com> Gerrit-Comment-Date: Thu, 28 Apr 2022 04:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP032
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Nicolò Boatto. Hello Nicolò Boatto, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/63905 to review the following change. Change subject: flashchips: Add ISSI IS25LP032 ...................................................................... flashchips: Add ISSI IS25LP032 Change-Id: I3757bc0624eb3a736438dc932d965fa6da213f69 Signed-off-by: Nicolò Boatto <nicoloboatto(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/63905/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..c2d83ab 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7379,6 +7379,47 @@ { .vendor = "ISSI", + .name = "IS25LP032", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25LP032, + .total_size = 4096, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "ISSI", .name = "IS25LP064", .bustype = BUS_SPI, .manufacture_id = ISSI_ID_SPI, diff --git a/flashchips.h b/flashchips.h index ba97719..ba32291 100644 --- a/flashchips.h +++ b/flashchips.h @@ -472,6 +472,7 @@ #define ISSI_ID 0xD5 /* ISSI Integrated Silicon Solutions, see also PMC. */ #define ISSI_ID_SPI 0x9D /* ISSI ID used for SPI flash, see also PMC_ID_NOPREFIX */ +#define ISSI_IS25LP032 0x6016 #define ISSI_IS25LP064 0x6017 #define ISSI_IS25LP128 0x6018 #define ISSI_IS25LP256 0x6019 -- To view, visit https://review.coreboot.org/c/flashrom/+/63905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3757bc0624eb3a736438dc932d965fa6da213f69 Gerrit-Change-Number: 63905 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nicolò Boatto <nicoloboatto(a)gmail.com> Gerrit-Attention: Nicolò Boatto <nicoloboatto(a)gmail.com> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022