Attention is currently required from: Nico Huber, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60230 )
Change subject: spi25_statusreg.c: add SR3 read/write support
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/60230/comment/6954bc4e_09e9461b
PS11, Line 11:
: Extended WRSR doesn't cover SR3, so only one feature flag is added.
Sorry I only now noticed: the latest version does not add any flag. So this statement needs to be changed. I would say "Feature flag is not needed because .... <insert why>".
--
To view, visit https://review.coreboot.org/c/flashrom/+/60230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id987c544c02da2b956e6ad2c525265cac8f15be1
Gerrit-Change-Number: 60230
Gerrit-PatchSet: 11
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 04:55:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), roman.stingler(a)gmail.com,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/63906
to look at the new patch set (#2).
Change subject: flashchips: Add Macronix MX25V8035F
......................................................................
flashchips: Add Macronix MX25V8035F
Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526
Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com>
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M flashchips.c
1 file changed, 42 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/63906/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/63906
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526
Gerrit-Change-Number: 63906
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: roman.stingler(a)gmail.com
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, roman.stingler(a)gmail.com.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63906 )
Change subject: flashchips: Add Macronix MX25V8035F
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
From https://github.com/flashrom/flashrom/pull/206
--
To view, visit https://review.coreboot.org/c/flashrom/+/63906
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526
Gerrit-Change-Number: 63906
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: roman.stingler(a)gmail.com
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: roman.stingler(a)gmail.com
Gerrit-Comment-Date: Thu, 28 Apr 2022 04:51:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63904 )
Change subject: flashchips: Add ZB25VQ64
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
From https://github.com/flashrom/flashrom/pull/224
--
To view, visit https://review.coreboot.org/c/flashrom/+/63904
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idc85084f97275d295c801d982ab47ce3f3358fa3
Gerrit-Change-Number: 63904
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Thu, 28 Apr 2022 04:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62868 )
Change subject: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros
......................................................................
Patch Set 19:
(1 comment)
Patchset:
PS14:
> Just checking, have you done
> make clean && make CONFIG_EVERYTHING=yes VERSION=none
>
> especially with `VERSION=none`, otherwise there is a different version between different patches.
Thanks Anastasia for help and sensing where could be the issue potentially.
updated the commit msg to reflect the actual scenario.
marking resolved now.
--
To view, visit https://review.coreboot.org/c/flashrom/+/62868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80
Gerrit-Change-Number: 62868
Gerrit-PatchSet: 19
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Thu, 28 Apr 2022 04:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment