April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: raiden_debug_spi.c: Document where raiden_debug_spi_requests are handled
by Edward O'Callaghan (Code Review) 28 Apr '22

28 Apr '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63902 ) Change subject: raiden_debug_spi.c: Document where raiden_debug_spi_requests are handled ...................................................................... raiden_debug_spi.c: Document where raiden_debug_spi_requests are handled Because the enum is a different name to the one within cr50 it was entirely unclear where these values were handled at the end-point and what a untargetted REQ_ENABLE actually did. Comment to avoid needing to chase this again. BUG=b:224358254 TEST=builds Change-Id: I8cc78a85660190c9f750bf67994f0d59d69592d8 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M raiden_debug_spi.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/63902/1 diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 521539f..a0deb28 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -399,6 +399,7 @@ USB_SPI_UNKNOWN_ERROR = 0x8000, }; +/* Corresponds with 'enum usb_spi_request' in platform/cr50/chip/g/usb_spi.h */ enum raiden_debug_spi_request { RAIDEN_DEBUG_SPI_REQ_ENABLE = 0x0000, RAIDEN_DEBUG_SPI_REQ_DISABLE = 0x0001, @@ -1445,6 +1446,10 @@ static int get_target(void) { + /** + * A untargetted REQ_ENABLE is handled as a sentinel value that + * a target value was unspecified. + */ int request_enable = RAIDEN_DEBUG_SPI_REQ_ENABLE; char *target_str = extract_programmer_param("target"); -- To view, visit https://review.coreboot.org/c/flashrom/+/63902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8cc78a85660190c9f750bf67994f0d59d69592d8 Gerrit-Change-Number: 63902 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashrom.8.tmpl: Add raiden_debug_spi doc entry
by Edward O'Callaghan (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Nikolai Artemiev. Hello build bot (Jenkins), Martin Roth, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62768 to look at the new patch set (#6). Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ...................................................................... flashrom.8.tmpl: Add raiden_debug_spi doc entry BUG=b:224358254 TEST=`man ./flashrom.8.tmpl`. Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.8.tmpl 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/62768/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/62768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4 Gerrit-Change-Number: 62768 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.c: Add support for XTX XT25F128B
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63901 ) Change subject: flashchips.c: Add support for XTX XT25F128B ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/236 -- To view, visit https://review.coreboot.org/c/flashrom/+/63901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5e57bec2980d67871429eafec6eb937e71831ded Gerrit-Change-Number: 63901 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 03:34:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Add support for XTX XT25F128B
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63901 ) Change subject: flashchips.c: Add support for XTX XT25F128B ...................................................................... flashchips.c: Add support for XTX XT25F128B Change-Id: I5e57bec2980d67871429eafec6eb937e71831ded Signed-off-by: f0rw4rd <f0rw4rd(a)protonmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/63901/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..051a80a 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19661,6 +19661,40 @@ .read = spi_chip_read, .voltage = {2700, 3600}, }, + { + .vendor = "XTX", + .name = "XT25F128B", + .bustype = BUS_SPI, + .manufacture_id = XTX_ID, + .model_id = XTX_XT25F128B, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_srwd, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, { .vendor = "Unknown", diff --git a/flashchips.h b/flashchips.h index ba97719..1167739 100644 --- a/flashchips.h +++ b/flashchips.h @@ -1030,4 +1030,7 @@ #define ZETTADEVICE_ZD25D20 0x2012 #define ZETTADEVICE_ZD25D40 0x2013 +#define XTX_ID 0x0B /* XTX Device */ +#define XTX_XT25F128B 0x4018 + #endif /* !FLASHCHIPS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/63901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5e57bec2980d67871429eafec6eb937e71831ded Gerrit-Change-Number: 63901 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips.c: Add XM25QH64A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63900 ) Change subject: flashchips.c: Add XM25QH64A ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/239 -- To view, visit https://review.coreboot.org/c/flashrom/+/63900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I496a55c788d2ff376f32c56ec734f58340692876 Gerrit-Change-Number: 63900 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 03:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Add XM25QH64A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63900 ) Change subject: flashchips.c: Add XM25QH64A ...................................................................... flashchips.c: Add XM25QH64A Change-Id: I496a55c788d2ff376f32c56ec734f58340692876 Signed-off-by: aiyion.prime <git(a)aiyionpri.me> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/63900/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..892f30c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19331,6 +19331,47 @@ { .vendor = "XMC", + .name = "XM25QH64A", + .bustype = BUS_SPI, + .manufacture_id = XMC_ID, + .model_id = XMC_XM25QH64A, + .total_size = 8192, + .page_size = 256, + /* supports SFDP */ + /* OTP: 512B total; enter 0x3A */ + /* QPI enable 0x38, disable 0xFF */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { { 8192 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { { 8192 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */ + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/flashchips.h b/flashchips.h index ba97719..9c6e020 100644 --- a/flashchips.h +++ b/flashchips.h @@ -1030,4 +1030,21 @@ #define ZETTADEVICE_ZD25D20 0x2012 #define ZETTADEVICE_ZD25D40 0x2013 +#define XMC_ID 0x20 /* same as ST_ID */ +#define XMC_XM25QH256B 0x6019 +#define XMC_XM25QH128A 0x1708 +#define XMC_XM25QH128B 0x6018 +#define XMC_XM25QH64A 0x7017 +#define XMC_XM25QH64B 0x6017 +#define XMC_XM25QH32B 0x4016 /* 0x6016 for QPI mode */ +#define XMC_XM25QH16B 0x4015 +#define XMC_XM25QH80B 0x4014 +#define XMC_XM25QH40B 0x4013 +#define XMC_XM25QU256B 0x7019 +#define XMC_XM25QU128B 0x5018 +#define XMC_XM25QU64A 0x3817 +#define XMC_XM25QU64B 0x5017 +#define XMC_XM25QU40B 0x5013 +#define XMC_XM25QU20B 0x5012 + #endif /* !FLASHCHIPS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/63900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I496a55c788d2ff376f32c56ec734f58340692876 Gerrit-Change-Number: 63900 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips.h: Add Spansion S25FL064L
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63898 ) Change subject: flashchips.h: Add Spansion S25FL064L ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: From https://github.com/flashrom/flashrom/pull/250 -- To view, visit https://review.coreboot.org/c/flashrom/+/63898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Gerrit-Change-Number: 63898 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 03:11:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.h: Add Spansion S25FL064L
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/63898 ) Change subject: flashchips.h: Add Spansion S25FL064L ...................................................................... flashchips.h: Add Spansion S25FL064L Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/63898/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Gerrit-Change-Number: 63898 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.h: Add Spansion S25FL064L
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63898 ) Change subject: flashchips.h: Add Spansion S25FL064L ...................................................................... flashchips.h: Add Spansion S25FL064L Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 --- M flashchips.c M flashchips.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/63898/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..7edc2c1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16069,6 +16069,35 @@ { .vendor = "Spansion", + .name = "S25FL064L", + .bustype = BUS_SPI, + .manufacture_id = SPANSION_ID, + .model_id = SPANSION_S25FL064L, + .total_size = 8192, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Spansion", .name = "S25FL116K/S25FL216K", /* FIXME: separate them */ .bustype = BUS_SPI, .manufacture_id = SPANSION_ID, diff --git a/flashchips.h b/flashchips.h index ba97719..b12bc55 100644 --- a/flashchips.h +++ b/flashchips.h @@ -659,6 +659,7 @@ #define SPANSION_S25FL016A 0x0214 #define SPANSION_S25FL032A 0x0215 /* Same as S25FL032P, but the latter supports EDI and CFI */ #define SPANSION_S25FL064A 0x0216 /* Same as S25FL064P, but the latter supports EDI and CFI */ +#define SPANSION_S25FL064L 0x6017 /* Inherited from Cypress Semiconductor */ #define SPANSION_S25FL128 0x2018 /* Same ID for various S25FL127S, S25FL128P, S25FL128S and S25FL129P (including dual-die S70FL256P) variants (EDI supported) */ #define SPANSION_S25FL256 0x0219 #define SPANSION_S25FL512 0x0220 -- To view, visit https://review.coreboot.org/c/flashrom/+/63898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Gerrit-Change-Number: 63898 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: platform.h: Add support for Synopsis ARC64 architecture
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63896 ) Change subject: platform.h: Add support for Synopsis ARC64 architecture ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/227 -- To view, visit https://review.coreboot.org/c/flashrom/+/63896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8707394871994f600b345d76614c5689fd081db4 Gerrit-Change-Number: 63896 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 02:46:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022