April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips.c: Add support for XTX XT25F128B
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63901 ) Change subject: flashchips.c: Add support for XTX XT25F128B ...................................................................... flashchips.c: Add support for XTX XT25F128B Change-Id: I5e57bec2980d67871429eafec6eb937e71831ded Signed-off-by: f0rw4rd <f0rw4rd(a)protonmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/63901/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..051a80a 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19661,6 +19661,40 @@ .read = spi_chip_read, .voltage = {2700, 3600}, }, + { + .vendor = "XTX", + .name = "XT25F128B", + .bustype = BUS_SPI, + .manufacture_id = XTX_ID, + .model_id = XTX_XT25F128B, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_srwd, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, { .vendor = "Unknown", diff --git a/flashchips.h b/flashchips.h index ba97719..1167739 100644 --- a/flashchips.h +++ b/flashchips.h @@ -1030,4 +1030,7 @@ #define ZETTADEVICE_ZD25D20 0x2012 #define ZETTADEVICE_ZD25D40 0x2013 +#define XTX_ID 0x0B /* XTX Device */ +#define XTX_XT25F128B 0x4018 + #endif /* !FLASHCHIPS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/63901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5e57bec2980d67871429eafec6eb937e71831ded Gerrit-Change-Number: 63901 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips.c: Add XM25QH64A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63900 ) Change subject: flashchips.c: Add XM25QH64A ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/239 -- To view, visit https://review.coreboot.org/c/flashrom/+/63900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I496a55c788d2ff376f32c56ec734f58340692876 Gerrit-Change-Number: 63900 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 03:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Add XM25QH64A
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63900 ) Change subject: flashchips.c: Add XM25QH64A ...................................................................... flashchips.c: Add XM25QH64A Change-Id: I496a55c788d2ff376f32c56ec734f58340692876 Signed-off-by: aiyion.prime <git(a)aiyionpri.me> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/63900/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..892f30c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19331,6 +19331,47 @@ { .vendor = "XMC", + .name = "XM25QH64A", + .bustype = BUS_SPI, + .manufacture_id = XMC_ID, + .model_id = XMC_XM25QH64A, + .total_size = 8192, + .page_size = 256, + /* supports SFDP */ + /* OTP: 512B total; enter 0x3A */ + /* QPI enable 0x38, disable 0xFF */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { { 8192 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { { 8192 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */ + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/flashchips.h b/flashchips.h index ba97719..9c6e020 100644 --- a/flashchips.h +++ b/flashchips.h @@ -1030,4 +1030,21 @@ #define ZETTADEVICE_ZD25D20 0x2012 #define ZETTADEVICE_ZD25D40 0x2013 +#define XMC_ID 0x20 /* same as ST_ID */ +#define XMC_XM25QH256B 0x6019 +#define XMC_XM25QH128A 0x1708 +#define XMC_XM25QH128B 0x6018 +#define XMC_XM25QH64A 0x7017 +#define XMC_XM25QH64B 0x6017 +#define XMC_XM25QH32B 0x4016 /* 0x6016 for QPI mode */ +#define XMC_XM25QH16B 0x4015 +#define XMC_XM25QH80B 0x4014 +#define XMC_XM25QH40B 0x4013 +#define XMC_XM25QU256B 0x7019 +#define XMC_XM25QU128B 0x5018 +#define XMC_XM25QU64A 0x3817 +#define XMC_XM25QU64B 0x5017 +#define XMC_XM25QU40B 0x5013 +#define XMC_XM25QU20B 0x5012 + #endif /* !FLASHCHIPS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/63900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I496a55c788d2ff376f32c56ec734f58340692876 Gerrit-Change-Number: 63900 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips.h: Add Spansion S25FL064L
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63898 ) Change subject: flashchips.h: Add Spansion S25FL064L ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: From https://github.com/flashrom/flashrom/pull/250 -- To view, visit https://review.coreboot.org/c/flashrom/+/63898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Gerrit-Change-Number: 63898 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 03:11:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.h: Add Spansion S25FL064L
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/63898 ) Change subject: flashchips.h: Add Spansion S25FL064L ...................................................................... flashchips.h: Add Spansion S25FL064L Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c M flashchips.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/63898/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Gerrit-Change-Number: 63898 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.h: Add Spansion S25FL064L
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63898 ) Change subject: flashchips.h: Add Spansion S25FL064L ...................................................................... flashchips.h: Add Spansion S25FL064L Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 --- M flashchips.c M flashchips.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/63898/1 diff --git a/flashchips.c b/flashchips.c index 0a1d21d..7edc2c1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16069,6 +16069,35 @@ { .vendor = "Spansion", + .name = "S25FL064L", + .bustype = BUS_SPI, + .manufacture_id = SPANSION_ID, + .model_id = SPANSION_S25FL064L, + .total_size = 8192, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Spansion", .name = "S25FL116K/S25FL216K", /* FIXME: separate them */ .bustype = BUS_SPI, .manufacture_id = SPANSION_ID, diff --git a/flashchips.h b/flashchips.h index ba97719..b12bc55 100644 --- a/flashchips.h +++ b/flashchips.h @@ -659,6 +659,7 @@ #define SPANSION_S25FL016A 0x0214 #define SPANSION_S25FL032A 0x0215 /* Same as S25FL032P, but the latter supports EDI and CFI */ #define SPANSION_S25FL064A 0x0216 /* Same as S25FL064P, but the latter supports EDI and CFI */ +#define SPANSION_S25FL064L 0x6017 /* Inherited from Cypress Semiconductor */ #define SPANSION_S25FL128 0x2018 /* Same ID for various S25FL127S, S25FL128P, S25FL128S and S25FL129P (including dual-die S70FL256P) variants (EDI supported) */ #define SPANSION_S25FL256 0x0219 #define SPANSION_S25FL512 0x0220 -- To view, visit https://review.coreboot.org/c/flashrom/+/63898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc4431749daf5621a8b35c70c60b6f02311516b5 Gerrit-Change-Number: 63898 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: platform.h: Add support for Synopsis ARC64 architecture
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63896 ) Change subject: platform.h: Add support for Synopsis ARC64 architecture ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From https://github.com/flashrom/flashrom/pull/227 -- To view, visit https://review.coreboot.org/c/flashrom/+/63896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8707394871994f600b345d76614c5689fd081db4 Gerrit-Change-Number: 63896 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 02:46:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: Add support for Synopsis ARC64 architecture
by Felix Singer (Code Review) 28 Apr '22

28 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63896 ) Change subject: platform.h: Add support for Synopsis ARC64 architecture ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/63896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8707394871994f600b345d76614c5689fd081db4 Gerrit-Change-Number: 63896 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 28 Apr 2022 02:46:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Close GitHub PRs and issues automatically
by Anastasia Klimchuk (Code Review) 28 Apr '22

28 Apr '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/63671 ) Change subject: Close GitHub PRs and issues automatically ...................................................................... Close GitHub PRs and issues automatically The flashrom project does not use GitHub for pull requests or issues. Thus, close issues and pull requests automatically using a GitHub Actions hook. Also, add a comment pointing to our guidelines. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I8076f0fb964970ffd05f355b9d1e33a65aa7a3c8 Reviewed-on: https://review.coreboot.org/c/flashrom/+/63671 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A .github/workflows/lockdown.yml 1 file changed, 36 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml new file mode 100644 index 0000000..39b6548 --- /dev/null +++ b/.github/workflows/lockdown.yml @@ -0,0 +1,36 @@ +name: 'Close issues and PRs' + +on: + issues: + types: opened + pull_request_target: + types: opened + +permissions: + issues: write + pull-requests: write + +jobs: + action: + runs-on: ubuntu-latest + steps: + - uses: dessant/repo-lockdown@0b093279a77b44bbc38e85089b5463dd06b4aea4 + with: + issue-comment: > + Thank you for your contribution. The flashrom project does not handle + GitHub issues or pull requests, since this repository on GitHub is + just a mirror of our actual repository. Thus, we would like to + encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). + Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). + If you have questions, feel free to reach out to us. There are + multiple ways to [contact us](https://www.flashrom.org/Contact). + pr-comment: > + Thank you for your contribution. The flashrom project does not handle + GitHub issues or pull requests, since this repository on GitHub is + just a mirror of our actual repository. Thus, we would like to + encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). + Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). + If you have questions, feel free to reach out to us. There are + multiple ways to [contact us](https://www.flashrom.org/Contact). -- To view, visit https://review.coreboot.org/c/flashrom/+/63671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8076f0fb964970ffd05f355b9d1e33a65aa7a3c8 Gerrit-Change-Number: 63671 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: meson: add option to disable tests
by Peter Marheine (Code Review) 28 Apr '22

28 Apr '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 00:55:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022