April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashrom: initialize restore func count in correct place
by Edward O'Callaghan (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Nico Huber, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63881 ) Change subject: flashrom: initialize restore func count in correct place ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4c7df424bd2ae2b5fb2a2ab6b47a3c9ff3233acf Gerrit-Change-Number: 63881 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:22:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros
by Subrata Banik (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Subrata Banik, Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62868 ) Change subject: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros ...................................................................... Patch Set 18: (1 comment) Patchset: PS14: > This one [comment] left > And then you can add "binary before CB:62888 CB:62868 and did not change" to the TEST section. @Anastasia: I could able to see only 2 changes (at 0x368 offset and 0x45B85 offset) while I tested two flashrom binaries (one with CB:62888 and another the complete patch train till CB:62868) flashrom$ cmp flashrom flashrom_old flashrom flashrom_old differ: byte 873, line 1 flashrom$ ls -lt flashrom* -rwxr-xr-x 1 subratabanik primarygroup 763808 Apr 27 09:27 flashrom -rwxr-xr-x 1 subratabanik primarygroup 763808 Apr 27 09:26 flashrom_old Those diff looks like related to timestamp. -- To view, visit https://review.coreboot.org/c/flashrom/+/62868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 Gerrit-Change-Number: 62868 Gerrit-PatchSet: 18 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 09:38:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros
by Subrata Banik (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Subrata Banik, Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62868 to look at the new patch set (#18). Change subject: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros ...................................................................... ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros This patch introduces useful macros (read/write/erase) and uses these macros throughout the SPI operations. Additionally, implicitly using the HSFC_CYCLE_READ macro for the SPI read operation. BUG=b:223630977 TEST=Able to perform read/write/erase operation on PCH 600 series chipset (board name: Brya). Additionally, flashrom binary comparison with CB:62888 and between CB:62888 to CB:62868 as below: flashrom$ cmp flashrom flashrom_old flashrom flashrom_old differ: byte 873, line 1 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 --- M ichspi.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/62868/18 -- To view, visit https://review.coreboot.org/c/flashrom/+/62868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 Gerrit-Change-Number: 62868 Gerrit-PatchSet: 18 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: relocate add_project_arguments() for IS_WINDOWS
by Angel Pons (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63827 ) Change subject: meson: relocate add_project_arguments() for IS_WINDOWS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6afb65fabf858449f2706bf250588225a94c1871 Gerrit-Change-Number: 63827 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 09:32:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom: initialize restore func count in correct place
by Angel Pons (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63881 ) Change subject: flashrom: initialize restore func count in correct place ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/63881/comment/131232a2_6c920462 PS3, Line 1865: nit: whitespace -- To view, visit https://review.coreboot.org/c/flashrom/+/63881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4c7df424bd2ae2b5fb2a2ab6b47a3c9ff3233acf Gerrit-Change-Number: 63881 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 27 Apr 2022 09:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Align BITBANG_SPI with the other DEPENDS_ and USE_ configs
by Angel Pons (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63886 ) Change subject: Makefile: Align BITBANG_SPI with the other DEPENDS_ and USE_ configs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63886/comment/5d9ad16b_a751b0e7 PS1, Line 9: D typo: F -- To view, visit https://review.coreboot.org/c/flashrom/+/63886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a519c929f7747af70568284823b51678751e285 Gerrit-Change-Number: 63886 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 08:40:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Align BITBANG_SPI with the other DEPENDS_ and USE_ configs
by Thomas Heijligen (Code Review) 27 Apr '22

27 Apr '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63886 ) Change subject: Makefile: Align BITBANG_SPI with the other DEPENDS_ and USE_ configs ...................................................................... Makefile: Align BITBANG_SPI with the other DEPENDS_ and USE_ configs Drop not needed `-DCONDIG_BITBANG_SPI=1` Change-Id: I2a519c929f7747af70568284823b51678751e285 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 5 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/63886/1 diff --git a/Makefile b/Makefile index 26c77d9..5dc8528 100644 --- a/Makefile +++ b/Makefile @@ -537,14 +537,6 @@ $(eval $(var)=yes))) endif -# Bitbanging SPI infrastructure, default off unless needed. - -ifneq ($(call filter_deps,$(DEPENDS_ON_BITBANG_SPI)), ) -override CONFIG_BITBANG_SPI = yes -else -CONFIG_BITBANG_SPI ?= no -endif - ############################################################################### # Handle CONFIG_* variables that depend on others set (and verified) above. @@ -614,11 +606,6 @@ PROGRAMMER_OBJS += pony_spi.o endif -ifeq ($(CONFIG_BITBANG_SPI), yes) -FEATURE_FLAGS += -D'CONFIG_BITBANG_SPI=1' -PROGRAMMER_OBJS += bitbang_spi.o -endif - ifeq ($(CONFIG_NIC3COM), yes) FEATURE_FLAGS += -D'CONFIG_NIC3COM=1' PROGRAMMER_OBJS += nic3com.o @@ -784,6 +771,11 @@ PROGRAMMER_OBJS += ni845x_spi.o endif +USE_BITBANG_SPI := $(if $(call filter_deps,$(DEPENDS_ON_BITBANG_SPI)),yes,no) +ifeq ($(USE_BITBANG_SPI), yes) +LIB_OBJS += bitbang_spi.o +endif + USE_LINUX_I2C := $(if $(call filter_deps,$(DEPENDS_ON_LINUX_I2C)),yes,no) ifeq ($(USE_LINUX_I2C), yes) LIB_OBJS += i2c_helper_linux.o -- To view, visit https://review.coreboot.org/c/flashrom/+/63886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a519c929f7747af70568284823b51678751e285 Gerrit-Change-Number: 63886 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 ) Change subject: [WIP] meson: rework the programmer selection ...................................................................... Patch Set 11: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63724/comment/2bcc7f59_1d823168 PS7, Line 12: get mandetory > get mandetory -> gets mandatory Done https://review.coreboot.org/c/flashrom/+/63724/comment/f624dc41_c70bf933 PS7, Line 20: get's selectet > get's selectet -> gets selected Done https://review.coreboot.org/c/flashrom/+/63724/comment/473c11be_ec3444f3 PS7, Line 21: determin > determin -> determine Done File meson.build: https://review.coreboot.org/c/flashrom/+/63724/comment/8f5c60cc_208f4578 PS7, Line 109: get edded > does it mean "gets added"? Done File meson_options.txt: https://review.coreboot.org/c/flashrom/+/63724/comment/a7a6b9b2_1d243c1b PS7, Line 9: 'atahpt', 'atapromise', 'buspirate_spi', 'ch341a_spi', 'dediprog', 'developerbox_spi', : 'digilent_spi', 'jlink_spi', 'drkaiser', 'dummy', 'ft2232_spi', 'gfxnvidia', 'raiden_debug_spi', : 'internal', 'it8212', 'linux_mtd', 'linux_spi', 'mstarddc_spi', 'nic3com', 'nicintel_eeprom', : 'nicintel', 'nicintel_spi', 'nicnatsemi', 'nicrealtek', 'ogp_spi', 'pickit2_spi', 'pony_spi', : 'rayer_spi', 'satamv', 'satasii', 'serprog', 'usbblaster_spi', 'stlinkv3_spi', : 'lspcon_i2c_spi', 'mediatek_i2c_spi', 'realtek_mst_i2c_spi', > For the list of individual programmers, do you think maybe we can order them alphabetically? It wasn […] Yes, I just haven't done it yet. -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 11 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 08:07:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63724 to look at the new patch set (#11). Change subject: [WIP] meson: rework the programmer selection ...................................................................... [WIP] meson: rework the programmer selection This is a WIP implementation for a new programmer selection. It should work by now but has some known and unknown bugs. (see Gerrit Comments) - Each dependency is optional and gets mandatory when the programmer is selected as active. - Each programmer is defined through an entry in the programmer dictionary - The entry lists systems & cpu_families where the programmer is supported; Dependencies, sources and flags. The group parameter is for selecting a set of programmer, the default parameter is to include the programmer to the `all` and `auto` set. - If the programmer gets selected the `active` entry is set to true. The `active` entry can be used afterwards to determine if the programmer should be included in sources, config, documentation - Needed system headers are represended through a pseudo dependency. - The programmer's `srcs` attribute contains all files which are needed to build the programmer. Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M meson_options.txt 2 files changed, 413 insertions(+), 337 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/63724/11 -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 11 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: add option to disable tests
by Thomas Heijligen (Code Review) 27 Apr '22

27 Apr '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63832/comment/e9492ee2_b4986aab PS1, Line 10: Run `meson -Dtests=true` to enable tests. (default) : Run `meson -Dtests=false` to disable tests. > One last test scenario: does it work with no option mentioned in command line? just meson, or just m […] I've updated the commit message. Now it should be mode clear what happen. When you run `meson build` tests are enabled as before. File meson.build: https://review.coreboot.org/c/flashrom/+/63832/comment/b3253822_af04a01a PS1, Line 522: if cmocka_dep.found() > I remember that is an important thing, to check cmocka dep. […] cmocka is now a required dependency for tests. Therefore the `if cmocka_dep.found()` is no longer needed. There are only two options: tests are enabled and cmocka is required and tests are disabled and cmocka is not required. We could soften this by using a feature option which has a tristate: `auto`, `enabled` and `disabled`. TODO: Add `not_found_message` to cmocka dependency File meson_options.txt: https://review.coreboot.org/c/flashrom/+/63832/comment/853b8ee1_1c0ababa PS1, Line 45: and run > I think tests will only be run via `meson test`, so this option only controls whether they're built […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 08:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022