April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: cli_classic: add writeprotect CLI
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58738 ) Change subject: cli_classic: add writeprotect CLI ...................................................................... Patch Set 77: (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58738/comment/80a3b817_b093abd0 PS77, Line 10: You can add into commit message the patch is also updating manpage for new cli commands. https://review.coreboot.org/c/flashrom/+/58738/comment/3e369d60_08a6a4dd PS77, Line 14: --wp-{enable,disable,range,list,status} There is also --wp-region command, you probably tested it too? File cli_classic.c: https://review.coreboot.org/c/flashrom/+/58738/comment/fd674d56_969c7934 PS77, Line 274: likley Typo: likley -> likely https://review.coreboot.org/c/flashrom/+/58738/comment/14c0b4ed_51080cc8 PS77, Line 493: uint32_t wp_start = 0, wp_len = 0; Maybe move it above next to other wp variables? Between #471 and #472 for example. https://review.coreboot.org/c/flashrom/+/58738/comment/5bd64738_4ba7f776 PS77, Line 770: case OPTION_WP_SET_REGION: Is there a reason why OPTION_WP_SET_REGION comes last in the switch, and not next to all other WP options? https://review.coreboot.org/c/flashrom/+/58738/comment/4669960f_18c8a54f PS77, Line 985: disable_wp Just to double-check: can disable_wp run together with set_wp_range or set_wp_region? -- To view, visit https://review.coreboot.org/c/flashrom/+/58738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I499f521781ee8999921996517802c0c0c641d869 Gerrit-Change-Number: 58738 Gerrit-PatchSet: 77 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 23:44:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: raiden_debug_spi.c: Allow custom_rst param value of 'false'
by Edward O'Callaghan (Code Review) 12 Apr '22

12 Apr '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63601 ) Change subject: raiden_debug_spi.c: Allow custom_rst param value of 'false' ...................................................................... raiden_debug_spi.c: Allow custom_rst param value of 'false' As identified while documenting driver, allow for passing 'false' even though it is the default for custom_rst to be consistent. BUG=b:224358254 TEST=builds Change-Id: I25bfe6f8e3f7cfffb1a9c99ac90ec56a750d7f84 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M raiden_debug_spi.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/63601/1 diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 3f35552..e37c313 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -1414,6 +1414,8 @@ if (custom_rst_str) { if (!strcasecmp(custom_rst_str, "true")) ap_request = RAIDEN_DEBUG_SPI_REQ_ENABLE_AP_CUSTOM; + else if (!strcasecmp(custom_rst_str, "false")) + ap_request = RAIDEN_DEBUG_SPI_REQ_ENABLE_AP; else { msg_perr("Invalid custom rst param: %s\n", custom_rst_str); -- To view, visit https://review.coreboot.org/c/flashrom/+/63601 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25bfe6f8e3f7cfffb1a9c99ac90ec56a750d7f84 Gerrit-Change-Number: 63601 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: platform.h: remove const from forward declarations
by Angel Pons (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63585 ) Change subject: platform.h: remove const from forward declarations ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea26d75719ebb718203dbba883ac88f459c68c0a Gerrit-Change-Number: 63585 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 23:28:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add voltage data to chips without that
by Ao Zhong (Code Review) 12 Apr '22

12 Apr '22

Ao Zhong has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63596 ) Change subject: Add voltage data to chips without that ...................................................................... Add voltage data to chips without that Eon EN25Q128 Datasheet: https://www.netcheif.com/Reviews/DSL-7850U/pdf/EN25Q128.pdf Intel 28F002BC/BL/BV/BX-T Datasheet: https://datasheet.octopart.com/E28F002BC-T80-Intel-datasheet-111286.pdf Intel 28F004B5/BE/BV/BX-B Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F200B5_IntelCorporation.pdf Intel 28F004B5/BE/BV/BX-T Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F200B5_IntelCorporation.pdf Intel 28F008S3/S5/SC Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F004S3_IntelCorporation.pdf Datasheet: https://www.digchip.com/datasheets/download_datasheet.php?id=38424&part-num… Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F004SC_IntelCorporation.pdf Intel 28F400BV/BX/CE/CV-B Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F400BX-TB_IntelCorporation.p… Intel 28F400BV/BX/CE/CV-T Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F400BV-TB_IntelCorporation.p… Micron/Numonyx/ST M25P40-old Datasheet: https://www.farnell.com/datasheets/40267.pdf SyncMOS/MoselVitelic {F,S,V}29C51002B Datasheet: https://cdn.datasheetspdf.com/pdf-down/F/2/9/F29C51002T_SyncMOS.pdf SyncMOS/MoselVitelic {F,S,V}29C51002T Datasheet: https://cdn.datasheetspdf.com/pdf-down/F/2/9/F29C51002T_SyncMOS.pdf Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 Datasheet: https://tz.micro-semiconductor.hk/datasheet/fb-W29EE011P90Z.pdf Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old Datasheet: http://www.romservice.ru/datashee/W29C010.PDF Signe-by: Ao Zhong <hacc1225(a)gmail.com> Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e --- M flashchips.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/63596/1 diff --git a/flashchips.c b/flashchips.c index 3224142..5e7934c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -4953,6 +4953,7 @@ .unlock = spi_disable_blockprotect, .write = spi_chip_write_256, .read = spi_chip_read, + .voltage = {2700, 3600}, }, { @@ -8112,6 +8113,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8139,6 +8141,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8166,6 +8169,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8189,6 +8193,7 @@ .unlock = unlock_28f004s5, .write = write_82802ab, .read = read_memmapped, + .voltage = {3000, 3600}, }, { @@ -8217,6 +8222,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8245,6 +8251,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -10521,6 +10528,7 @@ .unlock = spi_disable_blockprotect_bp3_srwd, .write = spi_chip_write_256, .read = spi_chip_read, + .voltage = {2700, 3600}, }, { @@ -16884,6 +16892,7 @@ }, .write = write_jedec_1, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -16910,6 +16919,7 @@ }, .write = write_jedec_1, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -18535,6 +18545,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -18558,6 +18569,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/63596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e Gerrit-Change-Number: 63596 Gerrit-PatchSet: 1 Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ichspi: Add support for Ice Lake
by Nico Huber (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63584 ) Change subject: ichspi: Add support for Ice Lake ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63584/comment/24f32b8d_06d1de4e PS1, Line 7: ichspi: Add support for Ice Lake > > Technically, it's already supported. Why do we need to do more than […] As discussed during review of the first of these patches, adding all the clutter that a new enum entry brings with it is wrong and should be fixed. They were only merged because Edwards said he could look into it later. Most of what these patches do needs to be undone even- tually. I assume this work (to check that the existing 300-series code behaves the same) was already done for Ice Lake. Just without the noise people make in other patches. File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/63584/comment/88b9d8dc_2c2850b1 PS1, Line 2149: 0x34a4 > > Is the SPI device guaranteed not to be hidden on Ice Lake? […] But can it be hidden? Maybe not everybody have updated their code to comply with the changed FAS. The safest way, IMO, would be to add the SPI controller ID and leave the entry with the PCH ID as is. This way, it can't regress in case there is a device with that ID and hidden SPI controller. -- To view, visit https://review.coreboot.org/c/flashrom/+/63584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If000b152c6e454617a7ad0245d16f8b1dea97fa0 Gerrit-Change-Number: 63584 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Apr 2022 14:06:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add support for Ice Lake
by Subrata Banik (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63584 ) Change subject: ichspi: Add support for Ice Lake ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63584/comment/c150f82c_0f65d131 PS1, Line 7: ichspi: Add support for Ice Lake > Technically, it's already supported. Why do we need to do more than > changing the PCI ID? Apart from adding PCH DID (instead of SPI DID), i don't see ICL support is added, compared to some recent work being done with CB:62783, CB:62282 and CB:62251 for other Intel chipsets. File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/63584/comment/436cc48c_aeb59c44 PS1, Line 2149: 0x34a4 > Is the SPI device guaranteed not to be hidden on Ice Lake? yes, SPI controller is visible on ICL. FAS doesn't specifies any restriction of hiding the SPI controller. -- To view, visit https://review.coreboot.org/c/flashrom/+/63584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If000b152c6e454617a7ad0245d16f8b1dea97fa0 Gerrit-Change-Number: 63584 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Apr 2022 13:53:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: remove const from forward declarations
by Thomas Heijligen (Code Review) 12 Apr '22

12 Apr '22

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63585 ) Change subject: platform.h: remove const from forward declarations ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63585/comment/f6346e17_0fcef8a4 PS1, Line 8: > Please add some reasoning, not every developer knows this, e.g. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/63585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea26d75719ebb718203dbba883ac88f459c68c0a Gerrit-Change-Number: 63585 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 13:48:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: remove const from forward declarations
by Thomas Heijligen (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Thomas Heijligen. Hello Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63585 to look at the new patch set (#2). Change subject: platform.h: remove const from forward declarations ...................................................................... platform.h: remove const from forward declarations A `const` on the parameter itself is irrelevant to the caller. Change-Id: Iea26d75719ebb718203dbba883ac88f459c68c0a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M platform.h 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/63585/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea26d75719ebb718203dbba883ac88f459c68c0a Gerrit-Change-Number: 63585 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Add support for Ice Lake
by Nico Huber (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63584 ) Change subject: ichspi: Add support for Ice Lake ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63584/comment/b0df2f89_e377a109 PS1, Line 7: ichspi: Add support for Ice Lake Technically, it's already supported. Why do we need to do more than changing the PCI ID? File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/63584/comment/af74a6aa_e86969fc PS1, Line 2149: 0x34a4 Is the SPI device guaranteed not to be hidden on Ice Lake? -- To view, visit https://review.coreboot.org/c/flashrom/+/63584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If000b152c6e454617a7ad0245d16f8b1dea97fa0 Gerrit-Change-Number: 63584 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Apr 2022 13:37:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: remove const from forward declarations
by Nico Huber (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63585 ) Change subject: platform.h: remove const from forward declarations ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63585/comment/d892c130_509c107d PS1, Line 8: Please add some reasoning, not every developer knows this, e.g. A `const` on the parameter itself is irrelevant to the caller. -- To view, visit https://review.coreboot.org/c/flashrom/+/63585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea26d75719ebb718203dbba883ac88f459c68c0a Gerrit-Change-Number: 63585 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 13:26:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022