April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: hwaccess: replace macros by C code
by Nico Huber (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62898 ) Change subject: hwaccess: replace macros by C code ...................................................................... Patch Set 10: Code-Review+2 (1 comment) Patchset: PS2: > I've mixed a little bit around with macros and inline functions. […] Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/62898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I86d38d816b37c283279c485fac8027f8fb94364a Gerrit-Change-Number: 62898 Gerrit-PatchSet: 10 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 09:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Add raiden_debug_spi doc entry
by Nico Huber (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Felix Singer, Martin Roth, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62768 ) Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ...................................................................... Patch Set 4: (4 comments) Patchset: PS4: Edward, it's nice that you want to document things. But please don't make the reviewers do all the work. File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/62768/comment/064ed08c_b85c2e3b PS3, Line 1166: false > It was suggested in review to document like this, it actually works by matching "true" otherwise the […] ``` $ ./flashrom -p raiden_debug_spi:target=ap,custom_rst=false flashrom v1.2-682-gb94a5a21c on Linux 5.16.13-arch1-1 (x86_64) flashrom is free software, get the source code at https://flashrom.org Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Invalid custom rst param: false Raiden target: -1 Error: Programmer initialization failed. ``` File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/62768/comment/04d0a182_3b1cd0e7 PS4, Line 1141: must be specified The code looks like it explicitly sends RAIDEN_DEBUG_SPI_REQ_ENABLE if no `target` was specified. What does it do? should it bail out instead? https://review.coreboot.org/c/flashrom/+/62768/comment/594ad59e_c0a24642 PS4, Line 1168: parameter changes the timeout value from 3ms to 10ms. This is only applicable to `target=ap` AFAICS. -- To view, visit https://review.coreboot.org/c/flashrom/+/62768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4 Gerrit-Change-Number: 62768 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 09:22:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_msr: rename msr function to msr_xxx
by Thomas Heijligen (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62851 ) Change subject: hwaccess_x86_msr: rename msr function to msr_xxx ...................................................................... Patch Set 4: (1 comment) File hwaccess_x86_msr.c: https://review.coreboot.org/c/flashrom/+/62851/comment/c3c41f3e_4d239b2f PS4, Line 302: * DirectHW has identical, but conflicting typedef for msr_t. We redefine msr_t > If it's identical, couldn't we just cast from one type to the other? I wasn't able to do so. Maybe there is a trick I didn't know. That's the way that I found working. -- To view, visit https://review.coreboot.org/c/flashrom/+/62851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4 Gerrit-Change-Number: 62851 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 09:03:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_msr: rename msr function to msr_xxx
by Nico Huber (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62851 ) Change subject: hwaccess_x86_msr: rename msr function to msr_xxx ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62851/comment/98eba5e1_dcba55f3 PS3, Line 10: na understan*d*able File hwaccess_x86_msr.c: https://review.coreboot.org/c/flashrom/+/62851/comment/cc0934e8_011cd73f PS4, Line 302: * DirectHW has identical, but conflicting typedef for msr_t. We redefine msr_t If it's identical, couldn't we just cast from one type to the other? -- To view, visit https://review.coreboot.org/c/flashrom/+/62851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4 Gerrit-Change-Number: 62851 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 08:44:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add Jasper Lake support
by Subrata Banik (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 ) Change subject: ichspi: Add Jasper Lake support ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib942d0b8942fe0a991b2af0b187414818485153d Gerrit-Change-Number: 62282 Gerrit-PatchSet: 12 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 05:31:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add -W options from Makefile into meson warning_flags
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58561 ) Change subject: Add -W options from Makefile into meson warning_flags ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > Meson has build-in support for warnings. Maybe it's better to use them. […] Official doc do not explain what exactly each warning level is doing :\ But I found info here: https://github.com/mesonbuild/meson/issues/3275 Quote: * warning_level 1 adds `-Wall`, -warning_level 2 adds warning_level 1 + `-Wextra`, * warning_level 3 adds warning_level 2 + `-Wpedantic` Looks like warning_level was actually what we want (corresponding to makefile). So for this patch, I added two remaining options that were missing in comparison with makefile. PS2: > Maybe we can combine Werror with the buildtype? I was thinking to use werror option (it is mentioned here https://mesonbuild.com/Builtin-options.html#core-options) but I wanted to do it in a separate patch. I will try and see how it goes. -- To view, visit https://review.coreboot.org/c/flashrom/+/58561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25 Gerrit-Change-Number: 58561 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 05:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Mark all static functions as static
by Felix Singer (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63571 ) Change subject: tests: Mark all static functions as static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic54da5ac1b2a46f55e3e3bee4ed952bdf59e8444 Gerrit-Change-Number: 63571 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Apr 2022 05:21:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors_tool: Fix -Wsign-compare warnings
by Felix Singer (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63488 ) Change subject: ich_descriptors_tool: Fix -Wsign-compare warnings ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1f9325e9cf89f57f18d63cc3906a0958b47286d7 Gerrit-Change-Number: 63488 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Apr 2022 05:21:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add and include headers with function prototypes
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63489 ) Change subject: tests: Add and include headers with function prototypes ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63489/comment/3823e819_dc519eaa PS1, Line 10: and makefile. > Please explain which warnings are fixed. I added info about which exactly warnings, but please tell me if this is not sufficient. File tests/chip.c: https://review.coreboot.org/c/flashrom/+/63489/comment/39eaa1d0_a6a94e31 PS1, Line 50: static > The scope is set by the commit message. So currently Angel seems right, […] I separated CB:63571 for making static functions static (previous in the chain). This patch now takes care of non-static functions. I mark this as resolved? -- To view, visit https://review.coreboot.org/c/flashrom/+/63489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia1ff22deb2354569f277649c6575ef2d5ffbb6e0 Gerrit-Change-Number: 63489 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 05:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors_tool: Fix -Wsign-compare warnings
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63488 ) Change subject: ich_descriptors_tool: Fix -Wsign-compare warnings ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63488/comment/47b6d8a2_32bfe1e7 PS1, Line 10: and makefile. > Please explain which warnings are fixed. I think it is done, but tell me if I misunderstood you. File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/63488/comment/a159e0ab_a7b96541 PS1, Line 87: uint32_t > NB. Using write(2) like this is not correct because it can be interrupted […] I tried to combine all suggestions together. So ret is now `const ssize_t`. One thing I haven't done: variable declarations at the beginning of the method, because it can't go together with const. A question of using write(3) instead of write(2) looks like a good candidate to be a first ticket! I will create it when I can :) https://review.coreboot.org/c/flashrom/+/63488/comment/e7434ff1_c904c15f PS1, Line 270: uint32_t > There's no need to use a fixed-width type here. Please use `size_t` instead. Done thank you! I think I treated warning in a very literal way. -- To view, visit https://review.coreboot.org/c/flashrom/+/63488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1f9325e9cf89f57f18d63cc3906a0958b47286d7 Gerrit-Change-Number: 63488 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 05:10:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022