April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: cli_classic: add writeprotect CLI and update man page
by Nikolai Artemiev (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58738 ) Change subject: cli_classic: add writeprotect CLI and update man page ...................................................................... Patch Set 78: (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/58738/comment/e1ffb56c_142c6dc4 PS78, Line 518: 1 > One thing I noticed, wp-range used to have "required_argument" and now it's "1"? Is this intentional […] Yep, I changed it to be consistent with the other commands since `required_argument == 1`. -- To view, visit https://review.coreboot.org/c/flashrom/+/58738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I499f521781ee8999921996517802c0c0c641d869 Gerrit-Change-Number: 58738 Gerrit-PatchSet: 78 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 03:45:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: add writeprotect CLI and update man page
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58738 ) Change subject: cli_classic: add writeprotect CLI and update man page ...................................................................... Patch Set 78: Code-Review+1 (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/58738/comment/c66f2682_40d39298 PS78, Line 518: 1 One thing I noticed, wp-range used to have "required_argument" and now it's "1"? Is this intentional? -- To view, visit https://review.coreboot.org/c/flashrom/+/58738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I499f521781ee8999921996517802c0c0c641d869 Gerrit-Change-Number: 58738 Gerrit-PatchSet: 78 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 03:29:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flash: move nested struct to top level
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Edward O'Callaghan, Tom Hughes. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62999 ) Change subject: flash: move nested struct to top level ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: And also same comment: why C++ ? -- To view, visit https://review.coreboot.org/c/flashrom/+/62999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I89988e4a6a7ca65866ba019320e480e491389d56 Gerrit-Change-Number: 62999 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 03:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: layout: space needed between literal and identifier
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Edward O'Callaghan, Tom Hughes. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63000 ) Change subject: layout: space needed between literal and identifier ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I just now read the comment in https://review.coreboot.org/c/flashrom/+/63001 I have to admit, I also want to understand, why C++ ? -- To view, visit https://review.coreboot.org/c/flashrom/+/63000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f5572d6c2dc27b7c54ee6ee97874a7a1940229 Gerrit-Change-Number: 63000 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 03:13:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: add writeprotect CLI and update man page
by Nikolai Artemiev (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58738 ) Change subject: cli_classic: add writeprotect CLI and update man page ...................................................................... Patch Set 77: (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58738/comment/4e8652ee_bc39b79c PS77, Line 10: > You can add into commit message the patch is also updating manpage for new cli commands. Done https://review.coreboot.org/c/flashrom/+/58738/comment/21673712_828e045e PS77, Line 14: --wp-{enable,disable,range,list,status} > There is also --wp-region command, you probably tested it too? I think I've tested it before, but to be sure I retested with a W25Q128.W flash and a simple layout file: ``` 0:0x7fffff a 0:0x3fffff b ``` File cli_classic.c: https://review.coreboot.org/c/flashrom/+/58738/comment/10f089cf_7e560f24 PS77, Line 274: likley > Typo: likley -> likely Done https://review.coreboot.org/c/flashrom/+/58738/comment/bd76781e_77258a30 PS77, Line 493: uint32_t wp_start = 0, wp_len = 0; > Maybe move it above next to other wp variables? […] Done https://review.coreboot.org/c/flashrom/+/58738/comment/8df93538_18eea96d PS77, Line 770: case OPTION_WP_SET_REGION: > Is there a reason why OPTION_WP_SET_REGION comes last in the switch, and not next to all other WP op […] Done https://review.coreboot.org/c/flashrom/+/58738/comment/db0a5d5d_fd41fe7a PS77, Line 985: disable_wp > Just to double-check: can disable_wp run together with set_wp_range or set_wp_region? Yep, they can run together since they're modifying different protection settings. -- To view, visit https://review.coreboot.org/c/flashrom/+/58738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I499f521781ee8999921996517802c0c0c641d869 Gerrit-Change-Number: 58738 Gerrit-PatchSet: 77 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 03:13:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: add writeprotect CLI and update man page
by Nikolai Artemiev (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58738 to look at the new patch set (#78). Change subject: cli_classic: add writeprotect CLI and update man page ...................................................................... cli_classic: add writeprotect CLI and update man page Tested with: GD25LQ128, GD25Q32, GD25Q256. BUG=b:195381327,b:153800563 BRANCH=none TEST=flashrom -{r,w,E} TEST=flashrom --wp-{enable,disable,range,region,list,status} Change-Id: I499f521781ee8999921996517802c0c0c641d869 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M cli_classic.c M flashrom.8.tmpl 2 files changed, 347 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/58738/78 -- To view, visit https://review.coreboot.org/c/flashrom/+/58738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I499f521781ee8999921996517802c0c0c641d869 Gerrit-Change-Number: 58738 Gerrit-PatchSet: 78 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flash: move nested struct to top level
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Edward O'Callaghan, Tom Hughes. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62999 ) Change subject: flash: move nested struct to top level ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62999/comment/dd652730_b382e85a PS1, Line 8: : The nested "struct tested" struct is "struct flashchip::tested" in C++. : Move "struct tested" to the top level namespace to avoid this : difference when using the "TEST_" macros that cast to "struct tested". If you could be more specific on what exactly the problem this patch is solving? What does it mean "to avoid this difference"? https://review.coreboot.org/c/flashrom/+/62999/comment/180b04cd_19d2705f PS1, Line 14: TEST=emerge-hatch flashrom You need to add info how you tested in upstream tree (emerge-hatch is not upstream). For example, did you build with make? did you run unit tests? File flash.h: https://review.coreboot.org/c/flashrom/+/62999/comment/d04331f7_38f27da6 PS1, Line 157: Indicate how well flashrom supports different operations of this flash chip. This comment now duplicates for struct type and below. I think it is fine to leave it below (where it was originally). But here, you need a different comment: describe what enum means? -- To view, visit https://review.coreboot.org/c/flashrom/+/62999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I89988e4a6a7ca65866ba019320e480e491389d56 Gerrit-Change-Number: 62999 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 03:02:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: layout: space needed between literal and identifier
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Edward O'Callaghan, Tom Hughes. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63000 ) Change subject: layout: space needed between literal and identifier ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63000/comment/18918a4e_02e3dba7 PS1, Line 14: TEST=emerge-hatch flashrom If you could test that pre-processor output is the same before and after, that would be perfect! Patchset: PS1: Sorry for delay File layout.h: https://review.coreboot.org/c/flashrom/+/63000/comment/34dd5de1_f357db30 PS1, Line 33: PRIxCHIPOFF I can't find usages of PRIxCHIPOFF and PRIuCHIPSIZE... what I am missing? Is there some concatenation somewhere that makes the usages hard to find? -- To view, visit https://review.coreboot.org/c/flashrom/+/63000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f5572d6c2dc27b7c54ee6ee97874a7a1940229 Gerrit-Change-Number: 63000 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 02:53:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: raiden_debug_spi: Add more informative error message when WP is enabled
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Robert Zieba, Nico Huber, Diana Zigterman, Edward O'Callaghan, Karthik Ramasubramanian. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62909 ) Change subject: raiden_debug_spi: Add more informative error message when WP is enabled ...................................................................... Patch Set 3: Code-Review+1 (4 comments) File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/62909/comment/dfd31704_1326f1c4 PS3, Line 987: trailing space https://review.coreboot.org/c/flashrom/+/62909/comment/5149acf3_9dcd3477 PS3, Line 987: /* Check if we received an error from the device. An error will have no response : data, just the packet_id and status_code. */ We follow coding style https://www.flashrom.org/Development_Guidelines#Coding_style which is for the multi-line comment like this would be /* * Check if we received an error from the device. An error will have no response * data, just the packet_id and status_code. */ Keep an eye to remove all trailing spaces, they often sneak in after first /* https://review.coreboot.org/c/flashrom/+/62909/comment/5a323ab7_8f3de752 PS3, Line 989: trailing space https://review.coreboot.org/c/flashrom/+/62909/comment/eefb8852_1da803bc PS3, Line 990: sizeof(struct usb_spi_response_v2) - USB_SPI_PAYLOAD_SIZE_V2_RESPONSE && : rsp_config.packet_v2.rsp_start.status_code != USB_SPI_SUCCESS) { Could you please add one more tab before these two lines? It would be easier to visually distinguish between if condition and body. There is another if condition just above this one, which uses the same formatting approach. -- To view, visit https://review.coreboot.org/c/flashrom/+/62909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1e8383baa9c3ea41ab1079af12e3dc8cdff90ae Gerrit-Change-Number: 62909 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 02:28:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Drop unused `_pprint_reg` macro
by Anastasia Klimchuk (Code Review) 12 Apr '22

12 Apr '22

Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63549 ) Change subject: ichspi: Drop unused `_pprint_reg` macro ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/63549 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee7a23447de38423b61008b3242d28ce553ae0a2 Gerrit-Change-Number: 63549 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 01:43:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022