April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62833 ) Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... print_buildinfo: remove unreachable print of libpci version The libpci header is neither directly nor indirectly included in flashrom.c. `PCILIB_VERSION` is therefore never set and the following print statement is dead code. Since libpci is the only library in buildinfo, Drop it. Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62833 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M flashrom.c 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/flashrom.c b/flashrom.c index ac61259..51a9fbe 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1646,13 +1646,6 @@ void print_buildinfo(void) { msg_gdbg("flashrom was built with"); -#if NEED_PCI == 1 -#ifdef PCILIB_VERSION - msg_gdbg(" libpci %s,", PCILIB_VERSION); -#else - msg_gdbg(" unknown PCI library,"); -#endif -#endif #ifdef __clang__ msg_gdbg(" LLVM Clang"); #ifdef __clang_version__ 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: Makefile: build shared usb code only when needed by programmer
by Thomas Heijligen (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Nico Huber, Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62832 ) Change subject: Makefile: build shared usb code only when needed by programmer ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Need review on how to build common code which is used by multiple programmer -- To view, visit https://review.coreboot.org/c/flashrom/+/62832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9a91c5801a573e7021686a183a1bd874122e35cc Gerrit-Change-Number: 62832 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 11:30:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: NEED_PCI: remove macro
by Thomas Heijligen (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62834 to look at the new patch set (#5). Change subject: NEED_PCI: remove macro ...................................................................... NEED_PCI: remove macro The NEED_PCI macro is only used to guard prototypes. This is not needed. Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M meson.build M programmer.h 3 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/62834/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/62834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Gerrit-Change-Number: 62834 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: hwaccess_x86_msr: rename msr function to msr_xxx
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62851 ) Change subject: hwaccess_x86_msr: rename msr function to msr_xxx ...................................................................... hwaccess_x86_msr: rename msr function to msr_xxx This eliminates the need to redefine the rdmsr and wrmsr symbols, resulting in more understandable code. The common prefix clarify the relation between the functions. Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62851 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M board_enable.c M chipset_enable.c M hwaccess_x86_msr.c M hwaccess_x86_msr.h 4 files changed, 64 insertions(+), 61 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index 9e4ab93..d740806 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1310,10 +1310,10 @@ unsigned long boot_loc; /* Geode only has a single core */ - if (setup_cpu_msr(0)) + if (msr_setup(0)) return -1; - msr = rdmsr(DBE6x_MSR_DIVIL_BALL_OPTS); + msr = msr_read(DBE6x_MSR_DIVIL_BALL_OPTS); if ((msr.lo & (DBE6x_BOOT_OP_LATCHED)) == (DBE6x_BOOT_LOC_FWHUB << DBE6x_BOOT_OP_LATCHED_SHIFT)) @@ -1325,9 +1325,9 @@ msr.lo |= ((boot_loc << DBE6x_PRI_BOOT_LOC_SHIFT) | (boot_loc << DBE6x_SEC_BOOT_LOC_SHIFT)); - wrmsr(DBE6x_MSR_DIVIL_BALL_OPTS, msr); + msr_write(DBE6x_MSR_DIVIL_BALL_OPTS, msr); - cleanup_cpu_msr(); + msr_cleanup(); return 0; } diff --git a/chipset_enable.c b/chipset_enable.c index b050f64..27ab126 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1264,21 +1264,21 @@ msr_t msr; /* Geode only has a single core */ - if (setup_cpu_msr(0)) + if (msr_setup(0)) return -1; - msr = rdmsr(MSR_RCONF_DEFAULT); + msr = msr_read(MSR_RCONF_DEFAULT); if ((msr.hi >> 24) != 0x22) { msr.hi &= 0xfbffffff; - wrmsr(MSR_RCONF_DEFAULT, msr); + msr_write(MSR_RCONF_DEFAULT, msr); } - msr = rdmsr(MSR_NORF_CTL); + msr = msr_read(MSR_NORF_CTL); /* Raise WE_CS3 bit. */ msr.lo |= 0x08; - wrmsr(MSR_NORF_CTL, msr); + msr_write(MSR_NORF_CTL, msr); - cleanup_cpu_msr(); + msr_cleanup(); #undef MSR_RCONF_DEFAULT #undef MSR_NORF_CTL diff --git a/hwaccess_x86_msr.c b/hwaccess_x86_msr.c index 79cf2f8..1fbfa9e 100644 --- a/hwaccess_x86_msr.c +++ b/hwaccess_x86_msr.c @@ -41,7 +41,7 @@ static int fd_msr = -1; -msr_t rdmsr(int addr) +msr_t msr_read(int addr) { uint32_t buf[2]; msr_t msr = { 0xffffffff, 0xffffffff }; @@ -68,7 +68,7 @@ return msr; } -int wrmsr(int addr, msr_t msr) +int msr_write(int addr, msr_t msr) { uint32_t buf[2]; buf[0] = msr.lo; @@ -93,7 +93,7 @@ return 0; } -int setup_cpu_msr(int cpu) +int msr_setup(int cpu) { char msrfilename[64] = { 0 }; snprintf(msrfilename, sizeof(msrfilename), "/dev/cpu/%d/msr", cpu); @@ -114,7 +114,7 @@ return 0; } -void cleanup_cpu_msr(void) +void msr_cleanup(void) { if (fd_msr == -1) { msg_pinfo("No MSR initialized.\n"); @@ -127,14 +127,19 @@ fd_msr = -1; } #elif defined(__OpenBSD__) && defined (__i386__) /* This does only work for certain AMD Geode LX systems see amdmsr(4). */ +#include <stdlib.h> #include <stdint.h> #include <stdio.h> +#include <string.h> +#include <errno.h> +#include <fcntl.h> +#include <unistd.h> #include <sys/ioctl.h> #include <machine/amdmsr.h> static int fd_msr = -1; -msr_t rdmsr(int addr) +msr_t msr_read(int addr) { struct amdmsr_req args; @@ -154,7 +159,7 @@ return msr; } -int wrmsr(int addr, msr_t msr) +int msr_write(int addr, msr_t msr) { struct amdmsr_req args; @@ -170,7 +175,7 @@ return 0; } -int setup_cpu_msr(int cpu) +int msr_setup(int cpu) { char msrfilename[64] = { 0 }; snprintf(msrfilename, sizeof(msrfilename), "/dev/amdmsr"); @@ -190,7 +195,7 @@ return 0; } -void cleanup_cpu_msr(void) +void msr_cleanup(void) { if (fd_msr == -1) { msg_pinfo("No MSR initialized.\n"); @@ -222,7 +227,7 @@ static int fd_msr = -1; -msr_t rdmsr(int addr) +msr_t msr_read(int addr) { cpu_msr_args_t args; @@ -242,7 +247,7 @@ return msr; } -int wrmsr(int addr, msr_t msr) +int msr_write(int addr, msr_t msr) { cpu_msr_args_t args; @@ -258,7 +263,7 @@ return 0; } -int setup_cpu_msr(int cpu) +int msr_setup(int cpu) { char msrfilename[64] = { 0 }; snprintf(msrfilename, sizeof(msrfilename), "/dev/cpu%d", cpu); @@ -279,7 +284,7 @@ return 0; } -void cleanup_cpu_msr(void) +void msr_cleanup(void) { if (fd_msr == -1) { msg_pinfo("No MSR initialized.\n"); @@ -293,19 +298,41 @@ } #elif defined(__MACH__) && defined(__APPLE__) -/* rdmsr() and wrmsr() are provided by DirectHW which needs neither setup nor cleanup. */ -int setup_cpu_msr(int cpu) +/* + * DirectHW has identical, but conflicting typedef for msr_t. We redefine msr_t + * to directhw_msr_t for DirectHW. + * rdmsr() and wrmsr() are provided by DirectHW and need neither setup nor cleanup. + */ +#define msr_t directhw_msr_t +#include <DirectHW/DirectHW.h> +#undef msr_t + +msr_t msr_read(int addr) +{ + directhw_msr_t msr; + msr = rdmsr(addr); + return (msr_t){msr.hi, msr.lo}; +} + +int msr_write(int addr, msr_t msr) +{ + return wrmsr(addr, (directhw_msr_t){msr.hi, msr.lo}); +} + +int msr_setup(int cpu) { // Always succeed for now return 0; } -void cleanup_cpu_msr(void) +void msr_cleanup(void) { // Nothing, yet. } #elif defined(__LIBPAYLOAD__) -msr_t libpayload_rdmsr(int addr) +#include <arch/msr.h> + +msr_t msr_read(int addr) { msr_t msr; unsigned long long val = _rdmsr(addr); @@ -314,41 +341,41 @@ return msr; } -int libpayload_wrmsr(int addr, msr_t msr) +int msr_write(int addr, msr_t msr) { _wrmsr(addr, msr.lo | ((unsigned long long)msr.hi << 32)); return 0; } -int setup_cpu_msr(int cpu) +int msr_setup(int cpu) { return 0; } -void cleanup_cpu_msr(void) +void msr_cleanup(void) { } #else /* default MSR implementation */ -msr_t rdmsr(int addr) +msr_t msr_read(int addr) { msr_t ret = { 0xffffffff, 0xffffffff }; return ret; } -int wrmsr(int addr, msr_t msr) +int msr_write(int addr, msr_t msr) { return -1; } -int setup_cpu_msr(int cpu) +int msr_setup(int cpu) { msg_pinfo("No MSR support for your OS yet.\n"); return -1; } -void cleanup_cpu_msr(void) +void msr_cleanup(void) { // Nothing, yet. } diff --git a/hwaccess_x86_msr.h b/hwaccess_x86_msr.h index 4229b3b..eda007e 100644 --- a/hwaccess_x86_msr.h +++ b/hwaccess_x86_msr.h @@ -18,35 +18,11 @@ #include <stdint.h> -#if !(defined(__MACH__) && defined(__APPLE__)) && !defined(__FreeBSD__) && !defined(__FreeBSD_kernel__) && !defined(__DragonFly__) && !defined(__LIBPAYLOAD__) typedef struct { uint32_t hi, lo; } msr_t; -msr_t rdmsr(int addr); -int wrmsr(int addr, msr_t msr); -#endif -#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) -/* FreeBSD already has conflicting definitions for wrmsr/rdmsr. */ -#undef rdmsr -#undef wrmsr -#define rdmsr freebsd_rdmsr -#define wrmsr freebsd_wrmsr -typedef struct { uint32_t hi, lo; } msr_t; -msr_t freebsd_rdmsr(int addr); -int freebsd_wrmsr(int addr, msr_t msr); -#endif - -#if defined(__LIBPAYLOAD__) -#include <arch/io.h> -#include <arch/msr.h> -typedef struct { uint32_t hi, lo; } msr_t; -msr_t libpayload_rdmsr(int addr); -int libpayload_wrmsr(int addr, msr_t msr); -#undef rdmsr -#define rdmsr libpayload_rdmsr -#define wrmsr libpayload_wrmsr -#endif - -int setup_cpu_msr(int cpu); -void cleanup_cpu_msr(void); +msr_t msr_read(int addr); +int msr_write(int addr, msr_t msr); +int msr_setup(int cpu); +void msr_cleanup(void); #endif /* __HWACCESS_X86_MSR_H__ */ \ No newline at end of file 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/62851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4 Gerrit-Change-Number: 62851 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[master]: hwaccess: Add endianness converting deserialization functions
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31016 Change subject: hwaccess: Add endianness converting deserialization functions ...................................................................... hwaccess: Add endianness converting deserialization functions Add functions like uint32_t read_le32(const void *); Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M hwaccess.h 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/31016/1 diff --git a/hwaccess.h b/hwaccess.h index af7054b..5df4fc3 100644 --- a/hwaccess.h +++ b/hwaccess.h @@ -20,6 +20,7 @@ #ifndef __HWACCESS_H__ #define __HWACCESS_H__ 1 +#include <stdint.h> #include "platform.h" #if NEED_PCI == 1 @@ -109,6 +110,19 @@ #define le_to_cpu32 cpu_to_le32 #define le_to_cpu64 cpu_to_le64 +#define read_from(endianness, bits) \ +static inline uint##bits##_t read_##endianness##bits(const void *from) \ +{ \ + return le_to_cpu##bits(*(uint##bits##_t *)from); \ +} + +read_from(be, 8) +read_from(be, 16) +read_from(be, 32) +read_from(le, 8) +read_from(le, 16) +read_from(le, 32) + #if NEED_RAW_ACCESS == 1 #if IS_X86 -- To view, visit https://review.coreboot.org/c/flashrom/+/31016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452 Gerrit-Change-Number: 31016 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

6 32

Change in flashrom[master]: platform.h: remove const from forward declarations
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/63585 ) Change subject: platform.h: remove const from forward declarations ...................................................................... platform.h: remove const from forward declarations A `const` on the parameter itself is irrelevant to the caller. Change-Id: Iea26d75719ebb718203dbba883ac88f459c68c0a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/63585 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M platform.h 1 file changed, 16 insertions(+), 16 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/platform.h b/platform.h index adb2e73..4f2a4c1 100644 --- a/platform.h +++ b/platform.h @@ -77,27 +77,27 @@ uint##bits##_t name##bits (const uint##bits##_t value) { return swap##bits (value); } /* convert cpu native endian to little endian */ -uint8_t cpu_to_le8 (const uint8_t value); -uint16_t cpu_to_le16(const uint16_t value); -uint32_t cpu_to_le32(const uint32_t value); -uint64_t cpu_to_le64(const uint64_t value); +uint8_t cpu_to_le8 (uint8_t value); +uint16_t cpu_to_le16(uint16_t value); +uint32_t cpu_to_le32(uint32_t value); +uint64_t cpu_to_le64(uint64_t value); /* convert cpu native endian to big endian */ -uint8_t cpu_to_be8 (const uint8_t value); -uint16_t cpu_to_be16(const uint16_t value); -uint32_t cpu_to_be32(const uint32_t value); -uint64_t cpu_to_be64(const uint64_t value); +uint8_t cpu_to_be8 (uint8_t value); +uint16_t cpu_to_be16(uint16_t value); +uint32_t cpu_to_be32(uint32_t value); +uint64_t cpu_to_be64(uint64_t value); /* convert little endian to cpu native endian */ -uint8_t le_to_cpu8 (const uint8_t value); -uint16_t le_to_cpu16(const uint16_t value); -uint32_t le_to_cpu32(const uint32_t value); -uint64_t le_to_cpu64(const uint64_t value); +uint8_t le_to_cpu8 (uint8_t value); +uint16_t le_to_cpu16(uint16_t value); +uint32_t le_to_cpu32(uint32_t value); +uint64_t le_to_cpu64(uint64_t value); /* convert big endian to cpu native endian */ -uint8_t be_to_cpu8 (const uint8_t value); -uint16_t be_to_cpu16(const uint16_t value); -uint32_t be_to_cpu32(const uint32_t value); -uint64_t be_to_cpu64(const uint64_t value); +uint8_t be_to_cpu8 (uint8_t value); +uint16_t be_to_cpu16(uint16_t value); +uint32_t be_to_cpu32(uint32_t value); +uint64_t be_to_cpu64(uint64_t value); #endif /* !__PLATFORM_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/63585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea26d75719ebb718203dbba883ac88f459c68c0a Gerrit-Change-Number: 63585 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: hwaccess_x86_msr: rename msr function to msr_xxx
by Thomas Heijligen (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62851 ) Change subject: hwaccess_x86_msr: rename msr function to msr_xxx ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62851/comment/441a4f68_6f0d9f41 PS3, Line 10: na > understan*d*able Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4 Gerrit-Change-Number: 62851 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 11:03:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_msr: rename msr function to msr_xxx
by Thomas Heijligen (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62851 to look at the new patch set (#5). Change subject: hwaccess_x86_msr: rename msr function to msr_xxx ...................................................................... hwaccess_x86_msr: rename msr function to msr_xxx This eliminates the need to redefine the rdmsr and wrmsr symbols, resulting in more understandable code. The common prefix clarify the relation between the functions. Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M board_enable.c M chipset_enable.c M hwaccess_x86_msr.c M hwaccess_x86_msr.h 4 files changed, 64 insertions(+), 61 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/62851/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/62851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4 Gerrit-Change-Number: 62851 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: cli_classic: add writeprotect CLI and update man page
by Sergii Dmytruk (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58738 ) Change subject: cli_classic: add writeprotect CLI and update man page ...................................................................... Patch Set 78: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I499f521781ee8999921996517802c0c0c641d869 Gerrit-Change-Number: 58738 Gerrit-PatchSet: 78 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 09:26:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: Add optimisation level s into meson build
by Angel Pons (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63606 ) Change subject: meson: Add optimisation level s into meson build ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > I am not sure how much testing should I do for this patch? (in addition to running tests as usual). […] Does the resulting binary change? -- To view, visit https://review.coreboot.org/c/flashrom/+/63606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ca96a866529cac320e66516ef280d5100ceefab Gerrit-Change-Number: 63606 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022