April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: platform.h: rename swapX to ___swapX
by Angel Pons (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Idwer Vollering, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63612 ) Change subject: platform.h: rename swapX to ___swapX ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Hmmm, I remember reading something about names starting with underscores being special in the C spec. Could we use names that begin with something else instead? -- To view, visit https://review.coreboot.org/c/flashrom/+/63612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04d73967f694939c1127f48df8645a10e9dd66f3 Gerrit-Change-Number: 63612 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 13 Apr 2022 13:18:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: rename swapX to ___swapX
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Idwer Vollering, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63612 ) Change subject: platform.h: rename swapX to ___swapX ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04d73967f694939c1127f48df8645a10e9dd66f3 Gerrit-Change-Number: 63612 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 13 Apr 2022 11:49:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_msr: drop outdated comment
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62897 ) Change subject: hwaccess_x86_msr: drop outdated comment ...................................................................... hwaccess_x86_msr: drop outdated comment Change-Id: Ia361f7f3392b4f58a33f3e2d3b5f8f4340c388b3 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62897 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M hwaccess_x86_msr.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve diff --git a/hwaccess_x86_msr.c b/hwaccess_x86_msr.c index 1fbfa9e..98e51d4 100644 --- a/hwaccess_x86_msr.c +++ b/hwaccess_x86_msr.c @@ -17,7 +17,7 @@ */ /* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload - * and a non-working default implementation on the bottom. See also hwaccess.h for some (re)declarations. + * and a non-working default implementation on the bottom. */ #include "hwaccess_x86_msr.h" 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/62897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia361f7f3392b4f58a33f3e2d3b5f8f4340c388b3 Gerrit-Change-Number: 62897 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashrom.c: remove unused include
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/63412 ) Change subject: flashrom.c: remove unused include ...................................................................... flashrom.c: remove unused include getopt.h is only needed in cli_classic.c Change-Id: I09b3233a128582bc98c5af77b6c89bd49984800e Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/63412 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashrom.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/flashrom.c b/flashrom.c index 51a9fbe..7937885 100644 --- a/flashrom.c +++ b/flashrom.c @@ -30,7 +30,6 @@ #include <stdlib.h> #include <errno.h> #include <ctype.h> -#include <getopt.h> #if HAVE_UTSNAME == 1 #include <sys/utsname.h> #endif 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/63412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I09b3233a128582bc98c5af77b6c89bd49984800e Gerrit-Change-Number: 63412 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: Drop STANDALONE mode
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/63469 ) Change subject: Drop STANDALONE mode ...................................................................... Drop STANDALONE mode STANDALONE mode was used to build flashrom without having support for file handling. This was relevant to build libflashrom on top of libpayload. For a while now, the code which is covered by STANDALONE has moved to cli_*.c and is not used for libflashrom. Therefore we can drop STANDALONE mode. Change-Id: I58fb82270a9884a323d9850176708d230fdc5165 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/63469 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M Makefile M cli_classic.c M cli_output.c M flash.h M tests/meson.build 5 files changed, 2 insertions(+), 23 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved diff --git a/Makefile b/Makefile index 367d8ee..26c77d9 100644 --- a/Makefile +++ b/Makefile @@ -290,7 +290,6 @@ .DEFAULT_GOAL := libflashrom.a $(info Setting default goal to libflashrom.a) endif -FLASHROM_CFLAGS += -DSTANDALONE $(call mark_unsupported,CONFIG_DUMMY) # libpayload does not provide the romsize field in struct pci_dev that the atapromise code requires. $(call mark_unsupported,CONFIG_ATAPROMISE) diff --git a/cli_classic.c b/cli_classic.c index 0b6e79c..c543ff7 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -112,12 +112,10 @@ /* Ensure a file is open by means of fstat */ static bool check_file(FILE *file) { -#ifndef STANDALONE struct stat statbuf; if (fstat(fileno(file), &statbuf) < 0) return false; -#endif /* !STANDALONE */ return true; } @@ -279,9 +277,7 @@ char *referencefile = NULL; char *layoutfile = NULL; char *fmapfile = NULL; -#ifndef STANDALONE char *logfile = NULL; -#endif /* !STANDALONE */ char *tempstr = NULL; char *pparam = NULL; struct layout_include_args *include_args = NULL; @@ -481,9 +477,6 @@ exit(0); break; case 'o': -#ifdef STANDALONE - cli_classic_abort_usage("Log file not supported in standalone mode. Aborting.\n"); -#else /* STANDALONE */ if (logfile) { fprintf(stderr, "Warning: -o/--output specified multiple times.\n"); free(logfile); @@ -493,7 +486,6 @@ if (logfile[0] == '\0') { cli_classic_abort_usage("No log filename specified.\n"); } -#endif /* STANDALONE */ break; default: cli_classic_abort_usage(NULL); @@ -511,13 +503,10 @@ cli_classic_abort_usage(NULL); if (referencefile && check_filename(referencefile, "reference")) cli_classic_abort_usage(NULL); - -#ifndef STANDALONE if (logfile && check_filename(logfile, "log")) cli_classic_abort_usage(NULL); if (logfile && open_logfile(logfile)) cli_classic_abort_usage(NULL); -#endif /* !STANDALONE */ #if CONFIG_PRINT_WIKI == 1 if (list_supported_wiki) { @@ -532,9 +521,7 @@ goto out; } -#ifndef STANDALONE start_logging(); -#endif /* !STANDALONE */ print_buildinfo(); msg_gdbg("Command line (%i args):", argc - 1); @@ -808,9 +795,7 @@ /* clean up global variables */ free((char *)chip_to_probe); /* Silence! Freeing is not modifying contents. */ chip_to_probe = NULL; -#ifndef STANDALONE free(logfile); ret |= close_logfile(); -#endif /* !STANDALONE */ return ret; } diff --git a/cli_output.c b/cli_output.c index e12446d..629db67 100644 --- a/cli_output.c +++ b/cli_output.c @@ -24,7 +24,6 @@ enum flashrom_log_level verbose_screen = FLASHROM_MSG_INFO; enum flashrom_log_level verbose_logfile = FLASHROM_MSG_DEBUG2; -#ifndef STANDALONE static FILE *logfile = NULL; int close_logfile(void) @@ -64,7 +63,6 @@ print_version(); verbose_screen = oldverbose_screen; } -#endif /* !STANDALONE */ /* Please note that level is the verbosity, not the importance of the message. */ int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap) @@ -85,13 +83,13 @@ if (level != FLASHROM_MSG_SPEW) fflush(output_type); } -#ifndef STANDALONE + if ((level <= verbose_logfile) && logfile) { ret = vfprintf(logfile, fmt, logfile_args); if (level != FLASHROM_MSG_SPEW) fflush(logfile); } -#endif /* !STANDALONE */ + va_end(logfile_args); return ret; } diff --git a/flash.h b/flash.h index f63aa5d..b283c6c 100644 --- a/flash.h +++ b/flash.h @@ -442,11 +442,9 @@ /* cli_output.c */ extern enum flashrom_log_level verbose_screen; extern enum flashrom_log_level verbose_logfile; -#ifndef STANDALONE int open_logfile(const char * const filename); int close_logfile(void); void start_logging(void); -#endif int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap); /* Let gcc and clang check for correct printf-style format strings. */ int print(enum flashrom_log_level level, const char *fmt, ...) diff --git a/tests/meson.build b/tests/meson.build index 90e0df1..d3b46b1 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -102,7 +102,6 @@ cargs, '-ffunction-sections', '-fdata-sections', - # '-DSTANDALONE', ], export_dynamic : true, link_args : mocks, 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/63469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I58fb82270a9884a323d9850176708d230fdc5165 Gerrit-Change-Number: 63469 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: platform.h: rename swapX to ___swapX
by Thomas Heijligen (Code Review) 13 Apr '22

13 Apr '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63612 ) Change subject: platform.h: rename swapX to ___swapX ...................................................................... platform.h: rename swapX to ___swapX OpenBSD has conflicting definitions for swapX and __swapX. Change-Id: I04d73967f694939c1127f48df8645a10e9dd66f3 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M platform.h 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/63612/1 diff --git a/platform.h b/platform.h index cf73c29..d15082f 100644 --- a/platform.h +++ b/platform.h @@ -26,18 +26,19 @@ #include <stdint.h> /* swap bytes */ -static inline uint8_t swap8(const uint8_t value) +/* OpenBSD has conflicting definitions for swapX and __swapX */ +static inline uint8_t ___swap8(const uint8_t value) { return (value & (uint8_t)0xffU); } -static inline uint16_t swap16(const uint16_t value) +static inline uint16_t ___swap16(const uint16_t value) { return ((value & (uint16_t)0x00ffU) << 8) | ((value & (uint16_t)0xff00U) >> 8); } -static inline uint32_t swap32(const uint32_t value) +static inline uint32_t ___swap32(const uint32_t value) { return ((value & (uint32_t)0x000000ffUL) << 24) | ((value & (uint32_t)0x0000ff00UL) << 8) | @@ -45,7 +46,7 @@ ((value & (uint32_t)0xff000000UL) >> 24); } -static inline uint64_t swap64(const uint64_t value) +static inline uint64_t ___swap64(const uint64_t value) { return ((value & (uint64_t)0x00000000000000ffULL) << 56) | ((value & (uint64_t)0x000000000000ff00ULL) << 40) | @@ -72,10 +73,10 @@ * * `___return_swapped(cpu_to_be, 8)` * expands to - * `uint8_t cpu_to_be8 (const uint8_t value) { return swap8 (value); }` + * `uint8_t cpu_to_be8 (const uint8_t value) { return ___swap8 (value); }` */ #define ___return_swapped(name, bits) \ - uint##bits##_t name##bits (const uint##bits##_t value) { return swap##bits (value); } + uint##bits##_t name##bits (const uint##bits##_t value) { return ___swap##bits (value); } /* convert cpu native endian to little endian */ uint8_t cpu_to_le8 (uint8_t value); -- To view, visit https://review.coreboot.org/c/flashrom/+/63612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04d73967f694939c1127f48df8645a10e9dd66f3 Gerrit-Change-Number: 63612 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: NEED_PCI: remove macro
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62834 ) Change subject: NEED_PCI: remove macro ...................................................................... NEED_PCI: remove macro The NEED_PCI macro is only used to guard prototypes. This is not needed. Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62834 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M meson.build M programmer.h 3 files changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/Makefile b/Makefile index bfa9c67..367d8ee 100644 --- a/Makefile +++ b/Makefile @@ -838,7 +838,6 @@ USE_LIBPCI := $(if $(call filter_deps,$(DEPENDS_ON_LIBPCI)),yes,no) ifeq ($(USE_LIBPCI), yes) PROGRAMMER_OBJS += pcidev.o -FEATURE_FLAGS += -D'NEED_PCI=1' override CFLAGS += $(CONFIG_LIBPCI_CFLAGS) override LDFLAGS += $(CONFIG_LIBPCI_LDFLAGS) endif diff --git a/meson.build b/meson.build index 5a6bc2a..f8ca1d3 100644 --- a/meson.build +++ b/meson.build @@ -159,7 +159,6 @@ if get_option('pciutils') srcs += 'pcidev.c' deps += dependency('libpci') - cargs += '-DNEED_PCI=1' elif need_libpci error('pciutils is disabled but one or more enabled programmer requires PCI access') endif diff --git a/programmer.h b/programmer.h index 47d2dc3..86e45f7 100644 --- a/programmer.h +++ b/programmer.h @@ -115,7 +115,6 @@ unsigned int half_period; }; -#if NEED_PCI == 1 struct pci_dev; struct pci_filter; @@ -141,7 +140,6 @@ int rpci_write_byte(struct pci_dev *dev, int reg, uint8_t data); int rpci_write_word(struct pci_dev *dev, int reg, uint16_t data); int rpci_write_long(struct pci_dev *dev, int reg, uint32_t data); -#endif #if CONFIG_INTERNAL == 1 struct penable { 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/62834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Gerrit-Change-Number: 62834 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: NEED_PCI: remove macro
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62834 ) Change subject: NEED_PCI: remove macro ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Gerrit-Change-Number: 62834 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 11:35:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: NEED_PCI: remove macro
by Thomas Heijligen (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Nico Huber, Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62834 ) Change subject: NEED_PCI: remove macro ...................................................................... Patch Set 5: (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/62834/comment/1be42642_ac608e40 PS4, Line 265: > extraneous line change. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Gerrit-Change-Number: 62834 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 11:33:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62833 ) Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... print_buildinfo: remove unreachable print of libpci version The libpci header is neither directly nor indirectly included in flashrom.c. `PCILIB_VERSION` is therefore never set and the following print statement is dead code. Since libpci is the only library in buildinfo, Drop it. Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62833 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M flashrom.c 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/flashrom.c b/flashrom.c index ac61259..51a9fbe 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1646,13 +1646,6 @@ void print_buildinfo(void) { msg_gdbg("flashrom was built with"); -#if NEED_PCI == 1 -#ifdef PCILIB_VERSION - msg_gdbg(" libpci %s,", PCILIB_VERSION); -#else - msg_gdbg(" unknown PCI library,"); -#endif -#endif #ifdef __clang__ msg_gdbg(" LLVM Clang"); #ifdef __clang_version__ 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022