March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: pcidev: Move pci_dev_find() from internal to canonical place
by Edward O'Callaghan (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59280 to look at the new patch set (#4). Change subject: pcidev: Move pci_dev_find() from internal to canonical place ...................................................................... pcidev: Move pci_dev_find() from internal to canonical place BUG=b:220950271 TEST=```sudo ./flashrom -p internal -r /tmp/bios <snip> Found Programmer flash chip "Opaque flash chip" (16384 kB, Programmer-specific) mapped at physical address 0x0000000000000000. Reading flash... done. ``` Change-Id: Ie21f87699481a84398ca4450b3f03548f0528191 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M internal.c M pcidev.c M programmer.h 3 files changed, 13 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/59280/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/59280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie21f87699481a84398ca4450b3f03548f0528191 Gerrit-Change-Number: 59280 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: layout: Change signature for prepare_layout_for_extraction
by Nico Huber (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62554 ) Change subject: layout: Change signature for prepare_layout_for_extraction ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm not sure if I mentioned this somewhere already, the topic seems familiar. I kind of see this extract feature as CLI code. So one completely different solution would be to add an API to enumerate the regions of a layout, then in the CLI walk the regions and read each indvidually and save them to files. If we want to keep the current code, I suggest to add the new API in a separate header file, maybe even a separate library. So far, we have kept libflashrom free from file i/o and some target environments just don't support it. If we change that, careful separation could spare us some `#if` churn. -- To view, visit https://review.coreboot.org/c/flashrom/+/62554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7d3874d1097bb0d7bb8d9fa8e639cc1e71407627 Gerrit-Change-Number: 62554 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 04 Mar 2022 00:04:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pcidev: Move scandev_inclass logic from internal to pcidev
by Edward O'Callaghan (Code Review) 04 Mar '22

04 Mar '22

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/59277 ) Change subject: pcidev: Move scandev_inclass logic from internal to pcidev ...................................................................... pcidev: Move scandev_inclass logic from internal to pcidev BUG=b:220950271 TEST=```sudo ./flashrom -p internal -r /tmp/bios <snip> Found Programmer flash chip "Opaque flash chip" (16384 kB, Programmer-specific) mapped at physical address 0x0000000000000000. Reading flash... done. ``` Change-Id: I1978e178fb73485f1c5c7e732853522847267cee Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/59277 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M board_enable.c M chipset_enable.c M internal.c M mcp6x_spi.c M pcidev.c M programmer.h 6 files changed, 26 insertions(+), 26 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index 194357a..0ac522e 100644 --- a/board_enable.c +++ b/board_enable.c @@ -782,7 +782,7 @@ uint16_t base; uint8_t val, bit, offset; - dev = pci_dev_find_vendorclass(0x1106, 0x0601); + dev = pcidev_find_vendorclass(0x1106, 0x0601); switch (dev->device_id) { case 0x3177: /* VT8235 */ case 0x3227: /* VT8237/VT8237R */ @@ -1073,7 +1073,7 @@ } /* Check for the ISA bridge first. */ - dev = pci_dev_find_vendorclass(0x10DE, 0x0601); + dev = pcidev_find_vendorclass(0x10DE, 0x0601); switch (dev->device_id) { case 0x0030: /* CK804 */ case 0x0050: /* MCP04 */ diff --git a/chipset_enable.c b/chipset_enable.c index d9a1d3a..d4285a5 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -120,11 +120,11 @@ { struct pci_dev *sbdev; - sbdev = pci_dev_find_vendorclass(vendor, 0x0601); + sbdev = pcidev_find_vendorclass(vendor, 0x0601); if (!sbdev) - sbdev = pci_dev_find_vendorclass(vendor, 0x0680); + sbdev = pcidev_find_vendorclass(vendor, 0x0680); if (!sbdev) - sbdev = pci_dev_find_vendorclass(vendor, 0x0000); + sbdev = pcidev_find_vendorclass(vendor, 0x0000); if (!sbdev) msg_perr("No southbridge found for %s!\n", name); if (sbdev) diff --git a/internal.c b/internal.c index dcb83cd..7a326fc 100644 --- a/internal.c +++ b/internal.c @@ -34,25 +34,6 @@ enum chipbustype internal_buses_supported = BUS_NONE; -struct pci_dev *pci_dev_find_vendorclass(uint16_t vendor, uint16_t devclass) -{ - struct pci_dev *temp = NULL; - struct pci_filter filter; - uint16_t tmp2; - - pci_filter_init(NULL, &filter); - filter.vendor = vendor; - - while ((temp = pcidev_scandev(&filter, temp))) { - /* Read PCI class */ - tmp2 = pci_read_word(temp, 0x0a); - if (tmp2 == devclass) - return temp; - } - - return NULL; -} - struct pci_dev *pci_dev_find(uint16_t vendor, uint16_t device) { struct pci_filter filter; diff --git a/mcp6x_spi.c b/mcp6x_spi.c index 81ef1b5..d136be4 100644 --- a/mcp6x_spi.c +++ b/mcp6x_spi.c @@ -124,7 +124,7 @@ uint8_t mcp_gpiostate; /* Look for the SMBus device (SMBus PCI class) */ - smbusdev = pci_dev_find_vendorclass(0x10de, 0x0c05); + smbusdev = pcidev_find_vendorclass(0x10de, 0x0c05); if (!smbusdev) { if (want_spi) { msg_perr("ERROR: SMBus device not found. Not enabling " diff --git a/pcidev.c b/pcidev.c index 0f8c4e5..8b8b478 100644 --- a/pcidev.c +++ b/pcidev.c @@ -170,6 +170,25 @@ #endif } +struct pci_dev *pcidev_find_vendorclass(uint16_t vendor, uint16_t devclass) +{ + struct pci_dev *temp = NULL; + struct pci_filter filter; + uint16_t tmp2; + + pci_filter_init(NULL, &filter); + filter.vendor = vendor; + + while ((temp = pcidev_scandev(&filter, temp))) { + /* Read PCI class */ + tmp2 = pci_read_word(temp, PCI_CLASS_DEVICE); + if (tmp2 == devclass) + return temp; + } + + return NULL; +} + static int pcidev_shutdown(void *data) { if (pacc == NULL) { diff --git a/programmer.h b/programmer.h index d0e86a4..9305afb 100644 --- a/programmer.h +++ b/programmer.h @@ -127,6 +127,7 @@ struct pci_dev *pcidev_init(const struct dev_entry *devs, int bar); struct pci_dev *pcidev_scandev(struct pci_filter *filter, struct pci_dev *start); struct pci_dev *pcidev_getdevfn(struct pci_dev *dev, const int func); +struct pci_dev *pcidev_find_vendorclass(uint16_t vendor, uint16_t devclass); /* rpci_write_* are reversible writes. The original PCI config space register * contents will be restored on shutdown. * To clone the pci_dev instances internally, the `pacc` global @@ -260,7 +261,6 @@ #define SUPERIO_VENDOR_WINBOND 0x2 #endif #if NEED_PCI == 1 -struct pci_dev *pci_dev_find_vendorclass(uint16_t vendor, uint16_t devclass); struct pci_dev *pci_dev_find(uint16_t vendor, uint16_t device); struct pci_dev *pci_card_find(uint16_t vendor, uint16_t device, uint16_t card_vendor, uint16_t card_device); -- To view, visit https://review.coreboot.org/c/flashrom/+/59277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1978e178fb73485f1c5c7e732853522847267cee Gerrit-Change-Number: 59277 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: ichspi: Add Alder Lake support
by Nico Huber (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Sam McNally, Rizwan Qureshi, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 ) Change subject: ichspi: Add Alder Lake support ...................................................................... Patch Set 13: (2 comments) Patchset: PS12: > Probably best to start with a new enum and collapse down as a optimisation patch as a follow up rath […] I don't know what you mean exactly with `collapse down`. I sometimes try to optimize such things and then only after writing one or two alternative versions realize that it doesn't get any better overall. Saying it's hard to predict the result of future work. Also no idea what is half baked. So far we have kept compatible platforms together under one enum entry (with some exceptions, both false-positive and false-negatives, that slipped review). Breaking that pattern would seem inconsistent, or well, consistent with the inconsistency. File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/62251/comment/03f8a6de_7aef2101 PS12, Line 1041: return CHIPSET_600_SERIES_ALDER_POINT; > Please test the detection (easy to do with ich_descriptors_tool). For […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf Gerrit-Change-Number: 62251 Gerrit-PatchSet: 13 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 23:48:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom-media[master]: Add logo
by Felix Singer (Code Review) 03 Mar '22

03 Mar '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 ) Change subject: Add logo ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom-media/+/62572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom-media Gerrit-Branch: master Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88 Gerrit-Change-Number: 62572 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-MessageType: abandon

1 0

Change in flashrom-media[master]: Add logo
by Felix Singer (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 ) Change subject: Add logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Done I think please verify Awesome. Everything is there :) I will abandon this patch. -- To view, visit https://review.coreboot.org/c/flashrom-media/+/62572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom-media Gerrit-Branch: master Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88 Gerrit-Change-Number: 62572 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 23:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom-media[master]: Add logo
by Nico Huber (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Felix Singer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 ) Change subject: Add logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I meant the full history of the master branch, but if there are two than that, […] Done I think please verify -- To view, visit https://review.coreboot.org/c/flashrom-media/+/62572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom-media Gerrit-Branch: master Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88 Gerrit-Change-Number: 62572 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 22:57:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom-media[master]: Add logo
by Nico Huber (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Felix Singer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 ) Change subject: Add logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Not sure what you mean with "full history". […] I meant the full history of the master branch, but if there are two than that, I guess :) I'll try if I have enough rights to just push things. -- To view, visit https://review.coreboot.org/c/flashrom-media/+/62572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom-media Gerrit-Branch: master Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88 Gerrit-Change-Number: 62572 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 22:57:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom-media[master]: Add logo
by Felix Singer (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 ) Change subject: Add logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Should we import the full history instead? Not sure what you mean with "full history". I just looked at the repository again and saw that there are two branches. Maybe this? I asked Patrick to give me push rights for the repository so that I can create the other branch. -- To view, visit https://review.coreboot.org/c/flashrom-media/+/62572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom-media Gerrit-Branch: master Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88 Gerrit-Change-Number: 62572 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 22:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom-media[master]: Add logo
by Nico Huber (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Felix Singer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 ) Change subject: Add logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Should we import the full history instead? -- To view, visit https://review.coreboot.org/c/flashrom-media/+/62572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom-media Gerrit-Branch: master Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88 Gerrit-Change-Number: 62572 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 20:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022