Attention is currently required from: Sam McNally, Rizwan Qureshi, Edward O'Callaghan, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 )
Change subject: ichspi: Add Alder Lake support
......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS12:
> Probably best to start with a new enum and collapse down as a optimisation patch as a follow up rath […]
I don't know what you mean exactly with `collapse down`. I sometimes
try to optimize such things and then only after writing one or two
alternative versions realize that it doesn't get any better overall.
Saying it's hard to predict the result of future work.
Also no idea what is half baked. So far we have kept compatible
platforms together under one enum entry (with some exceptions,
both false-positive and false-negatives, that slipped review).
Breaking that pattern would seem inconsistent, or well, consistent
with the inconsistency.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62251/comment/03f8a6de_7aef2101
PS12, Line 1041: return CHIPSET_600_SERIES_ALDER_POINT;
> Please test the detection (easy to do with ich_descriptors_tool). For […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/62251
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf
Gerrit-Change-Number: 62251
Gerrit-PatchSet: 13
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 )
Change subject: Add logo
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/flashrom-media/+/62572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom-media
Gerrit-Branch: master
Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88
Gerrit-Change-Number: 62572
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-MessageType: abandon
Attention is currently required from: Nico Huber, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 )
Change subject: Add logo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Done I think please verify
Awesome. Everything is there :) I will abandon this patch.
--
To view, visit https://review.coreboot.org/c/flashrom-media/+/62572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom-media
Gerrit-Branch: master
Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88
Gerrit-Change-Number: 62572
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 )
Change subject: Add logo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I meant the full history of the master branch, but if there are two than that, […]
Done I think please verify
--
To view, visit https://review.coreboot.org/c/flashrom-media/+/62572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom-media
Gerrit-Branch: master
Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88
Gerrit-Change-Number: 62572
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 )
Change subject: Add logo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Not sure what you mean with "full history". […]
I meant the full history of the master branch, but if there are two than that,
I guess :) I'll try if I have enough rights to just push things.
--
To view, visit https://review.coreboot.org/c/flashrom-media/+/62572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom-media
Gerrit-Branch: master
Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88
Gerrit-Change-Number: 62572
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:57:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 )
Change subject: Add logo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Should we import the full history instead?
Not sure what you mean with "full history". I just looked at the repository again and saw that there are two branches. Maybe this?
I asked Patrick to give me push rights for the repository so that I can create the other branch.
--
To view, visit https://review.coreboot.org/c/flashrom-media/+/62572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom-media
Gerrit-Branch: master
Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88
Gerrit-Change-Number: 62572
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 )
Change subject: Add logo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Should we import the full history instead?
--
To view, visit https://review.coreboot.org/c/flashrom-media/+/62572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom-media
Gerrit-Branch: master
Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88
Gerrit-Change-Number: 62572
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:50:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom-media/+/62572 )
Change subject: Add logo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This adds the original commit from https://github.com/flashrom/flashrom-media
--
To view, visit https://review.coreboot.org/c/flashrom-media/+/62572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom-media
Gerrit-Branch: master
Gerrit-Change-Id: Ib15ba9643b9dc06d56b3f82367b59bcc13f8ae88
Gerrit-Change-Number: 62572
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment