March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: it87spi.c: Enable probing of IT8686E
by Angel Pons (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Nico Huber, Sea Wright. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62718 ) Change subject: it87spi.c: Enable probing of IT8686E ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/62718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f6fe582d9e50e66560b1c54be9a5fdd34584a93 Gerrit-Change-Number: 62718 Gerrit-PatchSet: 1 Gerrit-Owner: Sea Wright <menaechmi(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sea Wright <menaechmi(a)protonmail.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 22:21:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it87spi.c: Enable probing of IT8686E
by Sea Wright (Code Review) 09 Mar '22

09 Mar '22

Sea Wright has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62718 ) Change subject: it87spi.c: Enable probing of IT8686E ...................................................................... it87spi.c: Enable probing of IT8686E Enable probing for IT8686F to use the 'dualbiosindex' feature. Dumped and verified M_BIOS and B_BIOS. Tested on GIGABYTE GA-H270N-WIFI Change-Id: I7f6fe582d9e50e66560b1c54be9a5fdd34584a93 Signed-off-by: Sea Wright <menaechmi(a)protonmail.com> --- M it87spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/62718/1 diff --git a/it87spi.c b/it87spi.c index 728ec70..8f0d389 100644 --- a/it87spi.c +++ b/it87spi.c @@ -450,6 +450,7 @@ case 0x8705: ret |= it8705f_write_enable(superios[i].port); break; + case 0x8686: case 0x8716: case 0x8718: case 0x8720: -- To view, visit https://review.coreboot.org/c/flashrom/+/62718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f6fe582d9e50e66560b1c54be9a5fdd34584a93 Gerrit-Change-Number: 62718 Gerrit-PatchSet: 1 Gerrit-Owner: Sea Wright <menaechmi(a)protonmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips.c: Mark GD25Q40(B) as tested
by Nico Huber (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Felix Singer, Simon Buhrow, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62712 ) Change subject: flashchips.c: Mark GD25Q40(B) as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idec3d82efbdf095c3d57bfe5f0fd487007b554cb Gerrit-Change-Number: 62712 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Mar 2022 18:58:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Mark GD25Q40(B) as tested
by Angel Pons (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Felix Singer, Simon Buhrow, Nico Huber, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62712 ) Change subject: flashchips.c: Mark GD25Q40(B) as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idec3d82efbdf095c3d57bfe5f0fd487007b554cb Gerrit-Change-Number: 62712 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Mar 2022 15:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Mark GD25Q40(B) as tested
by Simon Buhrow (Code Review) 09 Mar '22

09 Mar '22

Simon Buhrow has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62712 ) Change subject: flashchips.c: Mark GD25Q40(B) as tested ...................................................................... flashchips.c: Mark GD25Q40(B) as tested As mentioned by Wolf Dieter Brandt in his mail from 07.Feb.22. Change-Id: Idec3d82efbdf095c3d57bfe5f0fd487007b554cb Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/62712/1 diff --git a/flashchips.c b/flashchips.c index acb7718..0846f24 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6822,7 +6822,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/62712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idec3d82efbdf095c3d57bfe5f0fd487007b554cb Gerrit-Change-Number: 62712 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Angel Pons (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 ) Change subject: hwaccess_x86_io: clean header concept ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 15 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 14:42:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Add 4BA block erasers to W25Q256.W
by Simon Buhrow (Code Review) 09 Mar '22

09 Mar '22

Simon Buhrow has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62711 ) Change subject: flashchips.c: Add 4BA block erasers to W25Q256.W ...................................................................... flashchips.c: Add 4BA block erasers to W25Q256.W Change-Id: I1085c76574dbc76e278644ee05a6eca009798aa6 Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> --- M flashchips.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/62711/1 diff --git a/flashchips.c b/flashchips.c index acb7718..adce09c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -17509,12 +17509,18 @@ .eraseblocks = { {4 * 1024, 8192} }, .block_erase = spi_block_erase_20, }, { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_21, + }, { .eraseblocks = { {32 * 1024, 1024} }, .block_erase = spi_block_erase_52, }, { .eraseblocks = { {64 * 1024, 512} }, .block_erase = spi_block_erase_d8, }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_dc, + }, { .eraseblocks = { {32 * 1024 * 1024, 1} }, .block_erase = spi_block_erase_60, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/62711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1085c76574dbc76e278644ee05a6eca009798aa6 Gerrit-Change-Number: 62711 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Thomas Heijligen (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 ) Change subject: hwaccess_x86_io: clean header concept ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: Build tested on Linux, FreeBSD, NetBSD, OpenBSD, DragonflyBSD -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 15 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 12:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix segfault when iomem=strict
by Evgeny Zinoviev (Code Review) 09 Mar '22

09 Mar '22

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48361 ) Change subject: Fix segfault when iomem=strict ...................................................................... Fix segfault when iomem=strict As I can see, physmap_common() only returns ERROR_PTR or a real pointer but never NULL. Tested on Linux 5.9.12. Change-Id: I5b11957fc10fd5c7a4fbb7f54fb94d791590f373 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io> --- M dmi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/48361/1 diff --git a/dmi.c b/dmi.c index c44221c..7488d61 100644 --- a/dmi.c +++ b/dmi.c @@ -164,7 +164,7 @@ unsigned int i = 0, j = 0; uint8_t *dmi_table_mem = physmap_ro("DMI Table", base, len); - if (dmi_table_mem == NULL) { + if (dmi_table_mem == ERROR_PTR) { msg_perr("Unable to access DMI Table\n"); return; } -- To view, visit https://review.coreboot.org/c/flashrom/+/48361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5b11957fc10fd5c7a4fbb7f54fb94d791590f373 Gerrit-Change-Number: 48361 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-MessageType: newchange

3 3

Change in flashrom[master]: cli_classic.c: Use correct format specifier for `size_t`
by Angel Pons (Code Review) 09 Mar '22

09 Mar '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62707 ) Change subject: cli_classic.c: Use correct format specifier for `size_t` ...................................................................... cli_classic.c: Use correct format specifier for `size_t` The return value of `flashrom_flash_getsize()` is of `size_t` type. Fixes: commit 83c5c50f91806df599fa9eebb654832879381772 Change-Id: I8025c0e046cb61e0e115d3786e6e4184190347f1 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M cli_classic.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/62707/1 diff --git a/cli_classic.c b/cli_classic.c index dc3a651..b3930d2 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -715,7 +715,7 @@ } if (flash_size) { - printf("%ld\n", flashrom_flash_getsize(fill_flash)); + printf("%zu\n", flashrom_flash_getsize(fill_flash)); goto out_shutdown; } -- To view, visit https://review.coreboot.org/c/flashrom/+/62707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8025c0e046cb61e0e115d3786e6e4184190347f1 Gerrit-Change-Number: 62707 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022