March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: pony_spi.c: Fixed memory leak in function pony_init_spi
by Anastasia Klimchuk (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fixed memory leak in function pony_init_spi ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62724/comment/9b5f79a9_9673bb6a PS1, Line 11: You can add information on how you tested this patch. For example, you found this by running scan-build, so you can say that you ran scan-build before and after and the issue disappeared (if this is true of course). Patchset: PS1: Welcome Aarya! You will need to read all the comments carefully, fix all them and upload new version of this patch (new patchset). If you don't understand the comment, it is totally fine to ask for clarification, and what does the comment mean. Good luck! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 09:46:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: serprog.c: Fixed passed null value when expectingn nonnull
by Angel Pons (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 ) Change subject: serprog.c: Fixed passed null value when expectingn nonnull ...................................................................... Patch Set 1: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62726/comment/adab96d1_0a7fd1b0 PS1, Line 7: n Remove extra `n` at the end https://review.coreboot.org/c/flashrom/+/62726/comment/f6fecfb0_13595276 PS1, Line 7: Fixed passed null value when expectingn nonnull How about: Avoid calling memcpy with NULL pointer arguments https://review.coreboot.org/c/flashrom/+/62726/comment/dbde3c41_f847a680 PS1, Line 11: Just added a check before : memcpy for parms==NULL. How about: Still, add a NULL check before calling memcpy to be safe. File serprog.c: https://review.coreboot.org/c/flashrom/+/62726/comment/06ec9096_6cdb7ffd PS1, Line 294: if Please add a space after `if` https://review.coreboot.org/c/flashrom/+/62726/comment/ba31a13e_e7ee09d3 PS1, Line 295: memcpy(&(sp[1]), parms, parmlen); We use tabs for indentation, and a tab is 8 characters wide. Please refer to https://flashrom.org/Development_Guidelines#Coding_style -- To view, visit https://review.coreboot.org/c/flashrom/+/62726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b Gerrit-Change-Number: 62726 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 09:41:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi.c: Check SPI Cycle In-Progress prior start HW Seq
by Edward O'Callaghan (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Subrata Banik. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61854 ) Change subject: ichspi.c: Check SPI Cycle In-Progress prior start HW Seq ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: > I know I can react much too harsh sometimes (it's just frustrating to see […] Thanks Nico, I just wanted to follow up here quickly to ensure that messaging does not get mixed up and this is going to get followed up on! Tomorrow is some company-wide day off. The short answer just for the moment is that Subrata and I were discussing today if a possible unit-test using HECI command set that could perhaps reliably exploit the issue and how it is remediated by this patch can be contrived to make this more concrete. I also followed up with Anastasia to help assist in making these changes smoother and she has provided some very useful insight to. More to come but I just wanted to follow up with something here ASAP. Leaving as unresolved. -- To view, visit https://review.coreboot.org/c/flashrom/+/61854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9265cc20513fd00f32f8fa22e28c312903ca484 Gerrit-Change-Number: 61854 Gerrit-PatchSet: 17 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Alex Levin <levinale(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 09:37:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi.c: Fixed memory leak in function pony_init_spi
by Angel Pons (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fixed memory leak in function pony_init_spi ...................................................................... Patch Set 1: (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62724/comment/9628eccf_f3b982d7 PS1, Line 9: Memory leaked was caused as data variable wasn't deallocated in some error cases where : the function returned without deallocatiing it. Please wrap commit message lines at 72 characters, c.f. https://flashrom.org/Development_Guidelines#Commit_message File pony_spi.c: https://review.coreboot.org/c/flashrom/+/62724/comment/8a9dfab8_dbaf898a PS1, Line 164: free(data); We use tabs for indentation, and a tab is 8 characters wide. Please refer to https://flashrom.org/Development_Guidelines#Coding_style Besides the indentation, this is correct. The shutdown function hasn't been registered (see comment on line 167), so `data` leaks. https://review.coreboot.org/c/flashrom/+/62724/comment/7260c2c7_1e1d0a77 PS1, Line 167: Once execution reaches this point, we know that `register_shutdown(pony_spi_shutdown, data)` has been called successfully. This means flashrom will automatically execute the `pony_spi_shutdown()` function before exiting, which in turn calls `free(data)`. So, there's no need to `free(data)` from this point onwards. https://review.coreboot.org/c/flashrom/+/62724/comment/b28a00e2_9407e9d0 PS1, Line 182: free(data); This isn't needed because the shutdown function has been registered, which will run `free(data)` already. Adding `free(data)` here would result in a double-free bug. https://review.coreboot.org/c/flashrom/+/62724/comment/63515572_6b943e63 PS1, Line 248: free(data); This isn't needed either, see my comment on line 182. https://review.coreboot.org/c/flashrom/+/62724/comment/c1f1bcca_174a24a2 PS1, Line 255: free(data); This won't work. The `register_spi_bitbang_master()` function stores a copy of the `data` pointer and uses it as argument for the `spi_data` parameter of the functions referenced by the `bitbang_spi_master_pony` struct. The memory is released by the `pony_spi_shutdown()` function. -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 09:34:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Rename run_lifecycle into run_basic_lifecycle
by Anastasia Klimchuk (Code Review) 10 Mar '22

10 Mar '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/59740 ) Change subject: tests: Rename run_lifecycle into run_basic_lifecycle ...................................................................... tests: Rename run_lifecycle into run_basic_lifecycle Lifecycle tests are getting an upgrade in this chain, with new type of tests: lifecycle with probing. Existing lifecycle, being the simplest possible one becomes "basic lifecycle". With time, most of existing tests will be upgraded to probing lifecycle, however not necessarily all of them. Basic lifecycle will likely to stay as an option. This can be convenient, for a developer who wishes to add a test for a programmer, to have a choice of basic and extended option. BUG=b:181803212 TEST=ninja test Change-Id: I2771921ae2bd37f4b3f49342e03d9abb5ee36ea0 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/59740 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M tests/lifecycle.c M tests/tests.c M tests/tests.h 3 files changed, 29 insertions(+), 29 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/tests/lifecycle.c b/tests/lifecycle.c index 2a8d6f5..8cb604b 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -19,7 +19,7 @@ #include "io_mock.h" #include "programmer.h" -static void run_lifecycle(void **state, const struct programmer_entry *prog, const char *param) +static void run_basic_lifecycle(void **state, const struct programmer_entry *prog, const char *param) { (void) state; /* unused */ @@ -36,19 +36,19 @@ free(param_dup); } -void dummy_init_and_shutdown_test_success(void **state) +void dummy_basic_lifecycle_test_success(void **state) { #if CONFIG_DUMMY == 1 - run_lifecycle(state, &programmer_dummy, "bus=parallel+lpc+fwh+spi"); + run_basic_lifecycle(state, &programmer_dummy, "bus=parallel+lpc+fwh+spi"); #else skip(); #endif } -void nicrealtek_init_and_shutdown_test_success(void **state) +void nicrealtek_basic_lifecycle_test_success(void **state) { #if CONFIG_NICREALTEK == 1 - run_lifecycle(state, &programmer_nicrealtek, ""); + run_basic_lifecycle(state, &programmer_nicrealtek, ""); #else skip(); #endif @@ -122,7 +122,7 @@ free(config); } -void raiden_debug_init_and_shutdown_test_success(void **state) +void raiden_debug_basic_lifecycle_test_success(void **state) { #if CONFIG_RAIDEN_DEBUG_SPI == 1 const struct io_mock raiden_debug_io = { @@ -142,7 +142,7 @@ io_mock_register(&raiden_debug_io); - run_lifecycle(state, &programmer_raiden_debug_spi, raiden_debug_param); + run_basic_lifecycle(state, &programmer_raiden_debug_spi, raiden_debug_param); io_mock_register(NULL); #else @@ -173,7 +173,7 @@ return wLength; } -void dediprog_init_and_shutdown_test_success(void **state) +void dediprog_basic_lifecycle_test_success(void **state) { #if CONFIG_DEDIPROG == 1 const struct io_mock dediprog_io = { @@ -183,7 +183,7 @@ io_mock_register(&dediprog_io); - run_lifecycle(state, &programmer_dediprog, "voltage=3.5V"); + run_basic_lifecycle(state, &programmer_dediprog, "voltage=3.5V"); io_mock_register(NULL); #else @@ -247,7 +247,7 @@ return 0; } -void linux_mtd_init_and_shutdown_test_success(void **state) +void linux_mtd_basic_lifecycle_test_success(void **state) { #if CONFIG_LINUX_MTD == 1 struct linux_mtd_io_state linux_mtd_io_state = { NULL }; @@ -260,7 +260,7 @@ io_mock_register(&linux_mtd_io); - run_lifecycle(state, &programmer_linux_mtd, ""); + run_basic_lifecycle(state, &programmer_linux_mtd, ""); io_mock_register(NULL); #else @@ -276,7 +276,7 @@ return memcpy(buf, max_buf_size, min(len, strlen(max_buf_size) + 1)); } -void linux_spi_init_and_shutdown_test_success(void **state) +void linux_spi_basic_lifecycle_test_success(void **state) { /* * Current implementation tests a particular path of the init procedure. @@ -289,7 +289,7 @@ io_mock_register(&linux_spi_io); - run_lifecycle(state, &programmer_linux_spi, "dev=/dev/null"); + run_basic_lifecycle(state, &programmer_linux_spi, "dev=/dev/null"); io_mock_register(NULL); #else @@ -332,7 +332,7 @@ return sz; } -void realtek_mst_init_and_shutdown_test_success(void **state) +void realtek_mst_basic_lifecycle_test_success(void **state) { #if CONFIG_REALTEK_MST_I2C_SPI == 1 const struct io_mock realtek_mst_io = { @@ -343,7 +343,7 @@ }; io_mock_register(&realtek_mst_io); - run_lifecycle(state, &programmer_realtek_mst_i2c_spi, "bus=254,enter-isp=0"); + run_basic_lifecycle(state, &programmer_realtek_mst_i2c_spi, "bus=254,enter-isp=0"); io_mock_register(NULL); #else diff --git a/tests/tests.c b/tests/tests.c index 74a4f57..21cc1ed 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -363,13 +363,13 @@ ret |= cmocka_run_group_tests_name("spi25.c tests", spi25_tests, NULL, NULL); const struct CMUnitTest lifecycle_tests[] = { - cmocka_unit_test(dummy_init_and_shutdown_test_success), - cmocka_unit_test(nicrealtek_init_and_shutdown_test_success), - cmocka_unit_test(raiden_debug_init_and_shutdown_test_success), - cmocka_unit_test(dediprog_init_and_shutdown_test_success), - cmocka_unit_test(linux_mtd_init_and_shutdown_test_success), - cmocka_unit_test(linux_spi_init_and_shutdown_test_success), - cmocka_unit_test(realtek_mst_init_and_shutdown_test_success), + cmocka_unit_test(dummy_basic_lifecycle_test_success), + cmocka_unit_test(nicrealtek_basic_lifecycle_test_success), + cmocka_unit_test(raiden_debug_basic_lifecycle_test_success), + cmocka_unit_test(dediprog_basic_lifecycle_test_success), + cmocka_unit_test(linux_mtd_basic_lifecycle_test_success), + cmocka_unit_test(linux_spi_basic_lifecycle_test_success), + cmocka_unit_test(realtek_mst_basic_lifecycle_test_success), }; ret |= cmocka_run_group_tests_name("lifecycle.c tests", lifecycle_tests, NULL, NULL); diff --git a/tests/tests.h b/tests/tests.h index 5480beb..1218a30 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -41,13 +41,13 @@ void probe_spi_st95_test_success(void **state); /* spi95.c */ /* lifecycle.c */ -void dummy_init_and_shutdown_test_success(void **state); -void nicrealtek_init_and_shutdown_test_success(void **state); -void raiden_debug_init_and_shutdown_test_success(void **state); -void dediprog_init_and_shutdown_test_success(void **state); -void linux_mtd_init_and_shutdown_test_success(void **state); -void linux_spi_init_and_shutdown_test_success(void **state); -void realtek_mst_init_and_shutdown_test_success(void **state); +void dummy_basic_lifecycle_test_success(void **state); +void nicrealtek_basic_lifecycle_test_success(void **state); +void raiden_debug_basic_lifecycle_test_success(void **state); +void dediprog_basic_lifecycle_test_success(void **state); +void linux_mtd_basic_lifecycle_test_success(void **state); +void linux_spi_basic_lifecycle_test_success(void **state); +void realtek_mst_basic_lifecycle_test_success(void **state); /* layout.c */ void included_regions_dont_overlap_test_success(void **state); 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/59740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2771921ae2bd37f4b3f49342e03d9abb5ee36ea0 Gerrit-Change-Number: 59740 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: pony_spi.c: Fixed memory leak in function pony_init_spi
by Paul Menzel (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fixed memory leak in function pony_init_spi ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62724/comment/a3f432a9_bf62dac3 PS1, Line 7: Fixed Imperative mood: Fix -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 09:25:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom.c: fixed unintialized value passed to function
by Paul Menzel (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 ) Change subject: libflashrom.c: fixed unintialized value passed to function ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62725/comment/482e8d14_eed9b097 PS1, Line 7: fixed Fix -- To view, visit https://review.coreboot.org/c/flashrom/+/62725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d Gerrit-Change-Number: 62725 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 09:24:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: serprog.c: Fixed passed null value when expectingn nonnull
by Paul Menzel (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 ) Change subject: serprog.c: Fixed passed null value when expectingn nonnull ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62726/comment/0c10b7ac_e09a5a2c PS1, Line 7: Fixed Fix -- To view, visit https://review.coreboot.org/c/flashrom/+/62726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b Gerrit-Change-Number: 62726 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 09:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Rename init_shutdown.c into lifecycle.c
by Anastasia Klimchuk (Code Review) 10 Mar '22

10 Mar '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/59739 ) Change subject: tests: Rename init_shutdown.c into lifecycle.c ...................................................................... tests: Rename init_shutdown.c into lifecycle.c Lifecycle tests are getting an upgrade later in this chain, which means lifecycle becomes more than just init and shutdown. Rename into lifecycle.c to reflect the upgrade. BUG=b:181803212 TEST=ninja test Change-Id: I8d734c43cc15c7ec1055d3fb5bdcdca8c90d0987 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/59739 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- R tests/lifecycle.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/tests/init_shutdown.c b/tests/lifecycle.c similarity index 100% rename from tests/init_shutdown.c rename to tests/lifecycle.c diff --git a/tests/meson.build b/tests/meson.build index 2f0fc67..610d1c6 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -20,7 +20,7 @@ 'helpers.c', 'flashrom.c', 'spi25.c', - 'init_shutdown.c', + 'lifecycle.c', 'layout.c', 'chip.c', ] diff --git a/tests/tests.c b/tests/tests.c index 1dda467..74a4f57 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -362,7 +362,7 @@ }; ret |= cmocka_run_group_tests_name("spi25.c tests", spi25_tests, NULL, NULL); - const struct CMUnitTest init_shutdown_tests[] = { + const struct CMUnitTest lifecycle_tests[] = { cmocka_unit_test(dummy_init_and_shutdown_test_success), cmocka_unit_test(nicrealtek_init_and_shutdown_test_success), cmocka_unit_test(raiden_debug_init_and_shutdown_test_success), @@ -371,7 +371,7 @@ cmocka_unit_test(linux_spi_init_and_shutdown_test_success), cmocka_unit_test(realtek_mst_init_and_shutdown_test_success), }; - ret |= cmocka_run_group_tests_name("init_shutdown.c tests", init_shutdown_tests, NULL, NULL); + ret |= cmocka_run_group_tests_name("lifecycle.c tests", lifecycle_tests, NULL, NULL); const struct CMUnitTest layout_tests[] = { cmocka_unit_test(included_regions_dont_overlap_test_success), diff --git a/tests/tests.h b/tests/tests.h index f1b4e9b..5480beb 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -40,7 +40,7 @@ void probe_spi_at25f_test_success(void **state); void probe_spi_st95_test_success(void **state); /* spi95.c */ -/* init_shutdown.c */ +/* lifecycle.c */ void dummy_init_and_shutdown_test_success(void **state); void nicrealtek_init_and_shutdown_test_success(void **state); void raiden_debug_init_and_shutdown_test_success(void **state); -- To view, visit https://review.coreboot.org/c/flashrom/+/59739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8d734c43cc15c7ec1055d3fb5bdcdca8c90d0987 Gerrit-Change-Number: 59739 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: tests: Upgrade linux_spi test to run probe lifecycle
by Thomas Heijligen (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59742 ) Change subject: tests: Upgrade linux_spi test to run probe lifecycle ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/59742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72 Gerrit-Change-Number: 59742 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Mar 2022 08:45:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022