March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Angel Pons (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62724/comment/2c19ea3f_97fec297 PS3, Line 11: ii nit: just one `i` -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 3 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 15:18:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Angel Pons (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Thanks for pointing out the mistakes. I have made the changes accordingly. […] Hi, it's what I described here: https://review.coreboot.org/c/flashrom/+/62724/1..3/pony_spi.c#b167 In a nutshell, `register_shutdown(pony_spi_shutdown, data)` registers the shutdown function *and also* stores a copy of the pointer to the data to be freed. I didn't explicitly mention this second part in my other comment. -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 3 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 15:17:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Light <aarya.chaumal(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: Fix compilation on 32bits
by Patrick Rudolph (Code Review) 10 Mar '22

10 Mar '22

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/62735 ) Change subject: cli_classic: Fix compilation on 32bits ...................................................................... Abandoned Duplicate of https://review.coreboot.org/62707 -- To view, visit https://review.coreboot.org/c/flashrom/+/62735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifb25cb8b860e1253ea34343fbe0c82977beae5f5 Gerrit-Change-Number: 62735 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: cli_classic.c: Use correct format specifier for `size_t`
by Patrick Rudolph (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Anastasia Klimchuk. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62707 ) Change subject: cli_classic.c: Use correct format specifier for `size_t` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8025c0e046cb61e0e115d3786e6e4184190347f1 Gerrit-Change-Number: 62707 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Mar 2022 13:06:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: Fix compilation on 32bits
by Patrick Rudolph (Code Review) 10 Mar '22

10 Mar '22

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62735 ) Change subject: cli_classic: Fix compilation on 32bits ...................................................................... cli_classic: Fix compilation on 32bits Change-Id: Ifb25cb8b860e1253ea34343fbe0c82977beae5f5 Signed-off-by: Patrick Rudolpg <patrick.rudolph(a)9elements.com> --- M cli_classic.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/62735/1 diff --git a/cli_classic.c b/cli_classic.c index dc3a651..72c9dff 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -715,7 +715,7 @@ } if (flash_size) { - printf("%ld\n", flashrom_flash_getsize(fill_flash)); + printf("%zd\n", flashrom_flash_getsize(fill_flash)); goto out_shutdown; } -- To view, visit https://review.coreboot.org/c/flashrom/+/62735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifb25cb8b860e1253ea34343fbe0c82977beae5f5 Gerrit-Change-Number: 62735 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: writeprotect_ranges.c: Use 1UL if left shifting more than 32bits
by Light (Code Review) 10 Mar '22

10 Mar '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62733 to look at the new patch set (#2). Change subject: writeprotect_ranges.c: Use 1UL if left shifting more than 32bits ...................................................................... writeprotect_ranges.c: Use 1UL if left shifting more than 32bits size_t is of size 64 bits, while 1 (int) is of 32 bits. Left shifting 1 by more than 32 will lead to shift-count-overflow bug. So use 1UL or 1ULL to make 1 of type unsigned long or unsigned long long respectively. Still the bug is not fixed :( Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- A tags M writeprotect_ranges.c 2 files changed, 5,216 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/62733/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Gerrit-Change-Number: 62733 Gerrit-PatchSet: 2 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: writeprotect_ranges.c: Use 1UL if left shifting more than 32bits
by Light (Code Review) 10 Mar '22

10 Mar '22

Light has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62733 ) Change subject: writeprotect_ranges.c: Use 1UL if left shifting more than 32bits ...................................................................... writeprotect_ranges.c: Use 1UL if left shifting more than 32bits size_t is of size 64 bits, while 1 (int) is of 32 bits. Left shifting 1 by more than 32 will lead to shift-count-overflow bug. So use 1UL or 1ULL to make 1 of type unsigned long or unsigned long long respectively. Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- A tags M writeprotect_ranges.c 2 files changed, 5,216 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/62733/1 -- To view, visit https://review.coreboot.org/c/flashrom/+/62733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Gerrit-Change-Number: 62733 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Light (Code Review) 10 Mar '22

10 Mar '22

Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62724 to look at the new patch set (#3). Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... pony_spi.c: Fix memory leak in function pony_init_spi I found the issue by running scan-build. Memory leaked was caused as data variable wasn't deallocated in some error cases where the function returned without deallocatiing it. After making the changes the issue was no longer appeared in scan-build. Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M pony_spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/62724/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 3 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Light (Code Review) 10 Mar '22

10 Mar '22

Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Thanks for pointing out the mistakes. I have made the changes accordingly. I have some doubts though: When does the shutdown function get registered and how does it get the pointer to data to free it? -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 2 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 10 Mar 2022 10:35:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Light (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62724 to look at the new patch set (#2). Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... pony_spi.c: Fix memory leak in function pony_init_spi Memory leaked was caused as data variable wasn't deallocated in some error cases where the function returned without deallocatiing it. Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M pony_spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/62724/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 2 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022