March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: libflashrom.c: Fix unintialized value passed to function
by Light (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Paul Menzel, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 ) Change subject: libflashrom.c: Fix unintialized value passed to function ...................................................................... Patch Set 8: (7 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62725/comment/4cab97f9_7fb67547 PS1, Line 7: fixed > Fix Done https://review.coreboot.org/c/flashrom/+/62725/comment/21ff9726_77bfe34c PS1, Line 7: unintialized > typo: uninitialized Done https://review.coreboot.org/c/flashrom/+/62725/comment/f9753369_97f97c77 PS1, Line 9: y > t Done https://review.coreboot.org/c/flashrom/+/62725/comment/e8906c23_ce6faf20 PS1, Line 9: In function flash_layouy_read_from_ifd variable chip_layout remains uninitialized if prepare_flash_access returns > Please wrap commit message lines at 72 characters, c.f. https://flashrom. […] Done https://review.coreboot.org/c/flashrom/+/62725/comment/48451152_364a8005 PS1, Line 10: unintialzed > 2 typos: uninitialized Done https://review.coreboot.org/c/flashrom/+/62725/comment/9388ea73_05b118da PS1, Line 10: flase > typo: false Done File libflashrom.c: https://review.coreboot.org/c/flashrom/+/62725/comment/c85e277b_9ed5fec6 PS1, Line 445: struct flashrom_layout *dump_layout=0, *chip_layout=0; > Since these are pointers, I'd use NULL. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d Gerrit-Change-Number: 62725 Gerrit-PatchSet: 8 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 02:58:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Light (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Martin Roth, Light. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62724 to look at the new patch set (#6). Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... pony_spi.c: Fix memory leak in function pony_init_spi I found the issue by running scan-build. Memory leaked was caused as data variable wasn't deallocated in some error cases where the function returned without deallocating it. After making the changes the issue was no longer appeared in scan-build. Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M pony_spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/62724/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 6 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
by Felix Singer (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Martin Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 01:08:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Felix Singer (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Martin Roth, Light. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > I've added scan-build output to the flashrom jenkins build: […] Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 5 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 00:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it87spi.c: Enable probing of IT8686E
by Sea Wright (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Nico Huber, David Hendricks. Sea Wright has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62718 ) Change subject: it87spi.c: Enable probing of IT8686E ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62718/comment/fb8828df_1bbfae88 PS1, Line 13: Signed-off-by: Sea Wright <menaechmi(a)protonmail.com> > Pseudonym? By law, it is my name. I can understand why you asked, though, so thanks and I appreciate the thoroughness! -- To view, visit https://review.coreboot.org/c/flashrom/+/62718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f6fe582d9e50e66560b1c54be9a5fdd34584a93 Gerrit-Change-Number: 62718 Gerrit-PatchSet: 1 Gerrit-Owner: Sea Wright <menaechmi(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 22:34:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
by Martin Roth (Code Review) 10 Mar '22

10 Mar '22

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... test_build.sh: Allow WARNERROR to be overridden Currently, WARNERROR is hardcoded to 'yes' which is what we want most of the time, but there are cases (such as when building with -fanalyzer) that we don't want it enabled, so we see the entire output of the build, and it doesn't halt at the first error. After the flashrom build passes with the -fanalyzer setting set, we can go back to setting WARNERROR=yes for that build in jenkins. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 --- M test_build.sh 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/62745/1 diff --git a/test_build.sh b/test_build.sh index dc286f8..1d60377 100755 --- a/test_build.sh +++ b/test_build.sh @@ -1,8 +1,7 @@ #!/usr/bin/env sh set -e -make CONFIG_EVERYTHING=yes WARNERROR=yes - +make CONFIG_EVERYTHING=yes WARNERROR="${WARNERROR-yes}" builddir=out meson $builddir -- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Martin Roth (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Light. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I've added scan-build output to the flashrom jenkins build: https://qa.coreboot.org/job/flashrom/1061/artifact/scan_build/2022-03-10-18… When everything found by scan-build is fixed, we can enable it as part of the gerrit check. -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 5 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 22:17:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: writeprotect_ranges.c: Check for underflow when using unsigned types
by Light (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62733 ) Change subject: writeprotect_ranges.c: Check for underflow when using unsigned types ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > Heh, a third solution comes to mind. Sorry if this is getting too […] Yes, I think your reasoning is accurate. I was also thinking along the same lines earlier. Also, these cases are perfectly possible, and asserting bits->bp_bit_count>1 would stop the program inappropriately. It would be best to just ignore the tool for this issue. Also, ignore my previous patch set. :) -- To view, visit https://review.coreboot.org/c/flashrom/+/62733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Gerrit-Change-Number: 62733 Gerrit-PatchSet: 5 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 18:32:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: writeprotect_ranges.c: Check for underflow when using unsigned types
by Light (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Angel Pons, Light, Nikolai Artemiev. Hello build bot (Jenkins), Nico Huber, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62733 to look at the new patch set (#6). Change subject: writeprotect_ranges.c: Check for underflow when using unsigned types ...................................................................... writeprotect_ranges.c: Check for underflow when using unsigned types size_t is an unsigned type so bp_max-2 causes an underflow. This results in undefined behaviour. So assert before that bits->bp_bit-count > 1 so that bp_max has a minimum value of 2. But the when bp_bit_count == 0 then bp == 0 and when bp_bit_count == 1 then bp == 0 or bp == 1 == bp_max. These cases are handled seaprately so the underflow will never occur. Ignore the tool for this issue. Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M writeprotect_ranges.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/62733/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/62733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Gerrit-Change-Number: 62733 Gerrit-PatchSet: 6 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: writeprotect_ranges.c: Check for underflow when using unsigned types
by Light (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Angel Pons, Light, Nikolai Artemiev. Hello build bot (Jenkins), Nico Huber, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62733 to look at the new patch set (#5). Change subject: writeprotect_ranges.c: Check for underflow when using unsigned types ...................................................................... writeprotect_ranges.c: Check for underflow when using unsigned types size_t is an unsigned type so bp_max-2 causes an underflow. This results in undefined behaviour. So assert before that bits->bp_bit-count > 1 so that bp_max has a minimum value of 2. Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M writeprotect_ranges.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/62733/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/62733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Gerrit-Change-Number: 62733 Gerrit-PatchSet: 5 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022