March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Thomas Heijligen (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 ) Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: I've build tested it on Linux and openindiana (SunOS successor) openindiana builds successful with `gmake WARNERROR=no` and has all serial programmer enabled. WARNERROR=no is needed for other bugs. File Makefile: https://review.coreboot.org/c/flashrom/+/62196/comment/c124a5ed_1ba39d3d PS2, Line 807: ifneq ($(NEED_POSIX_SOCKETS), ) > Yes, it's only serprog. I'll make an extra group. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 11 Mar 2022 22:54:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Thomas Heijligen (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Felix Singer, Nico Huber. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62196 to look at the new patch set (#4). Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Makefile: use HAS_ USE_ pattern for serial support Align the usage of serial function with the selection of other dependencies. Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/62196/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Thomas Heijligen (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 ) Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Patch Set 3: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/62196/comment/a9c6eacc_4aa2658a PS2, Line 807: ifneq ($(NEED_POSIX_SOCKETS), ) > Not sure about this. It seems special to serprog. It looks like currently […] Yes, it's only serprog. I'll make an extra group. -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 11 Mar 2022 22:01:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it87spi.c: Enable probing of IT8686E
by David Hendricks (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Nico Huber, Sea Wright. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62718 ) Change subject: it87spi.c: Enable probing of IT8686E ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62718/comment/4de17f6a_22723ada PS1, Line 13: Signed-off-by: Sea Wright <menaechmi(a)protonmail.com> > By law, it is my name. […] Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/62718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f6fe582d9e50e66560b1c54be9a5fdd34584a93 Gerrit-Change-Number: 62718 Gerrit-PatchSet: 1 Gerrit-Owner: Sea Wright <menaechmi(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sea Wright <menaechmi(a)protonmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 20:28:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Sea Wright <menaechmi(a)protonmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add run_probe_lifecycle and add dummyflasher probe test
by Nico Huber (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59741 ) Change subject: tests: Add run_probe_lifecycle and add dummyflasher probe test ...................................................................... Patch Set 4: (1 comment) File tests/lifecycle.c: https://review.coreboot.org/c/flashrom/+/59741/comment/6a6cbfcd_19b978e8 PS4, Line 34: flashrom_flash_release(flashctx); /* cleanup */ > Or aborts `assert_int_equal` the test? I was about to ask the same question :) If this line is executed on failure too, we need the `NULL` initialization because flashrom_flash_probe() might not set any value on failure (unless documented otherwise). If it's not executed, the value doesn't matter ofc. -- To view, visit https://review.coreboot.org/c/flashrom/+/59741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9eb7fe3a436fbba5e70db957139fd26e00efec36 Gerrit-Change-Number: 59741 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Mar 2022 14:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc
by Light (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62747 ) Change subject: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc ...................................................................... Patch Set 3: (1 comment) File writeprotect_ranges.c: https://review.coreboot.org/c/flashrom/+/62747/comment/79ac4984_958853b9 PS2, Line 30: assert(bits->bp_bit_count > 1); > Yes it wasn't accepting empty commit or something. I think it's fixed now -- To view, visit https://review.coreboot.org/c/flashrom/+/62747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6b9269129968fb3b55b0d2a2e384c8a1aeba43ab Gerrit-Change-Number: 62747 Gerrit-PatchSet: 3 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 10:14:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Light <aarya.chaumal(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc
by Light (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62747 ) Change subject: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc ...................................................................... Patch Set 2: (1 comment) File writeprotect_ranges.c: https://review.coreboot.org/c/flashrom/+/62747/comment/dc5b0803_acd137af PS2, Line 30: assert(bits->bp_bit_count > 1); > Looks like a bad rebase Yes it wasn't accepting empty commit or something. -- To view, visit https://review.coreboot.org/c/flashrom/+/62747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6b9269129968fb3b55b0d2a2e384c8a1aeba43ab Gerrit-Change-Number: 62747 Gerrit-PatchSet: 2 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 10:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add run_probe_lifecycle and add dummyflasher probe test
by Angel Pons (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Nico Huber, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59741 ) Change subject: tests: Add run_probe_lifecycle and add dummyflasher probe test ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/59741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9eb7fe3a436fbba5e70db957139fd26e00efec36 Gerrit-Change-Number: 59741 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Mar 2022 10:01:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc
by Angel Pons (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62747 ) Change subject: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc ...................................................................... Patch Set 2: (1 comment) File writeprotect_ranges.c: https://review.coreboot.org/c/flashrom/+/62747/comment/a45e98d1_63ecd5d6 PS2, Line 30: assert(bits->bp_bit_count > 1); Looks like a bad rebase -- To view, visit https://review.coreboot.org/c/flashrom/+/62747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6b9269129968fb3b55b0d2a2e384c8a1aeba43ab Gerrit-Change-Number: 62747 Gerrit-PatchSet: 2 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 10:00:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: writeprotect_ranges.c: Check for underflow when using unsigned types
by Angel Pons (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Nico Huber, Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62733 ) Change subject: writeprotect_ranges.c: Check for underflow when using unsigned types ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/62733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad Gerrit-Change-Number: 62733 Gerrit-PatchSet: 7 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 09:56:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022