March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: board_enable.c: Fix dead assignment
by Light (Code Review) 12 Mar '22

12 Mar '22

Light has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62761 ) Change subject: board_enable.c: Fix dead assignment ...................................................................... board_enable.c: Fix dead assignment In function board_asus_p3b_f there were two consecutive lines which modified the value of variable b -- b=INB(0x80);b=INB(smbba);. Since the value of b is not used after first assignment I have removed that assignment. Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M board_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/62761/1 diff --git a/board_enable.c b/board_enable.c index 0ac522e..c00caf3 100644 --- a/board_enable.c +++ b/board_enable.c @@ -910,7 +910,7 @@ /* Wait until SMBus transaction is complete. */ b = 0x1; while (b & 0x01) { - b = INB(0x80); + INB(0x80); b = INB(smbba); } -- To view, visit https://review.coreboot.org/c/flashrom/+/62761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc Gerrit-Change-Number: 62761 Gerrit-PatchSet: 1 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Thomas Heijligen (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 ) Change subject: hwaccess_x86_io: clean header concept ...................................................................... Patch Set 16: (2 comments) Patchset: PS15: > Oh, and please update the commit message wrt. the test status. It restores old behavior; don't know the current build status for Android. File hwaccess_x86_io.c: https://review.coreboot.org/c/flashrom/+/61276/comment/e20d8a9c_48892f7a PS15, Line 31: * - USE_LIBC_LAST : * - USE_LIBC_FIRST > Highlighted the identifiers in my editor, and taadaa the most errors are […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 16 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 12 Mar 2022 17:42:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Thomas Heijligen (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61276 to look at the new patch set (#16). Change subject: hwaccess_x86_io: clean header concept ...................................................................... hwaccess_x86_io: clean header concept Move all function implementations into the .c file TEST: `[g]make [WARNERROR=no]` on Linux, FreeBSD, NetBSD, OpenBSD, DragonflyBSD, OpenIndiana, Debian-GNU/Hurd Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M hwaccess_x86_io.c M hwaccess_x86_io.h M meson.build 4 files changed, 315 insertions(+), 188 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/61276/16 -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 16 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Thomas Heijligen (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 ) Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Patch Set 4: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/62196/comment/266b18d8_82745fd7 PS4, Line 253: HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) > Only if you want to :) and probably something for another commit, as this wasn't […] Then I'll leave it as it is for now. -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 12 Mar 2022 16:51:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Nico Huber (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 ) Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Patch Set 4: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/62196/comment/26896cc1_34a08ee3 PS4, Line 253: HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) > Yes, DEPENDS_ON_SOCKETS is a subset of DEPENDS_OF_SERIAL. […] Only if you want to :) and probably something for another commit, as this wasn't handled explicilty before either. -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 12 Mar 2022 16:48:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_io: refactor rget_io_perms()
by Nico Huber (Code Review) 12 Mar '22

12 Mar '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/61275 ) Change subject: hwaccess_x86_io: refactor rget_io_perms() ...................................................................... hwaccess_x86_io: refactor rget_io_perms() Abstract the different I/O Port permission methods in own functions. Change-Id: If4b2f8c2532f3732086ee1d479da6ae6693f9a42 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/61275 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M hwaccess_x86_io.c 1 file changed, 98 insertions(+), 50 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved diff --git a/hwaccess_x86_io.c b/hwaccess_x86_io.c index 635b27e..e891d98 100644 --- a/hwaccess_x86_io.c +++ b/hwaccess_x86_io.c @@ -2,6 +2,8 @@ * This file is part of the flashrom project. * * Copyright (C) 2009,2010 Carl-Daniel Hailfinger + * Copyright (C) 2022 secunet Security Networks AG + * (Written by Thomas Heijligen <thomas.heijligen(a)secunet.com) * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -14,70 +16,116 @@ * GNU General Public License for more details. */ +/* + * This file implements x86 I/O port permission handling. + * + * For this purpose the platform specific code is encapsuled in two functions + * and compiled only on the respective platform. `platform_get_io_perms()` is + * called to get the permissions and `platform_release_io_perms()` is called for + * releasing those. + */ + #include <errno.h> #include <string.h> -#if !defined (__DJGPP__) && !defined(__LIBPAYLOAD__) -/* No file access needed/possible to get hardware access permissions. */ -#include <unistd.h> -#include <fcntl.h> -#endif -#include "hwaccess_x86_io.h" #include "flash.h" +#include "hwaccess_x86_io.h" -#if USE_IOPERM -#include <sys/io.h> -#endif - -#if USE_DEV_IO -int io_fd; -#endif - -#if !(defined(__DJGPP__) || defined(__LIBPAYLOAD__)) -static int release_io_perms(void *p) +#if defined(__DJGPP__) || defined(__LIBPAYLOAD) /* DJGPP, libpayload */ +static int platform_get_io_perms(void) { -#if defined (__sun) + return 0; +} + +static int platform_release_io_perms(void *p) +{ + return 0; +} +#endif + +#if defined(__sun) /* SunOS */ +#include <sys/sysi86.h> + +static int platform_get_io_perms(void) +{ + return sysi86(SI86V86, V86SC_IOPL, PS_IOPL); +} + +static int platform_release_io_perms(void *p) +{ sysi86(SI86V86, V86SC_IOPL, 0); -#elif USE_DEV_IO + return 0; +} +#endif + +#if USE_DEV_IO /* FreeBSD, DragonFlyBSD */ +#include <fcntl.h> +#include <unistd.h> + +int io_fd; + +static int platform_get_io_perms(void) +{ + io_fd = open("/dev/io", O_RDWR); + return (io_fd >= 0 ? 0 : -1); +} + +static int platform_release_io_perms(void *p) +{ close(io_fd); -#elif USE_IOPERM + return 0; +} +#endif + +#if USE_IOPERM /* GNU Hurd */ +#include <sys/io.h> + +static int platform_get_io_perms(void) +{ + return ioperm(0, 65536, 1); +} + +static int platform_release_io_perms(void *p) +{ ioperm(0, 65536, 0); -#elif USE_IOPL + return 0; +} +#endif + +#if USE_IOPL /* Linux, Darwin, NetBSD, OpenBSD */ +static int platform_get_io_perms(void) +{ + return iopl(3); +} + +static int platform_release_io_perms(void *p) +{ iopl(0); -#endif return 0; } +#endif -/* Get I/O permissions with automatic permission release on shutdown. */ +/** + * @brief Get access to the x86 I/O ports + * + * This function abstracts the platform dependent function to get access to the + * x86 I/O ports and musst be called before using IN[B/W/L] or OUT[B/W/L]. + * It registers a shutdown function to release those privileges. + * + * @return 0 on success, platform specific number on failure + */ int rget_io_perms(void) { - #if defined (__sun) - if (sysi86(SI86V86, V86SC_IOPL, PS_IOPL) != 0) { -#elif USE_DEV_IO - if ((io_fd = open("/dev/io", O_RDWR)) < 0) { -#elif USE_IOPERM - if (ioperm(0, 65536, 1) != 0) { -#elif USE_IOPL - if (iopl(3) != 0) { -#endif - msg_perr("ERROR: Could not get I/O privileges (%s).\n", strerror(errno)); - msg_perr("You need to be root.\n"); - msg_perr("On OpenBSD set securelevel=-1 in /etc/rc.securelevel and\n" - "reboot, or reboot into single user mode.\n"); - msg_perr("On NetBSD reboot into single user mode or make sure\n" - "that your kernel configuration has the option INSECURE enabled.\n"); - return 1; - } else { - register_shutdown(release_io_perms, NULL); + if (platform_get_io_perms() == 0) { + register_shutdown(platform_release_io_perms, NULL); + return 0; } - return 0; + msg_perr("ERROR: Could not get I/O privileges (%s).\n", strerror(errno)); + msg_perr("Make sure you are root. If you are root, your kernel may still\n" + "prevent access based on security policies.\n"); + msg_perr("On OpenBSD set securelevel=-1 in /etc/rc.securelevel and\n" + "reboot, or reboot into single user mode.\n"); + msg_perr("On NetBSD reboot into single user mode or make sure\n" + "that your kernel configuration has the option INSECURE enabled.\n"); + return 1; } - -#else - -/* DJGPP and libpayload environments have full PCI port I/O permissions by default. */ -int rget_io_perms(void) -{ - return 0; -} -#endif -- To view, visit https://review.coreboot.org/c/flashrom/+/61275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If4b2f8c2532f3732086ee1d479da6ae6693f9a42 Gerrit-Change-Number: 61275 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Nico Huber (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 ) Change subject: hwaccess_x86_io: clean header concept ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: > Wasn't this fixing Android? That could be added to the commit message. Oh, and please update the commit message wrt. the test status. -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 15 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 12 Mar 2022 16:46:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Nico Huber (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 ) Change subject: hwaccess_x86_io: clean header concept ...................................................................... Patch Set 15: Code-Review+2 (3 comments) Patchset: PS15: Wasn't this fixing Android? That could be added to the commit message. File hwaccess_x86_io.h: https://review.coreboot.org/c/flashrom/+/61276/comment/33d5b12c_691053ba PS15, Line 57: #define INL(x) __extension__ ({ u_int inl_tmp = (x); inl(inl_tmp); }) I really wonder why we did this odd dance. Could be something with macros that assumed they can reference the argument (i.e. create a pointer with &). Was added in commit 65c1b86fe (Changes to make flashrom compile (and work) on FreeBSD), review turned out to be on the coreboot mailing list, but I couldn't find any discussion. File hwaccess_x86_io.c: https://review.coreboot.org/c/flashrom/+/61276/comment/6068b965_2cecfcde PS15, Line 31: * - USE_LIBC_LAST : * - USE_LIBC_FIRST Highlighted the identifiers in my editor, and taadaa the most errors are in comments as usual :) Needs _TARGET update. -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 15 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 12 Mar 2022 16:45:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Thomas Heijligen (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 ) Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Patch Set 4: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/62196/comment/4bec5450_09db2838 PS4, Line 253: HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) > It just happens to be the same for sockets, right? I was wondering why […] Yes, DEPENDS_ON_SOCKETS is a subset of DEPENDS_OF_SERIAL. I could add a `HAS_SOCKETS := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes))` -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 12 Mar 2022 15:38:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi
by Felix Singer (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Nico Huber, Martin Roth, Paul Menzel, Angel Pons, Light, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 ) Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > Could we make it comments like with checkpatch in coreboot? I think that would be great. How much time does such a scan take? Just asking, not that the build time of one build job increases too much. > If we'd make it a Verified -1, I guess we'd need some guidelines how to deal with false positives. I wouldn't do that. I would let the reviewers take care of that. -- To view, visit https://review.coreboot.org/c/flashrom/+/62724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301 Gerrit-Change-Number: 62724 Gerrit-PatchSet: 6 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 12 Mar 2022 15:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022