March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashrom.8.tmpl: document lspcon_i2c_spi
by Peter Marheine (Code Review) 25 Mar '22

25 Mar '22

Peter Marheine has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63104 ) Change subject: flashrom.8.tmpl: document lspcon_i2c_spi ...................................................................... flashrom.8.tmpl: document lspcon_i2c_spi This programmer operates much the same as realtek_mst_i2c_spi, so the I2C options are moved to a new section describing both programmers and a short description is added for this programmer itself. Signed-off-by: Peter … [View More]Marheine <pmarheine(a)chromium.org> Change-Id: I9ccb9694fdea29e68f062cc049efc0204917a139 --- M flashrom.8.tmpl 1 file changed, 22 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/63104/1 diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index a6637d2..952b4e3 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -389,6 +389,8 @@ .sp .BR "* realtek_mst_i2c_spi" " (for SPI flash ROMs attached to Realtek DisplayPort hubs accessible through I2C)" .sp +.BR "* lspcon_i2c_spi" " (for SPI flash ROMs attached to Parade Technologies LSPCONs)" +.sp Some programmers have optional or mandatory parameters which are described in detail in the .B PROGRAMMER-SPECIFIC INFORMATION @@ -1411,21 +1413,25 @@ If the passed frequency is not supported by the adapter the nearest lower supported frequency will be used. .SS -.BR "realtek_mst_i2c_spi " programmer +.BR "realtek_mst_i2c_spi " and " lspcon_i2c_spi " programmers .IP -This programmer supports SPI flash programming for chips attached to Realtek -DisplayPort MST hubs, themselves accessed through I2C (tunneling SPI flash -commands through the MST hub's I2C connection with the host). - -The I2C bus on which the hub is reachable must be specified by either a device -path with the \fBdevpath\fP option: +These programmers tunnel SPI commands through I2C-connected devices. The I2C +bus over which communication occurs must be specified either by device path +with the \fBdevpath\fP option: .sp .B " flashrom \-p realtek_mst_i2c_spi:devpath=/dev/i2c-8" .sp or by a bus number with the \fBbus\fP option, which implies a device path like /dev/i2c-N where N is the specified bus number: .sp -.B " flashrom \-p realtek_mst_i2c_spi:bus=8" +.B " flashrom \-p lspcon_i2c_spi:bus=8" + +.SS +.BR "realtek_mst_i2c_spi " programmer +.IP +This programmer supports SPI flash programming for chips attached to Realtek +DisplayPort MST hubs, themselves accessed through I2C (tunneling SPI flash +commands through the MST hub's I2C connection with the host). .TP .B In-system programming (ISP) mode .sp @@ -1450,7 +1456,12 @@ .B " flashrom -p realtek_mst_i2c_spi:bus=0,enter-isp=1,reset-mcu=0 -E" .br .B " flashrom -p realtek_mst_i2c_spi:bus=0,enter-isp=0,reset-mcu=1 -w new.bin" -.sp +.SS +.BR "lspcon_i2c_spi " programmer +.IP +This programmer supports SPI flash programming for chips attached to Parade +Technologies DisplayPort-to-HDMI level shifter/protocol converters (LSPCONs). +Communication to the SPI flash is tunneled through the LSPCON over I2C. .SH EXAMPLES To back up and update your BIOS, run @@ -1529,8 +1540,8 @@ .B ogp needs PCI configuration space read access and raw memory access. .sp -.B realtek_mst_i2c_spi -needs userspace access to the selected I2C bus. +.BR realtek_mst_i2c_spi " and " lspcon_i2c_spi +need userspace access to the selected I2C bus. .sp On OpenBSD, you can obtain raw access permission by setting .B "securelevel=-1" -- To view, visit https://review.coreboot.org/c/flashrom/+/63104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9ccb9694fdea29e68f062cc049efc0204917a139 Gerrit-Change-Number: 63104 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

Change in flashrom[master]: board_enable.c: Remove unnecessary assignment
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Felix Singer, Idwer Vollering, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62761 ) Change subject: board_enable.c: Remove unnecessary assignment ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62761/comment/b2bd474f_27081558 PS7, Line 7: Fix dead assignment > Well, actually this doesn't fix … [View More]

1 0

Change in flashrom[master]: serprog.c: Avoid calling memcpy with NULL pointer arguments
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 ) Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ...................................................................... Patch Set 14: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62726/comment/4474ac52_d00fcf4d PS12, Line 10: Although, since parmlen is also 0 at that … [View More]

1 0

Change in flashrom[master]: serprog.c: Avoid calling memcpy with NULL pointer arguments
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Paul Menzel, Angel Pons, Light. Hello build bot (Jenkins), Nico Huber, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62726 to look at the new patch set (#14). Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ...................................................................... serprog.c: Avoid calling memcpy with NULL pointer arguments In … [View More]

1 0

Change in flashrom[master]: libflashrom.c: Fix unintialized value passed to function
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 ) Change subject: libflashrom.c: Fix unintialized value passed to function ...................................................................... Patch Set 16: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62725/comment/8c4468e7_a689578e PS15, Line 11: value > IMO, "variable is passed"… [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow ...
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Angel Pons, Light, Anastasia Klimchuk. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62764 to look at the new patch set (#10). Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error ...................................................................... ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow … [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Initialize structures
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Angel Pons, Light. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62763 to look at the new patch set (#8). Change subject: ich_descriptors.c: Initialize structures ...................................................................... ich_descriptors.c: Initialize structures Initialize structures so that they do not … [View More]

1 0

Change in flashrom[master]: board_enable.c: Remove unnecessary assignment
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Idwer Vollering, Angel Pons, Light. Hello Felix Singer, Keith Hui, build bot (Jenkins), Nico Huber, Angel Pons, Anastasia Klimchuk, Keith Hui, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62761 to look at the new patch set (#8). Change subject: board_enable.c: Remove unnecessary assignment ...................................................................... board_enable.c: Remove unnecessary … [View More]

1 0

Change in flashrom[master]: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Light, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62747 to look at the new patch set (#10). Change subject: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc ...................................................................... flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc … [View More]

1 0

Change in flashrom[master]: serprog.c: Avoid calling memcpy with NULL pointer arguments
by Light (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Paul Menzel, Angel Pons, Light. Hello build bot (Jenkins), Nico Huber, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62726 to look at the new patch set (#13). Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ...................................................................... serprog.c: Avoid calling memcpy with NULL pointer arguments In … [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022