November 2022 - flashrom-gerrit

[M] Change in flashrom[master]: [RFC][OTP] dummyflasher: emulate OTP for W25Q128FV
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59404 ) Change subject: [RFC][OTP] dummyflasher: emulate OTP for W25Q128FV ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1af3ac22a66104517f1fe035e034404c6b249257 Gerrit-Change-Number: 59404 Gerrit-PatchSet: 27 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: [RFC][OTP] dummyflasher: add EN25QH128 chip with OTP mode
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59708 ) Change subject: [RFC][OTP] dummyflasher: add EN25QH128 chip with OTP mode ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id5857db43ebf2613bdb5e99342d28d4e0981a6b8 Gerrit-Change-Number: 59708 Gerrit-PatchSet: 23 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[L] Change in flashrom[master]: [RFC][OTP] flashchips: add support for OTP to several chip models
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59405 ) Change subject: [RFC][OTP] flashchips: add support for OTP to several chip models ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I98491ed00d1e5fa6682bcdc4d5e132ec76447f21 Gerrit-Change-Number: 59405 Gerrit-PatchSet: 27 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[L] Change in flashrom[master]: [RFC][OTP] tests: add tests for OTP regions
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59406 ) Change subject: [RFC][OTP] tests: add tests for OTP regions ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ff584395367dfd52db89332d8e45d7e865276e1 Gerrit-Change-Number: 59406 Gerrit-PatchSet: 27 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[L] Change in flashrom[master]: [RFC][OTP] cli_classic: add options for managing OTP regions
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59407 ) Change subject: [RFC][OTP] cli_classic: add options for managing OTP regions ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59407 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If77694e3b1c453b3fc0561da7a9eefdbce4fbb2b Gerrit-Change-Number: 59407 Gerrit-PatchSet: 27 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: [RFC][OTP] dummyflasher: implement SCUR and OTP for MX25L6436
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59710 ) Change subject: [RFC][OTP] dummyflasher: implement SCUR and OTP for MX25L6436 ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13716d597d305351ec27d532e9020615c397693a Gerrit-Change-Number: 59710 Gerrit-PatchSet: 23 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: [RFC][OTP] otp: support 2-bit locks
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59711 ) Change subject: [RFC][OTP] otp: support 2-bit locks ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0593724901a0e354f1016405577f60ac82d4b14c Gerrit-Change-Number: 59711 Gerrit-PatchSet: 23 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: [RFC][OTP] flashchips,otp: support MX25L6436E "family"
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59712 ) Change subject: [RFC][OTP] flashchips,otp: support MX25L6436E "family" ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7e9dbef8632d8a1ef9322286b5fb1c0b47e8007e Gerrit-Change-Number: 59712 Gerrit-PatchSet: 23 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: [RFC][OTP] tests: test OTP with security register
by Sergii Dmytruk (Code Review) Nov. 30, 2022

Nov. 30, 2022

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59713 ) Change subject: [RFC][OTP] tests: test OTP with security register ...................................................................... Abandoned No one is interested: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/BQWD… -- To view, visit https://review.coreboot.org/c/flashrom/+/59713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib0e4d948a200d0cf1e670d67623f7087005d5d39 Gerrit-Change-Number: 59713 Gerrit-PatchSet: 23 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: flashrom: Skip read/write/erase/verify ops on inaccessable flash regions
by Angel Pons (Code Review) Nov. 30, 2022

Nov. 30, 2022

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70128 ) Change subject: flashrom: Skip read/write/erase/verify ops on inaccessable flash regions ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/70128/comment/2c24b6ae_add81200 PS6, Line 10: invalid `unreadable` or `read-protected` would be more accurate. https://review.coreboot.org/c/flashrom/+/70128/comment/447835a0_cfea9341 PS6, Line 11: platforms with active an CSME coprocessor. Currently, the way to use flashrom to erase/write parts of a flash chip when some other regions are not readable is to use a layout (e.g. `--ifd`) and specify `--noverify-all` to skip verifying non-targeted regions. Looks like this approach silently ignores non-readable and non-writable regions, which is dangerous as it can trick the user into thinking that something went well when it did not. As people don't usually read flashrom logs (the `--noverify-all` thing is explained in the flashrom log, and we've pointed at it too many times after people asked for help about "transaction error"), an error message alone won't cut it: we *need* to bail out if flashrom can't do what the user asked for (except if the user explicitly asked to `force-I-want-a-brick`). How about adapting these changes to error out when the requested operations cannot be performed because of read/write restrictions? This means bailing out if trying to read a read-protected region or trying to erase/write a write-protected region. The latter would be especially useful as flashrom currently tries to erase/write when something (SMM BIOS write protection or protected ranges) prevents doing so, which risks bricking devices and will fail with a scary error message. See https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/PIZM… for an example of unnecessary risk that could be avoided. -- To view, visit https://review.coreboot.org/c/flashrom/+/70128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9b96fb04b863625d2c9f9a00b97c35b3ddb0871b Gerrit-Change-Number: 70128 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:12:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0