Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70128 )
Change subject: flashrom: Skip read/write/erase/verify ops on inaccessable flash regions ......................................................................
Patch Set 6:
https://review.coreboot.org/c/flashrom/+/70128/comment/2c24b6ae_add81200 PS6, Line 10: invalid `unreadable` or `read-protected` would be more accurate.
https://review.coreboot.org/c/flashrom/+/70128/comment/447835a0_cfea9341 PS6, Line 11: platforms with active an CSME coprocessor. Currently, the way to use flashrom to erase/write parts of a flash chip when some other regions are not readable is to use a layout (e.g. `--ifd`) and specify `--noverify-all` to skip verifying non-targeted regions. Looks like this approach silently ignores non-readable and non-writable regions, which is dangerous as it can trick the user into thinking that something went well when it did not. As people don't usually read flashrom logs (the `--noverify-all` thing is explained in the flashrom log, and we've pointed at it too many times after people asked for help about "transaction error"), an error message alone won't cut it: we *need* to bail out if flashrom can't do what the user asked for (except if the user explicitly asked to `force-I-want-a-brick`).
How about adapting these changes to error out when the requested operations cannot be performed because of read/write restrictions? This means bailing out if trying to read a read-protected region or trying to erase/write a write-protected region. The latter would be especially useful as flashrom currently tries to erase/write when something (SMM BIOS write protection or protected ranges) prevents doing so, which risks bricking devices and will fail with a scary error message. See https://email@example.com/thread/PIZM2... for an example of unnecessary risk that could be avoided.