November 2022 - flashrom-gerrit

[M] Change in flashrom[1.3.x]: ichspi: Fix number of bytes for HW seq operations
by Edward O'Callaghan (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70039 ) Change subject: ichspi: Fix number of bytes for HW seq operations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/70039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x Gerrit-Change-Id: I5b911655649c693e576497520687d7810bbd3c54 Gerrit-Change-Number: 70039 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 04:14:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tests: Add selfcheck to unit tests
by Evan Benn (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk. Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69620 ) Change subject: tests: Add selfcheck to unit tests ...................................................................... Patch Set 8: (14 comments) File tests/selfcheck.c: https://review.coreboot.org/c/flashrom/+/69620/comment/8d0f9f14_4229ce35 PS7, Line 40: programmer row > programmer entry Done https://review.coreboot.org/c/flashrom/+/69620/comment/58eea079_bb8d1d61 PS7, Line 68: assert_table(chip->bustype != BUS_NONE, "chip bustype is BUS_NONE", i, : chip->name); > make one line I had my clang-format set to 96 chars, but now I see flashrom likes 112 chars. fixed https://review.coreboot.org/c/flashrom/+/69620/comment/b72c8b15_59355dab PS7, Line 74: { > You can add `(void)state; /* unused */` in the beginning here. […] Done https://review.coreboot.org/c/flashrom/+/69620/comment/e8418d19_5ae70345 PS7, Line 87: /* Blocks with zero size are bugs in flashchips.c. */ : /* Blocks with zero size are bugs in flashchips.c. */ > Same line repeats twice? Done https://review.coreboot.org/c/flashrom/+/69620/comment/3d28afce_f56c8996 PS7, Line 89: if (eraser.eraseblocks[i].count : && !eraser.eraseblocks[i].size) { > make if condition on one line Done https://review.coreboot.org/c/flashrom/+/69620/comment/a4f70619_d5d01b1f PS7, Line 91: fail_msg( : "Flash chip %s erase function " : "%zu region %zu has size 0", > make one line (out of 91-93) Done https://review.coreboot.org/c/flashrom/+/69620/comment/dbbac0d2_e900949e PS7, Line 97: if (!eraser.eraseblocks[i].count : && eraser.eraseblocks[i].size) { > make if condition on one line Done https://review.coreboot.org/c/flashrom/+/69620/comment/790d3b36_9bc137ea PS7, Line 99: fail_msg( : "Flash chip %s erase function " : "%zu region %zu has count 0", > make one line (out of 99-101) Done https://review.coreboot.org/c/flashrom/+/69620/comment/8b6691fc_d8d797b4 PS7, Line 135: > remove empty new line Done https://review.coreboot.org/c/flashrom/+/69620/comment/7fb9031b_c903ded5 PS7, Line 136: fail_msg( : "Flash chip %s erase function " : "%zu and %zu are identical.", > make one line (out of 136-138) Done https://review.coreboot.org/c/flashrom/+/69620/comment/19ab723e_193eb06f PS7, Line 143: fail_msg( : "Flash chip %s erase function %zu is not " : "in order", > make one line (out of 143-145) Done https://review.coreboot.org/c/flashrom/+/69620/comment/90dee401_7976b64e PS7, Line 170: fail_msg("Board enable for %s %s is misdefined.\n", b->vendor_name, : b->board_name); > make one line Done File tests/tests.h: https://review.coreboot.org/c/flashrom/+/69620/comment/5499c9af_7133b932 PS7, Line 90: _tables > The file name is `selfcheck. […] Done File tests/well_formed_tables.c: https://review.coreboot.org/c/flashrom/+/69620/comment/1f4eb368_a59e995e PS6, Line 83: SKIP_TEST > not done :P sorry! clang-format overrode me -- To view, visit https://review.coreboot.org/c/flashrom/+/69620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Gerrit-Change-Number: 69620 Gerrit-PatchSet: 8 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 01:55:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tests: Add selfcheck to unit tests
by Evan Benn (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Evan Benn. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69620 to look at the new patch set (#8). Change subject: tests: Add selfcheck to unit tests ...................................................................... tests: Add selfcheck to unit tests Add unit tests for programmer_table, flashchips, and board_matches structs. The tests are derived from the selfcheck function, checking that the required fields have been filled in. BUG=b:140595239 BRANCH=None TEST=meson test Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Signed-off-by: Evan Benn <evanbenn(a)chromium.org> --- M board_enable.c M include/programmer.h M tests/meson.build A tests/selfcheck.c M tests/tests.c M tests/tests.h 6 files changed, 192 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/69620/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/69620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Gerrit-Change-Number: 69620 Gerrit-PatchSet: 8 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[1.3.x]: libpayload: Fix compiling bugs
by Anastasia Klimchuk (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70040 ) Change subject: libpayload: Fix compiling bugs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/70040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x Gerrit-Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f Gerrit-Change-Number: 70040 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 01:20:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[1.3.x]: ichspi: Fix number of bytes for HW seq operations
by Anastasia Klimchuk (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70039 ) Change subject: ichspi: Fix number of bytes for HW seq operations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/70039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x Gerrit-Change-Id: I5b911655649c693e576497520687d7810bbd3c54 Gerrit-Change-Number: 70039 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 01:19:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[1.3.x]: ichspi: Clear Fast SPI HSFC register before HW seq operation
by Anastasia Klimchuk (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69998 ) Change subject: ichspi: Clear Fast SPI HSFC register before HW seq operation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x Gerrit-Change-Id: I4cc3f24f880d1d621f1f48a6e6b276449fa46f98 Gerrit-Change-Number: 69998 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 01:19:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.3.x]: opaque_master: Mark Opaque chip as tested for WP
by Anastasia Klimchuk (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69997 ) Change subject: opaque_master: Mark Opaque chip as tested for WP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x Gerrit-Change-Id: I5ae4cb49eb0abc6ab26cfe2f3359e4e50dd4fd4f Gerrit-Change-Number: 69997 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 01:18:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.3.x]: linux_mtd: Mark Opaque chip as tested for WP
by Anastasia Klimchuk (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69996 ) Change subject: linux_mtd: Mark Opaque chip as tested for WP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x Gerrit-Change-Id: Icc0521c28555a93f26ce66bdbeaa68590f10c358 Gerrit-Change-Number: 69996 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 01:18:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.3.x]: cli_classic.c: Be consistent with pointer types
by Anastasia Klimchuk (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69995 ) Change subject: cli_classic.c: Be consistent with pointer types ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x Gerrit-Change-Id: Ie8f5bc0d9296f7c6b8f8a351b53052f5fe86b09d Gerrit-Change-Number: 69995 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 01:18:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tests: Add selfcheck to unit tests
by Anastasia Klimchuk (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Evan Benn. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69620 ) Change subject: tests: Add selfcheck to unit tests ...................................................................... Patch Set 7: (15 comments) File tests/selfcheck.c: https://review.coreboot.org/c/flashrom/+/69620/comment/d6d7adef_7cdced17 PS7, Line 40: programmer row programmer entry https://review.coreboot.org/c/flashrom/+/69620/comment/ba1faf3e_3c1c2f79 PS7, Line 68: assert_table(chip->bustype != BUS_NONE, "chip bustype is BUS_NONE", i, : chip->name); make one line https://review.coreboot.org/c/flashrom/+/69620/comment/01f43ced_4c329c3f PS7, Line 74: { You can add `(void)state; /* unused */` in the beginning here. And don't forget new line after :) https://review.coreboot.org/c/flashrom/+/69620/comment/a4882238_416078f2 PS7, Line 87: /* Blocks with zero size are bugs in flashchips.c. */ : /* Blocks with zero size are bugs in flashchips.c. */ Same line repeats twice? https://review.coreboot.org/c/flashrom/+/69620/comment/a4e9c405_ed9b7c65 PS7, Line 89: if (eraser.eraseblocks[i].count : && !eraser.eraseblocks[i].size) { make if condition on one line https://review.coreboot.org/c/flashrom/+/69620/comment/82a7942d_3a554945 PS7, Line 91: fail_msg( : "Flash chip %s erase function " : "%zu region %zu has size 0", make one line (out of 91-93) https://review.coreboot.org/c/flashrom/+/69620/comment/7b901ec3_fce91ab2 PS7, Line 97: if (!eraser.eraseblocks[i].count : && eraser.eraseblocks[i].size) { make if condition on one line https://review.coreboot.org/c/flashrom/+/69620/comment/2db58e2e_deba01a6 PS7, Line 99: fail_msg( : "Flash chip %s erase function " : "%zu region %zu has count 0", make one line (out of 99-101) https://review.coreboot.org/c/flashrom/+/69620/comment/2858275b_5457302b PS7, Line 135: remove empty new line https://review.coreboot.org/c/flashrom/+/69620/comment/644ebc9e_bc2215fa PS7, Line 136: fail_msg( : "Flash chip %s erase function " : "%zu and %zu are identical.", make one line (out of 136-138) https://review.coreboot.org/c/flashrom/+/69620/comment/0b4f067d_59c49825 PS7, Line 143: fail_msg( : "Flash chip %s erase function %zu is not " : "in order", make one line (out of 143-145) https://review.coreboot.org/c/flashrom/+/69620/comment/0721dbe9_6cd0eb7c PS7, Line 170: fail_msg("Board enable for %s %s is misdefined.\n", b->vendor_name, : b->board_name); make one line File tests/tests.h: https://review.coreboot.org/c/flashrom/+/69620/comment/bdad05c0_58858fc3 PS7, Line 90: _tables The file name is `selfcheck.c` without `_tables` suffix File tests/well_formed_tables.c: https://review.coreboot.org/c/flashrom/+/69620/comment/a9e6ae8b_7edd2282 PS6, Line 24: do { \ : if (!(assertion)) \ : fail_msg(#assertion " is false for index:%zu name:%s", (index), \ : (name) ? (name) : "unknown"); \ : } while (0) > I agree that would be the preferred style but a macro is used so that the __LINE__ format used by fa […] Having correct __LINE__ is important, helps a lot with debugging tests. So I am happy to keep as it is. Felix would you agree? https://review.coreboot.org/c/flashrom/+/69620/comment/12ce4e84_8a724dc2 PS6, Line 83: SKIP_TEST > Done not done :P -- To view, visit https://review.coreboot.org/c/flashrom/+/69620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Gerrit-Change-Number: 69620 Gerrit-PatchSet: 7 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 00:40:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022