Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68060 )
Change subject: print_wiki.c: Update mailing list reference
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Gerrit-Change-Number: 68060
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Sun, 02 Oct 2022 22:12:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68062
to review the following change.
Change subject: print_wiki.c: Update mailing list reference
......................................................................
print_wiki.c: Update mailing list reference
Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56030
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M print_wiki.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/68062/1
diff --git a/print_wiki.c b/print_wiki.c
index b2ac65c..aecefcc 100644
--- a/print_wiki.c
+++ b/print_wiki.c
@@ -80,7 +80,7 @@
or may not be added later.\n\n\
Mainboards (or individual revisions) which don't appear in the list may or may \
not work (we don't know, someone has to give it a try). Please report any \
-further verified mainboards on the [[Mailinglist|mailing list]].\n";
+further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n";
#endif
static const char chip_th[] = "\
--
To view, visit https://review.coreboot.org/c/flashrom/+/68062
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.2.x
Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Gerrit-Change-Number: 68062
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68063
to review the following change.
Change subject: Replace freenode references
......................................................................
Replace freenode references
The flashrom project no longer uses freenode. To avoid having outdated
man pages in the future, the contact methods are now listed in the wiki.
Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56031
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M README
M flashrom.8.tmpl
M flashrom.c
3 files changed, 32 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/68063/1
diff --git a/README b/README
index 4e7bd4f..71e8735 100644
--- a/README
+++ b/README
@@ -183,10 +183,6 @@
http://www.flashrom.org/
-The IRC channel is
+Available contact methods are
- #flashrom at irc.freenode.net
-
-The mailing list address is
-
- flashrom(a)flashrom.org
+ https://www.flashrom.org/Contact
diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl
index 959e5fd..e67cdea 100644
--- a/flashrom.8.tmpl
+++ b/flashrom.8.tmpl
@@ -1378,24 +1378,13 @@
.B "/etc/rc.securelevel"
and rebooting, or rebooting into single user mode.
.SH BUGS
-Please report any bugs to the
-.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" .
+You can report bugs, ask us questions or send success reports
+via our communication channels listed here:
+.URLB "https://www.flashrom.org/Contact" "" .
.sp
-We recommend to subscribe first at
-.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" .
-.sp
-Many of the developers communicate via the
-.B "#flashrom"
-IRC channel on
-.BR chat.freenode.net .
-If you don't have an IRC client, you can use the
-.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" .
-You are welcome to join and ask questions, send us bug and success reports there
-too. Please provide a way to contact you later (e.g.\& a mail address) and be
-patient if there is no immediate reaction. Also, we provide a
+Also, we provide a
.URLB https://paste.flashrom.org "pastebin service"
-that is very useful when you want to share logs etc.\& without spamming the
-channel.
+that is very useful to share logs without spamming the communication channels.
.SS
.B Laptops
.sp
diff --git a/flashrom.c b/flashrom.c
index e540027..61e9530 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -1864,16 +1864,16 @@
#if CONFIG_INTERNAL == 1
if (programmer == PROGRAMMER_INTERNAL)
msg_gerr("This means we have to add special support for your board, programmer or flash\n"
- "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n"
+ "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n"
+ "IRC (see https://www.flashrom.org/Contact for details), thanks!\n"
"-------------------------------------------------------------------------------\n"
"You may now reboot or simply leave the machine running.\n");
else
#endif
msg_gerr("Please check the connections (especially those to write protection pins) between\n"
"the programmer and the flash chip. If you think the error is caused by flashrom\n"
- "please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n"
+ "https://www.flashrom.org/Contact for details), thanks!\n");
}
static void emergency_help_message(void)
@@ -1881,14 +1881,14 @@
msg_gerr("Your flash chip is in an unknown state.\n");
#if CONFIG_INTERNAL == 1
if (programmer == PROGRAMMER_INTERNAL)
- msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n"
+ msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n"
+ "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!"
"-------------------------------------------------------------------------------\n"
"DO NOT REBOOT OR POWEROFF!\n");
else
#endif
- msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n"
+ "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n");
}
void list_programmers_linebreak(int startcol, int cols, int paren)
--
To view, visit https://review.coreboot.org/c/flashrom/+/68063
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.2.x
Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Gerrit-Change-Number: 68063
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68058 )
Change subject: print_wiki.c: Update mailing list reference
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Gerrit-Change-Number: 68058
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Sun, 02 Oct 2022 22:12:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68061
to review the following change.
Change subject: Replace freenode references
......................................................................
Replace freenode references
The flashrom project no longer uses freenode. To avoid having outdated
man pages in the future, the contact methods are now listed in the wiki.
Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56031
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M README
M flashrom.8.tmpl
M flashrom.c
3 files changed, 32 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/68061/1
diff --git a/README b/README
index 4e7bd4f..71e8735 100644
--- a/README
+++ b/README
@@ -183,10 +183,6 @@
http://www.flashrom.org/
-The IRC channel is
+Available contact methods are
- #flashrom at irc.freenode.net
-
-The mailing list address is
-
- flashrom(a)flashrom.org
+ https://www.flashrom.org/Contact
diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl
index 5192d0b..df9c79b 100644
--- a/flashrom.8.tmpl
+++ b/flashrom.8.tmpl
@@ -1277,24 +1277,13 @@
.B "/etc/rc.securelevel"
and rebooting, or rebooting into single user mode.
.SH BUGS
-Please report any bugs to the
-.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" .
+You can report bugs, ask us questions or send success reports
+via our communication channels listed here:
+.URLB "https://www.flashrom.org/Contact" "" .
.sp
-We recommend to subscribe first at
-.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" .
-.sp
-Many of the developers communicate via the
-.B "#flashrom"
-IRC channel on
-.BR chat.freenode.net .
-If you don't have an IRC client, you can use the
-.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" .
-You are welcome to join and ask questions, send us bug and success reports there
-too. Please provide a way to contact you later (e.g.\& a mail address) and be
-patient if there is no immediate reaction. Also, we provide a
+Also, we provide a
.URLB https://paste.flashrom.org "pastebin service"
-that is very useful when you want to share logs etc.\& without spamming the
-channel.
+that is very useful to share logs without spamming the communication channels.
.SS
.B Laptops
.sp
diff --git a/flashrom.c b/flashrom.c
index d6c4d24..b7d77c7 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -1982,16 +1982,16 @@
#if CONFIG_INTERNAL == 1
if (programmer == PROGRAMMER_INTERNAL)
msg_gerr("This means we have to add special support for your board, programmer or flash\n"
- "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n"
+ "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n"
+ "IRC (see https://www.flashrom.org/Contact for details), thanks!\n"
"-------------------------------------------------------------------------------\n"
"You may now reboot or simply leave the machine running.\n");
else
#endif
msg_gerr("Please check the connections (especially those to write protection pins) between\n"
"the programmer and the flash chip. If you think the error is caused by flashrom\n"
- "please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n"
+ "https://www.flashrom.org/Contact for details), thanks!\n");
}
static void emergency_help_message(void)
@@ -1999,14 +1999,14 @@
msg_gerr("Your flash chip is in an unknown state.\n");
#if CONFIG_INTERNAL == 1
if (programmer == PROGRAMMER_INTERNAL)
- msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n"
+ msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n"
+ "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!"
"-------------------------------------------------------------------------------\n"
"DO NOT REBOOT OR POWEROFF!\n");
else
#endif
- msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n"
+ "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n");
}
/* The way to go if you want a delimited list of programmers */
--
To view, visit https://review.coreboot.org/c/flashrom/+/68061
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Gerrit-Change-Number: 68061
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68060
to review the following change.
Change subject: print_wiki.c: Update mailing list reference
......................................................................
print_wiki.c: Update mailing list reference
Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56030
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M print_wiki.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/68060/1
diff --git a/print_wiki.c b/print_wiki.c
index ea8c4d7..7e86ab4 100644
--- a/print_wiki.c
+++ b/print_wiki.c
@@ -80,7 +80,7 @@
or may not be added later.\n\n\
Mainboards (or individual revisions) which don't appear in the list may or may \
not work (we don't know, someone has to give it a try). Please report any \
-further verified mainboards on the [[Mailinglist|mailing list]].\n";
+further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n";
#endif
static const char chip_th[] = "\
--
To view, visit https://review.coreboot.org/c/flashrom/+/68060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Gerrit-Change-Number: 68060
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68059
to review the following change.
Change subject: Replace freenode references
......................................................................
Replace freenode references
The flashrom project no longer uses freenode. To avoid having outdated
man pages in the future, the contact methods are now listed in the wiki.
Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56031
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M README
M flashrom.8.tmpl
M flashrom.c
3 files changed, 32 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/68059/1
diff --git a/README b/README
index b5ed946..cd2a927 100644
--- a/README
+++ b/README
@@ -182,10 +182,6 @@
http://www.flashrom.org/
-The IRC channel is
+Available contact methods are
- #flashrom at irc.freenode.net
-
-The mailing list address is
-
- flashrom(a)flashrom.org
+ https://www.flashrom.org/Contact
diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl
index 143d76c..37e8398 100644
--- a/flashrom.8.tmpl
+++ b/flashrom.8.tmpl
@@ -1146,24 +1146,13 @@
.B "/etc/rc.securelevel"
and rebooting, or rebooting into single user mode.
.SH BUGS
-Please report any bugs to the
-.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" .
+You can report bugs, ask us questions or send success reports
+via our communication channels listed here:
+.URLB "https://www.flashrom.org/Contact" "" .
.sp
-We recommend to subscribe first at
-.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" .
-.sp
-Many of the developers communicate via the
-.B "#flashrom"
-IRC channel on
-.BR chat.freenode.net .
-If you don't have an IRC client, you can use the
-.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" .
-You are welcome to join and ask questions, send us bug and success reports there
-too. Please provide a way to contact you later (e.g.\& a mail address) and be
-patient if there is no immediate reaction. Also, we provide a
+Also, we provide a
.URLB https://paste.flashrom.org "pastebin service"
-that is very useful when you want to share logs etc.\& without spamming the
-channel.
+that is very useful to share logs without spamming the communication channels.
.SS
.B Laptops
.sp
diff --git a/flashrom.c b/flashrom.c
index 51f9721..2213da1 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -1940,16 +1940,16 @@
#if CONFIG_INTERNAL == 1
if (programmer == PROGRAMMER_INTERNAL)
msg_gerr("This means we have to add special support for your board, programmer or flash\n"
- "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n"
+ "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n"
+ "IRC (see https://www.flashrom.org/Contact for details), thanks!\n"
"-------------------------------------------------------------------------------\n"
"You may now reboot or simply leave the machine running.\n");
else
#endif
msg_gerr("Please check the connections (especially those to write protection pins) between\n"
"the programmer and the flash chip. If you think the error is caused by flashrom\n"
- "please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n"
+ "https://www.flashrom.org/Contact for details), thanks!\n");
}
static void emergency_help_message(void)
@@ -1957,14 +1957,14 @@
msg_gerr("Your flash chip is in an unknown state.\n");
#if CONFIG_INTERNAL == 1
if (programmer == PROGRAMMER_INTERNAL)
- msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n"
+ msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n"
+ "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!"
"-------------------------------------------------------------------------------\n"
"DO NOT REBOOT OR POWEROFF!\n");
else
#endif
- msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n"
+ "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n");
}
/* The way to go if you want a delimited list of programmers */
--
To view, visit https://review.coreboot.org/c/flashrom/+/68059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Gerrit-Change-Number: 68059
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68058
to review the following change.
Change subject: print_wiki.c: Update mailing list reference
......................................................................
print_wiki.c: Update mailing list reference
Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56030
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M print_wiki.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/68058/1
diff --git a/print_wiki.c b/print_wiki.c
index d2fb5e2..7438852 100644
--- a/print_wiki.c
+++ b/print_wiki.c
@@ -84,7 +84,7 @@
or may not be added later.\n\n\
Mainboards (or individual revisions) which don't appear in the list may or may \
not work (we don't know, someone has to give it a try). Please report any \
-further verified mainboards on the [[Mailinglist|mailing list]].\n";
+further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n";
#endif
static const char chip_th[] = "\
--
To view, visit https://review.coreboot.org/c/flashrom/+/68058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Gerrit-Change-Number: 68058
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Thomas Heijligen.
Shreeyash has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 )
Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
......................................................................
Patch Set 2:
(1 comment)
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/66225/comment/7217f6b2_1c9ca24d
PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx,
> Sorry, this has gone under. […]
I think both the issues have been 'fixed'. It would be better to NULL-Initialize stlinkv3_handle atleast to eradicate static analysis warnings, else more patches dealing with the same issue will pop up. I see that there has been some change with extract_programmer_param_str function and the variables that store its return value. This must be from a patch introduced somewhere else (and the cause of merge conflict?).
What do I have to do now?
--
To view, visit https://review.coreboot.org/c/flashrom/+/66225
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f
Gerrit-Change-Number: 66225
Gerrit-PatchSet: 2
Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Sun, 02 Oct 2022 14:55:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com>
Gerrit-MessageType: comment