October 2022 - flashrom-gerrit

[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
by Edward O'Callaghan (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Thomas Heijligen, Angel Pons, Jonathon Hall, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ...................................................................... Patch Set 7: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/67695/comment/b72297f5_0d60f312 PS2, Line 1865: &mapper_phys > +1 regarding divide and conquer. […] Yep Angel said it very well. Ideally if we can get to 'the new way' right at the very end of the series that is best. That way it is easy to bisect &| revert. Recent story: Recently we worked on getting rid of the programmer parameter singleton pattern in flashrom.c I made sure to do all the refactoring so the switch over was right at the end assuming there was a devil hiding there. There definitely was!!! My first attempt needed to be reverted, Angel took another go at it and after one more patch after that we finally got there in the end. Because of all the global state in flashrom it is sometimes exceedingly hard to see where it will all explode despite everyone's best intentions. We just got to be a little particular about laying out the groundwork to avoid too much foot gun wrangling this map stuff but things are getting easier to manage step by step, thank you for working on this - a lot!!! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 09:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: realtek_mst_i2c_spi.c: Move variable allow_brick into parameters struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67896 ) Change subject: realtek_mst_i2c_spi.c: Move variable allow_brick into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I98ef6f7a44714ea684b6875dc7e61ea5e5911184 Gerrit-Change-Number: 67896 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: realtek_mst_i2c_spi.c: Move variable enter_isp into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67897 ) Change subject: realtek_mst_i2c_spi.c: Move variable enter_isp into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If95160c68b2dea40fb31abf68a430be5d20c4cf1 Gerrit-Change-Number: 67897 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: realtek_mst_i2c_spi.c: Move parameters into struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67895 to look at the new patch set (#3). Change subject: realtek_mst_i2c_spi.c: Move parameters into struct ...................................................................... realtek_mst_i2c_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I471ce9e6fedc5ec7f3d2bf54a0e1633dbac3cfd5 --- M realtek_mst_i2c_spi.c 1 file changed, 30 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67895/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I471ce9e6fedc5ec7f3d2bf54a0e1633dbac3cfd5 Gerrit-Change-Number: 67895 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `psu` into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67894 ) Change subject: buspirate_spi.c: Move variable `psu` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I928af8450734473cdf1c07796b6c57c328d587d5 Gerrit-Change-Number: 67894 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `pullup` into parameters struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67893 ) Change subject: buspirate_spi.c: Move variable `pullup` into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6b571d2f034fc3f8657cc4e9a0f2891df84e38c3 Gerrit-Change-Number: 67893 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `spispeed` into parameters struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67892 ) Change subject: buspirate_spi.c: Move variable `spispeed` into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I816a0017dcb206a8f3284c1c79aed20a96008406 Gerrit-Change-Number: 67892 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: buspirate_spi.c: Move parameters into struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67891 to look at the new patch set (#3). Change subject: buspirate_spi.c: Move parameters into struct ...................................................................... buspirate_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I5a791f1d9204982d7972eed85ccf8eb10ce02b78 --- M buspirate_spi.c 1 file changed, 39 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/67891/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a791f1d9204982d7972eed85ccf8eb10ce02b78 Gerrit-Change-Number: 67891 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `enable_target_power` into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67889 ) Change subject: jlink_spi.c: Move variable `enable_target_power` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id32a6866372658a04fd62385d226294cfbcd4227 Gerrit-Change-Number: 67889 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `reset_cs` into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67888 ) Change subject: jlink_spi.c: Move variable `reset_cs` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I79f9009b407bc5601fa03878b6fe53c190214c3f Gerrit-Change-Number: 67888 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022