October 2022 - flashrom-gerrit

[M] Change in flashrom[1.0.x]: Replace freenode references
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68059 to review the following change. Change subject: Replace freenode references ...................................................................... Replace freenode references The flashrom project no longer uses freenode. To avoid having outdated man pages in the future, the contact methods are now listed in the wiki. Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56031 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M README M flashrom.8.tmpl M flashrom.c 3 files changed, 32 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/68059/1 diff --git a/README b/README index b5ed946..cd2a927 100644 --- a/README +++ b/README @@ -182,10 +182,6 @@ http://www.flashrom.org/ -The IRC channel is +Available contact methods are - #flashrom at irc.freenode.net - -The mailing list address is - - flashrom(a)flashrom.org + https://www.flashrom.org/Contact diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 143d76c..37e8398 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -1146,24 +1146,13 @@ .B "/etc/rc.securelevel" and rebooting, or rebooting into single user mode. .SH BUGS -Please report any bugs to the -.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" . +You can report bugs, ask us questions or send success reports +via our communication channels listed here: +.URLB "https://www.flashrom.org/Contact" "" . .sp -We recommend to subscribe first at -.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" . -.sp -Many of the developers communicate via the -.B "#flashrom" -IRC channel on -.BR chat.freenode.net . -If you don't have an IRC client, you can use the -.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" . -You are welcome to join and ask questions, send us bug and success reports there -too. Please provide a way to contact you later (e.g.\& a mail address) and be -patient if there is no immediate reaction. Also, we provide a +Also, we provide a .URLB https://paste.flashrom.org "pastebin service" -that is very useful when you want to share logs etc.\& without spamming the -channel. +that is very useful to share logs without spamming the communication channels. .SS .B Laptops .sp diff --git a/flashrom.c b/flashrom.c index 51f9721..2213da1 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1940,16 +1940,16 @@ #if CONFIG_INTERNAL == 1 if (programmer == PROGRAMMER_INTERNAL) msg_gerr("This means we have to add special support for your board, programmer or flash\n" - "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n" + "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n" + "IRC (see https://www.flashrom.org/Contact for details), thanks!\n" "-------------------------------------------------------------------------------\n" "You may now reboot or simply leave the machine running.\n"); else #endif msg_gerr("Please check the connections (especially those to write protection pins) between\n" "the programmer and the flash chip. If you think the error is caused by flashrom\n" - "please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n" + "https://www.flashrom.org/Contact for details), thanks!\n"); } static void emergency_help_message(void) @@ -1957,14 +1957,14 @@ msg_gerr("Your flash chip is in an unknown state.\n"); #if CONFIG_INTERNAL == 1 if (programmer == PROGRAMMER_INTERNAL) - msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n" + msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n" + "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!" "-------------------------------------------------------------------------------\n" "DO NOT REBOOT OR POWEROFF!\n"); else #endif - msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n" + "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n"); } /* The way to go if you want a delimited list of programmers */ -- To view, visit https://review.coreboot.org/c/flashrom/+/68059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Gerrit-Change-Number: 68059 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.0.x]: print_wiki.c: Update mailing list reference
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68058 to review the following change. Change subject: print_wiki.c: Update mailing list reference ...................................................................... print_wiki.c: Update mailing list reference Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56030 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M print_wiki.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/68058/1 diff --git a/print_wiki.c b/print_wiki.c index d2fb5e2..7438852 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -84,7 +84,7 @@ or may not be added later.\n\n\ Mainboards (or individual revisions) which don't appear in the list may or may \ not work (we don't know, someone has to give it a try). Please report any \ -further verified mainboards on the [[Mailinglist|mailing list]].\n"; +further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n"; #endif static const char chip_th[] = "\ -- To view, visit https://review.coreboot.org/c/flashrom/+/68058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026 Gerrit-Change-Number: 68058 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Shreeyash (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Shreeyash has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (1 comment) File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/7217f6b2_1c9ca24d PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, > Sorry, this has gone under. […] I think both the issues have been 'fixed'. It would be better to NULL-Initialize stlinkv3_handle atleast to eradicate static analysis warnings, else more patches dealing with the same issue will pop up. I see that there has been some change with extract_programmer_param_str function and the variables that store its return value. This must be from a patch introduced somewhere else (and the cause of merge conflict?). What do I have to do now? -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 02 Oct 2022 14:55:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
by Edward O'Callaghan (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Thomas Heijligen, Angel Pons, Jonathon Hall, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ...................................................................... Patch Set 7: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/67695/comment/b72297f5_0d60f312 PS2, Line 1865: &mapper_phys > +1 regarding divide and conquer. […] Yep Angel said it very well. Ideally if we can get to 'the new way' right at the very end of the series that is best. That way it is easy to bisect &| revert. Recent story: Recently we worked on getting rid of the programmer parameter singleton pattern in flashrom.c I made sure to do all the refactoring so the switch over was right at the end assuming there was a devil hiding there. There definitely was!!! My first attempt needed to be reverted, Angel took another go at it and after one more patch after that we finally got there in the end. Because of all the global state in flashrom it is sometimes exceedingly hard to see where it will all explode despite everyone's best intentions. We just got to be a little particular about laying out the groundwork to avoid too much foot gun wrangling this map stuff but things are getting easier to manage step by step, thank you for working on this - a lot!!! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 09:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: realtek_mst_i2c_spi.c: Move variable allow_brick into parameters struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67896 ) Change subject: realtek_mst_i2c_spi.c: Move variable allow_brick into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I98ef6f7a44714ea684b6875dc7e61ea5e5911184 Gerrit-Change-Number: 67896 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: realtek_mst_i2c_spi.c: Move variable enter_isp into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67897 ) Change subject: realtek_mst_i2c_spi.c: Move variable enter_isp into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If95160c68b2dea40fb31abf68a430be5d20c4cf1 Gerrit-Change-Number: 67897 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: realtek_mst_i2c_spi.c: Move parameters into struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67895 to look at the new patch set (#3). Change subject: realtek_mst_i2c_spi.c: Move parameters into struct ...................................................................... realtek_mst_i2c_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I471ce9e6fedc5ec7f3d2bf54a0e1633dbac3cfd5 --- M realtek_mst_i2c_spi.c 1 file changed, 30 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67895/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I471ce9e6fedc5ec7f3d2bf54a0e1633dbac3cfd5 Gerrit-Change-Number: 67895 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `psu` into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67894 ) Change subject: buspirate_spi.c: Move variable `psu` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I928af8450734473cdf1c07796b6c57c328d587d5 Gerrit-Change-Number: 67894 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `pullup` into parameters struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67893 ) Change subject: buspirate_spi.c: Move variable `pullup` into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6b571d2f034fc3f8657cc4e9a0f2891df84e38c3 Gerrit-Change-Number: 67893 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `spispeed` into parameters struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67892 ) Change subject: buspirate_spi.c: Move variable `spispeed` into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I816a0017dcb206a8f3284c1c79aed20a96008406 Gerrit-Change-Number: 67892 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022