Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68068 )
Change subject: [WIP] test_build.sh: Rework programmer selection using Meson
......................................................................
Patch Set 3:
(1 comment)
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/68068/comment/992f5c53_85d41eea
PS3, Line 66: generate_meson_programmer_list
The return value should be checked that its size is greater than 0
--
To view, visit https://review.coreboot.org/c/flashrom/+/68068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859
Gerrit-Change-Number: 68068
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 03 Oct 2022 02:10:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68067 )
Change subject: [WIP] test_build.sh: Rework selection of programmers using Make
......................................................................
Patch Set 4:
(1 comment)
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/68067/comment/fb8aac87_cce3e6fb
PS4, Line 44: generate_make_programmer_list
The return value should be checked that its size is greater than 0
--
To view, visit https://review.coreboot.org/c/flashrom/+/68067
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf
Gerrit-Change-Number: 68067
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 03 Oct 2022 02:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68067
to look at the new patch set (#4).
Change subject: [WIP] test_build.sh: Rework selection of programmers using Make
......................................................................
[WIP] test_build.sh: Rework selection of programmers using Make
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf
---
M test_build.sh
1 file changed, 24 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/68067/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/68067
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf
Gerrit-Change-Number: 68067
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68068 )
Change subject: [WIP] test_build.sh: Rework programmer selection using Meson
......................................................................
Patch Set 2:
(1 comment)
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/68068/comment/2cd7194b_fd6b6922
PS2, Line 52: programmer_list=$(cat ${meson_logfile} | tail -n 1 | sed 's/^.*auto/auto/' | sed 's/\,//g' | sed 's/\"//g')
If anybody knows a better way how to get a list of available programmers, I am open for suggestions
--
To view, visit https://review.coreboot.org/c/flashrom/+/68068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859
Gerrit-Change-Number: 68068
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 03 Oct 2022 01:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68068
to look at the new patch set (#2).
Change subject: [WIP] test_build.sh: Rework programmer selection using Meson
......................................................................
[WIP] test_build.sh: Rework programmer selection using Meson
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859
---
M test_build.sh
1 file changed, 27 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/68068/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859
Gerrit-Change-Number: 68068
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68067
to look at the new patch set (#3).
Change subject: [WIP] test_build.sh: Rework selection of programmers using Make
......................................................................
[WIP] test_build.sh: Rework selection of programmers using Make
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf
---
M test_build.sh
1 file changed, 25 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/68067/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/68067
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf
Gerrit-Change-Number: 68067
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68067
to look at the new patch set (#2).
Change subject: [WIP] test_build.sh: Rework selection of programmers using Make
......................................................................
[WIP] test_build.sh: Rework selection of programmers using Make
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf
---
M test_build.sh
1 file changed, 19 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/68067/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68067
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf
Gerrit-Change-Number: 68067
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset