October 2022 - flashrom-gerrit

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region to par/spi/opaque_master
by Jonathon Hall (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67695 to look at the new patch set (#8). Change subject: drivers: Move (un)map_flash_region to par/spi/opaque_master ...................................................................... drivers: Move (un)map_flash_region to par/spi/opaque_master Move (un)map_flash_region function pointers from programmer_entry to par_master, spi_master, and opaque_master. This enables programmers to specify a different mapper per bus, which is needed for the internal programmer. Mapping is closely tied to the way the memory is accessed using the other functions in the bus master structs. Validate that FWH/LPC programmers provide specialized mapping in register_par_master(); this is needed for chips with FEATURE_REGISTERMAP, which only exist on FWH or LPC buses. programmer.c: Update comment in fallback_map(), NULL return is the desired behavior. Test: Read firmware on SB600 Promontory mainboard (requires physmap) Test: Read firmware externally with ft2232_spi Test: Read firmware on ICH hwseq, verify physmap still occurs Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M atavia.c M dummyflasher.c M flashrom.c M ichspi.c M include/flash.h M include/programmer.h M internal.c M it87spi.c M parallel.c M programmer.c M sb600spi.c M serprog.c M wbsio_spi.c 13 files changed, 146 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67695/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 8 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
by Jonathon Hall (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ...................................................................... Patch Set 7: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/67695/comment/7c34af6b_cd17ffa9 PS2, Line 1865: &mapper_phys > Yep Angel said it very well. […] Yep thank you all, I totally agree! I'm still getting the hang of the Gerrit workflow and what works best for review but I really appreciate all the help! I will rebase this on those patches and split it up. I think this will require temporarily adding a mapper to the opaque bus master that I then remove in a later patch, but that should be straightforward. -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 19:47:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ft2232_spi.c: Split out most programmer param parsing
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67908 ) Change subject: ft2232_spi.c: Split out most programmer param parsing ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Then also see CB:67886 ;) […] Thomas, thanks for the suggestion. We're not sure how to integrate it, though. Could you please elaborate a bit more on it? Thanks. The ultimate goal is to have something like this: ``` int my_prog_init_new(prog_cfg *cfg) { int ret = 0; const struct my_prog_params params = my_prog_get_params(&ret, cfg); if (!ret) ret = my_prog_init(&params); my_prog_release_params(&params); return ret; } ``` Where parsing programmer parameters from the string is separate from actually initializing the programmer itself. The "release_params" function provides a way to free all temporary strings needed for programmer init (e.g. serial numbers and the like). This approach will introduce a bit of overhead (`strdup()` plus `free()`) for strings in programmer params that are stored into the "master" data (e.g. device paths), but it ensures that the dynamic memory used by programmers is under their own control and can't be invalidated by the caller after programmer init. -- To view, visit https://review.coreboot.org/c/flashrom/+/67908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Gerrit-Change-Number: 67908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:04:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Rework programmer selection using Meson
by Felix Singer (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68068 ) Change subject: [WIP] test_build.sh: Rework programmer selection using Meson ...................................................................... Patch Set 3: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/68068/comment/992f5c53_85d41eea PS3, Line 66: generate_meson_programmer_list The return value should be checked that its size is greater than 0 -- To view, visit https://review.coreboot.org/c/flashrom/+/68068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859 Gerrit-Change-Number: 68068 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 02:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Rework selection of programmers using Make
by Felix Singer (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68067 ) Change subject: [WIP] test_build.sh: Rework selection of programmers using Make ...................................................................... Patch Set 4: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/68067/comment/fb8aac87_cce3e6fb PS4, Line 44: generate_make_programmer_list The return value should be checked that its size is greater than 0 -- To view, visit https://review.coreboot.org/c/flashrom/+/68067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf Gerrit-Change-Number: 68067 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 02:09:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Rework selection of programmers using Make
by Felix Singer (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68067 to look at the new patch set (#4). Change subject: [WIP] test_build.sh: Rework selection of programmers using Make ...................................................................... [WIP] test_build.sh: Rework selection of programmers using Make Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf --- M test_build.sh 1 file changed, 24 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/68067/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/68067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf Gerrit-Change-Number: 68067 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Rework programmer selection using Meson
by Felix Singer (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68068 ) Change subject: [WIP] test_build.sh: Rework programmer selection using Meson ...................................................................... Patch Set 2: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/68068/comment/2cd7194b_fd6b6922 PS2, Line 52: programmer_list=$(cat ${meson_logfile} | tail -n 1 | sed 's/^.*auto/auto/' | sed 's/\,//g' | sed 's/\"//g') If anybody knows a better way how to get a list of available programmers, I am open for suggestions -- To view, visit https://review.coreboot.org/c/flashrom/+/68068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859 Gerrit-Change-Number: 68068 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 01:43:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Rework programmer selection using Meson
by Felix Singer (Code Review) 03 Oct '22

03 Oct '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68068 to look at the new patch set (#2). Change subject: [WIP] test_build.sh: Rework programmer selection using Meson ...................................................................... [WIP] test_build.sh: Rework programmer selection using Meson Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859 --- M test_build.sh 1 file changed, 27 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/68068/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859 Gerrit-Change-Number: 68068 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Rework selection of programmers using Make
by Felix Singer (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68067 to look at the new patch set (#3). Change subject: [WIP] test_build.sh: Rework selection of programmers using Make ...................................................................... [WIP] test_build.sh: Rework selection of programmers using Make Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf --- M test_build.sh 1 file changed, 25 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/68067/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18c3c9eb17e13168a51364cee2eff74c2cc0badf Gerrit-Change-Number: 68067 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Rework programmer selection using Meson
by Felix Singer (Code Review) 03 Oct '22

03 Oct '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68068 ) Change subject: [WIP] test_build.sh: Rework programmer selection using Meson ...................................................................... [WIP] test_build.sh: Rework programmer selection using Meson Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859 --- M test_build.sh 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/68068/1 diff --git a/test_build.sh b/test_build.sh index d2ff129..f89827c 100755 --- a/test_build.sh +++ b/test_build.sh @@ -44,6 +44,22 @@ } +generate_meson_programmer_list () { + tmp_dir="tmp" + meson_logfile="${tmp_dir}/meson-logs/meson-log.txt" + + set +e + meson ${tmp_dir} -Dprogrammer=unknown_programmer > /dev/null + set -e + + programmer_list=$(cat ${meson_logfile} | tail -n 1 | sed 's/^.*auto/auto/' | sed 's/\,//g' | sed 's/\"//g') + + rm -rf ${tmp_dir} + + echo ${programmer_list} +} + + build_meson () { build_dir=out meson_opts="-Dtests=enabled" @@ -51,7 +67,7 @@ rm -rf ${build_dir} - for programmer in ${meson_programmer_opts}; do + for programmer in $(generate_meson_programmer_list); do programmer_dir="${build_dir}/${programmer}" # In case of clang analyzer we don't want to run it on -- To view, visit https://review.coreboot.org/c/flashrom/+/68068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859 Gerrit-Change-Number: 68068 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022