October 2022 - flashrom-gerrit

[M] Change in flashrom[master]: buspirate_spi.c: Move parameters into struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67891 to look at the new patch set (#3). Change subject: buspirate_spi.c: Move parameters into struct ...................................................................... buspirate_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I5a791f1d9204982d7972eed85ccf8eb10ce02b78 --- M buspirate_spi.c 1 file changed, 39 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/67891/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a791f1d9204982d7972eed85ccf8eb10ce02b78 Gerrit-Change-Number: 67891 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `enable_target_power` into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67889 ) Change subject: jlink_spi.c: Move variable `enable_target_power` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id32a6866372658a04fd62385d226294cfbcd4227 Gerrit-Change-Number: 67889 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `reset_cs` into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67888 ) Change subject: jlink_spi.c: Move variable `reset_cs` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I79f9009b407bc5601fa03878b6fe53c190214c3f Gerrit-Change-Number: 67888 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move serial number vars into parameter struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67887 ) Change subject: jlink_spi.c: Move serial number vars into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a Gerrit-Change-Number: 67887 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: jlink_spi.c: Move parameters into struct
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67886 to look at the new patch set (#5). Change subject: jlink_spi.c: Move parameters into struct ...................................................................... jlink_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 --- M jlink_spi.c 1 file changed, 45 insertions(+), 31 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/67886/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/67886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 Gerrit-Change-Number: 67886 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move function argument into previous line
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67883 to look at the new patch set (#4). Change subject: jlink_spi.c: Move function argument into previous line ...................................................................... jlink_spi.c: Move function argument into previous line Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I13b7f37adb242abbbd3a2961e7cdc4cf7ec578d8 --- M jlink_spi.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/67883/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/67883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13b7f37adb242abbbd3a2961e7cdc4cf7ec578d8 Gerrit-Change-Number: 67883 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Set `use_serial_number` to false by default
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67881 to look at the new patch set (#3). Change subject: jlink_spi.c: Set `use_serial_number` to false by default ...................................................................... jlink_spi.c: Set `use_serial_number` to false by default Set `use_serial_number` to false by default removing the else branch which is entered when its related programmer argument `serial` is not found. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I83b5e651097d1a248baf5ddb6b09e5cff161317d --- M jlink_spi.c 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/67881/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I83b5e651097d1a248baf5ddb6b09e5cff161317d Gerrit-Change-Number: 67881 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: ft2232_spi.c: Split out most programmer param parsing
by Felix Singer (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67908 ) Change subject: ft2232_spi.c: Split out most programmer param parsing ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Sry, this should have gone to the first patch Then also see CB:67886 ;) Though, patches need to be squashed and I need to push the rest rest of the programmers I have only locally. -- To view, visit https://review.coreboot.org/c/flashrom/+/67908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Gerrit-Change-Number: 67908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 06:38:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ft2232_spi.c: Split out most programmer param parsing
by Thomas Heijligen (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67908 ) Change subject: ft2232_spi.c: Split out most programmer param parsing ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > On the first view, still from a mobile device, I like this patch. […] Sry, this should have gone to the first patch -- To view, visit https://review.coreboot.org/c/flashrom/+/67908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Gerrit-Change-Number: 67908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 06:21:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ft2232_spi.c: Split out most programmer param parsing
by Thomas Heijligen (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67908 ) Change subject: ft2232_spi.c: Split out most programmer param parsing ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: On the first view, still from a mobile device, I like this patch. what do you think of creating an const instance of ft2232_parameters with the default values instead of passing them in the code? So you have `struct ft2232_parameters programmer_parameters = ft2232_default_parameters;` -- To view, visit https://review.coreboot.org/c/flashrom/+/67908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Gerrit-Change-Number: 67908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 06:21:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022