October 2022 - flashrom-gerrit

[S] Change in flashrom[master]: realtek_mst_i2c_spi.c: Move parameters into struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67895 to look at the new patch set (#3). Change subject: realtek_mst_i2c_spi.c: Move parameters into struct ...................................................................... realtek_mst_i2c_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I471ce9e6fedc5ec7f3d2bf54a0e1633dbac3cfd5 --- M realtek_mst_i2c_spi.c 1 file changed, 30 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67895/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I471ce9e6fedc5ec7f3d2bf54a0e1633dbac3cfd5 Gerrit-Change-Number: 67895 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `psu` into parameter struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67894 ) Change subject: buspirate_spi.c: Move variable `psu` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I928af8450734473cdf1c07796b6c57c328d587d5 Gerrit-Change-Number: 67894 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `pullup` into parameters struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67893 ) Change subject: buspirate_spi.c: Move variable `pullup` into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6b571d2f034fc3f8657cc4e9a0f2891df84e38c3 Gerrit-Change-Number: 67893 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Move variable `spispeed` into parameters struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67892 ) Change subject: buspirate_spi.c: Move variable `spispeed` into parameters struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I816a0017dcb206a8f3284c1c79aed20a96008406 Gerrit-Change-Number: 67892 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: buspirate_spi.c: Move parameters into struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67891 to look at the new patch set (#3). Change subject: buspirate_spi.c: Move parameters into struct ...................................................................... buspirate_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I5a791f1d9204982d7972eed85ccf8eb10ce02b78 --- M buspirate_spi.c 1 file changed, 39 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/67891/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a791f1d9204982d7972eed85ccf8eb10ce02b78 Gerrit-Change-Number: 67891 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `enable_target_power` into parameter struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67889 ) Change subject: jlink_spi.c: Move variable `enable_target_power` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id32a6866372658a04fd62385d226294cfbcd4227 Gerrit-Change-Number: 67889 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `reset_cs` into parameter struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67888 ) Change subject: jlink_spi.c: Move variable `reset_cs` into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I79f9009b407bc5601fa03878b6fe53c190214c3f Gerrit-Change-Number: 67888 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move serial number vars into parameter struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67887 ) Change subject: jlink_spi.c: Move serial number vars into parameter struct ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a Gerrit-Change-Number: 67887 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: jlink_spi.c: Move parameters into struct
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67886 to look at the new patch set (#5). Change subject: jlink_spi.c: Move parameters into struct ...................................................................... jlink_spi.c: Move parameters into struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 --- M jlink_spi.c 1 file changed, 45 insertions(+), 31 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/67886/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/67886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 Gerrit-Change-Number: 67886 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Set `use_serial_number` to false by default
by Felix Singer (Code Review) Oct. 2, 2022

Oct. 2, 2022

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67881 to look at the new patch set (#3). Change subject: jlink_spi.c: Set `use_serial_number` to false by default ...................................................................... jlink_spi.c: Set `use_serial_number` to false by default Set `use_serial_number` to false by default removing the else branch which is entered when its related programmer argument `serial` is not found. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I83b5e651097d1a248baf5ddb6b09e5cff161317d --- M jlink_spi.c 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/67881/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I83b5e651097d1a248baf5ddb6b09e5cff161317d Gerrit-Change-Number: 67881 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0