January 2022 - flashrom-gerrit

Change in flashrom[master]: Makefile: reorder make targets
by Thomas Heijligen (Code Review) 12 Jan '22

12 Jan '22

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/60836 to look at the new patch set (#3). Change subject: Makefile: reorder make targets ...................................................................... Makefile: reorder make targets Use the order in which the targets get executed. Change-Id: Ic45c2fc98c679ac7be4ee2860d72b517b8b67a17 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 36 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/60836/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/60836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic45c2fc98c679ac7be4ee2860d72b517b8b67a17 Gerrit-Change-Number: 60836 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [RFC][WIP] Makefile: use directory for object files
by Thomas Heijligen (Code Review) 12 Jan '22

12 Jan '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/61034 ) Change subject: [RFC][WIP] Makefile: use directory for object files ...................................................................... [RFC][WIP] Makefile: use directory for object files Use $(OBJPATH), defaults to .obj, as storage location for object and dependency files. This keeps the main source directory clean. The Makefile in util/ich_descriptors_tool does this already. Change-Id: Id0b5eea0b4c941f5af37c0d27dcc95c0bb45461f Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/61034/1 diff --git a/Makefile b/Makefile index b8287a9..47efebc 100644 --- a/Makefile +++ b/Makefile @@ -36,6 +36,7 @@ RANLIB ?= ranlib PKG_CONFIG ?= pkg-config BUILD_DETAILS_FILE ?= build_details.txt +OBJPATH = .obj # The following parameter changes the default programmer that will be used if there is no -p/--programmer # argument given when running flashrom. The predefined setting does not enable any default so that every @@ -906,8 +907,8 @@ @+$(MAKE) -C util/ich_descriptors_tool/ HOST_OS=$(HOST_OS) TARGET_OS=$(TARGET_OS) endif -$(PROGRAM)$(EXEC_SUFFIX): $(OBJS) - $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS) $(LIBS) $(PCILIBS) $(FEATURE_LIBS) +$(PROGRAM)$(EXEC_SUFFIX): $(addprefix $(OBJPATH)/,$(OBJS)) + $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $^ $(LDFLAGS) $(LIBS) $(PCILIBS) $(FEATURE_LIBS) libflashrom.a: $(LIBFLASHROM_OBJS) $(AR) rcs $@ $^ @@ -918,14 +919,17 @@ # stored files, they can be handled here as well. TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root") -%.o: %.c features +_create_OBJPATH: + mkdir -p $(OBJPATH) + +$(OBJPATH)/%.o: %.c features _create_OBJPATH $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $< # Make sure to add all names of generated binaries here. # This includes all frontends and libflashrom. # We don't use EXEC_SUFFIX here because we want to clean everything. clean: - rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE) + rm -rf $(PROGRAM) $(PROGRAM).exe libflashrom.a $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE) $(OBJPATH) @+$(MAKE) -C util/ich_descriptors_tool/ clean distclean: clean @@ -1086,4 +1090,4 @@ # Disable implicit suffixes and built-in rules (for performance and profit) .SUFFIXES: --include $(OBJS:.o=.d) +-include $(OBJPATH)/$(OBJS:.o=.d) -- To view, visit https://review.coreboot.org/c/flashrom/+/61034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id0b5eea0b4c941f5af37c0d27dcc95c0bb45461f Gerrit-Change-Number: 61034 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: add writeprotect bit layout map to chips
by Nikolai Artemiev (Code Review) 12 Jan '22

12 Jan '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58477 ) Change subject: flashchips: add writeprotect bit layout map to chips ...................................................................... Patch Set 24: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/58477/comment/0b7c85ac_3998f79e PS20, Line 6353: .tb = {STATUS1, 5, RW}, /* Called BP3 in datasheet, acts like TB */ : .sec = {STATUS1, 6, RW}, /* Called BP4 in datasheet, acts like SEC */ > Hmmm, this can indeed be a problem. I haven't had time to check datasheets yet. Any thoughts about how this should be handled? The main issue in my experience is that someone may add support for a new chip using bit names from the datasheet without realizing that the naming is suboptimal, e.g. they might call a bit BP3 when it acts like TB. That leads to unnecessary duplication of range decoding functions that only differ in bit naming. It happened a lot in cros WP code and caused unnecessary range lookup tables to be added. It might be sufficient to add a comment warning people to check the function of each bit, rather than directly using the datasheet names. We could also add some kind of test for it maybe. E.g. for every range decoding function, check that none of the BP bits act like TB/CMP/SEC. It would be easy to detect if a bit acts like TB or CMP, but SEC would be harder and I'm not sure if would be worth it overall. Another option is to always use the datasheet's names, and avoid duplication by factoring out common logic from the range decoding functions. But that still leaves a few problems, e.g. names can change between datasheet revisions or between datasheets for different chips that share a single chip definition. -- To view, visit https://review.coreboot.org/c/flashrom/+/58477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id08d77e6d4ca5109c0d698271146d026dbc21284 Gerrit-Change-Number: 58477 Gerrit-PatchSet: 24 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 12 Jan 2022 07:28:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: check ioctl() return value properly
by Nikolai Artemiev (Code Review) 12 Jan '22

12 Jan '22

Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60996 ) Change subject: linux_mtd: check ioctl() return value properly ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/60996/comment/ea784251_0af74915 PS1, Line 12: none > keep the bugs though b:213561594,b:210973586,b:182223106 Done -- To view, visit https://review.coreboot.org/c/flashrom/+/60996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40cfbdee2ab608fbe6c17d9cac6ec53ff224d9a4 Gerrit-Change-Number: 60996 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 Jan 2022 04:55:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: check ioctl() return value properly
by Nikolai Artemiev (Code Review) 12 Jan '22

12 Jan '22

Attention is currently required from: Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/60996 to look at the new patch set (#2). Change subject: linux_mtd: check ioctl() return value properly ...................................................................... linux_mtd: check ioctl() return value properly Make the linux_mtd driver treat any negative return value from the MEMERASE ioctl as an error. Previously it only treated -1 as an error. BUG=b:213561594,b:210973586,b:182223106 BRANCH=none TEST=builds Change-Id: I40cfbdee2ab608fbe6c17d9cac6ec53ff224d9a4 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M linux_mtd.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/60996/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/60996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40cfbdee2ab608fbe6c17d9cac6ec53ff224d9a4 Gerrit-Change-Number: 60996 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: layout: Hoist get_region_range() into libflashrom API
by Edward O'Callaghan (Code Review) 11 Jan '22

11 Jan '22

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60881 ) Change subject: layout: Hoist get_region_range() into libflashrom API ...................................................................... layout: Hoist get_region_range() into libflashrom API While using the libflashrom API to read specific regions there is no currently no general way to find the offset into the read buffer of the expected region. flashrom_layout_include_region() probably should have returned the region offset and size if it was included. However to avoid a change in API signature we can instead hoist up get_region_range() into the API to be called after. BUG=b:207808292 TEST=`make` && tested in porting cbfstool use-case. Change-Id: I8cf95b5eaec943a51d0ea668f26a56bf6d6b4446 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60881 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sam McNally <sammc(a)google.com> --- M cli_classic.c M layout.c M layout.h M libflashrom.h M libflashrom.map M tests/layout.c 6 files changed, 28 insertions(+), 16 deletions(-) Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved diff --git a/cli_classic.c b/cli_classic.c index d69b798..1b9c5ba 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -782,7 +782,7 @@ } if (set_wp_region && wp_region) { - if (get_region_range(layout, wp_region, &wp_start, &wp_len)) { + if (flashrom_layout_get_region_range(layout, wp_region, &wp_start, &wp_len)) { ret = 1; goto out_release; } diff --git a/layout.c b/layout.c index 534deba..05bee19 100644 --- a/layout.c +++ b/layout.c @@ -188,18 +188,6 @@ return 0; } -int get_region_range(struct flashrom_layout *const l, const char *name, - unsigned int *start, unsigned int *len) -{ - const struct romentry *const entry = _layout_entry_by_name(l, name); - if (entry) { - *start = entry->start; - *len = entry->end - entry->start + 1; - return 0; - } - return 1; -} - /* process -i arguments * returns 0 to indicate success, >0 to indicate failure */ @@ -445,6 +433,29 @@ } /** + * @brief Get given region's offset and length. + * + * @param layout The layout to alter. + * @param name The name of the region. + * @param start The start address to be written. + * @param len The length of the region to be written. + * + * @return 0 on success, + * 1 if the given name can't be found. + */ +int flashrom_layout_get_region_range(struct flashrom_layout *const l, const char *name, + unsigned int *start, unsigned int *len) +{ + const struct romentry *const entry = _layout_entry_by_name(l, name); + if (entry) { + *start = entry->start; + *len = entry->end - entry->start + 1; + return 0; + } + return 1; +} + +/** * @brief Free a layout. * * @param layout Layout to free. diff --git a/layout.h b/layout.h index 713241f..abbdc22 100644 --- a/layout.h +++ b/layout.h @@ -59,8 +59,6 @@ int process_include_args(struct flashrom_layout *, const struct layout_include_args *); void cleanup_include_args(struct layout_include_args **); -int get_region_range(struct flashrom_layout *, const char *name, - unsigned int *start, unsigned int *len); const struct romentry *layout_next_included_region(const struct flashrom_layout *, chipoff_t); const struct romentry *layout_next_included(const struct flashrom_layout *, const struct romentry *); const struct romentry *layout_next(const struct flashrom_layout *, const struct romentry *); diff --git a/libflashrom.h b/libflashrom.h index 3bd6855..557978d 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -114,6 +114,8 @@ struct flashrom_flashctx *, const uint8_t *buf, size_t len); int flashrom_layout_add_region(struct flashrom_layout *, size_t start, size_t end, const char *name); int flashrom_layout_include_region(struct flashrom_layout *, const char *name); +int flashrom_layout_get_region_range(struct flashrom_layout *, const char *name, + unsigned int *start, unsigned int *len); void flashrom_layout_release(struct flashrom_layout *); void flashrom_layout_set(struct flashrom_flashctx *, const struct flashrom_layout *); diff --git a/libflashrom.map b/libflashrom.map index feb20f8..2249d35 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -14,6 +14,7 @@ flashrom_image_verify; flashrom_image_write; flashrom_init; + flashrom_layout_get_region_range; flashrom_layout_include_region; flashrom_layout_read_fmap_from_buffer; flashrom_layout_read_fmap_from_rom; diff --git a/tests/layout.c b/tests/layout.c index 59e409b..1e7e31d 100644 --- a/tests/layout.c +++ b/tests/layout.c @@ -121,7 +121,7 @@ printf("done\n"); printf("Asserting region range... "); - get_region_range(layout, "region", &start, &len); + flashrom_layout_get_region_range(layout, "region", &start, &len); assert_int_equal(start, region_start); assert_int_equal(len, region_end - region_start + 1); printf("done\n"); -- To view, visit https://review.coreboot.org/c/flashrom/+/60881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8cf95b5eaec943a51d0ea668f26a56bf6d6b4446 Gerrit-Change-Number: 60881 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: linux_mtd: check ioctl() return value properly
by Edward O'Callaghan (Code Review) 11 Jan '22

11 Jan '22

Attention is currently required from: Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60996 ) Change subject: linux_mtd: check ioctl() return value properly ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/60996/comment/a0eeffae_1e6d7e4f PS1, Line 12: none keep the bugs though b:213561594,b:210973586,b:182223106 -- To view, visit https://review.coreboot.org/c/flashrom/+/60996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40cfbdee2ab608fbe6c17d9cac6ec53ff224d9a4 Gerrit-Change-Number: 60996 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 11 Jan 2022 22:50:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: check ioctl() return value properly
by Edward O'Callaghan (Code Review) 11 Jan '22

11 Jan '22

Attention is currently required from: Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60996 ) Change subject: linux_mtd: check ioctl() return value properly ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/60996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40cfbdee2ab608fbe6c17d9cac6ec53ff224d9a4 Gerrit-Change-Number: 60996 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 11 Jan 2022 22:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: remove obsolete distclean target
by Nico Huber (Code Review) 11 Jan '22

11 Jan '22

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59233 ) Change subject: Makefile: remove obsolete distclean target ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/59233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7d5717b99bf44a610a77177662c208da7f58c9e7 Gerrit-Change-Number: 59233 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 11 Jan 2022 13:50:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: remove obsolete distclean target
by Thomas Heijligen (Code Review) 11 Jan '22

11 Jan '22

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59233 ) Change subject: Makefile: remove obsolete distclean target ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Commit Message: https://review.coreboot.org/c/flashrom/+/59233/comment/7cff7785_61e50c3c PS1, Line 9: distclean removes .libdeps which does not exist anymore > Please mention that it's obsolete (as `make export` only exports […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/59233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7d5717b99bf44a610a77177662c208da7f58c9e7 Gerrit-Change-Number: 59233 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 11 Jan 2022 10:22:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2022