David Hendricks has uploaded a new patch set (#2) to the change originally created by David Hendricks. ( https://review.coreboot.org/c/flashrom/+/57581 )
Change subject: ich_descriptors: Add check for ISL == 139 for LBG
......................................................................
ich_descriptors: Add check for ISL == 139 for LBG
Purley and Whitley BKC images have an ISL (PSL) value of 0x8B (139). This
matches the documented value in the LBG SPI programming guide.
Change-Id: Icb8d19fd6771ed787b488044aa5ed5516812b27c
Signed-off-by: David Hendricks <ddaveh(a)amazon.com>
---
M ich_descriptors.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/57581/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/57581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icb8d19fd6771ed787b488044aa5ed5516812b27c
Gerrit-Change-Number: 57581
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Christian Walter, Stefan Reinauer, Edward O'Callaghan, David Hendricks, Deomid "rojer" Ryabkov, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 )
Change subject: Revert "Add support for Intel Emmitsburg PCH"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> > I'm not going to discuss that patch to fix a regression. It was obviously […]
Patch to explicitly check for Ibex Peak (using the value of 16 which you've verified), and note that it's also the historical default: https://review.coreboot.org/c/flashrom/+/57580
--
To view, visit https://review.coreboot.org/c/flashrom/+/57589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a
Gerrit-Change-Number: 57589
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sun, 12 Sep 2021 22:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jonathan Zhang.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54965 )
Change subject: Add support for Intel Emmitsburg PCH
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> Note: I checked Purley and Whitley BKC images and they use 0x8b (139) as the ISL value, according to […]
Patch to update C620 values for Purley and Whitley: https://review.coreboot.org/c/flashrom/+/57581
--
To view, visit https://review.coreboot.org/c/flashrom/+/54965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2a1bb7467e693d1583aa885fa0e277075edd4a3e
Gerrit-Change-Number: 54965
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Comment-Date: Sun, 12 Sep 2021 22:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: comment
David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57581 )
Change subject: ich_descriptors: Add check for ISL == 139 for LBG
......................................................................
ich_descriptors: Add check for ISL == 139 for LBG
Purley and Whitley BKC images have an ISL (PSL) value of 0x8B (139) in
their BKC images. This matches the documented value in the LBG SPI
programming guide.
Change-Id: Icb8d19fd6771ed787b488044aa5ed5516812b27c
Signed-off-by: David Hendricks <ddaveh(a)amazon.com>
---
M ich_descriptors.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/57581/1
diff --git a/ich_descriptors.c b/ich_descriptors.c
index d1c142d..3d2c445 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -941,7 +941,8 @@
warn_peculiar_desc(content->ISL != 23, "Gemini Lake");
return CHIPSET_GEMINI_LAKE;
}
- if (content->ISL <= 80)
+ /* Emmitsburg has 80, Purley and Whitley have 139 */
+ if (content->ISL == 80 || content->ISL == 139)
return CHIPSET_C620_SERIES_LEWISBURG;
/* Ibex Peak is historically used as the default */
warn_peculiar_desc(content->ISL != 16, "Ibex Peak");
--
To view, visit https://review.coreboot.org/c/flashrom/+/57581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icb8d19fd6771ed787b488044aa5ed5516812b27c
Gerrit-Change-Number: 57581
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks
Gerrit-MessageType: newchange
David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57580 )
Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value
......................................................................
ich_descriptors: Explicitly check for Ibex Peak ISL value
This adds an explicit check for Ibex Peak when guessing chipset from IFD
contents, and also adds a comment that Ibex Peak is historically the default
when other chipsets are not detected.
Change-Id: I8a880251a393666757f3879629a165b7fe3533ef
Signed-off-by: David Hendricks <ddaveh(a)amazon.com>
---
M ich_descriptors.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/57580/1
diff --git a/ich_descriptors.c b/ich_descriptors.c
index d56ade7..d1c142d 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -933,6 +933,8 @@
return CHIPSET_ICH9;
if (content->ISL <= 10)
return CHIPSET_ICH10;
+ if (content->ISL == 16)
+ return CHIPSET_5_SERIES_IBEX_PEAK;
if (content->FLMAP2 == 0) {
if (content->ISL == 19)
return CHIPSET_APOLLO_LAKE;
@@ -941,6 +943,7 @@
}
if (content->ISL <= 80)
return CHIPSET_C620_SERIES_LEWISBURG;
+ /* Ibex Peak is historically used as the default */
warn_peculiar_desc(content->ISL != 16, "Ibex Peak");
return CHIPSET_5_SERIES_IBEX_PEAK;
} else if (upper->MDTBA == 0x00) {
--
To view, visit https://review.coreboot.org/c/flashrom/+/57580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8a880251a393666757f3879629a165b7fe3533ef
Gerrit-Change-Number: 57580
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks
Gerrit-MessageType: newchange
Attention is currently required from: Jonathan Zhang.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54965 )
Change subject: Add support for Intel Emmitsburg PCH
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> > I'm not talking about the detection. I mean if anybody checked that […]
Note: I checked Purley and Whitley BKC images and they use 0x8b (139) as the ISL value, according to `ifdtool`. I also checked a couple other EBG BKC images and they use 0x50 (80). Both Whitley and Purley use the Lewisburg chipset.
So for Lewisburg I think we should check for both 80 and 139.
--
To view, visit https://review.coreboot.org/c/flashrom/+/54965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2a1bb7467e693d1583aa885fa0e277075edd4a3e
Gerrit-Change-Number: 54965
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Comment-Date: Sun, 12 Sep 2021 21:55:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Angel Pons, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 )
Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops
......................................................................
Patch Set 8:
(1 comment)
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/56023/comment/81c14aa3_acc49d95
PS2, Line 2339: return 0;
Ok, it's roughly what I expected. And it's still what I consider the hardest
way to implement this feature. For instance, the first line, it's a probe
command by definition (cf. fourth paragraph of the manual), that does much
more than probing. So at least we'd have to change all the documentation
because of this (I expect that this is just the tip of the iceberg).
So why, for instance, would this be worse:
> # tuxedo_unlock_me
> # reboot
> ...
> # flashrom -p internal -w image.rom
> # poweroff
--
To view, visit https://review.coreboot.org/c/flashrom/+/56023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb
Gerrit-Change-Number: 56023
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Sun, 12 Sep 2021 21:15:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Christian Walter, Stefan Reinauer, Edward O'Callaghan, David Hendricks, Deomid "rojer" Ryabkov, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 )
Change subject: Revert "Add support for Intel Emmitsburg PCH"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm not going to discuss that patch to fix a regression. It was obviously
> merged without proper review.
Ibex Peak is still used as the default when other chipsets aren't found. That's how it worked before the EBG patch.
If you're worried about Ibex Peak, then we should figure out what ISL value to compare with so it's positively identified.
> Forcing people to work for your cause by breaking things and then blocking
> the project is really the worst shitshow.
No need for this. Let's just figure out how to properly detect Ibex Peak, fix this logic, and move on.
BTW, since this logic was broken on EBG (prior to CB:54965) it was probably also broken on LBG and other recent chipsets.
--
To view, visit https://review.coreboot.org/c/flashrom/+/57589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a
Gerrit-Change-Number: 57589
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sun, 12 Sep 2021 21:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Edward O'Callaghan, Deomid "rojer" Ryabkov, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 )
Change subject: Revert "Add support for Intel Emmitsburg PCH"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> See comments in CB:54965
I'm not going to discuss that patch to fix a regression. It was obviously
merged without proper review.
Forcing people to work for your cause by breaking things and then blocking
the project is really the worst shitshow. I guess I'll have to move/fork
flashrom away from coreboot.org if this continues.
--
To view, visit https://review.coreboot.org/c/flashrom/+/57589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a
Gerrit-Change-Number: 57589
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sun, 12 Sep 2021 20:20:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Christian Walter, Stefan Reinauer, Edward O'Callaghan, David Hendricks, Deomid "rojer" Ryabkov, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 )
Change subject: Revert "Add support for Intel Emmitsburg PCH"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Ibex Peak isn't "detected", it's the default when `content->ISL != 16`. […]
See comments in CB:54965
--
To view, visit https://review.coreboot.org/c/flashrom/+/57589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a
Gerrit-Change-Number: 57589
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sun, 12 Sep 2021 19:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: comment