June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: programmer_table: move each entry to the associated programmer source
by Anastasia Klimchuk (Code Review) 11 Jun '21

11 Jun '21

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52946 ) Change subject: programmer_table: move each entry to the associated programmer source ...................................................................... Patch Set 12: (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/52946/comment/9b8d2853_5ddd7da9 PS4, Line 402: #if CONFIG_DUMMY == 1 > > Please just drop all these `#if`. The only difference it makes is […] This is invaluable, thank you so much! I saved (copied) this whole thread for myself. -- To view, visit https://review.coreboot.org/c/flashrom/+/52946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921 Gerrit-Change-Number: 52946 Gerrit-PatchSet: 12 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 00:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: lspcon: restart MPU on programmer shutdown
by Peter Marheine (Code Review) 10 Jun '21

10 Jun '21

Peter Marheine has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55403 ) Change subject: lspcon: restart MPU on programmer shutdown ...................................................................... lspcon: restart MPU on programmer shutdown Programmer initialization stops the on-chip MPU, and it was never restarted. Leaving it stopped seems to prevent some display detection from working, so implement restarting the MPU on programmer shutdown. BUG=b:190359231 TEST=display hotplug works reliably after device communication Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855 --- M lspcon_i2c_spi.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/55403/1 diff --git a/lspcon_i2c_spi.c b/lspcon_i2c_spi.c index 9f3bb9a..f8df9e4 100644 --- a/lspcon_i2c_spi.c +++ b/lspcon_i2c_spi.c @@ -327,6 +327,16 @@ return ret; } +static int lspcon_i2c_spi_start_mpu(int fd) +{ + int ret; + // Assert reset + if ((ret = lspcon_i2c_spi_write_register(fd, MPU, 0xc0)) != 0) + return ret; + // Release reset and start MPU + return lspcon_i2c_spi_write_register(fd, MPU, 0); +} + static int lspcon_i2c_spi_map_page(int fd, unsigned int offset) { int ret = 0; @@ -418,15 +428,16 @@ .write_aai = lspcon_i2c_spi_write_aai, }; -/* TODO: MPU still stopped at this point, probably need to reset it. */ static int lspcon_i2c_spi_shutdown(void *data) { int ret = 0; struct lspcon_i2c_spi_data *lspcon_data = (struct lspcon_i2c_spi_data *)data; int fd = lspcon_data->fd; + ret |= lspcon_i2c_spi_enable_write_protection(fd); ret |= lspcon_i2c_spi_toggle_register_protection(fd, 0); + ret |= lspcon_i2c_spi_start_mpu(fd); i2c_close(fd); free(data); -- To view, visit https://review.coreboot.org/c/flashrom/+/55403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855 Gerrit-Change-Number: 55403 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: dummyflasher: Replace another case of `sizeof(struct ...)`
by Anastasia Klimchuk (Code Review) 10 Jun '21

10 Jun '21

Attention is currently required from: Nico Huber. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55358 ) Change subject: dummyflasher: Replace another case of `sizeof(struct ...)` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I have +2 ??! I almost dropped my tea cup when I saw this :) I meant to say, thank you, it is an honour for me! -- To view, visit https://review.coreboot.org/c/flashrom/+/55358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If88ba394095f86c598dcc5cf1751e1c23b132d04 Gerrit-Change-Number: 55358 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 10 Jun 2021 22:18:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: remove compile guard from programmer drivers
by Anastasia Klimchuk (Code Review) 10 Jun '21

10 Jun '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55387 ) Change subject: programmer.h: remove compile guard from programmer drivers ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55387/comment/c8f7acdf_8fdaa5f6 PS1, Line 9: musst must -- To view, visit https://review.coreboot.org/c/flashrom/+/55387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I01e6a785269c3e0bd648eeaee217a7a855ab0853 Gerrit-Change-Number: 55387 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 10 Jun 2021 21:47:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: remove compile guard from programmer drivers
by Anastasia Klimchuk (Code Review) 10 Jun '21

10 Jun '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55387 ) Change subject: programmer.h: remove compile guard from programmer drivers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I01e6a785269c3e0bd648eeaee217a7a855ab0853 Gerrit-Change-Number: 55387 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 10 Jun 2021 21:44:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase
by Nico Huber (Code Review) 10 Jun '21

10 Jun '21

Attention is currently required from: Xiang W, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 ) Change subject: bitbang-spi.c: support clock polarity and phase ...................................................................... Patch Set 26: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49255/comment/fff68f52_b85ef938 PS1, Line 8: > 1. implements a better mode 0 Actually, it's not there yet, but there is potential. I see two things in the original implementation: * the spurious mosi settings * the very first clock setting in the first loop-iteration for each byte could be skipped. -- To view, visit https://review.coreboot.org/c/flashrom/+/49255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04c1dfe132d756119229b27c3cd611d1be1abc8d Gerrit-Change-Number: 49255 Gerrit-PatchSet: 26 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Jun 2021 20:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Xiang W <wxjstz(a)126.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase
by Angel Pons (Code Review) 10 Jun '21

10 Jun '21

Angel Pons has restored this change. ( https://review.coreboot.org/c/flashrom/+/49271 ) Change subject: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/flashrom/+/49271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I415a528c013f1a523e883d812b6890be39bfcc7b Gerrit-Change-Number: 49271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-MessageType: restore

1 0

Change in flashrom[master]: bitbang_spi.c: Do not set MOSI during initialization
by Angel Pons (Code Review) 10 Jun '21

10 Jun '21

Angel Pons has restored this change. ( https://review.coreboot.org/c/flashrom/+/49270 ) Change subject: bitbang_spi.c: Do not set MOSI during initialization ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/flashrom/+/49270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I925d0ae55ae006dfcc6e7fb90364235526c576ef Gerrit-Change-Number: 49270 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: restore

1 0

Change in flashrom[master]: bitbang_spi: Refactor `set_sck_set_mosi`
by Angel Pons (Code Review) 10 Jun '21

10 Jun '21

Angel Pons has restored this change. ( https://review.coreboot.org/c/flashrom/+/49269 ) Change subject: bitbang_spi: Refactor `set_sck_set_mosi` ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/flashrom/+/49269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia84d32965e56ca563062893ebbefbbea5c35814c Gerrit-Change-Number: 49269 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: restore

1 0

Change in flashrom[master]: bitbang_spi: Drop `set_mosi` and `get_miso` operations
by Angel Pons (Code Review) 10 Jun '21

10 Jun '21

Angel Pons has restored this change. ( https://review.coreboot.org/c/flashrom/+/49268 ) Change subject: bitbang_spi: Drop `set_mosi` and `get_miso` operations ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/flashrom/+/49268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6b1edb1e01330feffc5f1ed2ca2c2ebc4fb3b66 Gerrit-Change-Number: 49268 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: restore

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021