June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: lspcon: restart MPU on programmer shutdown
by Angel Pons (Code Review) 15 Jun '21

15 Jun '21

Attention is currently required from: Sam McNally, Edward O'Callaghan, Peter Marheine. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55403 ) Change subject: lspcon: restart MPU on programmer shutdown ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855 Gerrit-Change-Number: 55403 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Jun 2021 09:04:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: lspcon: restart MPU on programmer shutdown
by Peter Marheine (Code Review) 15 Jun '21

15 Jun '21

Attention is currently required from: Sam McNally, Edward O'Callaghan. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55403 ) Change subject: lspcon: restart MPU on programmer shutdown ...................................................................... Patch Set 2: (1 comment) File lspcon_i2c_spi.c: https://review.coreboot.org/c/flashrom/+/55403/comment/1aa4fa32_aba9e01f PS1, Line 321: static int lspcon_i2c_spi_reset_mpu_stop(int fd) : { : int ret = 0; : ret |= lspcon_i2c_spi_write_register(fd, MPU, 0xc0); // cmd mode : ret |= lspcon_i2c_spi_write_register(fd, MPU, 0x40); // stop mcu : : return ret; : } : : static int lspcon_i2c_spi_start_mpu(int fd) : { : int ret; : // Assert reset : if ((ret = lspcon_i2c_spi_write_register(fd, MPU, 0xc0)) != 0) : return ret; : // Release reset and start MPU : return lspcon_i2c_spi_write_register(fd, MPU, 0); : } : > Hey Peter, could just perhaps just combine these two functions as `lspcon_i2c_spi_mcu_state_toggle` […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/55403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855 Gerrit-Change-Number: 55403 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Jun 2021 00:42:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: lspcon: restart MPU on programmer shutdown
by Peter Marheine (Code Review) 15 Jun '21

15 Jun '21

Attention is currently required from: Sam McNally, Peter Marheine. Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55403 to look at the new patch set (#2). Change subject: lspcon: restart MPU on programmer shutdown ...................................................................... lspcon: restart MPU on programmer shutdown Programmer initialization stops the on-chip MPU, and it was never restarted. Leaving it stopped seems to prevent some display detection from working, so implement restarting the MPU on programmer shutdown. BUG=b:190359231 TEST=display hotplug works reliably after device communication Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855 --- M lspcon_i2c_spi.c 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/55403/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855 Gerrit-Change-Number: 55403 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Angel Pons (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 14 Jun 2021 12:18:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Thomas Heijligen (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 2: (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/55495/comment/1302b184_55466068 PS1, Line 86: extern const struct programmer_entry programmer_nicintel; > doesn't `nicintel` come before `nicintel_eeprom`? right, I've used the sort function from the IDE and it sorts with the ';' included -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 14 Jun 2021 12:12:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Thomas Heijligen (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Thomas Heijligen, Angel Pons. Hello Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55495 to look at the new patch set (#2). Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... programmer.h: sort programmer entries alphabetically Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M programmer.h 1 file changed, 29 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/55495/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Nico Huber (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 1: (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/55495/comment/4e74386e_3ec3c1ae PS1, Line 86: extern const struct programmer_entry programmer_nicintel; > doesn't `nicintel` come before `nicintel_eeprom`? `env LC_ALL=C sort` says it does indeed. I do such things in vim, VISUAL LINE mode and :'<,'>!env LC_ALL=C sort actually just `:'<,'>!sort` because my LC_COLLATE is set to C anyway ;) -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 14 Jun 2021 12:11:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Angel Pons (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/55495/comment/c773c853_d3900eed PS1, Line 86: extern const struct programmer_entry programmer_nicintel; doesn't `nicintel` come before `nicintel_eeprom`? -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 14 Jun 2021 12:00:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Nico Huber (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 14 Jun 2021 11:35:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Thomas Heijligen (Code Review) 14 Jun '21

14 Jun '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... programmer.h: sort programmer entries alphabetically Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M programmer.h 1 file changed, 29 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/55495/1 diff --git a/programmer.h b/programmer.h index 9d1a9ad..558b80b 100644 --- a/programmer.h +++ b/programmer.h @@ -58,45 +58,45 @@ extern const size_t programmer_table_size; /* programmer drivers */ -extern const struct programmer_entry programmer_internal; -extern const struct programmer_entry programmer_dummy; -extern const struct programmer_entry programmer_nic3com; -extern const struct programmer_entry programmer_gfxnvidia; -extern const struct programmer_entry programmer_raiden_debug_spi; -extern const struct programmer_entry programmer_drkaiser; -extern const struct programmer_entry programmer_nicrealtek; -extern const struct programmer_entry programmer_nicnatsemi; -extern const struct programmer_entry programmer_nicintel; -extern const struct programmer_entry programmer_nicintel_spi; -extern const struct programmer_entry programmer_nicintel_eeprom; -extern const struct programmer_entry programmer_ogp_spi; -extern const struct programmer_entry programmer_satamv; -extern const struct programmer_entry programmer_satasii; extern const struct programmer_entry programmer_atahpt; -extern const struct programmer_entry programmer_atavia; extern const struct programmer_entry programmer_atapromise; -extern const struct programmer_entry programmer_it8212; -extern const struct programmer_entry programmer_ft2232_spi; -extern const struct programmer_entry programmer_usbblaster_spi; -extern const struct programmer_entry programmer_mstarddc_spi; -extern const struct programmer_entry programmer_pickit2_spi; -extern const struct programmer_entry programmer_stlinkv3_spi; -extern const struct programmer_entry programmer_rayer_spi; -extern const struct programmer_entry programmer_pony_spi; +extern const struct programmer_entry programmer_atavia; extern const struct programmer_entry programmer_buspirate_spi; -extern const struct programmer_entry programmer_linux_mtd; -extern const struct programmer_entry programmer_linux_spi; +extern const struct programmer_entry programmer_ch341a_spi; extern const struct programmer_entry programmer_dediprog; extern const struct programmer_entry programmer_developerbox; -extern const struct programmer_entry programmer_ch341a_spi; extern const struct programmer_entry programmer_digilent_spi; +extern const struct programmer_entry programmer_drkaiser; +extern const struct programmer_entry programmer_dummy; extern const struct programmer_entry programmer_ene_lpc; +extern const struct programmer_entry programmer_ft2232_spi; +extern const struct programmer_entry programmer_gfxnvidia; +extern const struct programmer_entry programmer_internal; +extern const struct programmer_entry programmer_it8212; extern const struct programmer_entry programmer_jlink_spi; -extern const struct programmer_entry programmer_ni845x_spi; -extern const struct programmer_entry programmer_mec1308; -extern const struct programmer_entry programmer_serprog; +extern const struct programmer_entry programmer_linux_mtd; +extern const struct programmer_entry programmer_linux_spi; extern const struct programmer_entry programmer_lspcon_i2c_spi; +extern const struct programmer_entry programmer_mec1308; +extern const struct programmer_entry programmer_mstarddc_spi; +extern const struct programmer_entry programmer_ni845x_spi; +extern const struct programmer_entry programmer_nic3com; +extern const struct programmer_entry programmer_nicintel_eeprom; +extern const struct programmer_entry programmer_nicintel_spi; +extern const struct programmer_entry programmer_nicintel; +extern const struct programmer_entry programmer_nicnatsemi; +extern const struct programmer_entry programmer_nicrealtek; +extern const struct programmer_entry programmer_ogp_spi; +extern const struct programmer_entry programmer_pickit2_spi; +extern const struct programmer_entry programmer_pony_spi; +extern const struct programmer_entry programmer_raiden_debug_spi; +extern const struct programmer_entry programmer_rayer_spi; extern const struct programmer_entry programmer_realtek_mst_i2c_spi; +extern const struct programmer_entry programmer_satamv; +extern const struct programmer_entry programmer_satasii; +extern const struct programmer_entry programmer_serprog; +extern const struct programmer_entry programmer_stlinkv3_spi; +extern const struct programmer_entry programmer_usbblaster_spi; int programmer_init(const struct programmer_entry *prog, const char *param); int programmer_shutdown(void); -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021