June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ich_descriptors.c: Fix PCH detection for Tiger Lake
by Michał Żygowski (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Nico Huber, Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55577 ) Change subject: ich_descriptors.c: Fix PCH detection for Tiger Lake ...................................................................... Patch Set 1: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/55577/comment/9a8a215c_d52afbe2 PS1, Line 955: CHIPSET_300_SERIES_CANNON_POINT > This is not Tiger Lake. I'd suggest adding a new chipset type `CHIPSET_500_SERIES_TIGER_POINT`. It will be confusing, because 500 series is the Rocket Lake PCH and Tiger Point, well... It's over 10 years old Pineview PCH: https://en.wikipedia.org/wiki/Platform_Controller_Hub#Tiger_Point Thus I left it as is -- To view, visit https://review.coreboot.org/c/flashrom/+/55577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib61d432ab4eaf00aa4eef50d2844940e73b5cad6 Gerrit-Change-Number: 55577 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 16 Jun 2021 15:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors.c: Fix PCH detection for Tiger Lake
by Angel Pons (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Nico Huber, Michał Żygowski. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55577 ) Change subject: ich_descriptors.c: Fix PCH detection for Tiger Lake ...................................................................... Patch Set 1: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/55577/comment/e9c07cc6_da70b634 PS1, Line 955: CHIPSET_300_SERIES_CANNON_POINT This is not Tiger Lake. I'd suggest adding a new chipset type `CHIPSET_500_SERIES_TIGER_POINT`. -- To view, visit https://review.coreboot.org/c/flashrom/+/55577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib61d432ab4eaf00aa4eef50d2844940e73b5cad6 Gerrit-Change-Number: 55577 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Jun 2021 14:35:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Add Tiger Lake U Premium support
by Michał Żygowski (Code Review) 16 Jun '21

16 Jun '21

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55578 ) Change subject: chipset_enable.c: Add Tiger Lake U Premium support ...................................................................... chipset_enable.c: Add Tiger Lake U Premium support TEST=Flash BIOS region on Intel i5-1135G7 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/55578/1 diff --git a/chipset_enable.c b/chipset_enable.c index cdd51ae..b030635 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2029,6 +2029,7 @@ {0x8086, 0x9d84, B_S, DEP, "Intel", "Cannon Lake U Premium", enable_flash_pch300}, {0x8086, 0x0284, B_S, DEP, "Intel", "Comet Lake U Premium", enable_flash_pch400}, {0x8086, 0x0285, B_S, DEP, "Intel", "Comet Lake U Base", enable_flash_pch400}, + {0x8086, 0xa082, B_S, DEP, "Intel", "Tiger Lake U Premium", enable_flash_pch400}, {0x8086, 0xa141, B_S, NT, "Intel", "Sunrise Point Desktop Sample", enable_flash_pch100}, {0x8086, 0xa142, B_S, NT, "Intel", "Sunrise Point Unknown Sample", enable_flash_pch100}, {0x8086, 0xa143, B_S, DEP, "Intel", "H110", enable_flash_pch100}, -- To view, visit https://review.coreboot.org/c/flashrom/+/55578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd Gerrit-Change-Number: 55578 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ich_descriptors.c: Fix PCH detection for Tiger Lake
by Michał Żygowski (Code Review) 16 Jun '21

16 Jun '21

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55577 ) Change subject: ich_descriptors.c: Fix PCH detection for Tiger Lake ...................................................................... ich_descriptors.c: Fix PCH detection for Tiger Lake Comet Lake and Tiger Lake have different FLMAP2 register layout than their predecessors: ICCRIBA became CPU Soft Strap Length (previous MSL) without any bit position change and FSMBA became CPU Soft Strap Offset from PMC base with length of 10 bits on position 11:2. Because of that the PCH detection may fail on such chipsets. Unlike Comet Lake, the Tiger Lake has very low ICCRIBA (TGL=0x11, CNL=0x34 and CML=0x34). So because of that flashrom was reporting 100 Series Sunrise Point PCH and trying to use FLCOMP freq_read field which does not exists anymore on Tiger Lake PCH. It caused flashrom to think that SPI read frequency is not correct. Check if ICCRIBA greater than 0x11 for Sunrise Point else report as Cannon Point compatible PCH series to avoid using freq_read as indicator. TEST=Flash BIOS region on Intel i5-1135G7 with the patch adding Tiger Lake support Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ib61d432ab4eaf00aa4eef50d2844940e73b5cad6 --- M ich_descriptors.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/55577/1 diff --git a/ich_descriptors.c b/ich_descriptors.c index a6ac881..88be2b5 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -946,10 +946,14 @@ msg_pwarn("Peculiar firmware descriptor, assuming Wildcat Point compatibility.\n"); return CHIPSET_9_SERIES_WILDCAT_POINT; } else if (content->ICCRIBA < 0x34) { - if (content->NM == 6) + if (content->NM == 6) { return CHIPSET_C620_SERIES_LEWISBURG; - else - return CHIPSET_100_SERIES_SUNRISE_POINT; + } else { + if (content->ICCRIBA > 0x11) + return CHIPSET_100_SERIES_SUNRISE_POINT; + else + return CHIPSET_300_SERIES_CANNON_POINT; + } } else if (content->ICCRIBA == 0x34) { if (content->NM == 6) return CHIPSET_C620_SERIES_LEWISBURG; -- To view, visit https://review.coreboot.org/c/flashrom/+/55577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib61d432ab4eaf00aa4eef50d2844940e73b5cad6 Gerrit-Change-Number: 55577 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: libflashrom: remove flashrom_system_info
by Angel Pons (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55351 ) Change subject: libflashrom: remove flashrom_system_info ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'd appreciate if you could rebase this change atop CB:55350 to avoid running into any merge conflicts when submitting. -- To view, visit https://review.coreboot.org/c/flashrom/+/55351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iad805322aeead149a8d51ad8bf0babde2a12f01f Gerrit-Change-Number: 55351 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 16 Jun 2021 12:10:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: remove flashrom_supported_programmers
by Angel Pons (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Nico Huber, Michał Żygowski, ?ukasz Dmitrowski, Thomas Heijligen, David Hendricks, Piotr Król. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55350 ) Change subject: libflashrom: remove flashrom_supported_programmers ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0157926a654e337c14d840dd398e5576471c304f Gerrit-Change-Number: 55350 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Jun 2021 12:08:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: remove flashrom_supported_programmers
by Thomas Heijligen (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Nico Huber, Michał Żygowski, ?ukasz Dmitrowski, Thomas Heijligen, David Hendricks, Piotr Król. Hello build bot (Jenkins), Nico Huber, Michał Żygowski, ?ukasz Dmitrowski, David Hendricks, Angel Pons, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55350 to look at the new patch set (#3). Change subject: libflashrom: remove flashrom_supported_programmers ...................................................................... libflashrom: remove flashrom_supported_programmers const char **flashrom_supported_programmers(void) returns an array of strings without returning the array size or making a NULL termination. This can lead to undefined behavior when iterating over the array. Change-Id: I0157926a654e337c14d840dd398e5576471c304f Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M libflashrom.c M libflashrom.h M libflashrom.map 3 files changed, 0 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/55350/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/55350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0157926a654e337c14d840dd398e5576471c304f Gerrit-Change-Number: 55350 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: libflashrom: remove flashrom_supported_programmers
by Angel Pons (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Nico Huber, Michał Żygowski, ?ukasz Dmitrowski, Thomas Heijligen, David Hendricks, Piotr Król. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55350 ) Change subject: libflashrom: remove flashrom_supported_programmers ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Looks like this needs a manual rebase. -- To view, visit https://review.coreboot.org/c/flashrom/+/55350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0157926a654e337c14d840dd398e5576471c304f Gerrit-Change-Number: 55350 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Jun 2021 11:05:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: remove flashrom_supported_programmers
by Thomas Heijligen (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Nico Huber, Michał Żygowski, ?ukasz Dmitrowski, David Hendricks, Piotr Król. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55350 ) Change subject: libflashrom: remove flashrom_supported_programmers ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55350/comment/e60a84b5_127f6241 PS1, Line 11: iterate > nit: iterating Done -- To view, visit https://review.coreboot.org/c/flashrom/+/55350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0157926a654e337c14d840dd398e5576471c304f Gerrit-Change-Number: 55350 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Jun 2021 09:57:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: remove flashrom_supported_programmers
by Thomas Heijligen (Code Review) 16 Jun '21

16 Jun '21

Attention is currently required from: Nico Huber, Michał Żygowski, ?ukasz Dmitrowski, David Hendricks, Thomas Heijligen, Piotr Król. Hello build bot (Jenkins), Nico Huber, Michał Żygowski, ?ukasz Dmitrowski, David Hendricks, Angel Pons, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55350 to look at the new patch set (#2). Change subject: libflashrom: remove flashrom_supported_programmers ...................................................................... libflashrom: remove flashrom_supported_programmers const char **flashrom_supported_programmers(void) returns an array of strings without returning the array size or making a NULL termination. This can lead to undefined behavior when iterating over the array. Change-Id: I0157926a654e337c14d840dd398e5576471c304f Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M libflashrom.c M libflashrom.h M libflashrom.map 3 files changed, 0 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/55350/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0157926a654e337c14d840dd398e5576471c304f Gerrit-Change-Number: 55350 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: ?ukasz Dmitrowski <lukasz.dmitrowski(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021