October 2021 - flashrom-gerrit

Change in flashrom[master]: Makefile: Revise utsname and clock_gettime test
by Thomas Heijligen (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58618 to look at the new patch set (#3). Change subject: Makefile: Revise utsname and clock_gettime test ...................................................................... Makefile: Revise utsname and clock_gettime test Clean up the feature target by outsourcing the test to an own variable. Change the print output and don't write to the build-details file. This is in preparation for further changes. Change-Id: Ie1f43b3d5a8ad79bff3f9bbc21f359ec35abc42a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile A Makefile.d/clock_gettime_test.c A Makefile.d/utsname_test.c M Makefile.include 4 files changed, 31 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/58618/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie1f43b3d5a8ad79bff3f9bbc21f359ec35abc42a Gerrit-Change-Number: 58618 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: compiler target: separate fixed text and value by a colon
by Thomas Heijligen (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58617 ) Change subject: Makefile: compiler target: separate fixed text and value by a colon ...................................................................... Patch Set 3: (2 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/58617/comment/7c8341f5_5e208fee PS2, Line 902: @if [ $(TARGET_OS) = libpayload ] && $(CC) --version 2>&1 | grep -q -v coreboot; then \ > @if [ $(TARGET_OS) = libpayload ] && ! $(CC) --version 2>&1 | grep -q coreboot; then \ Done https://review.coreboot.org/c/flashrom/+/58617/comment/c9c29287_f3392129 PS2, Line 902: @if [ $(TARGET_OS) = libpayload ] && $(CC) --version 2>&1 | grep -q -v coreboot; then \ > `grep -v` looks for any non-matching line Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I69959c20aa2e43ed67b3057c37e964a34cdab136 Gerrit-Change-Number: 58617 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 15:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Revise C compiler check
by Thomas Heijligen (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58616 ) Change subject: Makefile: Revise C compiler check ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58616/comment/e5cbbcee_cc2ea840 PS2, Line 7: Makefile: move c compiler check to the top > Note that C (the programming language) is written in uppercase Done https://review.coreboot.org/c/flashrom/+/58616/comment/5520423a_6e554602 PS2, Line 9: Cleanup > Verb is spelled with a space: Clean up. Done https://review.coreboot.org/c/flashrom/+/58616/comment/46fb6a0d_57909d79 PS2, Line 10: > It's also changing the output, e.g. prints version, and doesn't write […] Done File Makefile: https://review.coreboot.org/c/flashrom/+/58616/comment/a491194e_c93757b0 PS2, Line 896: echo $$( > Redirection through `echo` seems unnecessary. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d6f08ef030744c772b4ec0dc2c9e614fb90461d Gerrit-Change-Number: 58616 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 26 Oct 2021 15:05:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Introduce include directory for header files
by Angel Pons (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce include directory for header files ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58622/comment/5e183a4e_2bd1499a PS2, Line 9: src/include > I guess I would have chosen `include/`. Having everything in `src/` just […] +1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 15:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Revise utsname and clock_tettime test
by Thomas Heijligen (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58618 to look at the new patch set (#2). Change subject: Makefile: Revise utsname and clock_tettime test ...................................................................... Makefile: Revise utsname and clock_tettime test Clean up the feature target by outsourcing the test to an own variable. Change the print output and don't write to the build-details file. This is in preparation for further changes. Change-Id: Ie1f43b3d5a8ad79bff3f9bbc21f359ec35abc42a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile A Makefile.d/clock_gettime_test.c A Makefile.d/utsname_test.c M Makefile.include 4 files changed, 31 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/58618/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie1f43b3d5a8ad79bff3f9bbc21f359ec35abc42a Gerrit-Change-Number: 58618 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: compiler target: separate fixed text and value by a colon
by Thomas Heijligen (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58617 to look at the new patch set (#3). Change subject: Makefile: compiler target: separate fixed text and value by a colon ...................................................................... Makefile: compiler target: separate fixed text and value by a colon Continue to use the "key: value" format like for the C compiler. Use only shell code for TARGET_OS comparison. Change-Id: I69959c20aa2e43ed67b3057c37e964a34cdab136 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 6 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/17/58617/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I69959c20aa2e43ed67b3057c37e964a34cdab136 Gerrit-Change-Number: 58617 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: Revise C compiler check
by Thomas Heijligen (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58616 to look at the new patch set (#3). Change subject: Makefile: Revise C compiler check ...................................................................... Makefile: Revise C compiler check Clean up the compiler target by outsourcing the test to an own variable. Change the print output and don't write to the build-details file. This is in preparation for further changes. Change-Id: I3d6f08ef030744c772b4ec0dc2c9e614fb90461d Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile A Makefile.d/cc_test.c M Makefile.include 3 files changed, 14 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/58616/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d6f08ef030744c772b4ec0dc2c9e614fb90461d Gerrit-Change-Number: 58616 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Introduce include directory for header files
by Nico Huber (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce include directory for header files ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58622/comment/5b39037b_16256f04 PS2, Line 9: src/include I guess I would have chosen `include/`. Having everything in `src/` just makes the hierarchy deeper. Any thoughts? -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 15:01:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Introduce include directory for header files
by Nico Huber (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce include directory for header files ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/58622/comment/bacf49b4_145fd605 PS2, Line 413: include_directories : include_directories('src/include'), IIRC, you can avoid repeating the patch by using a variable, e.g. one on top: include_dirs = include_directories('src/include') and then use include_directories : include_dirs, everywhere. It even works literally in the `ich_descriptors_tool/meson.build`, cf. CB:58305. -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 14:55:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Introduce include directory for header files
by Angel Pons (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce include directory for header files ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 13:51:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021