October 2021 - flashrom-gerrit

Change in flashrom[master]: [RFC] writeprotect, cli_classic: create writeprotect foundation
by Angel Pons (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58474 ) Change subject: [RFC] writeprotect, cli_classic: create writeprotect foundation ...................................................................... Patch Set 5: (2 comments) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/58474/comment/ea24904a_2f71d408 PS5, Line 778: set_wp_disable should be done before setting the range > Is there way to check this pre-requisite in set_wp_range? Or even have `set_wp_range` disable WP beforehand (bail out if it fails) and restore the WP state afterwards. File writeprotect.c: PS3: > Yes I agree. […] I don't understand what the point of `struct wp` is. Currently, write protection support is only considered for SPI, so I don't see the need to have pointer indirection. Also, if `struct wp` is to be removed, why not get rid of it in first place? What benefit does keeping it provide? -- To view, visit https://review.coreboot.org/c/flashrom/+/58474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I67e9b31f86465e5a8f7d3def637198671ee818a8 Gerrit-Change-Number: 58474 Gerrit-PatchSet: 5 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 26 Oct 2021 08:54:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add tests to write on chip
by Anastasia Klimchuk (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58357 ) Change subject: tests: Add tests to write on chip ...................................................................... Patch Set 3: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/58357/comment/d17081d0_9a1527d8 PS2, Line 270: flash > Although it would be nice to have `struct flashromctx ctx = { 0 };` sort of future, see https://gith […] Thank you! I agree with future idea. For now, I did option #2, next patch CB:58596 -- To view, visit https://review.coreboot.org/c/flashrom/+/58357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6f0336613ab16a7e59857006496e3590ddb14d00 Gerrit-Change-Number: 58357 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 26 Oct 2021 03:05:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Rename flash context in chip tests to flashctx
by Anastasia Klimchuk (Code Review) 26 Oct '21

26 Oct '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58596 ) Change subject: tests: Rename flash context in chip tests to flashctx ...................................................................... tests: Rename flash context in chip tests to flashctx Flash context used to be named `flash` which was missing the context part of it. Now it is renamed into flashctx for clarity. BUG=b:181803212 TEST=ninja test Change-Id: I3f4d9c4fe85752e16bab71ad22b0135a96cac28a Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/chip.c 1 file changed, 22 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/58596/1 diff --git a/tests/chip.c b/tests/chip.c index 4181aed..9c06fe7 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -86,10 +86,10 @@ return 0; } -static void setup_chip(struct flashrom_flashctx *flash, struct flashrom_layout **layout, +static void setup_chip(struct flashrom_flashctx *flashctx, struct flashrom_layout **layout, struct flashchip *chip, const char *programmer_param) { - flash->chip = chip; + flashctx->chip = chip; g_chip_state.unlock_calls = 0; @@ -99,7 +99,7 @@ assert_int_equal(0, flashrom_layout_add_region(*layout, 0, chip->total_size * KiB - 1, "region")); assert_int_equal(0, flashrom_layout_include_region(*layout, "region")); - flashrom_layout_set(flash, *layout); + flashrom_layout_set(flashctx, *layout); printf("done\n"); /* @@ -110,7 +110,7 @@ printf("Dummyflasher initialising with param=\"%s\"... ", programmer_param); assert_int_equal(0, programmer_init(&programmer_dummy, programmer_param)); /* Assignment below normally happens while probing, but this test is not probing. */ - flash->mst = &registered_masters[0]; + flashctx->mst = &registered_masters[0]; printf("done\n"); } @@ -174,15 +174,15 @@ { (void) state; /* unused */ - struct flashrom_flashctx flash = { 0 }; + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_8MiB; const char *param = ""; /* Default values for all params. */ - setup_chip(&flash, &layout, &mock_chip, param); + setup_chip(&flashctx, &layout, &mock_chip, param); printf("Erase chip operation started.\n"); - assert_int_equal(0, do_erase(&flash)); + assert_int_equal(0, do_erase(&flashctx)); printf("Erase chip operation done.\n"); teardown(&layout); @@ -192,7 +192,7 @@ { (void) state; /* unused */ - struct flashrom_flashctx flash = { 0 }; + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_W25Q128_V; /* @@ -201,10 +201,10 @@ */ char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); - setup_chip(&flash, &layout, &mock_chip, param_dup); + setup_chip(&flashctx, &layout, &mock_chip, param_dup); printf("Erase chip operation started.\n"); - assert_int_equal(0, do_erase(&flash)); + assert_int_equal(0, do_erase(&flashctx)); printf("Erase chip operation done.\n"); teardown(&layout); @@ -216,17 +216,17 @@ { (void) state; /* unused */ - struct flashrom_flashctx flash = { 0 }; + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_8MiB; const char *param = ""; /* Default values for all params. */ - setup_chip(&flash, &layout, &mock_chip, param); + setup_chip(&flashctx, &layout, &mock_chip, param); const char *const filename = "read_chip.test"; printf("Read chip operation started.\n"); - assert_int_equal(0, do_read(&flash, filename)); + assert_int_equal(0, do_read(&flashctx, filename)); printf("Read chip operation done.\n"); teardown(&layout); @@ -236,7 +236,7 @@ { (void) state; /* unused */ - struct flashrom_flashctx flash = { 0 }; + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_W25Q128_V; /* @@ -245,12 +245,12 @@ */ char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); - setup_chip(&flash, &layout, &mock_chip, param_dup); + setup_chip(&flashctx, &layout, &mock_chip, param_dup); const char *const filename = "read_chip.test"; printf("Read chip operation started.\n"); - assert_int_equal(0, do_read(&flash, filename)); + assert_int_equal(0, do_read(&flashctx, filename)); printf("Read chip operation done.\n"); teardown(&layout); @@ -262,12 +262,12 @@ { (void) state; /* unused */ - struct flashrom_flashctx flash = { 0 }; + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_8MiB; const char *param = ""; /* Default values for all params. */ - setup_chip(&flash, &layout, &mock_chip, param); + setup_chip(&flashctx, &layout, &mock_chip, param); /* * Providing filename "-" means content is taken from standard input. @@ -285,7 +285,7 @@ const char *const filename = "-"; printf("Write chip operation started.\n"); - assert_int_equal(0, do_write(&flash, filename, NULL)); + assert_int_equal(0, do_write(&flashctx, filename, NULL)); printf("Write chip operation done.\n"); teardown(&layout); @@ -295,7 +295,7 @@ { (void) state; /* unused */ - struct flashrom_flashctx flash = { 0 }; + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_W25Q128_V; /* @@ -304,13 +304,13 @@ */ char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); - setup_chip(&flash, &layout, &mock_chip, param_dup); + setup_chip(&flashctx, &layout, &mock_chip, param_dup); /* See comment in write_chip_test_success */ const char *const filename = "-"; printf("Write chip operation started.\n"); - assert_int_equal(0, do_write(&flash, filename, NULL)); + assert_int_equal(0, do_write(&flashctx, filename, NULL)); printf("Write chip operation done.\n"); teardown(&layout); -- To view, visit https://review.coreboot.org/c/flashrom/+/58596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f4d9c4fe85752e16bab71ad22b0135a96cac28a Gerrit-Change-Number: 58596 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [RFC] writeprotect, cli_classic: create writeprotect foundation
by Anastasia Klimchuk (Code Review) 26 Oct '21

26 Oct '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58474 ) Change subject: [RFC] writeprotect, cli_classic: create writeprotect foundation ...................................................................... Patch Set 5: (3 comments) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/58474/comment/82ed827e_1087e431 PS5, Line 778: set_wp_disable should be done before setting the range Is there way to check this pre-requisite in set_wp_range? https://review.coreboot.org/c/flashrom/+/58474/comment/996e6962_854566fd PS5, Line 783: set_wp_range must happen before set_wp_enable Same question as previous, can set_wp_enable check that set_wp_range has been called? (the comment is useful anyway) File writeprotect.c: PS3: > That seems reasonable, I can just comment out the calls in cli_classic.c. […] Yes I agree. I would remove ~everything and then add one function at a time with implementation, and with usage in cli_classic (or two at a time, if it is get-set). The question is how to make work-in-progress look nice in cli_classic. What if we leave struct wp for the work-in-progress time? You are removing it in this first patch, but replacement is not ready yet. Maybe do not remove? What I am thinking is to leave struct wp, so that cli_classic compiles as before. Then add 1-2 new functions at a time, with implementation and upgrading the usage in cli_classic. At the end when all functions implemented, there will be no usages of struct wp, so you can remove it? -- To view, visit https://review.coreboot.org/c/flashrom/+/58474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I67e9b31f86465e5a8f7d3def637198671ee818a8 Gerrit-Change-Number: 58474 Gerrit-PatchSet: 5 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 26 Oct 2021 00:28:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add tests to write on chip
by Edward O'Callaghan (Code Review) 25 Oct '21

25 Oct '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58357 ) Change subject: tests: Add tests to write on chip ...................................................................... Patch Set 2: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/58357/comment/07dcdd88_b89bf24b PS2, Line 270: flash > yes three lines in a row start with "struct flash...." :) […] Although it would be nice to have `struct flashromctx ctx = { 0 };` sort of future, see https://github.com/flashrom/flashrom/blob/master/flash.h#L166 I think for now `struct flashrom_flashctx flashctx = { 0 }` seems at least consistent until that above TODO is resolved. It is also more clear to say "flashctx" than just "flash" since the 'ctx' part is actually the more relevant component than the 'flash' prefix. -- To view, visit https://review.coreboot.org/c/flashrom/+/58357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6f0336613ab16a7e59857006496e3590ddb14d00 Gerrit-Change-Number: 58357 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 25 Oct 2021 23:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi: fix memory leak
by Angel Pons (Code Review) 25 Oct '21

25 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58583 ) Change subject: pony_spi: fix memory leak ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: > Thanks for being so patient with me and always correcting my commit messages. […] My pleasure! I'm happy to help someone's who's so eager to learn 😊 -- To view, visit https://review.coreboot.org/c/flashrom/+/58583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Gerrit-Change-Number: 58583 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 25 Oct 2021 21:23:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi: fix memory leak
by Thomas Heijligen (Code Review) 25 Oct '21

25 Oct '21

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58583 ) Change subject: pony_spi: fix memory leak ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58583/comment/ebb9bebe_fe946f3b PS2, Line 9: free > Please capitalize `Free` Done https://review.coreboot.org/c/flashrom/+/58583/comment/cb7cef87_5d9125bf PS2, Line 9: return > This should be `returns` Done https://review.coreboot.org/c/flashrom/+/58583/comment/73ee6d0d_e20e1f61 PS2, Line 9: failed > I'd use timeless present: `fails` Done Patchset: PS3: Thanks for being so patient with me and always correcting my commit messages. At some point I will be able to write it straight away. ^^ -- To view, visit https://review.coreboot.org/c/flashrom/+/58583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Gerrit-Change-Number: 58583 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 25 Oct 2021 21:21:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi: fix memory leak
by Thomas Heijligen (Code Review) 25 Oct '21

25 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58583 to look at the new patch set (#3). Change subject: pony_spi: fix memory leak ...................................................................... pony_spi: fix memory leak Free data if sp_openserport() fails and pony_spi_init() returns early with 1. Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M pony_spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/58583/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Gerrit-Change-Number: 58583 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: pony_spi: fix memory leak
by Angel Pons (Code Review) 25 Oct '21

25 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58583 ) Change subject: pony_spi: fix memory leak ...................................................................... Patch Set 2: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58583/comment/3ab3a772_69dc3195 PS2, Line 9: free Please capitalize `Free` https://review.coreboot.org/c/flashrom/+/58583/comment/f0908f32_cad2e736 PS2, Line 9: return This should be `returns` https://review.coreboot.org/c/flashrom/+/58583/comment/3ee80ffb_f34dcd37 PS2, Line 9: failed I'd use timeless present: `fails` -- To view, visit https://review.coreboot.org/c/flashrom/+/58583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Gerrit-Change-Number: 58583 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 25 Oct 2021 20:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pony_spi: fix memory leak
by Thomas Heijligen (Code Review) 25 Oct '21

25 Oct '21

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58583 to look at the new patch set (#2). Change subject: pony_spi: fix memory leak ...................................................................... pony_spi: fix memory leak free data if sp_openserport() failed and pony_spi_init() return early with 1. Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M pony_spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/58583/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Gerrit-Change-Number: 58583 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021