October 2021 - flashrom-gerrit

Change in flashrom[master]: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58278 to look at the new patch set (#2). Change subject: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros ...................................................................... buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros Determinate with macro has to been set for the target sytem. Do this in the buildsystem instead of using preprocessor macros. Change-Id: Ic41ea025e35feb93f07ce7a94c0d15e6e84f38b9 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M hwaccess.c M meson.build 3 files changed, 37 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/58278/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic41ea025e35feb93f07ce7a94c0d15e6e84f38b9 Gerrit-Change-Number: 58278 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: buildsystem: handle the IS_WINDOWS macro
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58277 to look at the new patch set (#2). Change subject: buildsystem: handle the IS_WINDOWS macro ...................................................................... buildsystem: handle the IS_WINDOWS macro On Windows target systems set the IS_WINDOWS=1 macro by the buildsystem. Change-Id: I334708f2dec08ec9ca6ad4161fbd7fe22ac023a6 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M meson.build M platform.h 3 files changed, 13 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/58277/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I334708f2dec08ec9ca6ad4161fbd7fe22ac023a6 Gerrit-Change-Number: 58277 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: platform.h: remove IS_LINUX and IS_MACOSX macro
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58276 to look at the new patch set (#2). Change subject: platform.h: remove IS_LINUX and IS_MACOSX macro ...................................................................... platform.h: remove IS_LINUX and IS_MACOSX macro Replace the remaining uses by the plain macros. Windows, Linux and MacOS are the only systems with explicit macros. Only the Windows macro is used in several places. The others can easily handled like all other systems. Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M hwaccess.c M platform.h 2 files changed, 2 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/58276/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4 Gerrit-Change-Number: 58276 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: buildsystem: Determine the endianness only in the buildsystem
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58273 to look at the new patch set (#3). Change subject: buildsystem: Determine the endianness only in the buildsystem ...................................................................... buildsystem: Determine the endianness only in the buildsystem Let the buildsystem (make / meson) handle the endianness determination and set the __FLASHROM_LITTLE_ENDIAN__ or __FLASHROM_BIG_ENDIAN__ macro as cflag. Change-Id: I37093528ae55e712cc30a0267a8ceac332750e7d Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M meson.build M platform.h 3 files changed, 14 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/58273/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I37093528ae55e712cc30a0267a8ceac332750e7d Gerrit-Change-Number: 58273 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move endian determination test into the Makefile
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58270 to look at the new patch set (#2). Change subject: Makefile: move endian determination test into the Makefile ...................................................................... Makefile: move endian determination test into the Makefile Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M Makefile.include D endiantest.c 3 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/58270/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8 Gerrit-Change-Number: 58270 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move architecture determination test into the Makefile
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58269 to look at the new patch set (#2). Change subject: Makefile: move architecture determination test into the Makefile ...................................................................... Makefile: move architecture determination test into the Makefile Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M Makefile.include D archtest.c M platform.h 4 files changed, 38 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/58269/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa Gerrit-Change-Number: 58269 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move OS determination test into the Makefile
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58015 to look at the new patch set (#4). Change subject: Makefile: move OS determination test into the Makefile ...................................................................... Makefile: move OS determination test into the Makefile Change-Id: Id911f17f4100f242e1fde10d23a8459ddf38b369 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M Makefile.include D os.h M util/ich_descriptors_tool/Makefile 4 files changed, 48 insertions(+), 75 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/58015/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id911f17f4100f242e1fde10d23a8459ddf38b369 Gerrit-Change-Number: 58015 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move target system determination tests at one place
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58248 to look at the new patch set (#2). Change subject: Makefile: move target system determination tests at one place ...................................................................... Makefile: move target system determination tests at one place Change-Id: Ia1b3f0257aaeebb355700b65c51a2ba70b80d5ae Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile 1 file changed, 9 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/58248/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia1b3f0257aaeebb355700b65c51a2ba70b80d5ae Gerrit-Change-Number: 58248 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58247 to look at the new patch set (#2). Change subject: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS ...................................................................... Makefile: summarize systems with the same CPPFLAGS and LDFLAGS Change-Id: I067430e52eb41bf0af4f08246bbe59117bc09bdb Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile 1 file changed, 5 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/58247/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I067430e52eb41bf0af4f08246bbe59117bc09bdb Gerrit-Change-Number: 58247 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: use STRIP_ARGS = -s on all systems
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58246 to look at the new patch set (#2). Change subject: Makefile: use STRIP_ARGS = -s on all systems ...................................................................... Makefile: use STRIP_ARGS = -s on all systems Set -s (--strip-all) as STRIP_ARGS explicit on all systems instead of only on systems (SunOS / Solaris) where strip-all is not the default dehavior. Change-Id: I2c80d553fb54d94bc65f07e700c90dd1bae4854e Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/58246/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2c80d553fb54d94bc65f07e700c90dd1bae4854e Gerrit-Change-Number: 58246 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021