October 2021 - flashrom-gerrit

Change in flashrom[master]: gfxnvidia: Fix indents
by Felix Singer (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer. Hello Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58301 to look at the new patch set (#2). Change subject: gfxnvidia: Fix indents ...................................................................... gfxnvidia: Fix indents Change-Id: I18f916923d3574dd8c68019e4db3985444dd7bee Signed-off-by: Felix Singer <felix.singer(a)secunet.com> --- M gfxnvidia.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/58301/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18f916923d3574dd8c68019e4db3985444dd7bee Gerrit-Change-Number: 58301 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: serprog: Move content of programmer specific header to C file
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58300 ) Change subject: serprog: Move content of programmer specific header to C file ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5c65f43db200129489d487ff948daa08bd0e92fa Gerrit-Change-Number: 58300 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 13 Oct 2021 15:33:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: replace flashrom specific macros by compiler defines
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58280 ) Change subject: hwaccess: replace flashrom specific macros by compiler defines ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia0f022d12390722816066d292e1878824adc613c Gerrit-Change-Number: 58280 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:24:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: buildsystem: Determine the endianness only in the buildsystem
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58273 ) Change subject: buildsystem: Determine the endianness only in the buildsystem ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: ``` $(CC) -dM -E - </dev/null | grep __BYTE_ORDER__ | awk '{gsub(/.*__ORDER_/,""); gsub(/_ENDIAN__/,""); print tolower($0)}' ``` will result in little, big, pdp or '' -- To view, visit https://review.coreboot.org/c/flashrom/+/58273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I37093528ae55e712cc30a0267a8ceac332750e7d Gerrit-Change-Number: 58273 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:18:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58278 ) Change subject: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros ...................................................................... Patch Set 2: Code-Review+2 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58278/comment/b95f3bed_d3825d15 PS2, Line 9: sytem `system` https://review.coreboot.org/c/flashrom/+/58278/comment/8af087cf_ffa92b3f PS2, Line 9: with `which` https://review.coreboot.org/c/flashrom/+/58278/comment/5538127d_d27c1163 PS2, Line 9: Determinate `Determine` https://review.coreboot.org/c/flashrom/+/58278/comment/de905bc7_98e0d5eb PS2, Line 9: been `be` -- To view, visit https://review.coreboot.org/c/flashrom/+/58278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic41ea025e35feb93f07ce7a94c0d15e6e84f38b9 Gerrit-Change-Number: 58278 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:16:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: buildsystem: handle the IS_WINDOWS macro
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58277 ) Change subject: buildsystem: handle the IS_WINDOWS macro ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/58277/comment/24cfc1bb_d7c0f5fd PS2, Line 45: Just one empty line? -- To view, visit https://review.coreboot.org/c/flashrom/+/58277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I334708f2dec08ec9ca6ad4161fbd7fe22ac023a6 Gerrit-Change-Number: 58277 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:12:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: remove IS_LINUX and IS_MACOSX macro
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58276 ) Change subject: platform.h: remove IS_LINUX and IS_MACOSX macro ...................................................................... Patch Set 2: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58276/comment/37ebff2f_cdc65f09 PS2, Line 7: macro `macros` https://review.coreboot.org/c/flashrom/+/58276/comment/099995a3_dc47cf36 PS2, Line 9: Replace the remaining uses by the plain macros. Add an empty line to split paragraphs? https://review.coreboot.org/c/flashrom/+/58276/comment/bf6631c5_78b0aad0 PS2, Line 11: easily Missing a word here, `can easily *be* handled`? -- To view, visit https://review.coreboot.org/c/flashrom/+/58276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4 Gerrit-Change-Number: 58276 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:09:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: buildsystem: Determine the endianness only in the buildsystem
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58273 ) Change subject: buildsystem: Determine the endianness only in the buildsystem ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I37093528ae55e712cc30a0267a8ceac332750e7d Gerrit-Change-Number: 58273 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:06:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move endian determination test into the Makefile
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58270 ) Change subject: Makefile: move endian determination test into the Makefile ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I would prefer to keep the current detection code (moved into a separate .h file?) until we have better build-test coverage or maybe after another release. It seems safe to assume that we always use gcc/clang, but I just don't know it. -- To view, visit https://review.coreboot.org/c/flashrom/+/58270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8 Gerrit-Change-Number: 58270 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:05:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move architecture determination test into the Makefile
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58269 ) Change subject: Makefile: move architecture determination test into the Makefile ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Roughly the same as in the parent commit, what you add to `Makefile.include` could instead be a separate file, e.g. `make-tests/arch.h`. IMHO, that's much easier to handle than longer C-code parts in the Makefile. -- To view, visit https://review.coreboot.org/c/flashrom/+/58269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa Gerrit-Change-Number: 58269 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021