October 2021 - flashrom-gerrit

Change in flashrom[master]: Makefile: move OS determination test into the Makefile
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58015 ) Change subject: Makefile: move OS determination test into the Makefile ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I would prefer to keep the `os.h`; maybe just move it into another dir so it's clear that it's not meant to be included in C code, e.g. `make-tests/`? -- To view, visit https://review.coreboot.org/c/flashrom/+/58015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id911f17f4100f242e1fde10d23a8459ddf38b369 Gerrit-Change-Number: 58015 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 14:02:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move target system determination tests at one place
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58248 ) Change subject: Makefile: move target system determination tests at one place ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/58248/comment/05c75b8d_066bec1c PS2, Line 162: line `lines` https://review.coreboot.org/c/flashrom/+/58248/comment/cddcc3d7_16cd5691 PS2, Line 164: line `lines` https://review.coreboot.org/c/flashrom/+/58248/comment/6997d91a_a41ec093 PS2, Line 164: uses `use` -- To view, visit https://review.coreboot.org/c/flashrom/+/58248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia1b3f0257aaeebb355700b65c51a2ba70b80d5ae Gerrit-Change-Number: 58248 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 13:44:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58247 ) Change subject: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I067430e52eb41bf0af4f08246bbe59117bc09bdb Gerrit-Change-Number: 58247 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 13:38:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use STRIP_ARGS = -s on all systems
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58246 ) Change subject: Makefile: use STRIP_ARGS = -s on all systems ...................................................................... Patch Set 2: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58246/comment/5dae2657_29e475ea PS2, Line 9: explicit `explicitly` https://review.coreboot.org/c/flashrom/+/58246/comment/eca93b8d_98973229 PS2, Line 9: Set -s (--strip-all) as STRIP_ARGS explicit on all systems instead of only Please break at 72 chars. https://review.coreboot.org/c/flashrom/+/58246/comment/b48158c5_05917ff3 PS2, Line 10: dehavior `behavior` -- To view, visit https://review.coreboot.org/c/flashrom/+/58246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2c80d553fb54d94bc65f07e700c90dd1bae4854e Gerrit-Change-Number: 58246 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 13 Oct 2021 13:31:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: gfxnvidia: Fix indents
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58301 ) Change subject: gfxnvidia: Fix indents ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18f916923d3574dd8c68019e4db3985444dd7bee Gerrit-Change-Number: 58301 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 13 Oct 2021 12:09:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util: Add Nix shell file
by Nico Huber (Code Review) 12 Oct '21

12 Oct '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58012 ) Change subject: util: Add Nix shell file ...................................................................... Patch Set 5: (1 comment) File util/shell.nix: https://review.coreboot.org/c/flashrom/+/58012/comment/40bf9937_af220386 PS3, Line 3: stdenv > The problem here is that /bin/sh can be anything. Exactly. > So they decided using bash. That's fine. But by telling so, they encourage script authors to write bash scripts. And then they'll have a hard time when they want to work with an OS that doesn't have /bin/bash. -- To view, visit https://review.coreboot.org/c/flashrom/+/58012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9757b952f4b034e98c2b4b70fbede52d8efb9d50 Gerrit-Change-Number: 58012 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 12 Oct 2021 22:19:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: buildsystem: Determine the endianness only in the buildsystem
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58273 ) Change subject: buildsystem: Determine the endianness only in the buildsystem ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58273/comment/50acdda3_fe808800 PS2, Line 7: endian: Decide __FLASHROM_XXX_ENDIAN__ in the buildsystem > I just noticed that the `ENDIAN` variable is set at line 268. So it's not a built-in function. […] Should be clear now -- To view, visit https://review.coreboot.org/c/flashrom/+/58273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I37093528ae55e712cc30a0267a8ceac332750e7d Gerrit-Change-Number: 58273 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 20:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move target system determination tests at one place
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58248 ) Change subject: Makefile: move target system determination tests at one place ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58248/comment/7ea04cf0_65ab581a PS1, Line 7: reorder ARCH and ENDIAN test > This sounds like you are changing the execution order of the tests. How about this? […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia1b3f0257aaeebb355700b65c51a2ba70b80d5ae Gerrit-Change-Number: 58248 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 20:22:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use STRIP_ARGS = -s on all systems
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58246 ) Change subject: Makefile: use STRIP_ARGS = -s on all systems ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58246/comment/129ec5a6_51dc903d PS1, Line 9: Strip-all should be the default behavior of strip, but not all systems : support this. Use -s (--strip-all) on all systems to not depend on default behavior. > I guess it means that the default behavior is inconsistent? Is the new version more understandable? Some strip implementations need the -s / --strip-all as argument to function. On others this is the default behavior. -- To view, visit https://review.coreboot.org/c/flashrom/+/58246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2c80d553fb54d94bc65f07e700c90dd1bae4854e Gerrit-Change-Number: 58246 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 20:21:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: replace flashrom specific macros by compiler defines
by Thomas Heijligen (Code Review) 12 Oct '21

12 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58280 to look at the new patch set (#2). Change subject: hwaccess: replace flashrom specific macros by compiler defines ...................................................................... hwaccess: replace flashrom specific macros by compiler defines Replace the remaining IS_* macros with the associated compiler defines Change-Id: Ia0f022d12390722816066d292e1878824adc613c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M dediprog.c M developerbox_spi.c M dmi.c M flash.h M hwaccess.c M hwaccess.h M internal.c M pickit2_spi.c D platform.h M serial.c M serprog.c 11 files changed, 20 insertions(+), 113 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/58280/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia0f022d12390722816066d292e1878824adc613c Gerrit-Change-Number: 58280 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021