October 2021 - flashrom-gerrit

Change in flashrom[master]: platform.h: remove IS_LINUX and IS_MACOSX macros
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58276 to look at the new patch set (#3). Change subject: platform.h: remove IS_LINUX and IS_MACOSX macros ...................................................................... platform.h: remove IS_LINUX and IS_MACOSX macros Replace the remaining uses by the plain macros. Windows, Linux and MacOS are the only systems with explicit macros. Only the Windows macro is used in several places. The others can easily be handled like all other systems. Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M hwaccess.c M platform.h 2 files changed, 2 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/58276/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4 Gerrit-Change-Number: 58276 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move determination test for the endian in Makefile.d
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58270 to look at the new patch set (#3). Change subject: Makefile: move determination test for the endian in Makefile.d ...................................................................... Makefile: move determination test for the endian in Makefile.d Move the test code for endian detection in a extra directory to split it from the main flashrom code. Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M Makefile.include D endiantest.c 3 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/58270/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8 Gerrit-Change-Number: 58270 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move determination test for the architecture to Makefile.d
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58269 to look at the new patch set (#3). Change subject: Makefile: move determination test for the architecture to Makefile.d ...................................................................... Makefile: move determination test for the architecture to Makefile.d Move the test code for architecture detection in a extra directorz to split it from the main flashrom code. Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M Makefile.d/arch_test.h D archtest.c M platform.h 4 files changed, 60 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/58269/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa Gerrit-Change-Number: 58269 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move determination test for OS to Makefile.d
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58015 to look at the new patch set (#5). Change subject: Makefile: move determination test for OS to Makefile.d ...................................................................... Makefile: move determination test for OS to Makefile.d Move the test code for OS detection in a extra directory to split it from the main flashrom code. Change-Id: Id911f17f4100f242e1fde10d23a8459ddf38b369 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M .gitignore M Makefile A Makefile.d/arch_test.h R Makefile.d/os_test.h M Makefile.include M util/ich_descriptors_tool/Makefile 6 files changed, 15 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/58015/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/58015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id911f17f4100f242e1fde10d23a8459ddf38b369 Gerrit-Change-Number: 58015 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move determination tests for target systems to one place
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58248 to look at the new patch set (#3). Change subject: Makefile: move determination tests for target systems to one place ...................................................................... Makefile: move determination tests for target systems to one place Change-Id: Ia1b3f0257aaeebb355700b65c51a2ba70b80d5ae Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile 1 file changed, 9 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/58248/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia1b3f0257aaeebb355700b65c51a2ba70b80d5ae Gerrit-Change-Number: 58248 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58247 to look at the new patch set (#3). Change subject: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS ...................................................................... Makefile: summarize systems with the same CPPFLAGS and LDFLAGS Change-Id: I067430e52eb41bf0af4f08246bbe59117bc09bdb Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile 1 file changed, 5 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/58247/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I067430e52eb41bf0af4f08246bbe59117bc09bdb Gerrit-Change-Number: 58247 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: use STRIP_ARGS = -s on all systems
by Thomas Heijligen (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58246 to look at the new patch set (#3). Change subject: Makefile: use STRIP_ARGS = -s on all systems ...................................................................... Makefile: use STRIP_ARGS = -s on all systems Set -s (--strip-all) as STRIP_ARGS explicitly on all systems instead of only on systems (SunOS / Solaris) where strip-all is not the default behavior. Change-Id: I2c80d553fb54d94bc65f07e700c90dd1bae4854e Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/58246/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2c80d553fb54d94bc65f07e700c90dd1bae4854e Gerrit-Change-Number: 58246 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [POC]meson: Move header files
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Nico Huber. Hello Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58305 to look at the new patch set (#2). Change subject: [POC]meson: Move header files ...................................................................... [POC]meson: Move header files Change-Id: Ia01bfda6b467d75b0266924a4fd1b290b6c59119 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- R include/flash.h M meson.build M util/ich_descriptors_tool/meson.build 3 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/58305/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia01bfda6b467d75b0266924a4fd1b290b6c59119 Gerrit-Change-Number: 58305 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [POC]meson: Move header files
by Nico Huber (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer. Hello Felix Singer, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/58305 to review the following change. Change subject: [POC]meson: Move header files ...................................................................... [POC]meson: Move header files Change-Id: Ia01bfda6b467d75b0266924a4fd1b290b6c59119 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- R include/flash.h M meson.build M util/ich_descriptors_tool/meson.build 3 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/58305/1 diff --git a/flash.h b/include/flash.h similarity index 100% rename from flash.h rename to include/flash.h diff --git a/meson.build b/meson.build index 1a36df8..b9d6704 100644 --- a/meson.build +++ b/meson.build @@ -20,6 +20,8 @@ '-Wno-missing-braces', ] +includes = include_directories('include') + conf = configuration_data() cc = meson.get_compiler('c') @@ -380,6 +382,9 @@ sources : [ srcs, ], + include_directories : [ + includes, + ], soversion : lt_current, version : lt_version, dependencies : [ @@ -450,6 +455,9 @@ 'cli_output.c', 'flashrom.c', ], + include_directories : [ + includes, + ], dependencies : [ deps, ], @@ -469,13 +477,16 @@ required: false ) flashrom_test_dep = declare_dependency( - include_directories : include_directories('.'), sources : [ srcs, 'cli_common.c', 'cli_output.c', 'flashrom.c', ], + include_directories : [ + includes, + '.', + ], compile_args : [ '-includestdlib.h', '-includeunittest_env.h', diff --git a/util/ich_descriptors_tool/meson.build b/util/ich_descriptors_tool/meson.build index b5bf09e..75ef5a9 100644 --- a/util/ich_descriptors_tool/meson.build +++ b/util/ich_descriptors_tool/meson.build @@ -7,7 +7,10 @@ dependencies : [ deps, ], - include_directories : include_directories('../..'), + include_directories : [ + includes, + '../..', + ], c_args : [ '-DICH_DESCRIPTORS_FROM_DUMP_ONLY', ], -- To view, visit https://review.coreboot.org/c/flashrom/+/58305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia01bfda6b467d75b0266924a4fd1b290b6c59119 Gerrit-Change-Number: 58305 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: serprog: Move content of programmer specific header to C file
by Felix Singer (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58300 to look at the new patch set (#6). Change subject: serprog: Move content of programmer specific header to C file ...................................................................... serprog: Move content of programmer specific header to C file Move the programmer specific code into serprog.c and remove its related header file. Change-Id: I5c65f43db200129489d487ff948daa08bd0e92fa Signed-off-by: Felix Singer <felix.singer(a)secunet.com> --- M serprog.c D serprog.h 2 files changed, 26 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/58300/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/58300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5c65f43db200129489d487ff948daa08bd0e92fa Gerrit-Change-Number: 58300 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021